Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKmwm-0002XR-UJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jul 2016 13:33:01 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bKmwm-0007Im-AN for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jul 2016 13:33:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bKmwZ-00074f-07 for pgadmin-hackers@postgresql.org; Wed, 06 Jul 2016 13:32:47 +0000 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bKmwV-000591-1Y for pgadmin-hackers@postgresql.org; Wed, 06 Jul 2016 13:32:46 +0000 Received: by mail-wm0-x232.google.com with SMTP id f126so173939017wma.1 for ; Wed, 06 Jul 2016 06:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=517pCfzIjrvnw7CoZBIBY2lrs5hxi0BW6bYvGo/clUE=; b=oRszCHdx6xM32APVim3rwKXK4hf+K5Ne/wd8UAGCSHyycuF9z0SaBBmgh1ANOBFzBk pLA2ZaEMhe+WwCEFUmD38Td2wO8PQrajyx4ZX0AuQehG5mae4EINNMirBavw2GgehhSs uaD+F5GULqbO0+hh+vtyFWjfWudxS1Gc21k5hPOTtNl4tw9c8L9sayVPhH4uPMXjKleC AMc85duhZyS1XiWBB/WUukiVhu9Yhu1pCB28mIYQ2FecvbCs+VDTCBGASXetwldDrqbh W9kvybDH5jdxdMKDn2l+3Xo816v5CALdOIUvP455cI5JbhNZjcvlFgy5yS2TaJQZ5LDi S8yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=517pCfzIjrvnw7CoZBIBY2lrs5hxi0BW6bYvGo/clUE=; b=SWyQhGeX8o62NA3fjwg8uPkc1XUf4mXFhw1lYDbr9KER/jyca9lblORF3AojnCDtCq xVzBeKXlE51s0SB82GOYMUHM+PO9PGbSkARD6hO9Ofbq5G2TCeb5tNx2lMuWQzFXAcAk 6+i8SFHYD5eYK14AckT1tkeCwhr+7u8lMcRsmT1ypQuZvYDX6BmMexY6RQ5rKzOfItYq 6fAMwTLXZ6TD/bDeEGH71+tqnywG9ZPk+Y1fxKYUWK9mj91FtAO5pvHruKHUf3FU7uep IB9d+/zG856wj7CufVjjT3L8n6M93njAiX8Oi2VYLyP+Hu9gJbkDw+Nh5irZCq4JA9n5 uenA== X-Gm-Message-State: ALyK8tKBdL50if+VUMvttZR7DpRemGaLsxa/NaGWZjh1asQTAzaHhT2qtlpY/GLXlD3teeMXoOSLwOhrVfpVKWXy X-Received: by 10.28.69.14 with SMTP id s14mr21750863wma.49.1467811961304; Wed, 06 Jul 2016 06:32:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.24.2 with HTTP; Wed, 6 Jul 2016 06:32:11 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 6 Jul 2016 19:02:11 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error To: Dave Page Cc: Marc Linster , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c07598a8d12040536f79a79 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c07598a8d12040536f79a79 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: > Hi, > > I think we need more changes than just that; > > - The path at the top should not be editable (it should be greyed in fact= ) > Ok > > - The path at the top should only show the directory path. The > filename should never be appended. > Ok > > - The CSS needs to be fixed so the filename textbox at the bottom is > never hidden (as it is now if the dialogue opens at a small size). > Ok > > - Double-click to navigate vs. rename should be modified to work in > part like it does on Mac - Double-click on either the icon or the name > should open the item (browser into a folder, or select and "OK" on a > file), and Click then Enter should rename. I'm hesitant to try to > implement "slow double click to rename" as that would likely need to > be tunable for accessibility reasons. > Ok, I will fix it. > > On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar > wrote: > > Hi > > > > Please find the patch with issue fixed: > > File Browser - File does not exist error > >> > >> it is due to wrong path formation. strip the leftmost slash only from > the > >> file name selected not from the full path. > > > > > > Please review. > > > > Reply to the comments: > > The file browser is virtually unreadable (see screen shot), it does not > work > > like Mac app > > It seems to be font issue to me. I will fix it and send a patch. > > > > When I click on the folder name, it offers to change the folder name > instead > > of opening it (opening works when I click on the folder logo) > > we are performing two operations on double click: > > 1) Navigate inside the folder > > double clicking on folder icon allows to navigate inside the folder. > > 2) Rename folder > > double clicking on folder name allows to rename the file/folder. > > > > When I manage to navigate to the right file and want to open it, I get = a > red > > message =E2=80=98File does not exist=E2=80=99. That message disappears = after 2-3 seconds > > attached a patch with fix. > > > > Thanks, > > Surinder Kumar > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c07598a8d12040536f79a79 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.= org> wrote:
Hi,

I think we need more changes than just that;

- The path at the top should not be editable (it should be greyed in fact)<= br>
Ok=C2=A0

- The path at the top should only show the directory path. The
filename should never be appended.
Ok=C2=A0

- The CSS needs to be fixed so the filename textbox at the bottom is
never hidden (as it is now if the dialogue opens at a small size).
Ok=C2=A0

- Double-click to navigate vs. rename should be modified to work in
part like it does on Mac - Double-click on either the icon or the name
should open the item (browser into a folder, or select and "OK" o= n a
file), and Click then Enter should rename. I'm hesitant to try to
implement "slow double click to rename" as that would likely need= to
be tunable for accessibility reasons.
Ok, I will fix i= t.=C2=A0

On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi
>
> Please find the patch with issue fixed:
> File Browser - File does not exist error
>>
>> it is due to wrong path formation. strip the leftmost slash only f= rom the
>> file name selected not from the full path.
>
>
> Please review.
>
> Reply to the comments:
> The file browser is virtually unreadable (see screen shot), it does no= t work
> like Mac app
> It seems to be font issue to me. I will fix it and send a patch.
>
> When I click on the folder name, it offers to change the folder name i= nstead
> of opening it (opening works when I click on the folder logo)
> we are performing two operations on double click:
> 1) Navigate inside the folder
> double clicking on folder icon allows to navigate inside the folder. > 2) Rename folder
> double clicking on folder name allows to rename the file/folder.
>
> When I manage to navigate to the right file and want to open it, I get= a red
> message =E2=80=98File does not exist=E2=80=99. That message disappears= after 2-3 seconds
> attached a patch with fix.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c07598a8d12040536f79a79--