public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: RM#1435 - "Move to last page" should also scroll to end
Date: Wed, 6 Jul 2016 13:46:35 +0530
Message-ID: <CAM5-9D-RArPijootjCj4881voRzkZa6j8rDks_U4bOsNnpYrJw@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

Please find attached patch with fix.
Every time either a new row is added or pasted. Scroll to the bottom of the
table div.

Please review

Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM#1435.patch (1.1K, 3-RM%231435.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 295caf4..24e2697 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1816,6 +1816,9 @@ define(
             }
             else {
               self.collection.add(empty_model);
+              // scroll to new added row
+              var dgrid = document.getElementById("datagrid");
+              dgrid.scrollTop = dgrid.scrollHeight;

               /* If no of items on the page exceeds the page size limit then
                * advanced to the next page.
@@ -2319,6 +2322,9 @@ define(
             }
             else {
               self._paste_row();
+              // scroll to new added row
+              var dgrid = document.getElementById("datagrid");
+              dgrid.scrollTop = dgrid.scrollHeight;

               /* If no of items on the page exceeds the page size limit then
                * advanced to the next page.

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM#1435 - "Move to last page" should also scroll to end
  In-Reply-To: <CAM5-9D-RArPijootjCj4881voRzkZa6j8rDks_U4bOsNnpYrJw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox