Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boVu5-0006ce-9k for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 13:25:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1boVu4-0007VQ-PK for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 13:25:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1boVtr-0006lX-3S for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 13:24:51 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1boVto-000796-MX for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 13:24:50 +0000 Received: by mail-wm0-x22e.google.com with SMTP id b130so149168744wmc.0 for ; Mon, 26 Sep 2016 06:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=rVU0ryM753GHPEhhPVlcTq/cGqhj+Sd63wvC2En96Jk=; b=0CSpSWP6NNGMawDE1d/nBa5Pn8nVptWwVrQdMMdNYQ9Ll2lPvNUTdak6qLMlStEgKm v7VrQXqTvBeKWhIV5A99qVREkqk2W5TgplDlukyQgbnTij9VGYHO/6CFx5o+V72j3kVI atFNvd4nVeSOoHom9Iy3Wblf+WzzAQEbO0tlmlZ9jzrRlfaXwPchZAtqA0PZp8vE19+m PmjgHYMHnBydcINyJQjbd2iUqHyt7L+K6nQOdm5qY8Lca5ctn5Jc9shyz2WSW90a8/d2 5naUJ252lBFqcdrD/rW0G1u7bfzDwyTaJuakqdOqN9UA1f2iz8AIcAmUoZ3MLtv2zllH yBZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rVU0ryM753GHPEhhPVlcTq/cGqhj+Sd63wvC2En96Jk=; b=EjnPHr2+l1j+EeLG/cTtkblWjGHb8AFjeSK7WeQwXPr72Natcm/oefb83yD5gYDJfC iuO4d0NF66mtw4saZxi8DAQKSnYIljq0hyqYvkqFrprRPF9tPQfRWyl0+E8QlYSWfXY3 49hnLFLp1teSkPylDIH7hUtn3oI+3kIx8DPrgpbhxegxGiFoIxT5unUY6SfX/6s1fLhB uFdZsvRg33ra+2Ziwail5IiPY+OTtrK98hZ+0myWk0xj/TXv3hpU00RWL4TM9W4xahlR dOsuJran0liNISuuk5D/nkEzbnC4ck+T3duPSd71YGe3GrxBbBS0uP3Caf6/Ypp6S8SM VcEg== X-Gm-Message-State: AE9vXwPuEZZtTACICDH97xZextMqiccqXHr2+UFMNYvtjGz3lrqAGGd3F1qdN1vpkApCASA6ui15lNEKfmcTFtmf X-Received: by 10.194.61.72 with SMTP id n8mr17687590wjr.74.1474896286740; Mon, 26 Sep 2016 06:24:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Mon, 26 Sep 2016 06:24:16 -0700 (PDT) From: Surinder Kumar Date: Mon, 26 Sep 2016 18:54:16 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Error while expanding server group node. To: pgadmin-hackers Content-Type: multipart/mixed; boundary=047d7b66f34340ab53053d690db6 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b66f34340ab53053d690db6 Content-Type: multipart/alternative; boundary=047d7b66f34340ab4f053d690db4 --047d7b66f34340ab4f053d690db4 Content-Type: text/plain; charset=UTF-8 Hi *Issue:* Getting following error while expanding server group node. File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py", line 86, in get_nodes in_recovery = result['rows'][0]['inrecovery']; TypeError: string indices must be integers Not a proper scenario to reproduce it. *Solution:* Add proper check to fix it. --047d7b66f34340ab4f053d690db4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Issue:
Getting following error while expanding server group node. =C2=A0=
File "/Users/surinder/Documents/Pro= jects/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",= line 86, in get_nodes
=C2=A0 =C2=A0 in_r= ecovery =3D result['rows'][0]['inrecovery'];
TypeError: string indices must be integers

Not a proper s= cenario to reproduce it.

Solution:
Add proper check to fix it.


--047d7b66f34340ab4f053d690db4-- --047d7b66f34340ab53053d690db6 Content-Type: application/octet-stream; name="server_expand_issue.patch" Content-Disposition: attachment; filename="server_expand_issue.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itk35ahu0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL19faW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18ucHkKaW5kZXggMzU0OTRh Mi4uYTZmZTYyMCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18ucHkKKysrIGIvd2ViL3Bn YWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18u cHkKQEAgLTcxLDYgKzcxLDggQEAgY2xhc3MgU2VydmVyTW9kdWxlKHNnLlNl cnZlckdyb3VwUGx1Z2luTW9kdWxlKToKICAgICAgICAgICAgIG1hbmFnZXIg PSBkcml2ZXIuY29ubmVjdGlvbl9tYW5hZ2VyKHNlcnZlci5pZCkKICAgICAg ICAgICAgIGNvbm4gPSBtYW5hZ2VyLmNvbm5lY3Rpb24oKQogICAgICAgICAg ICAgY29ubmVjdGVkID0gY29ubi5jb25uZWN0ZWQoKQorICAgICAgICAgICAg aW5fcmVjb3ZlcnkgPSBOb25lCisgICAgICAgICAgICB3YWxfcGF1c2VkID0g Tm9uZQogICAgICAgICAgICAgaWYgY29ubmVjdGVkOgogICAgICAgICAgICAg ICAgIHN0YXR1cywgcmVzdWx0ID0gY29ubi5leGVjdXRlX2RpY3QoIiIiCiAg ICAgICAgICAgICAgICAgICAgIFNFTEVDVCBDQVNFIFdIRU4gdXNlc3VwZXIK QEAgLTgzLDExICs4NSw5IEBAIGNsYXNzIFNlcnZlck1vZHVsZShzZy5TZXJ2 ZXJHcm91cFBsdWdpbk1vZHVsZSk6CiAgICAgICAgICAgICAgICAgICAgICAg ICAgICBFTkQgYXMgaXNyZXBsYXlwYXVzZWQKICAgICAgICAgICAgICAgICAg ICAgRlJPTSBwZ191c2VyIFdIRVJFIHVzZW5hbWU9Y3VycmVudF91c2VyIiIi KQogCi0gICAgICAgICAgICAgICAgaW5fcmVjb3ZlcnkgPSByZXN1bHRbJ3Jv d3MnXVswXVsnaW5yZWNvdmVyeSddOwotICAgICAgICAgICAgICAgIHdhbF9w YXVzZWQgPSByZXN1bHRbJ3Jvd3MnXVswXVsnaXNyZXBsYXlwYXVzZWQnXQot ICAgICAgICAgICAgZWxzZToKLSAgICAgICAgICAgICAgICBpbl9yZWNvdmVy eSA9IE5vbmUKLSAgICAgICAgICAgICAgICB3YWxfcGF1c2VkID0gTm9uZQor ICAgICAgICAgICAgICAgIGlmIGxlbihyZXN1bHRbJ3Jvd3MnXSk6CisgICAg ICAgICAgICAgICAgICAgIGluX3JlY292ZXJ5ID0gcmVzdWx0Wydyb3dzJ11b MF1bJ2lucmVjb3ZlcnknXQorICAgICAgICAgICAgICAgICAgICB3YWxfcGF1 c2VkID0gcmVzdWx0Wydyb3dzJ11bMF1bJ2lzcmVwbGF5cGF1c2VkJ10KIAog ICAgICAgICAgICAgeWllbGQgc2VsZi5nZW5lcmF0ZV9icm93c2VyX25vZGUo CiAgICAgICAgICAgICAgICAgIiVkIiAlIChzZXJ2ZXIuaWQpLAo= --047d7b66f34340ab53053d690db6 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --047d7b66f34340ab53053d690db6--