Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMquM-0002yh-22 for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jul 2016 06:11:02 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMquL-0008CX-3O for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jul 2016 06:11:01 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMqu7-0007yf-Pp for pgadmin-hackers@postgresql.org; Tue, 12 Jul 2016 06:10:47 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMqtz-0008Bl-3R for pgadmin-hackers@postgresql.org; Tue, 12 Jul 2016 06:10:46 +0000 Received: by mail-wm0-x231.google.com with SMTP id i5so10197196wmg.0 for ; Mon, 11 Jul 2016 23:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ac3+fxZmUJFK1JjjiwVzbALmMX3ghZa2jzjbYg0MYqY=; b=NkD+mH1jWDlQ3smTy7zdDvaTprTi9sFUK06r0y++oP7xqCES0ih/BiKY9umrtMG5/H 0apemUA+VJRc3o+IzrCYxjs37R6qklhfKZcAuhwthb1UXW39FpLIoyoL33RaI2djbB8a D9wWaASNFn/7Q4wJ8nfCw/UR+rtvE2vP8uaXOWS3tCsKcLl+bj1qHf8IGRC3ANl/RiYO pC3rWJCS73Frl7SJURqi7vb1cjq/nHqdxBF/wfIgCHSE/w5ZSJ4GIDgwvqyHzbYviJLe FuVt8Zfyep8zPqNro8Os6dXtxPr6mn1oAxSQKgGjVx5Fyc7e3pS5IeEgaj4Qf0PMGDew eePA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ac3+fxZmUJFK1JjjiwVzbALmMX3ghZa2jzjbYg0MYqY=; b=fNGk+Ru5GYsdAUS7wb4+Aw4DwB/+ue/rTigSmcM6e2D09b/AF4nTeKMFg4n3iHg1NI jANe7E3sxlegdC7kFwc3DgviWxFu1DEApDB7rcCgT0QFunyKo5itS3PzMfN4Gn23pkiw AEOViQWL/TKl1PKtljN0iVRIPvRHAyqAm9QFAm0sYRnMhSlL+iOEuPC/oIxjoXVoxWbw 5hhDvk6r9/EtgXA/9yYC8kzaCUVs4xrkCVLmCiBtE8Y+6fhZYKGfiCmp0vW71V8Ca97M nS6B3LHYHcdVYBtpzYrJPPq9nL9J35MRWaot4a2Y0cXxw6k/HAASQXPmpZlvMV8ZZwak s28A== X-Gm-Message-State: ALyK8tIVuk4+hliUf64CNVqtfDcKimrzS+Mhy6vVj8lJ2YiGd7lEKLtXMdQG9IfxdNWrt/HUylEeBmOfK/hFF/R+ X-Received: by 10.194.203.35 with SMTP id kn3mr495297wjc.105.1468303836565; Mon, 11 Jul 2016 23:10:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Mon, 11 Jul 2016 23:10:07 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Tue, 12 Jul 2016 11:40:07 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error To: Dave Page Cc: Marc Linster , pgadmin-hackers Content-Type: multipart/alternative; boundary=e89a8f22beeb99e68105376a20ea X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --e89a8f22beeb99e68105376a20ea Content-Type: text/plain; charset=UTF-8 On Mon, Jul 11, 2016 at 6:41 PM, Dave Page wrote: > On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar > wrote: > > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar > > wrote: > >> > >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: > >>> > >>> Hi, > >>> > >>> I think we need more changes than just that; > >>> > >>> - The path at the top should not be editable (it should be greyed in > >>> fact) > >> > >> Ok > >>> > >>> > >>> - The path at the top should only show the directory path. The > >>> filename should never be appended. > >> > >> Ok > >>> > >>> > >>> - The CSS needs to be fixed so the filename textbox at the bottom is > >>> never hidden (as it is now if the dialogue opens at a small size). > >> > >> Ok > >>> > >>> > >>> - Double-click to navigate vs. rename should be modified to work in > >>> part like it does on Mac - Double-click on either the icon or the name > >>> should open the item (browser into a folder, or select and "OK" on a > >>> file), and Click then Enter should rename. I'm hesitant to try to > >>> implement "slow double click to rename" as that would likely need to > >>> be tunable for accessibility reasons. > >> > >> Ok, I will fix it. > > > > In the current scenario, the Enter Key is bound to the OK button by > default > > in Alertify dialog which servers the purpose of closing the dialog. > > Should we de-attach Enter Key event bound to OK button and use it for > rename > > file? > > please suggest what should I do? > > Hmm, good point. > > How hard would it be to look for 2 consecutive single-clicks (but not > a double-click) for rename? If we can do that, it avoids timing > considerations for double-clicks (which would be defined by the OS). > I tried to implement slow double click, here is Fiddle There are two events 1) double click (it will be used for folder navigation) 2) Slow double click(For rename), It is a simple click event, when clicked twice after delay we consider it a slow double click. But it is not working smoothly, double click and single click events are conflicting. Also, we have rename button in navigation for rename operation, Can we skip slow double click because it is very confusing? > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --e89a8f22beeb99e68105376a20ea Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin= .org> wrote:
On Thu, Jul 7, 2016 at 1:50 PM, Sur= inder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
> <surinder.kumar@= enterprisedb.com> wrote:
>>
>> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> I think we need more changes than just that;
>>>
>>> - The path at the top should not be editable (it should be gre= yed in
>>> fact)
>>
>> Ok
>>>
>>>
>>> - The path at the top should only show the directory path. The=
>>> filename should never be appended.
>>
>> Ok
>>>
>>>
>>> - The CSS needs to be fixed so the filename textbox at the bot= tom is
>>> never hidden (as it is now if the dialogue opens at a small si= ze).
>>
>> Ok
>>>
>>>
>>> - Double-click to navigate vs. rename should be modified to wo= rk in
>>> part like it does on Mac - Double-click on either the icon or = the name
>>> should open the item (browser into a folder, or select and &qu= ot;OK" on a
>>> file), and Click then Enter should rename. I'm hesitant to= try to
>>> implement "slow double click to rename" as that woul= d likely need to
>>> be tunable for accessibility reasons.
>>
>> Ok, I will fix it.
>
> In the current scenario, the Enter Key is bound to the OK button by de= fault
> in Alertify dialog which servers the purpose of closing the dialog. > Should we de-attach Enter Key event bound to OK button and use it for = rename
> file?
> please suggest what should I do?

Hmm, good point.

How hard would it be to look for 2 consecutive single-clicks (but not
a double-click) for rename? If we can do that, it avoids timing
considerations for double-clicks (which would be defined by the OS).
=C2=A0
I tried to implement slow double click, her= e is Fiddle=C2=A0
There are two events 1) double click (it will be used for folder navigatio= n)
2) Slow double click(For rename), It is a simple click event, = when clicked twice after delay we consider it a slow double click.

But it is not working smoothly, double click and single cl= ick events are conflicting.

Also, we have rename b= utton in navigation for rename operation,=C2=A0
Can we skip slow = double click because it is very confusing?


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--e89a8f22beeb99e68105376a20ea--