Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1adxFm-00017o-SI for pgadmin-hackers@arkaria.postgresql.org; Thu, 10 Mar 2016 09:51:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1adxFl-0004c6-Vk for pgadmin-hackers@arkaria.postgresql.org; Thu, 10 Mar 2016 09:51:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1adxFl-0004bv-8R for pgadmin-hackers@postgresql.org; Thu, 10 Mar 2016 09:51:33 +0000 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1adxFc-0000HD-Vp for pgadmin-hackers@postgresql.org; Thu, 10 Mar 2016 09:51:32 +0000 Received: by mail-wm0-x235.google.com with SMTP id l68so20994332wml.0 for ; Thu, 10 Mar 2016 01:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=q5Tj/nrlopVlP6cZewCL23yzYILfykSxjMQAUdocYWA=; b=ub9nS2S7NAfwDBuYRcH04dt2hYLoEUJfCNnPWS4WOqTcSGffuD78w3fNoJ00SLFZsM QpnhsSYc3k+OdlRlfp5/tIri3ytW7AQOTix2+RC+yGUWJ/Oko+XIR40OIt7wxRmDahvy HQXyGw8wQDVK5T4DzYH6SCwZNr1sZG1VtM0HFdwXclXVkUIhPJm+Rhla/F1qdHq4z+2f BhfYPoodQ9hk8HHUFB6Ag0rxKIPusEPOOoqtBu44SwE8mB0rcqSkc8YA7IRmut8N/OIU sy7RC6Br5eVgru1lSNIDkRWXWh/nr5CYbIanx9Es8IN79PhqGpj6vzCe8JzyvSQNh6x0 XsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=q5Tj/nrlopVlP6cZewCL23yzYILfykSxjMQAUdocYWA=; b=dHDp9fjGsmswmxNzxsxENU3cKMwML9/7KHPaiNgmOxcJGZ+O1ZP7Iwug020gyHkayD qchSxCM4V85Pfd5+9wN6XhHwiBgZHtggbj9XZSVgnck+5XjCP1j/jnJAVBQNbzEpRCrl fqb9Lu+N8wztXA6MKiEHv7dgFvaP05aWR2/jRI3dHpAMywpsgWgkeLX4b2CN8fz38Xra 17ZSA70XHCsrnYHA9JP2DsFmfr17c6K0QxliRqlIm+eNO5kYfc6LmU675KpZSv3q4Rjs T6/N2X9q3Z8xcYL84dJst20lokGNPtwt9XAqNpXAq3cCdIn3sQvK/wM7ABs3C0e5CU0u mmdA== X-Gm-Message-State: AD7BkJKCaij/588GejXwyuUQ7K9Qcw3At3sdUlY+g5FT/p2wewU6dZB2CKAgdv3Uu7RTBTrS0z2vXClxZHlmjI2+ X-Received: by 10.28.128.83 with SMTP id b80mr2788066wmd.6.1457603484041; Thu, 10 Mar 2016 01:51:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.55.74 with HTTP; Thu, 10 Mar 2016 01:50:54 -0800 (PST) In-Reply-To: References: From: Surinder Kumar Date: Thu, 10 Mar 2016 15:20:54 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Grant Wizard To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1142052ce3d7de052daec163 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1142052ce3d7de052daec163 Content-Type: text/plain; charset=UTF-8 Please apply Khusboo's patch for "Privileges macros under Schema" before using grant wizard patch. On Thu, Mar 10, 2016 at 2:52 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > PFA patch after rebasing. > > On Wed, Mar 9, 2016 at 11:04 PM, Dave Page wrote: > >> Sorry Surinder - can you rebase this please? I think it was broken by >> 8a7ec6b45221f042bc39c9bce2c577e12b43cc3a :-( > > >> > How much work would it be to enable it to work at database level as well? > > It depends on whether we need to enable grant wizard for all nodes under > database level or > enable it for specific nodes under database level. > >> >> On Tue, Mar 8, 2016 at 1:48 PM, Surinder Kumar >> wrote: >> > The menu option is dependent only on certain nodes like: >> > >> > 1. Schema Node >> > 2. Views Collection Node >> > 3. Tables Collection Node >> > 4. Sequences Collection Node >> > 5. Functions Collection Node >> > >> > It will be enabled on click of above listed nodes. >> > >> > On Tue, Mar 8, 2016 at 6:57 PM, Dave Page wrote: >> >> >> >> On Tue, Mar 8, 2016 at 10:00 AM, Surinder Kumar >> >> wrote: >> >> > Hi, >> >> > >> >> > I forgot to add 'node.ui.js' file in the previous patch, please >> ignore >> >> > the >> >> > previous patch. >> >> > Attached is the new patch, >> >> > >> >> > Please review the patch and let me know for any comments. >> >> >> >> Is this dependent on any other patches? The menu option never seems to >> >> be enabled for me when I test against git-master. >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a1142052ce3d7de052daec163 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Please apply Khusboo's patch for "Privileges macr= os under Schema" before using grant wizard patch.

On Thu, Mar 10, 2016 at 2:52 PM, Surinder Kumar <= ;surin= der.kumar@enterprisedb.com> wrote:
Hi,

PFA patch after rebasing.=

On Wed, Mar 9, 2016 at 11:04 PM, Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:
Sorry Surinder - can you rebase t= his please? I think it was broken by
8a7ec6b45221f042bc39c9bce2c577e12b43cc3a :-(=C2=A0
=C2=A0
How much work would it be to enable it to work at database level as well?
It depends on whether we need to enable grant wizard= for all nodes under database level or
enable it for specific nod= es under=C2=A0database=C2=A0level.

On Tue, Mar 8, 2016 at 1:48 PM, Surinder Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
> The menu option is dependent only on certain nodes like:
>
> 1. Schema Node
> 2. Views Collection Node
> 3. Tables Collection Node
> 4. Sequences Collection Node
> 5. Functions Collection Node
>
> It will be enabled on click of above listed nodes.
>
> On Tue, Mar 8, 2016 at 6:57 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Tue, Mar 8, 2016 at 10:00 AM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > I forgot to add 'node.ui.js' file in the previous pat= ch, please ignore
>> > the
>> > previous patch.
>> > Attached is the new patch,
>> >
>> > Please review the patch and let me know for any comments.
>>
>> Is this dependent on any other patches? The menu option never seem= s to
>> be enabled for me when I test against git-master.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a1142052ce3d7de052daec163--