Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx79R-0004sO-Ev for pgadmin-hackers@arkaria.postgresql.org; Thu, 20 Oct 2016 06:48:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bx79R-00011Q-1s for pgadmin-hackers@arkaria.postgresql.org; Thu, 20 Oct 2016 06:48:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bx79Q-00011F-01 for pgadmin-hackers@postgresql.org; Thu, 20 Oct 2016 06:48:28 +0000 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bx79N-0005PW-3x for pgadmin-hackers@postgresql.org; Thu, 20 Oct 2016 06:48:27 +0000 Received: by mail-qk0-x236.google.com with SMTP id f128so71961738qkb.1 for ; Wed, 19 Oct 2016 23:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=TfNbaGngZr2GEAn7rt/Bf2waO39MRlq95R2BHigNzHw=; b=crtYCskGar6krnTZNryiOJyBQJGARhp2Uj8EEyXDUIm7ks2283cCB2U0mjcGBOkawb 6fX2VjniSRpQwHDBD5yBbEO6u8fogKSh1+ACav8E9xXnoFiEmfzGqmmk0GKA/jR5b+J6 R9yQg98lMuUXLy30WiD2TkZFpNfhJsmE2b4Z6tt1bdl9CXR7ZMfYGqjFmEVW+pyFoPak rGJOLY4jjfinKXEkAuR8liI/Ua7KIrFErTm1qLJ4APjtJyvNDhOaZpmI2rzUhbn2rd3i j++nVRWIj3uNjOOwIpZzGv35Zlfw5EQyWVQVMleqL9wvqcWrXrxdLuhaYRXfj3GIBh0R if1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TfNbaGngZr2GEAn7rt/Bf2waO39MRlq95R2BHigNzHw=; b=EGOCYw8RZRBzrmIH7EmXZJD6FK939Z2VbQSTXxCkuN0etBuGXvkMsijFsJj7jcgDSb pKkPWnhGOOpO/IV6oAP1G49dvmUiq72SEc0IbYPGwLSYgzS99I4l4ljXWKhcJw62ocul qC7E+5YOCDoBpshThCNwyIdFW65RxYyWnxt+qg7KPAbG19Ayhsl66WYGR8fUIFTeWVTw NejseqCN71E3ngYlgHdFf6aG7QE0aOx1Q3h2x+ldqROUMdPcqN0HieTpkTJyMTzpGI8O JwaaOVwUpgorIG8+3qSro2/9rMzg/GLWEA99QhnpxfhCNg8WsMNOQo6luEfyNRAnoAmZ /yUg== X-Gm-Message-State: AA6/9RlnI7o9xJqElzjxq5CLd9QT/82Rp/V5jjpYYTA9xqx7qPy87XFjT2XNAChzZefyAnyJLegif1tvLE5UVMRV X-Received: by 10.194.158.131 with SMTP id wu3mr6492814wjb.93.1476946103014; Wed, 19 Oct 2016 23:48:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Wed, 19 Oct 2016 23:47:52 -0700 (PDT) From: Surinder Kumar Date: Thu, 20 Oct 2016 12:17:52 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: pgadmin-hackers Content-Type: multipart/mixed; boundary=089e013c67dad2c30a053f464f89 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e013c67dad2c30a053f464f89 Content-Type: multipart/alternative; boundary=089e013c67dad2c305053f464f87 --089e013c67dad2c305053f464f87 Content-Type: text/plain; charset=UTF-8 Hi, The options like "sort" and "nulls" must be conditional. i.e. include only when access method type is other than "gist" or "gin". Please find attached patch and review. Thanks, Surinder Kumar --089e013c67dad2c305053f464f87 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,=

The options like "s= ort" and "nulls" must be conditional. i.e. include only when= access method type is other than "gist" or "gin".

Please find attached patch an= d review.

<= /div>
Thanks,
Surinder Kumar

--089e013c67dad2c305053f464f87-- --089e013c67dad2c30a053f464f89 Content-Type: application/octet-stream; name="RM1840.patch" Content-Disposition: attachment; filename="RM1840.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iuhzjeym0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMv aW5kZXgvc3FsLzkuMV9wbHVzL2NyZWF0ZS5zcWwgYi93ZWIvcGdhZG1pbi9i cm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1h cy90YWJsZXMvdGVtcGxhdGVzL2luZGV4L3NxbC85LjFfcGx1cy9jcmVhdGUu c3FsCmluZGV4IDVjMmRjMDUuLjMzYWYxOTcgMTAwNjQ0Ci0tLSBhL3dlYi9w Z2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNl cy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvaW5kZXgvc3FsLzkuMV9wbHVz L2NyZWF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJf Z3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBs YXRlcy9pbmRleC9zcWwvOS4xX3BsdXMvY3JlYXRlLnNxbApAQCAtMyw4ICsz LDggQEAgQ1JFQVRFIHslIGlmIGRhdGEuaW5kaXN1bmlxdWUgJX1VTklRVUUg eyUgZW5kaWYgJX1JTkRFWCB7JSBpZiBkYXRhLmlzY29uY3VycmVudAoKIHsl IGlmIG1vZGUgPT0gJ2NyZWF0ZScgJX0KICAgICAoeyUgZm9yIGMgaW4gZGF0 YS5jb2x1bW5zICV9eyUgaWYgbG9vcC5pbmRleCAhPSAxICV9LCB7JSBlbmRp ZiAlfXt7Y29ubnxxdElkZW50KGMuY29sbmFtZSl9fXslIGlmIGMuY29sbHNw Y25hbWUgJX0gQ09MTEFURSB7e2MuY29sbHNwY25hbWV9fXslIGVuZGlmICV9 eyUgaWYgYy5vcF9jbGFzcyAlfQotIHt7Yy5vcF9jbGFzc319eyUgZW5kaWYg JX17JSBpZiBjLnNvcnRfb3JkZXIgaXMgZGVmaW5lZCAlfXslIGlmIGMuc29y dF9vcmRlciAlfSBERVNDeyUgZWxzZSAlfSBBU0N7JSBlbmRpZiAlfXslIGVu ZGlmICV9eyUgaWYgYy5udWxscyBpcyBkZWZpbmVkICV9IE5VTExTIHslIGlm IGMubnVsbHMgJX0KLUZJUlNUeyUgZWxzZSAlfUxBU1R7JSBlbmRpZiAlfXsl IGVuZGlmICV9eyUgZW5kZm9yICV9KQorIHt7Yy5vcF9jbGFzc319eyUgZW5k aWYgJX17JSBpZiBkYXRhLmFtbmFtZSBpcyBkZWZpbmVkIGFuZCBkYXRhLmFt bmFtZSBub3QgaW4gWydnaXN0JywgJ2dpbiddICV9eyUgaWYgYy5zb3J0X29y ZGVyIGlzIGRlZmluZWQgJX17JSBpZiBjLnNvcnRfb3JkZXIgJX0gREVTQ3sl IGVsc2UgJX0gQVNDeyUgZW5kaWYgJX17JSBlbmRpZiAlfXslIGlmIGMubnVs bHMgaXMgZGVmaW5lZCAlfSBOVUxMUyB7JSBpZiBjLm51bGxzICV9CitGSVJT VHslIGVsc2UgJX1MQVNUeyUgZW5kaWYgJX17JSBlbmRpZiAlfXslIGVuZGlm ICV9eyUgZW5kZm9yICV9KQogeyUgZWxzZSAlfQogeyMjIFdlIHdpbGwgZ2V0 IGluZGVudGVkIGRhdGEgZnJvbSBwb3N0Z3JlcyBmb3IgY29sdW1uICMjfQog ICAgICh7JSBmb3IgYyBpbiBkYXRhLmNvbHVtbnMgJX17JSBpZiBsb29wLmlu ZGV4ICE9IDEgJX0sIHslIGVuZGlmICV9e3tjLmNvbG5hbWV9fXslIGlmIGMu Y29sbHNwY25hbWUgJX0gQ09MTEFURSB7e2MuY29sbHNwY25hbWV9fXslIGVu ZGlmICV9eyUgaWYgYy5vcF9jbGFzcyAlfQpAQCAtMTYsNCArMTYsNCBAQCBG SVJTVHslIGVsc2UgJX1MQVNUeyUgZW5kaWYgJX17JSBlbmRpZiAlfXslIGVu ZGZvciAlfSkKIHslIGVuZGlmICV9eyUgaWYgZGF0YS5zcGNuYW1lICV9CiAg ICAgVEFCTEVTUEFDRSB7e2Nvbm58cXRJZGVudChkYXRhLnNwY25hbWUpfX17 JSBlbmRpZiAlfXslIGlmIGRhdGEuaW5kY29uc3RyYWludCAlfQogICAgIFdI RVJFIHt7ZGF0YS5pbmRjb25zdHJhaW50fX0KLXslIGVuZGlmICV9OwpcIE5v IG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKK3slIGVuZGlmICV9Owo= --089e013c67dad2c30a053f464f89 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --089e013c67dad2c30a053f464f89--