public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions
Date: Tue, 13 Sep 2016 19:11:08 +0530
Message-ID: <CAM5-9D-xe-YzHwH+6-v5ePx8bABsJbLCP=Ykmtcho1XSHQ7u9A@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

Trailing spaces included in SELECT Script due to *Indentation issue*.
Please find attached patch.

Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM1690.patch (1.2K, 3-RM1690.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
index f269dcb..6fcfd64 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
@@ -1320,7 +1320,7 @@ It may have been removed by another user or moved to another schema.
         """
         # Fetch the function definition.
         SQL = render_template("/".join([self.sql_template_path,
-                                        'get_definition.sql']), fnid=fnid, scid=scid)
+                              'get_definition.sql']), fnid=fnid, scid=scid)
         status, res = self.conn.execute_2darray(SQL)
         if not status:
             return internal_server_error(errormsg=res)
@@ -1338,7 +1338,7 @@ It may have been removed by another user or moved to another schema.
             for arg in list(set(args)):
                 formatted_arg = '\n\t<' + arg + '>'
                 name = name.replace(arg, formatted_arg)
-                name = name.replace(')', '\n)')
+            name = name.replace(')', '\n)')

         sql = "SELECT {0}".format(name)

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM1690 - Trailing spaces included in SELECT Script for functions
  In-Reply-To: <CAM5-9D-xe-YzHwH+6-v5ePx8bABsJbLCP=Ykmtcho1XSHQ7u9A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox