MIME-Version: 1.0
From: Surinder Kumar <surinder.kumar@enterprisedb.com>
Date: Tue, 12 Jul 2016 15:27:44 +0530
Message-ID: 
 <CAM5-9D80C1BH7xENfmrzjo+RS_=N1ijBx7chvDykBUtarSUfrA@mail.gmail.com>
Subject: [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error
 displayed if create any object through simplified Chinese character
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary=001a114174e0ab768005376d4edf
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a114174e0ab768005376d4edf
Content-Type: multipart/alternative; boundary=001a114174e0ab767b05376d4edd

--001a114174e0ab767b05376d4edd
Content-Type: text/plain; charset=UTF-8

Hi

*What is happening in code?*
Database is created with Chinese characters successfully with ascii
values(Chinese characters converted to ascii) before saving internally.

but when database properties is retrieved by name, it fails to fetch data
and throws UnicodeError.

*Solution:*
Database name should be encoded in 'utf-8' before storing to database.
This resolved the issue.
I have tested this patch by creating database name using Japanese and
Chinese characters. It works.

Also referenced the code to *set default encoding to 'uff-8' *before start
of application.
https://github.com/joeyespo/grip/issues/86

@Ashesh/@Dave can you please review the patch?
If it looks good, we can do the same changes in case of other nodes.

Thanks,
Surinder Kumar

--001a114174e0ab767b05376d4edd
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div><br></div><div><div><u>What is happening in code?</=
u></div><div>Database is created with Chinese characters successfully with =
ascii values(Chinese characters converted to ascii) before saving internall=
y.</div><div><br></div><div>but when database properties is retrieved by na=
me, it fails to fetch data and throws UnicodeError.</div><div><br></div><di=
v><u>Solution:</u></div><div>Database name should be encoded in &#39;utf-8&=
#39; before storing to database.</div><div>This resolved the issue.=C2=A0</=
div><div>I have tested this patch by creating database name using Japanese =
and Chinese characters. It works.</div><div><br></div><div>Also referenced =
the code to <b>set default encoding to &#39;uff-8&#39; </b>before start of =
application.</div><div><a href=3D"https://github.com/joeyespo/grip/issues/8=
6">https://github.com/joeyespo/grip/issues/86</a><br></div><div><br></div><=
div>@Ashesh/@Dave can you please review the patch?</div><div>If it looks go=
od, we can do the same changes in case of other nodes.</div><div><br></div>=
<div>Thanks,</div><div>Surinder Kumar</div><div><br></div><div><br></div><d=
iv><br></div></div></div>

--001a114174e0ab767b05376d4edd--

--001a114174e0ab768005376d4edf
Content-Type: application/octet-stream; name="RM#1419.patch"
Content-Disposition: attachment; filename="RM#1419.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_iqjads2d0

ZGlmZiAtLWdpdCBhL3dlYi9wZ0FkbWluNC5weSBiL3dlYi9wZ0FkbWluNC5w
eQppbmRleCBiNjc5Y2Q2Li5lYjc1OTMxIDEwMDY0NAotLS0gYS93ZWIvcGdB
ZG1pbjQucHkKKysrIGIvd2ViL3BnQWRtaW40LnB5CkBAIC04Niw2ICs4Niwx
MiBAQCBpZiBub3QgUEdBRE1JTl9SVU5USU1FOgogICAgICAgICAgIChjb25m
aWcuQVBQX05BTUUsIHNlcnZlcl9wb3J0KSkKICAgICBzeXMuc3Rkb3V0LmZs
dXNoKCkKCisjIFRvIGhhbmRsZSBub24tZW5nbGlzaCBjaGFyYWN0ZXJzIHNl
dCBkZWZhdWx0IGVuY29kaW5nCisjIHRvIHV0Zi04CisjIFJlZmVyZW5jZWQg
ZnJvbSBodHRwczovL2dpdGh1Yi5jb20vam9leWVzcG8vZ3JpcC9pc3N1ZXMv
ODYKK3JlbG9hZChzeXMpCitzeXMuc2V0ZGVmYXVsdGVuY29kaW5nKCd1dGYt
OCcpCisKIHRyeToKICAgICBhcHAucnVuKAogICAgICAgICBob3N0PWNvbmZp
Zy5ERUZBVUxUX1NFUlZFUiwKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jy
b3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9fX2luaXRf
Xy5weSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2
ZXJzL2RhdGFiYXNlcy9fX2luaXRfXy5weQppbmRleCAxZjdmZDA3Li4zNDAw
N2FlIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n
cm91cHMvc2VydmVycy9kYXRhYmFzZXMvX19pbml0X18ucHkKKysrIGIvd2Vi
L3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJh
c2VzL19faW5pdF9fLnB5CkBAIC0xMSw2ICsxMSw3IEBACgogaW1wb3J0IGpz
b24KIGltcG9ydCByZQoraW1wb3J0IHN5cwogZnJvbSBmdW5jdG9vbHMgaW1w
b3J0IHdyYXBzCgogaW1wb3J0IHBnYWRtaW4uYnJvd3Nlci5zZXJ2ZXJfZ3Jv
dXBzLnNlcnZlcnMgYXMgc2VydmVycwpAQCAtNDUzLDYgKzQ1NCw3IEBAIGNs
YXNzIERhdGFiYXNlVmlldyhQR0NoaWxkTm9kZVZpZXcpOgogICAgICAgICAg
ICAgICAgICAgICApCiAgICAgICAgICAgICAgICAgKQogICAgICAgICB0cnk6
CisgICAgICAgICAgICBkYXRhWyduYW1lJ10gPSBkYXRhWyduYW1lJ10uZW5j
b2RlKHN5cy5nZXRkZWZhdWx0ZW5jb2RpbmcoKSkKICAgICAgICAgICAgICMg
VGhlIGJlbG93IFNRTCB3aWxsIGV4ZWN1dGUgQ1JFQVRFIERETCBvbmx5CiAg
ICAgICAgICAgICBTUUwgPSByZW5kZXJfdGVtcGxhdGUoCiAgICAgICAgICAg
ICAgICAgIi8iLmpvaW4oW3NlbGYudGVtcGxhdGVfcGF0aCwgJ2NyZWF0ZS5z
cWwnXSksCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZl
cl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9fX2luaXRfXy5w
eSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz
L2RhdGFiYXNlcy9zY2hlbWFzL19faW5pdF9fLnB5CmluZGV4IDM3N2U2Zjcu
LmIzNWQ5MzIgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy
dmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL19faW5pdF9f
LnB5CisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9z
ZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL19faW5pdF9fLnB5CkBAIC05LDYg
KzksNyBAQAoKIGltcG9ydCBqc29uCiBpbXBvcnQgcmUKK2ltcG9ydCBzeXMK
IGZyb20gZnVuY3Rvb2xzIGltcG9ydCB3cmFwcwoKIGltcG9ydCBwZ2FkbWlu
LmJyb3dzZXIuc2VydmVyX2dyb3Vwcy5zZXJ2ZXJzIGFzIHNlcnZlcnMKQEAg
LTUwOSw2ICs1MTAsNyBAQCBJdCBtYXkgaGF2ZSBiZWVuIHJlbW92ZWQgYnkg
YW5vdGhlciB1c2VyLgogICAgICAgICAgICAgICAgICkKICAgICAgICAgdHJ5
OgogICAgICAgICAgICAgc2VsZi5mb3JtYXRfcmVxdWVzdF9hY2xzKGRhdGEp
CisgICAgICAgICAgICBkYXRhWyduYW1lJ10gPSBkYXRhWyduYW1lJ10uZW5j
b2RlKHN5cy5nZXRkZWZhdWx0ZW5jb2RpbmcoKSkKICAgICAgICAgICAgIFNR
TCA9IHJlbmRlcl90ZW1wbGF0ZSgKICAgICAgICAgICAgICAgICAiLyIuam9p
bihbc2VsZi50ZW1wbGF0ZV9wYXRoLCAnc3FsL2NyZWF0ZS5zcWwnXSksCiAg
ICAgICAgICAgICAgICAgZGF0YT1kYXRhLCBjb25uPXNlbGYuY29ubiwgXz1n
ZXR0ZXh0Cg==

--001a114174e0ab768005376d4edf
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--001a114174e0ab768005376d4edf--