Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsOGX-0005pq-6X for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 06:04:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bsOGV-0004v5-Gr for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 06:04:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsOGI-0004gp-8B for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 06:04:02 +0000 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bsOGF-0007Be-Gi for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 06:04:00 +0000 Received: by mail-wm0-x22c.google.com with SMTP id k125so12221102wma.1 for ; Thu, 06 Oct 2016 23:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=Qogs+Tqw2IQaey7ymRY2sW2a/4SVPGYeVahs9Bnay6o=; b=aBhEghn0+HK25VqjcwfyrZKjptYsNv8p+zwivtaezUpsO53MgyWGO27+qUP6w5J5hv OvBtWQ/WE02Cp8+8gg7SBZx4rD2dJGAG1RzMs0KQNdd1GmAbQ99xRRIBaqqdMpDOcUGc b6obfznGQFMUbXSJFoTikcZLgx2HjcmPtFp5AvMZQmk254QStqsoRMEohR/6TJnefEWn LTK4HHAe2lKc1x8z4Bg6X8y13EwUsG9LJ8x7rj18y1JHPvllpISbONgu+uC09lxYySbn BOt9fEoAxJRYuzFk/AaMZbQDx2XpExG+fT5oVSkwaCRRJo/dhvIWez9Z7SvaPEkIfqnw bmwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Qogs+Tqw2IQaey7ymRY2sW2a/4SVPGYeVahs9Bnay6o=; b=OvAidG1qXn7hc+b1Q5rlyNUO0jnO6niUYLkFB8LEFtwrD+eHABJ19Mtdd8rqYVPwlp 0qhUNl7ACfSrcMs2xBiL3hZDaQURf+1G3Zh+TWSYhBHVbROUavsYHZtz+i0wI+X0H681 02e5uIQmOeTitcXL2d/uweJILxFrOkc19qso+Hzd1ChyX6SuaDOcl2z9JXAknlAujwTu Ri7GaraKGAnJWHys9r40W5Z8WkIgGEVIXL5WXXgLuRXgBu0rEIsjeu0tfXT86pFfJT2f 92FEqKwuPYjtA8orZDiQJv1cyeNKnqyMvuvVfNRbtA9+1jU0BjhGKVZ5VmgVj61Jh9q+ J8MQ== X-Gm-Message-State: AA6/9RnqR/G5J9DlzJmNue0ON6xYcLj+c/FTlUt7gGhY9YcDi5yxCBQE0YxfatDnzuTkO+zWj1SOAHeq18PCgIE6 X-Received: by 10.194.51.5 with SMTP id g5mr15006004wjo.68.1475820236981; Thu, 06 Oct 2016 23:03:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Thu, 6 Oct 2016 23:03:26 -0700 (PDT) From: Surinder Kumar Date: Fri, 7 Oct 2016 11:33:26 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager] To: pgadmin-hackers Content-Type: multipart/mixed; boundary=bcaec508f4eefa7eb3053e402c11 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --bcaec508f4eefa7eb3053e402c11 Content-Type: multipart/alternative; boundary=bcaec508f4eefa7eb1053e402c0f --bcaec508f4eefa7eb1053e402c0f Content-Type: text/plain; charset=UTF-8 Hi, *Issue:* When clicked on upload icon while saving a file prompt user to leave page. It is because the icon is a button and its type is set to submit which makes it to prompt, instead it should be 'button' Storage Manager's menu items depends on capabilities list set by the module using it. If capabilities doesn't have 'upload' in it, It won't work. Upload button is bound to click event only when it is in capabilities. *Solution:* As upload button is being added only when it is in capabilities, so upload button html is removed from html file. It will not shown on UI untill it is in capabilities list. Please find attached patch and review. Thanks, Surinder Kumar --bcaec508f4eefa7eb1053e402c0f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,=

Issue:
When clicked on up= load icon while saving a file prompt user to leave page. It is because the = icon is a button and its type is set to submit which makes it to prompt, in= stead it should be 'button'

Storage Manager's menu items depends on capabilities list se= t by the module using it. If capabilities doesn't have 'upload'= in it, It won't work. Upload button is bound to click event only when = it is in capabilities.

Solution:
As upload button is being added only when it is in capabilities, so = upload button html is removed from html file. It will not shown on UI until= l it is in capabilities list.

Please find attached patch and review.


Thanks,
Surinder Kumar

--bcaec508f4eefa7eb1053e402c0f-- --bcaec508f4eefa7eb3053e402c11 Content-Type: application/octet-stream; name="RM1739.patch" Content-Disposition: attachment; filename="RM1739.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itzd8d0y0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL3Rl bXBsYXRlcy9maWxlX21hbmFnZXIvaW5kZXguaHRtbCBiL3dlYi9wZ2FkbWlu L21pc2MvZmlsZV9tYW5hZ2VyL3RlbXBsYXRlcy9maWxlX21hbmFnZXIvaW5k ZXguaHRtbAppbmRleCAzOTZlOTUwLi4xOTczODZmIDEwMDc1NQotLS0gYS93 ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci90ZW1wbGF0ZXMvZmlsZV9t YW5hZ2VyL2luZGV4Lmh0bWwKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9maWxl X21hbmFnZXIvdGVtcGxhdGVzL2ZpbGVfbWFuYWdlci9pbmRleC5odG1sCkBA IC0xOCw4ICsxOCw2IEBACiAgICAgICAgICAgICA8aW5wdXQgY2xhc3M9Im1v ZGUiIG5hbWU9Im1vZGUiIHR5cGU9ImhpZGRlbiIgdmFsdWU9ImFkZCIvPgog ICAgICAgICAgICAgPGlucHV0IGNsYXNzPSJjdXJyZW50cGF0aCIgbmFtZT0i Y3VycmVudHBhdGgiIHR5cGU9ImhpZGRlbiIvPgogICAgICAgICAgICAgPGJ1 dHRvbiB0eXBlPSJidXR0b24iIHRpdGxlPSJSZWZyZXNoIiBjbGFzcz0iYnRu IGZhIGZhLXJlZnJlc2ggcmVmcmVzaCI+PC9idXR0b24+Ci0gICAgICAgICAg ICA8YnV0dG9uIHR5cGU9InN1Ym1pdCIgdGl0bGU9IlVwbG9hZCBGaWxlIiB2 YWx1ZT0iVXBsb2FkIiBjbGFzcz0iYnRuIGZhIGZhLXVwbG9hZCB1cGxvYWQi PjxzcGFuPjwvc3Bhbj4KLSAgICAgICAgICAgIDwvYnV0dG9uPgogICAgICAg ICAgICAgPGJ1dHRvbiB0eXBlPSJidXR0b24iIHRpdGxlPSJEb3dubG9hZCBG aWxlIiBjbGFzcz0iYnRuIGZhIGZhLWRvd25sb2FkIGRvd25sb2FkIiBkaXNh YmxlZD48c3Bhbj48L3NwYW4+CiAgICAgICAgICAgICA8L2J1dHRvbj4KICAg ICAgICAgICAgIDxidXR0b24gbmFtZT0iZGVsZXRlIiB0eXBlPSJidXR0b24i IHRpdGxlPSJEZWxldGUgRmlsZS9Gb2xkZXIiIGNsYXNzPSJidG4gZmEgZmEt dHJhc2ggZGVsZXRlIiBkaXNhYmxlZD4KZGlmZiAtLWdpdCBhL3dlYi9wZ2Fk bWluL21pc2MvZmlsZV9tYW5hZ2VyL3RlbXBsYXRlcy9maWxlX21hbmFnZXIv anMvdXRpbGl0eS5qcyBiL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2Vy L3RlbXBsYXRlcy9maWxlX21hbmFnZXIvanMvdXRpbGl0eS5qcwppbmRleCA4 ZDg5MWZkLi4xYmY3Y2Q2IDEwMDc1NQotLS0gYS93ZWIvcGdhZG1pbi9taXNj L2ZpbGVfbWFuYWdlci90ZW1wbGF0ZXMvZmlsZV9tYW5hZ2VyL2pzL3V0aWxp dHkuanMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvdGVt cGxhdGVzL2ZpbGVfbWFuYWdlci9qcy91dGlsaXR5LmpzCkBAIC0xNDE4LDcg KzE0MTgsNyBAQCBpZiAoaGFzX2NhcGFiaWxpdHkoZGF0YSwgJ3VwbG9hZCcp KSB7CiAgICQoJy51cGxvYWQnKS5yZW1vdmUoKTsKICAgJCggIi5jcmVhdGUi ICkuYmVmb3JlKCAnPGJ1dHRvbiB2YWx1ZT0iVXBsb2FkIiB0eXBlPSJidXR0 b24iIHRpdGxlPSJVcGxvYWQgRmlsZSIgbmFtZT0idXBsb2FkIiBpZD0idXBs b2FkIiBjbGFzcz0iYnRuIGZhIGZhLXVwbG9hZCB1cGxvYWQiPjxzcGFuPjwv c3Bhbj48L2J1dHRvbj4gJyApOwoKLSAgJCgnLnVwbG9hZCcpLnVuYmluZCgp LmNsaWNrKGZ1bmN0aW9uKCkgeworICAkKCcjdXBsb2FkZXIgLnVwbG9hZCcp LnVuYmluZCgpLmNsaWNrKGZ1bmN0aW9uKCkgewogICAgIC8vIHdlIGNyZWF0 ZSBwcm9tcHQKICAgICB2YXIgbXNnICA9ICc8ZGl2IGlkPSJkcm9wem9uZS1j b250YWluZXIiPicgKwogICAgICAgICAgICc8YnV0dG9uIGNsYXNzPSJmYSBm YS10aW1lcyBkel9jcm9zc19idG4iPjwvYnV0dG9uPicgKwo= --bcaec508f4eefa7eb3053e402c11 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --bcaec508f4eefa7eb3053e402c11--