Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkqB7-0004AY-QE for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Sep 2016 10:15:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkqB7-0001Hy-Cr for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Sep 2016 10:15:29 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkqAu-0000vh-5i for pgadmin-hackers@postgresql.org; Fri, 16 Sep 2016 10:15:16 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkqAr-00017j-Ii for pgadmin-hackers@postgresql.org; Fri, 16 Sep 2016 10:15:14 +0000 Received: by mail-wm0-x230.google.com with SMTP id k186so32345159wmd.0 for ; Fri, 16 Sep 2016 03:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=lPxMmZA7sw/NVXy84EIQipEHEWKowZ+Ch+BxInQBZZI=; b=jeV1dFGD2JA485OhPsFQu59N9o6xIDjhul6dpvU/GpiwX5wbN3klMUwtbcinM2B0Zc EJLFM8BkBwBoInsvfXoMSomJF5I371xtoK79zlgbjSnhRp3lOCgupm70voH0+MkQvheA FA46orh3evPzsRKRsDPBdSrN3J6LzBmvSs3VW17FgO0GUtwTli8EzURtwDoi6msIaWto yzjrLKuXR9rZz8kPISrYyohbJU6DtOmdmfgVYdkiO5IpPGQBRsFWoQUvd36QbOvYfEUh 6/W9Gr+qyMQPsfjQoi/xBF18hfOYBDbXXFWmh4INTRjEd3FhMOz8o/AOzmxTOYc4h0MO q07Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lPxMmZA7sw/NVXy84EIQipEHEWKowZ+Ch+BxInQBZZI=; b=WQD1HK+cyemzDPbh2UI48Z6IATXXqpB6a9qdBHlyfkQdPztKZNJnfz0zpch5KXTP1r YRjInt9EqMNMVs8D4CH/373plEc1oMz7YCOKL7t0h5/n9+vtXUjOvFtzjMcTzcivjw1z pMGM5/BLZXL4yvRgnxaQOWlg+8yV91t1FcEPQl+o7iht7zvK6W6o+hNem9ToLVnL9lrI nlQ2gwxyIOLvBWgF/JhltigPIAWfM2XozlbXfuii5UQMzwXSkToD8qfzmGScfESyMxn5 wZADC/GuixyD7+FNOPlLMjfCkTcwii1jrZtc0wb6BpGCn4jSpgaC6g1B9DmAzzKXQjiF jq4w== X-Gm-Message-State: AE9vXwMPvHe1h2d07D0MZKXUSpdQ1Hg/PC/YZPuWXxuGI4eOLB23/Mn6w9J3GE7D6jGGWjHIJDVXQU3+sXeMVRCD X-Received: by 10.28.138.205 with SMTP id m196mr7644730wmd.44.1474020911754; Fri, 16 Sep 2016 03:15:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 16 Sep 2016 03:14:41 -0700 (PDT) From: Surinder Kumar Date: Fri, 16 Sep 2016 15:44:41 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM1595 - "no results to fetch error" displayed if modify definition with other table To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11435c2cd68ad3053c9d3c9b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11435c2cd68ad3053c9d3c9b Content-Type: multipart/alternative; boundary=001a11435c2cd68ace053c9d3c99 --001a11435c2cd68ace053c9d3c99 Content-Type: text/plain; charset=UTF-8 Hi *Issues fixed:* 1) Creating a m-view with *definition* and then updating view with* new definition,* it results into an error *"No results to fetch"*. 2) When definition of m-view is updated, it creates a new m-view with different OID, but it wasn't updating the old OID with new OID of tree node in tree view. thus on switching to another tab (e.g.: sql), it throws message *"Cannot find materialized view"*. Please find attached patch and review. Thanks, Surinder Kumar --001a11435c2cd68ace053c9d3c99 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Issues fixed:

1) Creat= ing a m-view with definition and then updating view with new defi= nition, it results into an error "No results to fetch"= .

2) When definition of m= -view is updated, it creates a new m-view with different OID, but it wasn&#= 39;t updating the old OID with new OID of tree node in tree view. thus on s= witching to another tab (e.g.: sql), it throws message "Cannot find= materialized view".

Please find attached patch and review.

Thanks,
Surinder Kumar
--001a11435c2cd68ace053c9d3c99-- --001a11435c2cd68ad3053c9d3c9b Content-Type: application/octet-stream; name="RM1595.patch" Content-Disposition: attachment; filename="RM1595.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it5lyvpp0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3ZpZXdzL19faW5pdF9fLnB5 IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMv ZGF0YWJhc2VzL3NjaGVtYXMvdmlld3MvX19pbml0X18ucHkKaW5kZXggZThh Mzc1ZS4uYjYwZTQ2MiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nl ci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdmll d3MvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2 ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdmlld3MvX19p bml0X18ucHkKQEAgLTUzNiw3ICs1MzYsNyBAQCBjbGFzcyBWaWV3Tm9kZShQ R0NoaWxkTm9kZVZpZXcsIFZhY3V1bVNldHRpbmdzKToKICAgICAgICAgdHJ5 OgogICAgICAgICAgICAgU1FMLCBuYW1lID0gc2VsZi5nZXRTUUwoZ2lkLCBz aWQsIGRhdGEsIHZpZCkKICAgICAgICAgICAgIFNRTCA9IFNRTC5zdHJpcCgn XG4nKS5zdHJpcCgnICcpCi0gICAgICAgICAgICBzdGF0dXMsIHJlcyA9IHNl bGYuY29ubi5leGVjdXRlX3NjYWxhcihTUUwpCisgICAgICAgICAgICBzdGF0 dXMsIHJlcyA9IHNlbGYuY29ubi5leGVjdXRlX3ZvaWQoU1FMKQogICAgICAg ICAgICAgaWYgbm90IHN0YXR1czoKICAgICAgICAgICAgICAgICByZXR1cm4g aW50ZXJuYWxfc2VydmVyX2Vycm9yKGVycm9ybXNnPXJlcykKCmRpZmYgLS1n aXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBsYXRlcy9icm93c2VyL2pz L2Jyb3dzZXIuanMgYi93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBsYXRlcy9i cm93c2VyL2pzL2Jyb3dzZXIuanMKaW5kZXggZTI3ODcxNy4uMTUxZDA1YiAx MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci90ZW1wbGF0ZXMvYnJv d3Nlci9qcy9icm93c2VyLmpzCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIv dGVtcGxhdGVzL2Jyb3dzZXIvanMvYnJvd3Nlci5qcwpAQCAtMTE0MCwxNiAr MTE0MCwyNCBAQCBmdW5jdGlvbihyZXF1aXJlLCAkLCBfLCBTLCBCb290c3Ry YXAsIHBnQWRtaW4sIEFsZXJ0aWZ5LCBDb2RlTWlycm9yKSB7CiAgICAgICAg ICAgfS5iaW5kKGN0eCksCiAgICAgICAgICAgdXBkYXRlTm9kZSA9IGZ1bmN0 aW9uKCkgewogICAgICAgICAgICAgaWYgKAotICAgICAgICAgICAgICB0aGlz LmkgJiYgdGhpcy5kICYmIHRoaXMubmV3Ll9pZCA9PSB0aGlzLmQuX2lkICYm Ci0gICAgICAgICAgICAgIHRoaXMubmV3Ll90eXBlID09IHRoaXMuZC5fdHlw ZQorICAgICAgICAgICAgICB0aGlzLmkgJiYgdGhpcy5kICYmIHRoaXMubmV3 Ll90eXBlID09IHRoaXMuZC5fdHlwZQogICAgICAgICAgICAgKSB7Ci0gICAg ICAgICAgICAgIC8vIEZvdW5kIHRoZSBjdXJyZWN0Ci0gICAgICAgICAgICAg IF8uZXh0ZW5kKHRoaXMuZCwgdGhpcy5uZXcuX2lkKTsKLSAgICAgICAgICAg ICAgdGhpcy50LnNldExhYmVsKGN0eC5pLCB7bGFiZWw6IHRoaXMubmV3Lmxh YmVsfSk7Ci0gICAgICAgICAgICAgIHRoaXMudC5hZGRJY29uKGN0eC5pLCB7 aWNvbjogdGhpcy5uZXcuaWNvbn0pOwotICAgICAgICAgICAgICB0aGlzLnQu c2V0SWQoY3R4LmlkLCB7aWQ6IHRoaXMubmV3LmlkfSk7Ci0gICAgICAgICAg ICAgIHRoaXMudC5vcGVuUGF0aCh0aGlzLmkpOwotICAgICAgICAgICAgICB0 aGlzLnQuc2VsZWN0KHRoaXMuaSk7CisgICAgICAgICAgICAgIHZhciBfaWQg PSB0aGlzLmQuX2lkOworICAgICAgICAgICAgICBpZiAodGhpcy5uZXcuX2lk ICE9IHRoaXMuZC5faWQpIHsKKyAgICAgICAgICAgICAgICAvLyBGb3VuZCB0 aGUgbmV3IG9pZCwgdXBkYXRlIGl0cyBub2RlX2lkCisgICAgICAgICAgICAg ICAgdmFyIG5vZGVfZGF0YSA9IHRoaXMudC5pdGVtRGF0YShjdHguaSk7Cisg ICAgICAgICAgICAgICAgbm9kZV9kYXRhLl9pZCA9IF9pZCA9IHRoaXMubmV3 Ll9pZDsKKyAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICBpZiAodGhp cy5uZXcuX2lkID09IF9pZCkgeworICAgICAgICAgICAgICAgIC8vIEZvdW5k IHRoZSBjdXJyZWN0CisgICAgICAgICAgICAgICAgXy5leHRlbmQodGhpcy5k LCB0aGlzLm5ldy5faWQpOworICAgICAgICAgICAgICAgIHRoaXMudC5zZXRM YWJlbChjdHguaSwge2xhYmVsOiB0aGlzLm5ldy5sYWJlbH0pOworICAgICAg ICAgICAgICAgIHRoaXMudC5hZGRJY29uKGN0eC5pLCB7aWNvbjogdGhpcy5u ZXcuaWNvbn0pOworICAgICAgICAgICAgICAgIHRoaXMudC5zZXRJZChjdHgu aWQsIHtpZDogdGhpcy5uZXcuaWR9KTsKKyAgICAgICAgICAgICAgICB0aGlz LnQub3BlblBhdGgodGhpcy5pKTsKKyAgICAgICAgICAgICAgICB0aGlzLnQu ZGVzZWxlY3QodGhpcy5pKTsKKyAgICAgICAgICAgICAgICB0aGlzLnQuc2Vs ZWN0KHRoaXMuaSk7CisgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIHZhciBzdWNjZXNzID0gdGhpcy5vICYmIHRoaXMuby5z dWNjZXNzOwogICAgICAgICAgICAgaWYgKHN1Y2Nlc3MgJiYgdHlwZW9mKHN1 Y2Nlc3MpID09ICdmdW5jdGlvbicpIHsK --001a11435c2cd68ad3053c9d3c9b Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11435c2cd68ad3053c9d3c9b--