Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP355-00018f-KA for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jul 2016 07:35:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bP355-0004j6-7P for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jul 2016 07:35:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bP354-0004iw-Om for pgadmin-hackers@postgresql.org; Mon, 18 Jul 2016 07:35:10 +0000 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bP351-00004z-JD for pgadmin-hackers@postgresql.org; Mon, 18 Jul 2016 07:35:10 +0000 Received: by mail-wm0-x236.google.com with SMTP id o80so102499831wme.1 for ; Mon, 18 Jul 2016 00:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=7d0UnkXvWp53U0NzFWBjQaFY0y8C5kf6X+PfqWOpIrY=; b=m918dk5LwyWPqo+I6VtIh0p5CP856+MqQTffmL4+DWJIcD1+MpUU27gp8hphLKkmdJ G1Qj24KUfZbjh2i3UCP90sImsMfyxZu+oiyfOdsLM4WKVyDXgvPL9qkmf6akvk1iQsUt ao+40018J4Z0YrNAkxd34L9DQTP+eWoeBNu/iR1xyaZ/RNSevuB0qDtNqkmmHORfR9EV UqFyf4sIqGLXIUu3xJnHKkxXC5OxFqcoT6LO/IU413bre2av87HdQVUdXUV1odl7WNOr sm8E5kHpAkBtv7rYJKE04siKiqNMy7zg2spITcI42ru7REHumYbK9/H623L2fo+v7QFi ALlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=7d0UnkXvWp53U0NzFWBjQaFY0y8C5kf6X+PfqWOpIrY=; b=XoZ9wd60BWbhWj+r+LWPp7EzlIi9y0wgCjNkK6LYNkk3lbIHd5R09IqrAhxUbpeYgW BzKPzR3Sh2ZOGK8kmC1Veil6/GWVM0yalPwUkMVe8eS+TAUra2LbNFDyUOn+EchGazpf e1UNpWLFAhmPdGaOr1ne4x0qrlzskwA+RWaf2FPGxX2V/sSu6u0NpeGVj+1uixDbH/3d NIDX7DZE8eWUB6YVnjqATeTTg5PrC4+fY/YGNQEPMSmFRzomgAG7wnBLmq1iDHGPgzAK wsOMHhKT2VbzkwrnqZRqx6XTI1o5Qpa5Th3q1XKBj5whASHE+ML4rgVu7hp8f7JKURNH FbCg== X-Gm-Message-State: ALyK8tIN49GMtrhVaNgRbMMad70luQ9GO1OYyvt4hwnt/gRxu+p5GN1hdM7bF230/lMadgW9dNueoSa7BY/tddO0 X-Received: by 10.28.44.131 with SMTP id s125mr34726586wms.61.1468827303896; Mon, 18 Jul 2016 00:35:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Mon, 18 Jul 2016 00:34:34 -0700 (PDT) From: Surinder Kumar Date: Mon, 18 Jul 2016 13:04:34 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1143ad2eaf9bec0537e401f7 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143ad2eaf9bec0537e401f7 Content-Type: multipart/alternative; boundary=001a1143ad2eaf9be60537e401f5 --001a1143ad2eaf9be60537e401f5 Content-Type: text/plain; charset=UTF-8 Hi Please find attached patch for the fix: *Issue:* This issue is regression of one of the flickering issue of RM#1242. "Aside from displaying/hiding the spinner, panes should have their content refreshed until and unless the new data differs from the previous, to reduce flicker" *Solution:* Along with caching the node node, we should also keep track of the previous node clicked. Fetch new data iff previous node and current node clicked differs. Please review. Thanks, Surinder Kumar --001a1143ad2eaf9be60537e401f5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

Please find attached patch for the f= ix:
Issue:
This issue is regression of one = of the flickering issue of RM#1242.
"Aside from displaying/hiding the spinner, panes should ha= ve their content refreshed until and unless the new data differs from the p= revious, to reduce flicker"

Sol= ution:
Along with caching the node node, we should also keep = track of the previous node clicked.
Fetch new data iff previous n= ode and current node clicked differs.

Please= review.

Thanks,
Surinder Kumar
--001a1143ad2eaf9be60537e401f5-- --001a1143ad2eaf9bec0537e401f7 Content-Type: application/octet-stream; name="RM#1462.patch" Content-Disposition: attachment; filename="RM#1462.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqrpx0n40 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jy b3dzZXIvanMvY29sbGVjdGlvbi5qcyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIv dGVtcGxhdGVzL2Jyb3dzZXIvanMvY29sbGVjdGlvbi5qcwppbmRleCA3NzFj YzA3Li45NjAzZWQwIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2Vy L3RlbXBsYXRlcy9icm93c2VyL2pzL2NvbGxlY3Rpb24uanMKKysrIGIvd2Vi L3BnYWRtaW4vYnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9jb2xsZWN0 aW9uLmpzCkBAIC0xMDMsMTIgKzEwMywxNCBAQCBmdW5jdGlvbigkLCBfLCBT LCBwZ0FkbWluLCBCYWNrYm9uZSwgQWxlcnRpZnksIEJhY2tmb3JtKSB7CiAg ICAgICAgICAgbl92YWx1ZSA9IHRyZWVIaWVyYXJjaHlbbl90eXBlXS5faWQ7 CiAgICAgICAgIH0KCi0gICAgICAgIGlmIChuX3ZhbHVlID09ICQocGFuZWwp LmRhdGEobl90eXBlKSkgeworICAgICAgICBpZiAobl92YWx1ZSA9PSAkKHBh bmVsKS5kYXRhKG5fdHlwZSkgJiYKKyAgICAgICAgICAgIG5fdHlwZSA9PSAk KHBhbmVsKS5kYXRhKCd1bmlxX2lkJykpIHsKICAgICAgICAgICByZXR1cm47 CiAgICAgICAgIH0KCiAgICAgICAgIC8vIENhY2hlIHRoZSBjdXJyZW50IElE cyBmb3IgbmV4dCB0aW1lCiAgICAgICAgICQocGFuZWwpLmRhdGEobl90eXBl LCBuX3ZhbHVlKTsKKyAgICAgICAgJChwYW5lbCkuZGF0YSgndW5pcV9pZCcs IG5fdHlwZSk7CgogICAgICAgICAvLyBSZXNldCB0aGUgZGF0YSBvYmplY3QK ICAgICAgICAgai5kYXRhKCdvYmotdmlldycsIG51bGwpOwpkaWZmIC0tZ2l0 IGEvd2ViL3BnYWRtaW4vYnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9u b2RlLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nl ci9qcy9ub2RlLmpzCmluZGV4IGU1YTk2YzQuLjM4YzcxMTYgMTAwNjQ0Ci0t LSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jyb3dzZXIvanMv bm9kZS5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBsYXRlcy9i cm93c2VyL2pzL25vZGUuanMKQEAgLTgwNCwxMiArODA0LDE0IEBAIGZ1bmN0 aW9uKCQsIF8sIFMsIHBnQWRtaW4sIE1lbnUsIEJhY2tib25lLCBBbGVydGlm eSwgcGdCcm93c2VyLCBCYWNrZm9ybSkgewogICAgICAgICAgICAgbl92YWx1 ZSA9IHRyZWVIaWVyYXJjaHlbbl90eXBlXS5faWQ7CiAgICAgICAgICAgfQoK LSAgICAgICAgICBpZiAobl92YWx1ZSA9PSAkKHBhbmVsKS5kYXRhKG5fdHlw ZSkpIHsKKyAgICAgICAgICBpZiAobl92YWx1ZSA9PSAkKHBhbmVsKS5kYXRh KG5fdHlwZSkgJiYKKyAgICAgICAgICAgICAgbl90eXBlID09ICQocGFuZWwp LmRhdGEoJ3VuaXFfaWQnKSkgewogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICAgIH0KCiAgICAgICAgICAgLy8gQ2FjaGUgdGhlIGN1cnJlbnQgSURz IGZvciBuZXh0IHRpbWUKICAgICAgICAgICAkKHBhbmVsKS5kYXRhKG5fdHlw ZSwgbl92YWx1ZSk7CisgICAgICAgICAgJChwYW5lbCkuZGF0YSgndW5pcV9p ZCcsIG5fdHlwZSk7CgogICAgICAgICAgIGlmICghY29udGVudC5oYXNDbGFz cygnaGFzLXBnLXByb3AtYnRuLWdyb3VwJykpCiAgICAgICAgICAgICBjb250 ZW50LmFkZENsYXNzKCdoYXMtcGctcHJvcC1idG4tZ3JvdXAnKTsKZGlmZiAt LWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvZGVwZW5kcy9zdGF0aWMvanMvZGVw ZW5kcy5qcyBiL3dlYi9wZ2FkbWluL21pc2MvZGVwZW5kcy9zdGF0aWMvanMv ZGVwZW5kcy5qcwppbmRleCA2ODgzYWEzLi5hNzJjZjg5IDEwMDY0NAotLS0g YS93ZWIvcGdhZG1pbi9taXNjL2RlcGVuZHMvc3RhdGljL2pzL2RlcGVuZHMu anMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9kZXBlbmRzL3N0YXRpYy9qcy9k ZXBlbmRzLmpzCkBAIC0xOTIsMTIgKzE5MiwxNCBAQCBkZWZpbmUoCiAgICAg ICAgIG5fdmFsdWUgPSB0cmVlSGllcmFyY2h5W25fdHlwZV0uX2lkOwogICAg ICAgfQoKLSAgICAgIGlmIChuX3ZhbHVlID09ICQocGFuZWxbMF0pLmRhdGEo bl90eXBlKSkgeworICAgICAgaWYgKG5fdmFsdWUgPT0gJChwYW5lbFswXSku ZGF0YShuX3R5cGUpICYmCisgICAgICAgICAgbl90eXBlID09ICQocGFuZWwp LmRhdGEoJ3VuaXFfaWQnKSkgewogICAgICAgICByZXR1cm47CiAgICAgICB9 CgogICAgICAgLy8gQ2FjaGUgdGhlIGN1cnJlbnQgSURzIGZvciBuZXh0IHRp bWUKICAgICAgICQocGFuZWxbMF0pLmRhdGEobl90eXBlLCBuX3ZhbHVlKTsK KyAgICAgICQocGFuZWwpLmRhdGEoJ3VuaXFfaWQnLCBuX3R5cGUpOwoKCiAg ICAgICAvLyBIaWRlIHRoZSBncmlkIGNvbnRhaW5lciBhbmQgc2hvdyB0aGUg ZGVmYXVsdCBtZXNzYWdlIGNvbnRhaW5lcgpkaWZmIC0tZ2l0IGEvd2ViL3Bn YWRtaW4vbWlzYy9zcWwvc3RhdGljL2pzL3NxbC5qcyBiL3dlYi9wZ2FkbWlu L21pc2Mvc3FsL3N0YXRpYy9qcy9zcWwuanMKaW5kZXggOWMwNmM2NS4uNTZi MTY3MyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vbWlzYy9zcWwvc3RhdGlj L2pzL3NxbC5qcworKysgYi93ZWIvcGdhZG1pbi9taXNjL3NxbC9zdGF0aWMv anMvc3FsLmpzCkBAIC03NCwxMiArNzQsMTQgQEAgZnVuY3Rpb24oXywgJCwg cGdCcm93c2VyKSB7CiAgICAgICAgICAgICAgICAgICBuX3ZhbHVlID0gdHJl ZUhpZXJhcmNoeVtuX3R5cGVdLl9pZDsKICAgICAgICAgICAgICAgfQoKLSAg ICAgICAgICAgICAgaWYgKG5fdmFsdWUgPT0gJChzcWxQYW5lbHNbMF0pLmRh dGEobl90eXBlKSkgeworICAgICAgICAgICAgICBpZiAobl92YWx1ZSA9PSAk KHNxbFBhbmVsc1swXSkuZGF0YShuX3R5cGUpICYmCisgICAgICAgICAgICAg ICAgICBuX3R5cGUgPT0gJChzcWxQYW5lbHMpLmRhdGEoJ3VuaXFfaWQnKSkg ewogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgfQoK ICAgICAgICAgICAgICAgLy8gQ2FjaGUgdGhlIGN1cnJlbnQgSURzIGZvciBu ZXh0IHRpbWUKLSAgICAgICAgICAgICAgJCh0aGlzLnNxbFBhbmVsc1swXSku ZGF0YShuX3R5cGUsIG5fdmFsdWUpOworICAgICAgICAgICAgICAkKHNxbFBh bmVsc1swXSkuZGF0YShuX3R5cGUsIG5fdmFsdWUpOworICAgICAgICAgICAg ICAkKHNxbFBhbmVscykuZGF0YSgndW5pcV9pZCcsIG5fdHlwZSk7CgogICAg ICAgICAgICAgICBzcWwgPSAnJzsKICAgICAgICAgICAgICAgdmFyIHVybCA9 IG5vZGUuZ2VuZXJhdGVfdXJsKGl0ZW0sICdzcWwnLCBkYXRhLCB0cnVlKTsK ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGlzdGljcy9zdGF0 aWMvanMvc3RhdGlzdGljcy5qcyBiL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGlz dGljcy9zdGF0aWMvanMvc3RhdGlzdGljcy5qcwppbmRleCBmMTIxN2FlLi44 N2EwYzIzIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL3N0YXRpc3Rp Y3Mvc3RhdGljL2pzL3N0YXRpc3RpY3MuanMKKysrIGIvd2ViL3BnYWRtaW4v bWlzYy9zdGF0aXN0aWNzL3N0YXRpYy9qcy9zdGF0aXN0aWNzLmpzCkBAIC0x NjYsMTIgKzE2NiwxNCBAQCBmdW5jdGlvbihfLCAkLCBwZ0Jyb3dzZXIsIEJh Y2tncmlkKSB7CiAgICAgICAgICAgICBuX3ZhbHVlID0gdHJlZUhpZXJhcmNo eVtuX3R5cGVdLl9pZDsKICAgICAgICAgICB9CgotICAgICAgICAgIGlmIChu X3ZhbHVlID09ICQodGhpcy5wYW5lbFswXSkuZGF0YShuX3R5cGUpKSB7Cisg ICAgICAgICAgaWYgKG5fdmFsdWUgPT0gJCh0aGlzLnBhbmVsWzBdKS5kYXRh KG5fdHlwZSkgJiYKKyAgICAgICAgICAgICAgbl90eXBlID09ICQocGFuZWwp LmRhdGEoJ3VuaXFfaWQnKSkgewogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICAgIH0KCiAgICAgICAgICAgLy8gQ2FjaGUgdGhlIGN1cnJlbnQgSURz IGZvciBuZXh0IHRpbWUKICAgICAgICAgICAkKHRoaXMucGFuZWxbMF0pLmRh dGEobl90eXBlLCBuX3ZhbHVlKTsKKyAgICAgICAgICAkKHBhbmVsKS5kYXRh KCd1bmlxX2lkJywgbl90eXBlKTsKCiAgICAgICAgICAgLyogU2V0IHRoZSBt ZXNzYWdlIGJlY2F1c2UgYWpheCByZXF1ZXN0IG1heSB0YWtlIHRpbWUgdG8K ICAgICAgICAgICAgKiBmZXRjaCB0aGUgaW5mb3JtYXRpb24gZnJvbSB0aGUg c2VydmVyLgo= --001a1143ad2eaf9bec0537e401f7 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1143ad2eaf9bec0537e401f7--