Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aydX8-00005E-Pm for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 11:02:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aydX7-0000Cn-Ft for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 11:02:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aydX6-0000Cg-Te for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 11:02:57 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aydX3-0007hz-Tx for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 11:02:55 +0000 Received: by mail-wm0-x231.google.com with SMTP id e201so53195826wme.0 for ; Fri, 06 May 2016 04:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=KNYcMiyg/7+9VrKKJRNUTMi5oVfO6jOFaqOXnzbIXoA=; b=DJgSwpNjLyPOFMrzRSTmc2hs6FRrzaPWpcsQYwC2h8PcjIHpCEIdrJghCS3gd2J6M4 e7a7n5UMeM66ot1mv6/aYPDQjEh6aQizXkdY4gGxI4HlGvAUb2+kC+BoMV/R5heaz1G+ Y96ksQp6ApNov6C6MM3MwIQETEg/Dcq6SAfK3t8b1kAInLtCYGK3nIE4hNMf+ATMSziX uXtQWy7VGWswXHqB+mUTklurm5yvqShFEdFICxU81oGeuKw4ry4CHDvGUqAQIIQhtYfL q+1EN8UxiMYlYxEejW0GmtHB9tDQY+tAnn1a9+CKHf2+mRXa/FMjj30d7+0/1jz61hKx 7Y4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KNYcMiyg/7+9VrKKJRNUTMi5oVfO6jOFaqOXnzbIXoA=; b=UiCZd0iHX1KCxJt52+J6eNEm9NI1fYMzaE23iK6u7zqyEHIVp6cG3RnVR3A93AcGJk awmyAWLW6rlwcuHfOnCGw6mviQdluU0iUgA2+Ne/MrzwpRUNXlwTlcAkct0KB3XwC+tt WpsT0PiwUvZ+eEy+sdcXCYe1Clm2ITvEK5KyhzDTiOU8sy5Rh4B+3B01vHIARHmg/skj cNuvoUXsN0fz0yvXF+8v68sgxhKVAMXXddYRlbApTI5gejhwv7Bvf57cNSSZJqGgxa5K WrZDd9A3lyK2BursNyyh+TgaIFayAycDXeyGqZlKn4ClFKL2aBNIL15zgy9Ih8q/p+nv js8A== X-Gm-Message-State: AOPr4FXAcJ1+FG3zVo31eaTxjlARwBDJM4nwt/UDyOUW0XT1j6diCfIV5xSurKNywECYR39pJpGkWAwnYeFfbAAt X-Received: by 10.28.0.87 with SMTP id 84mr8738621wma.68.1462532572277; Fri, 06 May 2016 04:02:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.53.133 with HTTP; Fri, 6 May 2016 04:02:22 -0700 (PDT) From: Surinder Kumar Date: Fri, 6 May 2016 16:32:22 +0530 Message-ID: Subject: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113c9f6e719bcb05322a66a4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113c9f6e719bcb05322a66a4 Content-Type: multipart/alternative; boundary=001a113c9f6e719bc705322a66a2 --001a113c9f6e719bc705322a66a2 Content-Type: text/plain; charset=UTF-8 Hi, PFA patch to fix the issue: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder", due to wrong schema name in generated SQL query. *For example*: It generates following query for '*postgis_toplology*' extension: CREATE EXTENSION *postgis_topology* SCHEMA *topology*; which is wrong. the correct query should be: CREATE EXTENSION *postgis_topology*; where it fetches '*topology*' schema from table *pg_available_extensions* and then sets schema when extension name is selected, but it should not set schema on name change. It is now fixed in this patch. Thanks Fahar for reporting. Please review and let me know for comments. Thanks, Surinder Kumar --001a113c9f6e719bc705322a66a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch to fix the issue:
Unable to create extension "postgis_topology" and "postgi= s_tiger_geocoder", due to wrong schema name in generated SQL query.

For example:

It gene= rates following query for 'postgis_toplology' extension:
CREATE EXTENSION <= b>postgis_topology SCHEMA=C2=A0topology;

which is wrong. the correct que= ry should be:
CREATE EXTENSION postgis_topology;

wher= e it fetches 'topology' schema from table pg_available_ex= tensions and=C2=A0
then sets schema when extension name is se= lected, but it should not set schema on name change.
It is now fi= xed in this patch.
Thanks Fahar for reporting.

Please review and let me know for comments.
Thanks,
Surinder Kumar
--001a113c9f6e719bc705322a66a2-- --001a113c9f6e719bcb05322a66a4 Content-Type: application/octet-stream; name="unable_to_create_ext_with_postgis.patch" Content-Disposition: attachment; filename="unable_to_create_ext_with_postgis.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_invm3dyx0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9leHRlbnNpb25zL3RlbXBsYXRlcy9leHRl bnNpb25zL2pzL2V4dGVuc2lvbnMuanMgYi93ZWIvcGdhZG1pbi9icm93c2Vy L3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvZXh0ZW5zaW9ucy90 ZW1wbGF0ZXMvZXh0ZW5zaW9ucy9qcy9leHRlbnNpb25zLmpzCmluZGV4IDdl Y2M0OWYuLjlhN2YyYjQgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dz ZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9leHRlbnNpb25z L3RlbXBsYXRlcy9leHRlbnNpb25zL2pzL2V4dGVuc2lvbnMuanMKKysrIGIv d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0 YWJhc2VzL2V4dGVuc2lvbnMvdGVtcGxhdGVzL2V4dGVuc2lvbnMvanMvZXh0 ZW5zaW9ucy5qcwpAQCAtMTU0LDkgKzE1NCw3IEBAIGZ1bmN0aW9uKCQsIF8s IFMsIHBnQWRtaW4sIHBnQnJvd3NlcikgewogICAgICAgICAgICAgICAgICAg ICAndmVyc2lvbicgOiAnJywKICAgICAgICAgICAgICAgICAgICAgJ3JlbG9j YXRhYmxlJzogKAogICAgICAgICAgICAgICAgICAgICAgICAgKCFfLmlzTnVs bChkLnJlbG9jYXRhYmxlWzBdKSAmJiAhXy5pc1VuZGVmaW5lZChkLnJlbG9j YXRhYmxlWzBdKSkgPwotICAgICAgICAgICAgICAgICAgICAgICAgZC5yZWxv Y2F0YWJsZVswXTogJycpLAotICAgICAgICAgICAgICAgICAgICAnc2NoZW1h JzogKCghXy5pc051bGwoZC5zY2hlbWFbMF0pICYmCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICFfLmlzVW5kZWZpbmVkKGQuc2NoZW1hWzBdKSkgPyBk LnNjaGVtYVswXTogJycpCisgICAgICAgICAgICAgICAgICAgICAgICBkLnJl bG9jYXRhYmxlWzBdOiAnJykKICAgICAgICAgICAgICAgICAgICAgfTsKICAg ICAgICAgICAgICAgICAgIHRoaXMubW9kZWwuc2V0KGNoYW5nZXMpOwogICAg ICAgICAgICAgICAgIH0KQEAgLTE2OCw2ICsxNjYsMjggQEAgZnVuY3Rpb24o JCwgXywgUywgcGdBZG1pbiwgcGdCcm93c2VyKSB7CiAgICAgICAgICAgICB9 KQogICAgICAgICAgIH0sCiAgICAgICAgICAgeworICAgICAgICAgICAgaWQ6 ICdzZWxlY3RfZmlsZScsIGxhYmVsOiAne3sgXygnU2VsZWN0IGZpbGUnKX19 JywKKyAgICAgICAgICAgIHR5cGU6ICd0ZXh0JywgbW9kZTogWydwcm9wZXJ0 aWVzJywgJ2NyZWF0ZSddLCBjb250cm9sOiBCYWNrZm9ybS5GaWxlQ29udHJv bCwKKyAgICAgICAgICAgIGRpYWxvZ190eXBlOiAnc2VsZWN0X2ZpbGUnLCBz dXBwX3R5cGVzOiBbJyonLCAncGRmJywgJ3RleHQnLCAncGF0Y2gnLCAncHkn XQorICAgICAgICAgIH0sCisgICAgICAgICAgeworICAgICAgICAgICAgaWQ6 ICdzZWxlY3RfZm9sZGVyJywgbGFiZWw6ICd7eyBfKCdTZWxlY3QgZm9sZGVy Jyl9fScsCisgICAgICAgICAgICB0eXBlOiAndGV4dCcsIG1vZGU6IFsncHJv cGVydGllcycsICdjcmVhdGUnXSwgY29udHJvbDogQmFja2Zvcm0uRmlsZUNv bnRyb2wsCisgICAgICAgICAgICBkaWFsb2dfdHlwZTogJ3NlbGVjdF9mb2xk ZXInCisgICAgICAgICAgfSwKKyAgICAgICAgICB7CisgICAgICAgICAgICBp ZDogJ2NyZWF0ZV9maWxlJywgbGFiZWw6ICd7eyBfKCdDcmVhdGUnKX19JywK KyAgICAgICAgICAgIHR5cGU6ICd0ZXh0JywgbW9kZTogWydwcm9wZXJ0aWVz JywgJ2NyZWF0ZSddLCBjb250cm9sOiBCYWNrZm9ybS5GaWxlQ29udHJvbCwK KyAgICAgICAgICAgIGV4dHJhQ2xhc3NlczogWydicm93c2VfZmlsZV9pbnB1 dCddLCBkaWFsb2dfdHlwZTogJ2NyZWF0ZV9maWxlJywKKyAgICAgICAgICAg IHN1cHBfdHlwZXM6IFsnKicsICdwZGYnLCAndGV4dCcsICdweScsICd6aXAn XQorICAgICAgICAgIH0sCisgICAgICAgICAgeworICAgICAgICAgICAgaWQ6 ICdzdG9yYWdlX2RpYWxvZycsIGxhYmVsOiAne3sgXygnU3RvcmFnZSBtYW5h Z2VyJyl9fScsCisgICAgICAgICAgICB0eXBlOiAndGV4dCcsIG1vZGU6IFsn cHJvcGVydGllcycsICdjcmVhdGUnXSwgY29udHJvbDogQmFja2Zvcm0uRmls ZUNvbnRyb2wsCisgICAgICAgICAgICBleHRyYUNsYXNzZXM6IFsnYnJvd3Nl X2ZpbGVfaW5wdXQnXSwgZGlhbG9nX3R5cGU6ICdzdG9yYWdlX2RpYWxvZycs CisgICAgICAgICAgICBzdXBwX3R5cGVzOiBbJyonLCAncGRmJywgJ3RleHQn LCAncHknLCAnemlwJ10KKyAgICAgICAgICB9LAorICAgICAgICAgIHsKICAg ICAgICAgICAgIGlkOiAnZWlkJywgbGFiZWw6ICd7eyBfKCdPSUQnKX19Jywg Y2VsbDogJ3N0cmluZycsCiAgICAgICAgICAgICB0eXBlOiAndGV4dCcsIGRp c2FibGVkOiB0cnVlLCBtb2RlOiBbJ3Byb3BlcnRpZXMnXQogICAgICAgICAg IH0sCg== --001a113c9f6e719bcb05322a66a4 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113c9f6e719bcb05322a66a4--