Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpxKN-0007y6-HH for pgadmin-hackers@arkaria.postgresql.org; Fri, 30 Sep 2016 12:54:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bpxKM-00029A-Ve for pgadmin-hackers@arkaria.postgresql.org; Fri, 30 Sep 2016 12:54:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bpxK9-0001Tb-1S for pgadmin-hackers@postgresql.org; Fri, 30 Sep 2016 12:53:57 +0000 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bpxK1-00049L-9q for pgadmin-hackers@postgresql.org; Fri, 30 Sep 2016 12:53:55 +0000 Received: by mail-wm0-x232.google.com with SMTP id k125so24124221wma.1 for ; Fri, 30 Sep 2016 05:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=3m7awfeiAQtlR+rAJl3+1XrBELKlm/1X6MEX8ETlWuw=; b=dh4vExjbWuY9C8McsYOcgwi7jT0judbP9rDRHLWzx2ycz2go3up72E3rXhpX42Svqe XPal97Z36b6gz9l9xUWhbINmd6B+ACDG8oeMIPMp8Awq+YdH/NCQ5xeKLRslFQRIPGue RABaqnyE3/6oiIsMjxjSV7zf70/K4YDAoc9nHJqcKaoby3X10ExA6KKR20otWgsEIJ8k o0MWEF46UFFOrre/nQF1H0zGbB2GXt/d8hZp9f4wZReOuD9B+xkqHHEglxLJHPbRFPlD C7vn+DS9tec49lYyV1W++gR/ldA+/eJ7f7vL53Sn4YGGlmVlGWlUKb8x6Gl4pWsQdwUH 8JHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3m7awfeiAQtlR+rAJl3+1XrBELKlm/1X6MEX8ETlWuw=; b=AWHfXF8ZGK4kheqo4LpQF33zJhh5aaqkSkwHkNK71CotzTXvMgWj+3h3mVtu6RG+0f D6nXQU5MPZpy4X4OZdFCavp6z6IMHqc5feCxHEnGMwjMTfVuZEq24Rl6odSgDv78kJYX G4SrXEsYmKmIA9howGeMl5V1pdze4lc7CVygIJ88DmspUWVjnPMyLr++8SQDdgHV1Jmv 9wwwgnd0dcGgZ2hD63kLqQ8fJzsHxtrAAEVZhAX5hBFM5HJGpGuyobrG/oCsBK6T1uAl NgPipher9MAhJ/pOqUqCCOXb61y+uQ90YWxVCN+f92T3qlVEhi2vAZ6AHYHDZOz1FTkw 8oWw== X-Gm-Message-State: AA6/9Rm2cw+hyLVmBhuaHjL3Jat3Ky2ViZfERpDcsTojlck5PLgDdGx1tY8YU6bHDzAeVAR0iaUDzyy0Ic5tjKQU X-Received: by 10.28.138.205 with SMTP id m196mr4170856wmd.44.1475240027379; Fri, 30 Sep 2016 05:53:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 30 Sep 2016 05:53:16 -0700 (PDT) From: Surinder Kumar Date: Fri, 30 Sep 2016 18:23:16 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11435c2ccaa12c053db915d4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11435c2ccaa12c053db915d4 Content-Type: multipart/alternative; boundary=001a11435c2ccaa126053db915d2 --001a11435c2ccaa126053db915d2 Content-Type: text/plain; charset=UTF-8 Hi When we add new server and enter an invalid port, it validates and display error message, but sometimes it doesn't unset errorModel when a valid value is entered. Please find attached patch and review. Thanks, Surinder Kumar --001a11435c2ccaa126053db915d2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

When we add new server an= d enter an invalid port, it validates and display error message, but someti= mes it doesn't unset errorModel when a valid value is entered.

Please find attached patch and re= view.


Thanks,
Surinder Kumar
--001a11435c2ccaa126053db915d2-- --001a11435c2ccaa12c053db915d4 Content-Type: application/octet-stream; name="ensure_errormodel_unset_properly.patch" Content-Disposition: attachment; filename="ensure_errormodel_unset_properly.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itprsdwv0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5w Z2FkbWluLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBn YWRtaW4uanMKaW5kZXggZmE2ODgxOC4uMWQ5NmRlMCAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKKysr IGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMK QEAgLTE1NzMsNiArMTU3Myw3IEBACiAgICAgICAvLyBBZnRlciB2YWxpZGF0 aW9uIHdlIG5lZWQgdG8gc2V0IHRoYXQgdmFsdWUgaW50byBtb2RlbCAob25s eSBpZiBhbGwgZmxhZ3MgYXJlIHRydWUpCiAgICAgICBpZiAoaXNWYWxpZCkg ewogICAgICAgICB0aGlzLnN0b3BMaXN0ZW5pbmcodGhpcy5tb2RlbCwgImNo YW5nZToiICsgbmFtZSwgdGhpcy5yZW5kZXIpOworICAgICAgICB0aGlzLm1v ZGVsLmVycm9yTW9kZWwudW5zZXQobmFtZSk7CiAgICAgICAgIHRoaXMubW9k ZWwuc2V0KG5hbWUsIHZhbHVlKTsKICAgICAgICAgdGhpcy5saXN0ZW5Ubyh0 aGlzLm1vZGVsLCAiY2hhbmdlOiIgKyBuYW1lLCB0aGlzLnJlbmRlcik7CiAg ICAgICB9IGVsc2UgewpAQCAtMTY2Niw2ICsxNjY3LDcgQEAKICAgICAgIC8v IEFmdGVyIHZhbGlkYXRpb24gd2UgbmVlZCB0byBzZXQgdGhhdCB2YWx1ZSBp bnRvIG1vZGVsIChvbmx5IGlmIGFsbCBmbGFncyBhcmUgdHJ1ZSkKICAgICAg IGlmIChpc1ZhbGlkKSB7CiAgICAgICAgIHRoaXMuc3RvcExpc3RlbmluZyh0 aGlzLm1vZGVsLCAiY2hhbmdlOiIgKyBuYW1lLCB0aGlzLnJlbmRlcik7Cisg ICAgICAgIHRoaXMubW9kZWwuZXJyb3JNb2RlbC51bnNldChuYW1lKTsKICAg ICAgICAgdGhpcy5tb2RlbC5zZXQobmFtZSwgdmFsdWUpOwogICAgICAgICB0 aGlzLmxpc3RlblRvKHRoaXMubW9kZWwsICJjaGFuZ2U6IiArIG5hbWUsIHRo aXMucmVuZGVyKTsKICAgICAgIH0gZWxzZSB7Cg== --001a11435c2ccaa12c053db915d4 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11435c2ccaa12c053db915d4--