Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1biLK4-0002oC-7E for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Sep 2016 12:54:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1biLK3-0007qs-Jk for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Sep 2016 12:54:23 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1biLJq-0007cO-1S for pgadmin-hackers@postgresql.org; Fri, 09 Sep 2016 12:54:10 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1biLJm-0006wd-Uc for pgadmin-hackers@postgresql.org; Fri, 09 Sep 2016 12:54:08 +0000 Received: by mail-wm0-x22a.google.com with SMTP id 199so5314389wma.1 for ; Fri, 09 Sep 2016 05:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iBuYXlVtqZp5vXlYUerE4PDYjyE9Kcy0XOuw3a/Veik=; b=TcLzeNUkxYVvgNdKBZwg0NqjnB5PCaUVsg2TLi1F98h4TMRHIwF38490gAihT6/0z4 PqBSUq4ElxPZbAg1QNFbEKmwE9NztBS9HZrHYZqRjGM3ls46MPC6Zn3WdLstsFjWYR0V yUoHyavNjRBLjp81aawglnIkGshIpkduje3J/AAujzDp25HaJTCVrTfvOvPv/gLnuxTl uGusec68C5EGFX8NvHPUlnLm2mCD1shIMMimThgXJcDMRkBHXHRpG7JLu+OujGTHpPhQ OYB4h/InQp4acIK2cfRWiONzrUgAtB/MKkmA4CdQSTYdDDWnCbFKXb0zH35PnbRJpcoQ DEsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iBuYXlVtqZp5vXlYUerE4PDYjyE9Kcy0XOuw3a/Veik=; b=EUTXiTzGCprpHbW4PCZaHT2Cwrq7F2pXLKzaSssjsTHoymYlrPimxoEF7diRm2iPFc uyvr0LRaQfgcHU0Z2FJs4titeGprarm1TNhsYfaX2djjQR9K5SllbkB7FPbXg8A46cl6 TF4x2BwVnWrj0APTWk6/u9nXVGTXkV3SALHVZT5O1Tly+XwlkVh6pqc3m0E9oMDiYbWr NPkV2OyZ2l9agsvdqDKBytjph0XNeqa1Ksmbck7M/F0dmjntxQGy2erwNY2RSFxcdmEV 2KqTVeq3cvSTeDSOz6VL2mNC6qv9Xmz0wUNmW2wcCc+CBAjS8oRt45tjSftfn92vJGa9 ++YA== X-Gm-Message-State: AE9vXwNSFZWLLoab7LSHMBnL8C4aWHJLeAHyPZhOzeFIIKXdzYi2yFNLHkAJiD+FuW0AfmZxgTqTEJT7R/PPCzaU X-Received: by 10.28.206.8 with SMTP id e8mr2699291wmg.57.1473425645158; Fri, 09 Sep 2016 05:54:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 9 Sep 2016 05:53:34 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Fri, 9 Sep 2016 18:23:34 +0530 Message-ID: Subject: Re: PATCH: Python2.6 compatibility fixes (pgAdmin4) To: Dave Page Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c19437e2fe152053c12a421 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c19437e2fe152053c12a421 Content-Type: multipart/alternative; boundary=94eb2c19437e2fe14f053c12a41f --94eb2c19437e2fe14f053c12a41f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable *Please find attached patch with following fix:* 1) While running pgAdmin4 with latest git pull on Windows x64 environment, I got an exception on terminal console, > NameError > NameError: global name 'arch_keys' is not defined=E2=80=8B *=E2=80=8BIssue:=E2=80=8B* arch_keys was defined inside the method add_serv= er, but used outside the method. I have handled this issue in attached patch. On Tue, Sep 6, 2016 at 6:52 PM, Dave Page wrote: > Thanks, patch applied. > > On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala > wrote: > > +++ Adding related RM. > > > > RM#1636 & RM#1659 > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala > > wrote: > >> > >> Hi, > >> > >> PFA minor patch for Python2.6 compatibility with pgAdmin4. > >> Please review. > >> > >> > >> Regards, > >> Murtuza Zabuawala > >> EnterpriseDB: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --94eb2c19437e2fe14f053c12a41f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
= Please find attached patch with following fix:

1) While running pgAdmin4 = with latest git pull on Windows x64 environment, I got an exception on term= inal console,
NameError
NameError: global name = 9;arch_keys' is not defined=E2=80=8B
=C2=A0
=E2=80=8BIssue:=E2=80=8B=C2=A0arch_keys was defined insid= e the method add_server, but used outside the method.

I have handled this issue in attached patch.

On Tue, Sep 6= , 2016 at 6:52 PM, Dave Page <dpage@pgadmin.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">Thanks, patch applied.

On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> +++ Adding related RM.
>
> RM#1636 & RM#1659
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> PFA minor patch for Python2.6 compatibility with pgAdmin4.
>> Please review.
>>
>>
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers

--94eb2c19437e2fe14f053c12a41f-- --94eb2c19437e2fe152053c12a421 Content-Type: application/octet-stream; name="py_26_fix.patch" Content-Disposition: attachment; filename="py_26_fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_isvrjnvs0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL19faW5pdF9fLnB5IGIvd2ViL3Bn YWRtaW4vX19pbml0X18ucHkKaW5kZXggMjNjMTQ4OS4uZDk4ODE3MiAxMDA2 NDQKLS0tIGEvd2ViL3BnYWRtaW4vX19pbml0X18ucHkKKysrIGIvd2ViL3Bn YWRtaW4vX19pbml0X18ucHkKQEAgLTI0Nyw3ICsyNDcsNiBAQCBkZWYgY3Jl YXRlX2FwcChhcHBfbmFtZT1jb25maWcuQVBQX05BTUUpOgogICAgICAgICAn JydBZGQgYSBzZXJ2ZXIgdG8gdGhlIGNvbmZpZyBkYXRhYmFzZScnJwogICAg ICAgICBkZWYgYWRkX3NlcnZlcih1c2VyX2lkLCBzZXJ2ZXJncm91cF9pZCwg bmFtZSwgc3VwZXJ1c2VyLCBwb3J0LCBkaXNjb3ZlcnlfaWQsIGNvbW1lbnQp OgogICAgICAgICAjIENyZWF0ZSBhIHNlcnZlciBvYmplY3QgaWYgbmVlZGVk LCBhbmQgc3RvcmUgaXQuCi0gICAgICAgICAgICBhcmNoX2tleXMgPSBzZXQo KQogICAgICAgICAgICAgc2VydmVycyA9IFNlcnZlci5xdWVyeS5maWx0ZXJf YnkoCiAgICAgICAgICAgICAgICAgdXNlcl9pZD11c2VyX2lkLAogICAgICAg ICAgICAgICAgIGRpc2NvdmVyeV9pZD1zdnJfZGlzY292ZXJ5X2lkCkBAIC0y NzIsNiArMjcxLDcgQEAgZGVmIGNyZWF0ZV9hcHAoYXBwX25hbWU9Y29uZmln LkFQUF9OQU1FKToKCiAgICAgICAgICMgRmlndXJlIG91dCB3aGF0IHNlcnZl cnMgYXJlIHByZXNlbnQKICAgICAgICAgaWYgd2lucmVnIGlzIG5vdCBOb25l OgorICAgICAgICAgICAgYXJjaF9rZXlzID0gc2V0KCkKICAgICAgICAgICAg IHByb2NfYXJjaCA9IG9zLmVudmlyb25bJ1BST0NFU1NPUl9BUkNISVRFQ1RV UkUnXS5sb3dlcigpCgogICAgICAgICAgICAgdHJ5Ogo= --94eb2c19437e2fe152053c12a421 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c19437e2fe152053c12a421--