Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNzs5-0001Gf-P4 for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jul 2016 09:57:26 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNzs4-0007LL-TK for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jul 2016 09:57:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNzs3-0007LE-Og for pgadmin-hackers@postgresql.org; Fri, 15 Jul 2016 09:57:24 +0000 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNzrz-0003TO-Pb for pgadmin-hackers@postgresql.org; Fri, 15 Jul 2016 09:57:22 +0000 Received: by mail-wm0-x235.google.com with SMTP id o80so22377790wme.1 for ; Fri, 15 Jul 2016 02:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LLDD6NHAmwSzVUhYEJRk0wt9nsTs+tIOfGMQbx4PlGY=; b=JlAnt8l6IbDavR0kDdexfAzS8mhg7C48gLon/WChHwTmu3PeYWb4s99/5g2uz+TQB7 N0iyj+KetIwMuVywItmeciEkitCSIB58PmjhdeJ8lkIqnCD6Sce/xhDAbsowPERHALdE fKbjLNbpUxaRgadeMdGniWzChDmwRmhNXoCD0sAvj5nZqLvkqF3gaDFpqbrqhTgcbdwT t06/eQ5KG0/XreYKvgpNpl+LZz9uNFx+DrCwyytZJMvt9BExHgw9bxtuq9TuDeMY4UqV f8oLRrbE/zOWcnfjJ3p2zI9riq0prvt+JM0ogTxwiGlyUJap2YEZyQww0eLUGhxEYGWL F1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LLDD6NHAmwSzVUhYEJRk0wt9nsTs+tIOfGMQbx4PlGY=; b=SAsHGnMokC53KMK8yaf9Cbpjs6tdACVpNm4lc33FP1iWgmEY4E38eUq4K804ElFtiV cfeCR3Lhk2RVJPgeShfk5+wUjJaIxJtuoG5FmneWRcN/PHXa9pLckvNNzBxjE+iU8iPm PggaLD2suvd2QGuLroRlT6d4MnJcEM/sjqpoHk8IUtErBFlVtnaVZ8fTWC+/1C8JLfJS gpzmLTIPOFM1EAk+0s0jBu7EbOjPbBAKE0LG9LVoqlnU67qrT/XpfGBy6EJNXUWD2hL+ xcSPIf5144svduptNAwTmuI7qPxumJrzuwkB/0J1ccSdRIih/b/35f6Q+JzitnSmdlRd yc6w== X-Gm-Message-State: ALyK8tIM+AAMSpUisWWF4Wujo5rUWJjcEXYcs8RuJQJ3reO+5ofFyVheHWeYXf7ZIsE5DGErXR1h9Lp64wDljjy0 X-Received: by 10.28.37.134 with SMTP id l128mr40161235wml.49.1468576638107; Fri, 15 Jul 2016 02:57:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Fri, 15 Jul 2016 02:56:48 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Fri, 15 Jul 2016 15:26:48 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error To: Dave Page Cc: Marc Linster , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114e3704d7110f0537a9a409 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114e3704d7110f0537a9a409 Content-Type: text/plain; charset=UTF-8 On Fri, Jul 15, 2016 at 3:22 PM, Dave Page wrote: > Thanks Surinder, patch applied. > > I suspect the font rendering issue is related to others we've seen, > where the solution is to ensure the -webkit-transform CSS attribute is > set to none. Can you have a poke around with it please? > Sure Dave. I will do. > > On Wed, Jul 13, 2016 at 2:58 PM, Surinder Kumar > wrote: > > Please find updated patch. > > This patch also includes the fix for issue "File Browser - File does not > > exist error". > > > > On Wed, Jul 13, 2016 at 7:23 PM, Surinder Kumar > > wrote: > >> > >> I forgot to merge the fix for issue "File Browser - File does not exist > >> error" in the patch. > >> Please ignore this patch. > >> > >> On Wed, Jul 13, 2016 at 7:20 PM, Surinder Kumar > >> wrote: > >>> > >>> Please find updated patch with following changes/enhancements: > >>> > >>> Double click on file/folder icon or name will navigate to the > >>> folder/file. > >>> Selected file/folder can be renamed by Rename button only. Double click > >>> rename is removed. > >>> Filename text box will not hide on smaller screen. Setting minimum > width > >>> of File Browser fixed it. > >>> Path at top will only show directory name, not the file name and it is > >>> greyed out. > >>> > >>> Issue not fixed: > >>> Icons and fonts of Query tool and File Browser looks blurred in Runtime > >>> environment. > >>> I tried debugging it. while debugging, It gets fixed on my ubuntu > >>> runtime. but I don't know how it gets fixed without changing css > styles. It > >>> needs more time to debug. > >>> > >>> Please review. > >>> > >>> On Wed, Jul 13, 2016 at 5:15 PM, Dave Page wrote: > >>>> > >>>> On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar > >>>> wrote: > >>>> > On Mon, Jul 11, 2016 at 6:41 PM, Dave Page > wrote: > >>>> >> > >>>> >> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar > >>>> >> wrote: > >>>> >> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar > >>>> >> > wrote: > >>>> >> >> > >>>> >> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page > >>>> >> >> wrote: > >>>> >> >>> > >>>> >> >>> Hi, > >>>> >> >>> > >>>> >> >>> I think we need more changes than just that; > >>>> >> >>> > >>>> >> >>> - The path at the top should not be editable (it should be > greyed > >>>> >> >>> in > >>>> >> >>> fact) > >>>> >> >> > >>>> >> >> Ok > >>>> >> >>> > >>>> >> >>> > >>>> >> >>> - The path at the top should only show the directory path. The > >>>> >> >>> filename should never be appended. > >>>> >> >> > >>>> >> >> Ok > >>>> >> >>> > >>>> >> >>> > >>>> >> >>> - The CSS needs to be fixed so the filename textbox at the > bottom > >>>> >> >>> is > >>>> >> >>> never hidden (as it is now if the dialogue opens at a small > >>>> >> >>> size). > >>>> >> >> > >>>> >> >> Ok > >>>> >> >>> > >>>> >> >>> > >>>> >> >>> - Double-click to navigate vs. rename should be modified to > work > >>>> >> >>> in > >>>> >> >>> part like it does on Mac - Double-click on either the icon or > the > >>>> >> >>> name > >>>> >> >>> should open the item (browser into a folder, or select and "OK" > >>>> >> >>> on a > >>>> >> >>> file), and Click then Enter should rename. I'm hesitant to try > to > >>>> >> >>> implement "slow double click to rename" as that would likely > need > >>>> >> >>> to > >>>> >> >>> be tunable for accessibility reasons. > >>>> >> >> > >>>> >> >> Ok, I will fix it. > >>>> >> > > >>>> >> > In the current scenario, the Enter Key is bound to the OK button > by > >>>> >> > default > >>>> >> > in Alertify dialog which servers the purpose of closing the > dialog. > >>>> >> > Should we de-attach Enter Key event bound to OK button and use it > >>>> >> > for > >>>> >> > rename > >>>> >> > file? > >>>> >> > please suggest what should I do? > >>>> >> > >>>> >> Hmm, good point. > >>>> >> > >>>> >> How hard would it be to look for 2 consecutive single-clicks (but > not > >>>> >> a double-click) for rename? If we can do that, it avoids timing > >>>> >> considerations for double-clicks (which would be defined by the > OS). > >>>> > > >>>> > > >>>> > I tried to implement slow double click, here is Fiddle > >>>> > There are two events 1) double click (it will be used for folder > >>>> > navigation) > >>>> > 2) Slow double click(For rename), It is a simple click event, when > >>>> > clicked > >>>> > twice after delay we consider it a slow double click. > >>>> > > >>>> > But it is not working smoothly, double click and single click events > >>>> > are > >>>> > conflicting. > >>>> > >>>> Yeah, so I see. > >>>> > >>>> > Also, we have rename button in navigation for rename operation, > >>>> > Can we skip slow double click because it is very confusing? > >>>> > >>>> OK, I must have been having a brain failure moment or something. Yes, > >>>> skip it - we obviously don't need it with the rename button. > >>>> > >>>> So we have: > >>>> > >>>> - Click to select > >>>> - Double click to open a folder > >>>> - Button to rename the select file/folder > >>>> > >>>> Sorry! > >>>> > >>>> -- > >>>> Dave Page > >>>> Blog: http://pgsnake.blogspot.com > >>>> Twitter: @pgsnake > >>>> > >>>> EnterpriseDB UK: http://www.enterprisedb.com > >>>> The Enterprise PostgreSQL Company > >>> > >>> > >> > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114e3704d7110f0537a9a409 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Fri, Jul 15, 2016 at 3:22 PM, Dave Page <dpage@pgadmin= .org> wrote:
Thanks Surinder, patch applied.

I suspect the font rendering issue is related to others we've seen,
where the solution is to ensure the -webkit-transform CSS attribute is
set to none. Can you have a poke around with it please?
Sure Dave. I will do.=C2=A0

On Wed, Jul 13, 2016 at 2:58 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Please find updated patch.
> This patch also includes the fix for issue=C2=A0 "File Browser - = File does not
> exist error".
>
> On Wed, Jul 13, 2016 at 7:23 PM, Surinder Kumar
> <surinder.kumar@= enterprisedb.com> wrote:
>>
>> I forgot to merge the fix for issue "File Browser - File does= not exist
>> error" in the patch.
>> Please ignore this patch.
>>
>> On Wed, Jul 13, 2016 at 7:20 PM, Surinder Kumar
>> <surinder.ku= mar@enterprisedb.com> wrote:
>>>
>>> Please find updated patch with following changes/enhancements:=
>>>
>>> Double click on file/folder icon or name will navigate to the<= br> >>> folder/file.
>>> Selected file/folder can be renamed by Rename button only. Dou= ble click
>>> rename is removed.
>>> Filename text box will not hide on smaller screen. Setting min= imum width
>>> of File Browser fixed it.
>>> Path at top will only show directory name, not the file name a= nd it is
>>> greyed out.
>>>
>>> Issue not fixed:
>>> Icons and fonts of Query tool and File Browser looks blurred i= n Runtime
>>> environment.
>>> I tried debugging it. while debugging, It gets fixed on my ubu= ntu
>>> runtime. but I don't know how it gets fixed without changi= ng css styles. It
>>> needs more time to debug.
>>>
>>> Please review.
>>>
>>> On Wed, Jul 13, 2016 at 5:15 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>>
>>>> On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar
>>>> <sur= inder.kumar@enterprisedb.com> wrote:
>>>> > On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>> >>
>>>> >> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar >>>> >> <surinder.kumar@enterprisedb.com> wrote:
>>>> >> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kum= ar
>>>> >> > <surinder.kumar@enterprisedb.com> wrote:
>>>> >> >>
>>>> >> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Pag= e <dpage@pgadmin.org>
>>>> >> >> wrote:
>>>> >> >>>
>>>> >> >>> Hi,
>>>> >> >>>
>>>> >> >>> I think we need more changes than ju= st that;
>>>> >> >>>
>>>> >> >>> - The path at the top should not be = editable (it should be greyed
>>>> >> >>> in
>>>> >> >>> fact)
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - The path at the top should only sh= ow the directory path. The
>>>> >> >>> filename should never be appended. >>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - The CSS needs to be fixed so the f= ilename textbox at the bottom
>>>> >> >>> is
>>>> >> >>> never hidden (as it is now if the di= alogue opens at a small
>>>> >> >>> size).
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - Double-click to navigate vs. renam= e should be modified to work
>>>> >> >>> in
>>>> >> >>> part like it does on Mac - Double-cl= ick on either the icon or the
>>>> >> >>> name
>>>> >> >>> should open the item (browser into a= folder, or select and "OK"
>>>> >> >>> on a
>>>> >> >>> file), and Click then Enter should r= ename. I'm hesitant to try to
>>>> >> >>> implement "slow double click to= rename" as that would likely need
>>>> >> >>> to
>>>> >> >>> be tunable for accessibility reasons= .
>>>> >> >>
>>>> >> >> Ok, I will fix it.
>>>> >> >
>>>> >> > In the current scenario, the Enter Key is bo= und to the OK button by
>>>> >> > default
>>>> >> > in Alertify dialog which servers the purpose= of closing the dialog.
>>>> >> > Should we de-attach Enter Key event bound to= OK button and use it
>>>> >> > for
>>>> >> > rename
>>>> >> > file?
>>>> >> > please suggest what should I do?
>>>> >>
>>>> >> Hmm, good point.
>>>> >>
>>>> >> How hard would it be to look for 2 consecutive si= ngle-clicks (but not
>>>> >> a double-click) for rename? If we can do that, it= avoids timing
>>>> >> considerations for double-clicks (which would be = defined by the OS).
>>>> >
>>>> >
>>>> > I tried to implement slow double click, here is Fiddl= e
>>>> > There are two events 1) double click (it will be used= for folder
>>>> > navigation)
>>>> > 2) Slow double click(For rename), It is a simple clic= k event, when
>>>> > clicked
>>>> > twice after delay we consider it a slow double click.=
>>>> >
>>>> > But it is not working smoothly, double click and sing= le click events
>>>> > are
>>>> > conflicting.
>>>>
>>>> Yeah, so I see.
>>>>
>>>> > Also, we have rename button in navigation for rename = operation,
>>>> > Can we skip slow double click because it is very conf= using?
>>>>
>>>> OK, I must have been having a brain failure moment or some= thing. Yes,
>>>> skip it - we obviously don't need it with the rename b= utton.
>>>>
>>>> So we have:
>>>>
>>>> - Click to select
>>>> - Double click to open a folder
>>>> - Button to rename the select file/folder
>>>>
>>>> Sorry!
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114e3704d7110f0537a9a409--