Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKj7J-00015a-Ma for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Jun 2017 10:32:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dKj7J-0000yz-96 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Jun 2017 10:32:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dKj7I-0000yq-Tj for pgadmin-hackers@postgresql.org; Tue, 13 Jun 2017 10:32:08 +0000 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dKj7F-00086y-J9 for pgadmin-hackers@postgresql.org; Tue, 13 Jun 2017 10:32:08 +0000 Received: by mail-wr0-x235.google.com with SMTP id g76so130901794wrd.1 for ; Tue, 13 Jun 2017 03:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Mlw82+1bUXPU8IAokh33Eto7WI4/2MV6Opv+JbnyIc4=; b=V0DWikeD/qv5vL8ZtDWZZzck7WtLVwpxTCK6T3K29v7PBIWzMh59IHBTlgyCjarFGX PfyaI+32ivKB0c12mrFRtLJjMh70beYEl7U4qq3ie728RV6es0v13mP4Jc9OJ0rx2Xa/ w819dXEBwcba7W60IEjdnVU6PIfBYk+IognaE/OODZw/OO+nVSV4sHVGLXUM9A+nQxKe IyPgqzvNZxbLqk6r0WddXXQl0nBZSXn84acO7mFyhvpWgWBKLdPh7U1kwbioyBUC51Xq TzBdKDa0s6eC+wMdHbDGbWkbGGm9H9Dr8GcDTEbHuF7rLRgXlDUOEDYLxww6CfJ5cgXZ LkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Mlw82+1bUXPU8IAokh33Eto7WI4/2MV6Opv+JbnyIc4=; b=kBm+MYM2HJqI2B4fcchSFFwIQAi97Fq6SxT8BFh4BTKcY1ukmUPvCgS1SEGqEo/unN HrdBiwzjLgYfJIQt4ERvp5wAdbC8NWbCl3A3LiPQIzZ8MaZdnJYxkw0ir8SUFt0A0O7k K87YHvvdSGYaRxRJg7DIIF2ZIIdr1IkMGfhhabCTHdq6tR8XJAbXFxAWvK/33GS7Cgyy URofTF5aqaffIRNSjbl4+H41fbIDrVnjzBD73FxihQA4Njr4iimp6f/bLz+rimUUU47l ALmOLj6O2ocnVtcwvcGjFA9HysCMaSgGiGTGbbAKih80fyMNUBdp8gkJKBR6p89Stp2L EPoA== X-Gm-Message-State: AKS2vOw/fYG8L+a2MIR58hwY2E1Fc+RswMjYXEq/73rCQpMO18Tj9aKT h92RH6c4fEX669NGslWGHGdZlOT9bbAA X-Received: by 10.28.9.142 with SMTP id 136mr2207035wmj.91.1497349915860; Tue, 13 Jun 2017 03:31:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.99.197 with HTTP; Tue, 13 Jun 2017 03:31:25 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Tue, 13 Jun 2017 16:01:25 +0530 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Dave Page Cc: Ashesh Vashi , Shruti B Iyer , Joao Pedro De Almeida Pereira , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11443a5ad6fe6c0551d4f126" List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11443a5ad6fe6c0551d4f126 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > wrote: > > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > >> > >> And then I find a problem. Sigh. > >> > >> When running in the desktop runtime, under QtWekKit (the forked, > >> updated version that is by far the best of the browser engines we've > >> used), we get the attached error at startup. I don't see this under > >> QtWebEngine, though as we've already found, that's not usable for > >> other reasons. > >> > >> Is this fixable? > > > > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html': > > " > > WebKit engine itself has not been updated since Qt 5.2 release. That's > why > > it didn't support recent changes in Web standards that happened after > 2013, > > including: new JavaScript language standard ES2015 (also known as ES6), > as > > well as improvements in DOM API and CSS. > > ... > > " > > > > Could this be a reason? > > For the old webkit, certainly, but if you read further down, the > version we're using has been updated and does now claim to support > most of ES2015. > =E2=80=8BIn fact the modern browsers don't support ES6 JS so the JS files containing ES6 code are first transpiled using babel into JS that browsers supports. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11443a5ad6fe6c0551d4f126 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jun 13, 2017 at 3:56 PM, Dave Pag= e <dpage@pgadmin.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On Tue, Jun 13, 2017 at 11:2= 2 AM, Ashesh Vashi
<ashesh.vashi@enterpris= edb.com> wrote:
> On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> And then I find a problem. Sigh.
>>
>> When running in the desktop runtime, under QtWekKit (the forked, >> updated version that is by far the best of the browser engines we&= #39;ve
>> used), we get the attached error at startup. I don't see this = under
>> QtWebEngine, though as we've already found, that's not usa= ble for
>> other reasons.
>>
>> Is this fixable?
>
> As per 'http://qtwebkit.blogspot.i= n/2016/08/qtwebkit-im-back.html':
> "
> WebKit engine itself has not been updated since Qt 5.2 release. That&#= 39;s why
> it didn't support recent changes in Web standards that happened af= ter 2013,
> including: new JavaScript language standard ES2015 (also known as ES6)= , as
> well as improvements in DOM API and CSS.
> ...
> "
>
> Could this be a reason?

For the old webkit, certainly, but if you read further down, the
version we're using has been updated and does now claim to support
most of ES2015.
=E2=80=8BIn fact the modern browsers don't support ES6 JS s= o the JS files containing ES6 code are first transpiled using babel into JS= that browsers supports.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11443a5ad6fe6c0551d4f126--