Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxbZ8-00019Y-Mi for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:17:02 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bxbZ8-0001Qw-95 for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:17:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bxbYu-00010X-Sv for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:16:48 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bxbYr-0001oP-KG for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:16:48 +0000 Received: by mail-wm0-x22b.google.com with SMTP id f193so688183wmg.0 for ; Fri, 21 Oct 2016 08:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KSWjp9l0vJIrLqhsLTXLK5rpSuKOVz8nXKFxZJLrs68=; b=Oa5UVNRVwAQ5RvGCoJuolzF4zf1dFRIknqBFPYH5Ib10DghiBnI0TTOBvNy0Xga4ix XGOe8vczs0xcKNxzm9WW8naH/J/rRRZ50E4Xh53U+AAKU56d3X5G7m9UlgduhPTCy0Wq 8EU6+mpGEreyqcLp8Qg/sUlZwGgOdyQxAam195/ELKw+UNhqJ+Rpk6nyN5kj4XN1APIc E4iU00k9ERXAL7NofiBpqq0aypvXgbhdxdQyBb4lq2WSHwleLofZSCq5e7VwbjTkYGcE Ha1RcGK95m2qw4lrWFnzf5GDRFV0SUUav3KO5BOJdp1du5HBLshJfiOhMyOv1gqEDp4m NF4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KSWjp9l0vJIrLqhsLTXLK5rpSuKOVz8nXKFxZJLrs68=; b=dlvzCQNzCGnMBx+RsB0f/GqdHDsk1PFPrfu7VQwo04A1HaCgv8fEf7FkPdkd6/N6Ly 7MtpmZBjFmeSOf1Y1ccuMccKCkIh1U7GYWbW8VKXlPzzhlw7a868tOoJIbTeaJg7ruRy ASTdgd0ZBO1GCF7QMEnntxs1i7e65B3sT9dKd6TBzonf7swpveW1b8v6bih0eTdM9/mz IIoFdbbcK/UZ8fPBSRg3SvDHpTQjvCrXjz6CZ1mPJInhCQlzlxY7yhqF1mVAhH1k1NOO ZuaEffZLdDcoQV54fKLQQEj8uAEA9Zn1tfce17PCoujk0NgBGPxE/VwFVJtPo6rc+S2S F1WQ== X-Gm-Message-State: ABUngvfUn6bQVD/fkuHX97qDu1IZzt2iGXUr6f3L8ueWMl71uu4Am2kofgbMBlr2ZBnye2f5RKZlUn0AjCXsi/ob X-Received: by 10.194.147.48 with SMTP id th16mr1205987wjb.68.1477063004221; Fri, 21 Oct 2016 08:16:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 21 Oct 2016 08:16:13 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Fri, 21 Oct 2016 20:46:13 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=089e012282b6ae12ad053f61870c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e012282b6ae12ad053f61870c Content-Type: multipart/alternative; boundary=089e012282b6ae12a8053f61870a --089e012282b6ae12a8053f61870a Content-Type: text/plain; charset=UTF-8 Hi This fix is for exclusion constraint. The options like "order" and "nulls" must be conditional. i.e. include only when access method type is other than "gist". Please find attached patch and review. On Fri, Oct 21, 2016 at 4:38 PM, Dave Page wrote: > Thanks, applied. > > On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar > wrote: > > Hi, > > > > The options like "sort" and "nulls" must be conditional. i.e. include > only > > when access method type is other than "gist" or "gin". > > > > Please find attached patch and review. > > > > Thanks, > > Surinder Kumar > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --089e012282b6ae12a8053f61870a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

This fix is for exclusion= constraint.
Th= e options like "order" and "nulls" must be conditional.= i.e. include only when access method type is other than "gist".<= br>

<= div class=3D"gmail_default" style=3D"font-size:small">Please find attached = patch and review.

On Fri, Oct 21, 2016 at 4:38 PM, Dave Page <dpage@pgadmin.org>= ; wrote:
Thanks, applied.

On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi,
>
> The options like "sort" and "nulls" must be condit= ional. i.e. include only
> when access method type is other than "gist" or "gin&qu= ot;.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--089e012282b6ae12a8053f61870a-- --089e012282b6ae12ad053f61870c Content-Type: application/octet-stream; name="RM1840_same_fix_for_exclusion_constraint.patch" Content-Disposition: attachment; filename="RM1840_same_fix_for_exclusion_constraint.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iujx4jfl0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMv ZXhjbHVzaW9uX2NvbnN0cmFpbnQvc3FsLzkuMV9wbHVzL2NyZWF0ZS5zcWwg Yi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9k YXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL2V4Y2x1c2lvbl9j b25zdHJhaW50L3NxbC85LjFfcGx1cy9jcmVhdGUuc3FsCmluZGV4IGRiMjkw NDguLmE4MDk3ZGUgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIv c2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxl cy90ZW1wbGF0ZXMvZXhjbHVzaW9uX2NvbnN0cmFpbnQvc3FsLzkuMV9wbHVz L2NyZWF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJf Z3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBs YXRlcy9leGNsdXNpb25fY29uc3RyYWludC9zcWwvOS4xX3BsdXMvY3JlYXRl LnNxbApAQCAtMSw3ICsxLDcgQEAKIEFMVEVSIFRBQkxFIHt7IGNvbm58cXRJ ZGVudChkYXRhLnNjaGVtYSwgZGF0YS50YWJsZSkgfX0KICAgICBBRER7JSBp ZiBkYXRhLm5hbWUgJX0gQ09OU1RSQUlOVCB7eyBjb25ufHF0SWRlbnQoZGF0 YS5uYW1lKSB9fXslIGVuZGlmJX0gRVhDTFVERSB7JSBpZiBkYXRhLmFtbmFt ZSBhbmQgZGF0YS5hbW5hbWUgIT0gJycgJX1VU0lORyB7e2RhdGEuYW1uYW1l fX17JSBlbmRpZiAlfSAoCiAgICAgeyUgZm9yIGNvbCBpbiBkYXRhLmNvbHVt bnMgJX17JSBpZiBsb29wLmluZGV4ICE9IDEgJX0sCi0gICAgeyUgZW5kaWYg JX17eyBjb25ufHF0SWRlbnQoY29sLmNvbHVtbil9fSB7JSBpZiBjb2wub3Bl cl9jbGFzcyBhbmQgY29sLm9wZXJfY2xhc3MgIT0gJycgJX17e2NvbC5vcGVy X2NsYXNzfX0geyUgZW5kaWYlfXslIGlmIGNvbC5vcmRlciAlfUFTQ3slIGVs c2UgJX1ERVNDeyUgZW5kaWYgJX0gTlVMTFMgeyUgaWYgY29sLm51bGxzX29y ZGVyICV9RklSU1R7JSBlbHNlICV9TEFTVHslIGVuZGlmICV9IFdJVEgge3tj b2wub3BlcmF0b3J9fXslIGVuZGZvciAlfSl7JSBpZiBkYXRhLmZpbGxmYWN0 b3IgJX0KKyAgICB7JSBlbmRpZiAlfXt7IGNvbm58cXRJZGVudChjb2wuY29s dW1uKX19IHslIGlmIGRhdGEuYW1uYW1lIGlzIGRlZmluZWQgYW5kIGRhdGEu YW1uYW1lICE9ICdnaXN0JyAlfXslIGlmIGNvbC5vcGVyX2NsYXNzIGFuZCBj b2wub3Blcl9jbGFzcyAhPSAnJyAlfXt7Y29sLm9wZXJfY2xhc3N9fSB7JSBl bmRpZiV9eyUgaWYgY29sLm9yZGVyICV9QVNDeyUgZWxzZSAlfURFU0N7JSBl bmRpZiAlfSBOVUxMUyB7JSBpZiBjb2wubnVsbHNfb3JkZXIgJX1GSVJTVHsl IGVsc2UgJX1MQVNUeyUgZW5kaWYgJX17JSBlbmRpZiAlfSBXSVRIIHt7Y29s Lm9wZXJhdG9yfX17JSBlbmRmb3IgJX0peyUgaWYgZGF0YS5maWxsZmFjdG9y ICV9CiAgICAgV0lUSCAoRklMTEZBQ1RPUj17e2RhdGEuZmlsbGZhY3Rvcn19 KXslIGVuZGlmICV9eyUgaWYgZGF0YS5zcGNuYW1lIGFuZCBkYXRhLnNwY25h bWUgIT0gInBnX2RlZmF1bHQiICV9CiAKICAgICBVU0lORyBJTkRFWCBUQUJM RVNQQUNFIHt7IGNvbm58cXRJZGVudChkYXRhLnNwY25hbWUpIH19eyUgZW5k aWYgJX0KQEAgLTE0LDQgKzE0LDQgQEAgQUxURVIgVEFCTEUge3sgY29ubnxx dElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLnRhYmxlKSB9fQogCiBDT01NRU5U IE9OIENPTlNUUkFJTlQge3sgY29ubnxxdElkZW50KGRhdGEubmFtZSkgfX0g T04ge3sgY29ubnxxdElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLnRhYmxlKSB9 fQogICAgIElTIHt7IGRhdGEuY29tbWVudHxxdExpdGVyYWwgfX07Ci17JSBl bmRpZiAlfQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKK3slIGVuZGlm ICV9CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxh dGVzL2V4Y2x1c2lvbl9jb25zdHJhaW50L3NxbC85LjJfcGx1cy9jcmVhdGUu c3FsIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy9leGNsdXNp b25fY29uc3RyYWludC9zcWwvOS4yX3BsdXMvY3JlYXRlLnNxbAppbmRleCBk YjI5MDQ4Li5hODA5N2RlIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvdGVtcGxhdGVzL2V4Y2x1c2lvbl9jb25zdHJhaW50L3NxbC85LjJf cGx1cy9jcmVhdGUuc3FsCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy dmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90 ZW1wbGF0ZXMvZXhjbHVzaW9uX2NvbnN0cmFpbnQvc3FsLzkuMl9wbHVzL2Ny ZWF0ZS5zcWwKQEAgLTEsNyArMSw3IEBACiBBTFRFUiBUQUJMRSB7eyBjb25u fHF0SWRlbnQoZGF0YS5zY2hlbWEsIGRhdGEudGFibGUpIH19CiAgICAgQURE eyUgaWYgZGF0YS5uYW1lICV9IENPTlNUUkFJTlQge3sgY29ubnxxdElkZW50 KGRhdGEubmFtZSkgfX17JSBlbmRpZiV9IEVYQ0xVREUgeyUgaWYgZGF0YS5h bW5hbWUgYW5kIGRhdGEuYW1uYW1lICE9ICcnICV9VVNJTkcge3tkYXRhLmFt bmFtZX19eyUgZW5kaWYgJX0gKAogICAgIHslIGZvciBjb2wgaW4gZGF0YS5j b2x1bW5zICV9eyUgaWYgbG9vcC5pbmRleCAhPSAxICV9LAotICAgIHslIGVu ZGlmICV9e3sgY29ubnxxdElkZW50KGNvbC5jb2x1bW4pfX0geyUgaWYgY29s Lm9wZXJfY2xhc3MgYW5kIGNvbC5vcGVyX2NsYXNzICE9ICcnICV9e3tjb2wu b3Blcl9jbGFzc319IHslIGVuZGlmJX17JSBpZiBjb2wub3JkZXIgJX1BU0N7 JSBlbHNlICV9REVTQ3slIGVuZGlmICV9IE5VTExTIHslIGlmIGNvbC5udWxs c19vcmRlciAlfUZJUlNUeyUgZWxzZSAlfUxBU1R7JSBlbmRpZiAlfSBXSVRI IHt7Y29sLm9wZXJhdG9yfX17JSBlbmRmb3IgJX0peyUgaWYgZGF0YS5maWxs ZmFjdG9yICV9CisgICAgeyUgZW5kaWYgJX17eyBjb25ufHF0SWRlbnQoY29s LmNvbHVtbil9fSB7JSBpZiBkYXRhLmFtbmFtZSBpcyBkZWZpbmVkIGFuZCBk YXRhLmFtbmFtZSAhPSAnZ2lzdCcgJX17JSBpZiBjb2wub3Blcl9jbGFzcyBh bmQgY29sLm9wZXJfY2xhc3MgIT0gJycgJX17e2NvbC5vcGVyX2NsYXNzfX0g eyUgZW5kaWYlfXslIGlmIGNvbC5vcmRlciAlfUFTQ3slIGVsc2UgJX1ERVND eyUgZW5kaWYgJX0gTlVMTFMgeyUgaWYgY29sLm51bGxzX29yZGVyICV9RklS U1R7JSBlbHNlICV9TEFTVHslIGVuZGlmICV9eyUgZW5kaWYgJX0gV0lUSCB7 e2NvbC5vcGVyYXRvcn19eyUgZW5kZm9yICV9KXslIGlmIGRhdGEuZmlsbGZh Y3RvciAlfQogICAgIFdJVEggKEZJTExGQUNUT1I9e3tkYXRhLmZpbGxmYWN0 b3J9fSl7JSBlbmRpZiAlfXslIGlmIGRhdGEuc3BjbmFtZSBhbmQgZGF0YS5z cGNuYW1lICE9ICJwZ19kZWZhdWx0IiAlfQogCiAgICAgVVNJTkcgSU5ERVgg VEFCTEVTUEFDRSB7eyBjb25ufHF0SWRlbnQoZGF0YS5zcGNuYW1lKSB9fXsl IGVuZGlmICV9CkBAIC0xNCw0ICsxNCw0IEBAIEFMVEVSIFRBQkxFIHt7IGNv bm58cXRJZGVudChkYXRhLnNjaGVtYSwgZGF0YS50YWJsZSkgfX0KIAogQ09N TUVOVCBPTiBDT05TVFJBSU5UIHt7IGNvbm58cXRJZGVudChkYXRhLm5hbWUp IH19IE9OIHt7IGNvbm58cXRJZGVudChkYXRhLnNjaGVtYSwgZGF0YS50YWJs ZSkgfX0KICAgICBJUyB7eyBkYXRhLmNvbW1lbnR8cXRMaXRlcmFsIH19Owot eyUgZW5kaWYgJX0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit7JSBl bmRpZiAlfQo= --089e012282b6ae12ad053f61870c Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --089e012282b6ae12ad053f61870c--