Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVFRr-00082A-Or for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Aug 2016 10:00:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bVFRq-0001cs-Pl for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Aug 2016 10:00:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bVFRd-0001L3-Oy for pgadmin-hackers@postgresql.org; Thu, 04 Aug 2016 10:00:05 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bVFRa-0001I3-6v for pgadmin-hackers@postgresql.org; Thu, 04 Aug 2016 10:00:04 +0000 Received: by mail-wm0-x234.google.com with SMTP id q128so1674320wma.1 for ; Thu, 04 Aug 2016 03:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=7+qOnVJNgAUavtsLL0chRjczm6foK7WxH1sBB85OHYI=; b=xgqErBoIfFrKTLfnF7wzrceZijYc4UfA5PN1lhnTOhPCI1Bg5Xzlis+RS8rmbg0AR7 5tX6gO8VOOKbILnix5zbVTdhizqHkltNOWyCGgYs6lscAoj7tl5T8jD/dGWTnLYdwhv7 D9oPE54+nqd44DWO4WY2E/kW5qCqxXrGcmrUhKOXBEF4E793JKBFWFFYlqdaR5TM10lJ lpJrbjk8j1yv8qnDNUw+uS1kpOk0azlx0NWlFIM8qAPfJzBotUqGW4mQcbcob3pz6LsI zSvyHdfRdp5HJGbfy3zz7sTtwTTZ7lIbo3YCy0O9C9MnOQOsNoasLM1vW6pOO2CjoJgK efkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=7+qOnVJNgAUavtsLL0chRjczm6foK7WxH1sBB85OHYI=; b=VeOyFp34LOzRTlLPvN0ZNiDwIcQ04L7wNXWju9ZkCJWGbHVyoN+0ep0M1a6A6uMuEQ mT5Q0EzAsqLoIAmBFQzu8Gxp/ESPUY8hESmHjfgrMrV0Esr6yXMbzAu+AyYZhYPALPGf 5F0Ij4bnKBvyC56Y4ZvFvx8qV+Aqf+wFiCW3KV/L20xse1Ll6dBC0MuSOwD4MwPpraml B5pwQafIG/hmUKoXbl7VPecmFqPCwdFtTcbNxuvI+c8gxXkGHhgM6dheUHsCyNAFlHKM WXz5+VaKgBRlsfLjVRhuBiA0O9+3s4OEeTaEt1D/C2QL5Q9Ep1le3CiVZax9zcTsUu6E pOsw== X-Gm-Message-State: AEkoout67LT/eYqdSPz0K54VMP7yGBN1pIkXNPUub08FAv9vs324AuprUHOn/nkwKp2cdPorTltbSamhAPb4uqjH X-Received: by 10.28.24.5 with SMTP id 5mr29314655wmy.6.1470304799610; Thu, 04 Aug 2016 02:59:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.167.81 with HTTP; Thu, 4 Aug 2016 02:59:28 -0700 (PDT) From: Surinder Kumar Date: Thu, 4 Aug 2016 15:29:28 +0530 Message-ID: Subject: [Patch][pgAdmin4]: RM1519 - Error running VACUUM FULL FREEZE ANALYZE VERBOSE To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114690584b363505393c0332 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114690584b363505393c0332 Content-Type: multipart/alternative; boundary=001a114690584b363205393c0330 --001a114690584b363205393c0330 Content-Type: text/plain; charset=UTF-8 Hi This issue is reproduced to me with following steps.: 1) When the query "VACUUM FULL FREEZE ANALYZE VERBOSE" is run for first time, it runs without error. 2) then the query "SELECT 1" is executed. no error. 3) But when query in step #1 is run again, it throws an error: *TypeError: cannot concatenate 'str' and 'NoneType' objects* 4) Now executing query in step #2 throws following error: *Error Message:execute cannot be used while an asynchronous query is underway********** Error *********** *Reason:* When the query in step #1 is run for second time as in step #3, it fails due to python error thus loading spinner stops and run query button is enabled. but the query is still running in background. then on running query in step #4 throws error with message "asynchronous query is underway" because last run query is not yet finished. *Solution:* This is due to python error. String type and NoneType is now formatted properly which resolves the issue. Please find attached patch and review. Thanks, Surinder Kumar --001a114690584b363205393c0330 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

This issue is reproduced = to me with following steps.:
1) When the query "VACUUM FULL FREEZE ANALYZE VERBOSE&qu= ot; is run for first time, it runs without error.
2) then the query "SELECT 1" i= s executed. no error.
3) But when query in step #1 is run again, it throws an error:
=
TypeError: cannot= concatenate 'str' and 'NoneType' objects

4) Now executing query in step #2 = throws following error:
Error Message:execute cannot be used while an asynchronous quer= y is underway********** Error **********

Reason:
When the query in step #1 is run for second = time as in step #3, it fails due to python error thus loading spinner stops= and run query button is enabled. but the query is still running in backgro= und.

=
then on running quer= y in step #4 throws error with message "asynchronous query is underway= " because last run query is not yet finished.

Solution:
This is due to python error.=C2=A0
String type and NoneType is= now formatted properly which resolves the issue.

Please find attached patch and review.


Thanks,
Surinder Kumar
--001a114690584b363205393c0330-- --001a114690584b363505393c0332 Content-Type: application/octet-stream; name="RM1519.patch" Content-Disposition: attachment; filename="RM1519.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_irg5ar650 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2lu aXRfXy5weSBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRf Xy5weQppbmRleCAwYzNlMzhkLi5iYjVjMjZiIDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi90b29scy9zcWxlZGl0b3IvX19pbml0X18ucHkKKysrIGIvd2Vi L3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL19faW5pdF9fLnB5CkBAIC00NjEs NyArNDYxLDcgQEAgZGVmIHBvbGwodHJhbnNfaWQpOgogICAgICAgICAgICAg IiIiCiAgICAgICAgICAgICBpZiBpc2luc3RhbmNlKGFkZGl0aW9uYWxfcmVz dWx0LCBsaXN0KSBcCiAgICAgICAgICAgICAgICAgICAgIGFuZCBsZW4oYWRk aXRpb25hbF9yZXN1bHQpID4gMDoKLSAgICAgICAgICAgICAgICByZXN1bHQg PSBzdHIoYWRkaXRpb25hbF9yZXN1bHRbLTFdKSArIHJlc3VsdAorICAgICAg ICAgICAgICAgIHJlc3VsdCA9ICJ7MH0gezF9Ii5mb3JtYXQoYWRkaXRpb25h bF9yZXN1bHRbLTFdLCByZXN1bHQpCgogICAgICAgICAgICAgcm93c19hZmZl Y3RlZCA9IGNvbm4ucm93c19hZmZlY3RlZCgpCgo= --001a114690584b363505393c0332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114690584b363505393c0332--