Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmHHH-0001H2-CD for pgadmin-hackers@arkaria.postgresql.org; Tue, 20 Sep 2016 09:23:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bmHHG-0004Ez-9r for pgadmin-hackers@arkaria.postgresql.org; Tue, 20 Sep 2016 09:23:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmHH2-00040t-Ua for pgadmin-hackers@postgresql.org; Tue, 20 Sep 2016 09:23:33 +0000 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bmHGv-0002Mr-F2 for pgadmin-hackers@postgresql.org; Tue, 20 Sep 2016 09:23:32 +0000 Received: by mail-lf0-x22e.google.com with SMTP id g62so8121963lfe.3 for ; Tue, 20 Sep 2016 02:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uUUYc2N6sMKy0bCw97MwVGD7uGxAePr1VzHWjGqzsN4=; b=Jt2AhV/ynYt/oKnxJLuotxH7S2nKAZcuOsxQkjEKh+7IPXhIzsanOHhw5UwAYEUTlI mDJznlvRz5RU/k5P0Q9HDIQpGTR5MJRqY4Ap2vIp2XhmvNiQbp6xrQVyU3jfyhKZeHyN rRn8IqyVtGKjJAiBJeO+bdujMA1vEhqcFslonz9G+bYWrfczuGrzyzRzBxG6I/pZrcJ3 t+P/omjqbmzs5XhqtFSBbT/oSeyOd7BlGr8mrrsmIyZQYm+kAmm37FH+ZNv5KMCWezal LWzauQ4/mmDcAaGr7owPZzfzhVxblhzhVQRdcilHMfG1YEfLqcU/xFVAH8o/NEhNaVFp Ixzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uUUYc2N6sMKy0bCw97MwVGD7uGxAePr1VzHWjGqzsN4=; b=P+t6vo7eXsg2aY6qxObz8VXCepjjNlL/jnBn3xZsGAxjkeEgzUi8XhF2/i/GJA6/PQ qRZzoyKaW5HNp3vnXUCXVJsVxsz32CrFlZVPexkPV1MayrOhc5c+/BzaeioCFOeEieua PAZvyDSO2XKmfrfuobLI6MYcRsJO301zRizMSeQzcxNUPJk5kd8d3fmNHD1u7ryzEhxA R+OjRKAtdkxDdVEDsrqzyHUXkM4n+3bsic6SJg0IQh9nYbi0GQ8plau9dEnOl5+/ug1o NKjUP61wPEjW62vDUv4bX07kCG44bjW+9FcI2S2IiblcbuxHM3JrHlRIXbhFGSthSB9T M7PQ== X-Gm-Message-State: AE9vXwPtvbW5M8p3X8O88cYcMT9vc30vflTvsmGlhgL8vkwLkAnuG/GG7rx4WRuTD3hr3lR371p4BXIyyn/+9p/P X-Received: by 10.194.61.72 with SMTP id n8mr26814739wjr.74.1474363404538; Tue, 20 Sep 2016 02:23:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Tue, 20 Sep 2016 02:22:53 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Tue, 20 Sep 2016 14:52:53 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button To: Dave Page Cc: pgadmin-hackers , Ashesh Vashi Content-Type: multipart/mixed; boundary=047d7b66f34301e802053cecfbda X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b66f34301e802053cecfbda Content-Type: multipart/alternative; boundary=047d7b66f34301e7fe053cecfbd8 --047d7b66f34301e7fe053cecfbd8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 19, 2016 at 9:49 PM, Dave Page wrote: > Hi > > > On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar > wrote: > > Hi > > > > Please find patch with following fixes: > > > > 1) Newly added server-group not listing in tree view. > > > > 2) On creating a first node for collection node with no child. the > created > > node doesn't show up under its respective parent node. > > - to add a node to child under its parent node. its parent node attribu= te > > must be set 'inode: true' but it always gets false for inode that doesn= 't > > add the node. > > > > Ashesh - Can you please review it? > > I tested this by adding a sequence to a database and schema that > didn't previously contain any. The node was not added, and in the > Javascript console I get: > > browser.js:1108 Failed to append =E2=80=8BThis issue is taken care in updated patch, Also properly handled t= he case for 'server-group' not listing in tree view, thus removing 'addNodeWithNoParent' method from previous patch. I have tested it for most of the nodes, it works. Please find updated patch and review. > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --047d7b66f34301e7fe053cecfbd8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = Mon, Sep 19, 2016 at 9:49 PM, Dave Page <dpage@pgadmin.org> = wrote:
Hi


On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find patch with following fixes:
>
> 1) Newly added server-group not listing in tree view.
>
> 2) On creating a first node for collection node with no child. the cre= ated
> node doesn't show up under its respective parent node.
> - to add a node to child under its parent node. its parent node attrib= ute
> must be set 'inode: true' but it always gets false for inode t= hat doesn't
> add the node.
>
> Ashesh - Can you please review it?

I tested this by adding a sequence to a database and schema that
didn't previously contain any. The node was not added, and in the
Javascript console I get:

browser.js:1108 Failed to append
=E2=80=8BThis issue is taken care in updated patch= , Also properly handled the case for 'server-group' not listing in = tree view, thus removing 'addNodeWithNoParent' method from previous= patch.
I have = tested it for most of the nodes, it works.
Please find updated patch and review.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--047d7b66f34301e7fe053cecfbd8-- --047d7b66f34301e802053cecfbda Content-Type: application/octet-stream; name="RM1627_v1.patch" Content-Disposition: attachment; filename="RM1627_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itb9rhw90 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jy b3dzZXIvanMvYnJvd3Nlci5qcyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVt cGxhdGVzL2Jyb3dzZXIvanMvYnJvd3Nlci5qcwppbmRleCAxNTFkMDViLi40 NmM0OWNmIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBs YXRlcy9icm93c2VyL2pzL2Jyb3dzZXIuanMKKysrIGIvd2ViL3BnYWRtaW4v YnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9icm93c2VyLmpzCkBAIC04 MjAsNiArODIwLDEwIEBAIGZ1bmN0aW9uKHJlcXVpcmUsICQsIF8sIFMsIEJv b3RzdHJhcCwgcGdBZG1pbiwgQWxlcnRpZnksIENvZGVNaXJyb3IpIHsKICAg ICAgICAgICAgICAgY3R4LmIuX2ZpbmRUcmVlQ2hpbGROb2RlKAogICAgICAg ICAgICAgICAgIGN0eC5pLCBkLCBjdHgKICAgICAgICAgICAgICAgKTsKKyAg ICAgICAgICAgICAgLy8gaWYgcGFyZW50IG5vZGUgaXMgbnVsbAorICAgICAg ICAgICAgICBpZiAoIV9kYXRhLl9waWQpIHsKKyAgICAgICAgICAgICAgICBh ZGRJdGVtTm9kZS5hcHBseShjdHgsIGFyZ3VtZW50cyk7CisgICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHJldHVybiB0cnVl OwogICAgICAgICAgIH0uYmluZChjdHgpLApAQCAtOTU4LDkgKzk2MiwxMSBA QCBmdW5jdGlvbihyZXF1aXJlLCAkLCBfLCBTLCBCb290c3RyYXAsIHBnQWRt aW4sIEFsZXJ0aWZ5LCBDb2RlTWlycm9yKSB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgIH0pOwogICAgICAgICAgICAgICAgICAgICAgICAgfS5iaW5k KGN0eCk7CgotICAgICAgICAgICAgICAgICAgICBpZiAoIWN0eC50LmlzSW5v ZGUoY3R4LmkpICYmIGN0eC5kLmlub2RlKSB7CisgICAgICAgICAgICAgICAg ICAgIGlmIChjdHguaSAmJiAhY3R4LnQuaXNJbm9kZShjdHguaSkpIHsKICAg ICAgICAgICAgICAgICAgICAgICAgIGN0eC50LnNldElub2RlKGN0eC5pLCB7 c3VjY2VzczogX2FwcGVuZH0pOwogICAgICAgICAgICAgICAgICAgICB9IGVs c2UgeworICAgICAgICAgICAgICAgICAgICAgICAgLy8gSGFuZGxlIGNhc2Ug Zm9yIG5vZGUgd2l0aG91dCBwYXJlbnQgaS5lLiBzZXJ2ZXItZ3JvdXAKKyAg ICAgICAgICAgICAgICAgICAgICAgIC8vIG9yIGlmIHBhcmVudCBub2RlJ3Mg aW5vZGUgaXMgdHJ1ZS4KICAgICAgICAgICAgICAgICAgICAgICAgIF9hcHBl bmQoKTsKICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg ICAgfQo= --047d7b66f34301e802053cecfbda Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --047d7b66f34301e802053cecfbda--