Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkSbL-0001Hs-7B for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 09:04:59 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkSbJ-0007xp-A9 for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 09:04:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkSb5-0007jo-Tb for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 09:04:44 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkSb1-0005n5-0S for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 09:04:43 +0000 Received: by mail-wm0-x22e.google.com with SMTP id k186so55546847wmd.0 for ; Thu, 15 Sep 2016 02:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3mTSRsvYCJAium8OFC4esPNIuaDx/c0m5JfZ8f/NBDA=; b=BURrVKHFI8iucpZp4z1OEU/mkkH1erSJLwRbR5ByuHl+ULp3msYSz7oXqvkNgi3MrB BCiq1mSUxfb1YlF2HeAvqDVlEG1V/acpfUxjd9uWMboOweSAclgrvkb5x/mXTS6SJ5F+ j971CSoHznpnv5ISe7yHNxDb8YkviaSR7UaNYBv7Uil2Fku/3FNwObHoqYXTIUK3ut3l GvGjrDTAFqEfqxp68KG1aZTNvvJtaTxFe0I0bcmROgVegamSJk2MpTCX2YAjDUnh61S4 upUopm4/iLQUsN8QCHtsxClQavTt2JKnKbhc16UiCNTacXXf4upOzJOuCumJXZkwSGQz Edew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3mTSRsvYCJAium8OFC4esPNIuaDx/c0m5JfZ8f/NBDA=; b=GxAPHNmY5DreBZ3h6fcNViAQlWp/TXK92RMTarA78BJwiZ9H9yfmmbCPP8zTbF34P7 Bdy1l+uCFPxdUFMH2qi7Ty9nByJXaw4W913yGbsl0G1W4zuE/PdzUg7grXyOEf2pRXSl mRdZz6FolB44CuvYlPNY4Rv2N42At4Xkvt8eoqdaedfRO1VUX2UgmPY2sOFPosk++RGN ltBTNTrgmYwyVlA2RWZXlrN+cIOsx8zGHhGyRNinlRFdecE3QuQy6kr62dmC6SzaZryb qobfxTdfQiUgmesvFKbSDkxEMkix9rcq1W8mS8vjt3hGdhWJd4Z5Wyr4cx42lhrAxT/x TZUw== X-Gm-Message-State: AE9vXwN8ibjrNDn+ovWJUkm+TUADTKyJWJluyG44NXQ7Uh7VYYh6vw3AQ444ogYBz46zItxRGkcEeG5+Isuln2uB X-Received: by 10.28.13.66 with SMTP id 63mr1989398wmn.113.1473930278007; Thu, 15 Sep 2016 02:04:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Thu, 15 Sep 2016 02:04:07 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Thu, 15 Sep 2016 14:34:07 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114426e2a57b13053c8822e2 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114426e2a57b13053c8822e2 Content-Type: multipart/alternative; boundary=001a114426e2a57b0e053c8822e0 --001a114426e2a57b0e053c8822e0 Content-Type: text/plain; charset=UTF-8 Hi Please find updated patch. On Thu, Sep 15, 2016 at 1:38 PM, Dave Page wrote: > (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.patch > error: patch failed: web/pgadmin/static/css/overrides.css:53 > error: web/pgadmin/static/css/overrides.css: patch does not apply > > Please rebase! > > On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar > wrote: > > Hi > > > > Please find the attached patch patch with following changes: > > > > 1) Implemented CodeMirror addon 'simplescrollbars'. > > > > 2) The CodeMirror instance of query tool was not rendering into > wcDocker's > > 'pg-panel-content' div. it renders outside the div, due to which it took > > little more time investigating why scrollbars doesn't appear in editor. > > > > 3) Add new css specific to query tool. > > > > > > Please review. > > > > Thanks, > > Surinder Kumar > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114426e2a57b0e053c8822e0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Please find updated patch= .

On T= hu, Sep 15, 2016 at 1:38 PM, Dave Page <dpage@pgadmin.org> w= rote:
(pgadmin4)piranha:pgadmin4 dpage$ g= it apply ~/Downloads/RM1579.patch
error: patch failed: web/pgadmin/static/css/overrides.css:53
error: web/pgadmin/static/css/overrides.css: patch does not apply

Please rebase!

On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi
>
> Please find the attached patch patch with following changes:
>
> 1) Implemented CodeMirror addon 'simplescrollbars'.
>
> 2) The CodeMirror instance of query tool was not rendering into wcDock= er's
> 'pg-panel-content' div. it renders outside the div, due to whi= ch it took
> little more time investigating why scrollbars doesn't appear in ed= itor.
>
> 3) Add new css specific to query tool.
>
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114426e2a57b0e053c8822e0-- --001a114426e2a57b13053c8822e2 Content-Type: application/octet-stream; name="RM1579_v1.patch" Content-Disposition: attachment; filename="RM1579_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it440d460 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3RlbXBsYXRlcy9iYXNlLmh0bWwg Yi93ZWIvcGdhZG1pbi90ZW1wbGF0ZXMvYmFzZS5odG1sCmluZGV4IDUzYWFm OGQuLmRiNzZmNjEgMTAwNzU1Ci0tLSBhL3dlYi9wZ2FkbWluL3RlbXBsYXRl cy9iYXNlLmh0bWwKKysrIGIvd2ViL3BnYWRtaW4vdGVtcGxhdGVzL2Jhc2Uu aHRtbApAQCAtNTAsNiArNTAsOCBAQAogICAgICAgICAgIGhyZWY9Int7IHVy bF9mb3IoJ3N0YXRpYycsIGZpbGVuYW1lPSdjc3Mvc2xpY2tncmlkL3NsaWNr LWRlZmF1bHQtdGhlbWUuY3NzJyl9fSIvPgogICAgIDxsaW5rIHR5cGU9InRl eHQvY3NzIiByZWw9InN0eWxlc2hlZXQiCiAgICAgICAgICAgaHJlZj0ie3sg dXJsX2Zvcignc3RhdGljJywgZmlsZW5hbWU9J2Nzcy9zbGlja2dyaWQvc21v b3RobmVzcy9qcXVlcnktdWktMS4xMS4zLmN1c3RvbS5jc3MnIGlmIGNvbmZp Zy5ERUJVRyBlbHNlICdjc3Mvc2xpY2tncmlkL3Ntb290aG5lc3MvanF1ZXJ5 LXVpLTEuMTEuMy5jdXN0b20ubWluLmNzcycpfX0iLz4KKyAgICA8bGluayB0 eXBlPSJ0ZXh0L2NzcyIgcmVsPSJzdHlsZXNoZWV0IgorICAgICAgICAgIGhy ZWY9Int7IHVybF9mb3IoJ3N0YXRpYycsIGZpbGVuYW1lPSdqcy9jb2RlbWly cm9yL2FkZG9uL3Njcm9sbC9zaW1wbGVzY3JvbGxiYXJzLmNzcycpfX0iLz4K CiAgICAgPCEtLSBWaWV3IHNwZWNpZmllZCBzdHlsZXNoZWV0cyAtLT4KICAg ICB7JSBmb3Igc3R5bGVzaGVldCBpbiBjdXJyZW50X2FwcC5zdHlsZXNoZWV0 cyAlfQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9y L3N0YXRpYy9jc3Mvc3FsZWRpdG9yLmNzcyBiL3dlYi9wZ2FkbWluL3Rvb2xz L3NxbGVkaXRvci9zdGF0aWMvY3NzL3NxbGVkaXRvci5jc3MKaW5kZXggNWVj ZmE1Zi4uMTA0NjM2NiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMv c3FsZWRpdG9yL3N0YXRpYy9jc3Mvc3FsZWRpdG9yLmNzcworKysgYi93ZWIv cGdhZG1pbi90b29scy9zcWxlZGl0b3Ivc3RhdGljL2Nzcy9zcWxlZGl0b3Iu Y3NzCkBAIC0xNTYsNiArMTU2LDE4IEBACiAgICAgbWluLWhlaWdodDogMTAw JTsKIH0KCisvKiBDaGFuZ2VzIHNwZWNpZmljIHRvIG91dHB1dCBwYW5lbCBv ZiBxdWVyeSB0b29sICovCisjb3V0cHV0LXBhbmVsLCAjb3V0cHV0LXBhbmVs IC5Db2RlTWlycm9yLCAjb3V0cHV0LXBhbmVsIC5Db2RlTWlycm9yLWd1dHRl cnMgeworICBoZWlnaHQ6IDEwMCUgIWltcG9ydGFudDsKK30KKworI291dHB1 dC1wYW5lbCAuQ29kZU1pcnJvci1ndXR0ZXItd3JhcHBlciB7CisgIHdpZHRo OiA0M3B4OworICBoZWlnaHQ6IDIycHg7CisgIGJvcmRlci1yaWdodDogMXB4 IHNvbGlkICNkZGQgIWltcG9ydGFudDsKKyAgYmFja2dyb3VuZDogI2Y3Zjdm NyAhaW1wb3J0YW50OworfQorCiAuQ29kZU1pcnJvci1mb2xkZ3V0dGVyIHsK ICAgd2lkdGg6IC45ZW07CiB9CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90 b29scy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRvci9qcy9zcWxlZGl0 b3IuanMgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVz L3NxbGVkaXRvci9qcy9zcWxlZGl0b3IuanMKaW5kZXggNzUyMDVkMy4uZDgx ZTc5ZCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9y L3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCisrKyBiL3dl Yi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9y L2pzL3NxbGVkaXRvci5qcwpAQCAtNyw3ICs3LDcgQEAgZGVmaW5lKAogICAg ICdjb2RlbWlycm9yL2FkZG9uL3NlbGVjdGlvbi9hY3RpdmUtbGluZScsCiAg ICAgJ2NvZGVtaXJyb3IvYWRkb24vZm9sZC9mb2xkZ3V0dGVyJywgJ2NvZGVt aXJyb3IvYWRkb24vZm9sZC9mb2xkY29kZScsCiAgICAgJ2NvZGVtaXJyb3Iv YWRkb24vaGludC9zaG93LWhpbnQnLCAnY29kZW1pcnJvci9hZGRvbi9oaW50 L3NxbC1oaW50JywKLSAgICAnY29kZW1pcnJvci9hZGRvbi9mb2xkL3BnYWRt aW4tc3FsZm9sZGNvZGUnLAorICAgICdjb2RlbWlycm9yL2FkZG9uL2ZvbGQv cGdhZG1pbi1zcWxmb2xkY29kZScsJ2NvZGVtaXJyb3IvYWRkb24vc2Nyb2xs L3NpbXBsZXNjcm9sbGJhcnMnLAogICAgICdiYWNrZ3JpZC5zaXplYWJsZS5j b2x1bW5zJywgJ3djZG9ja2VyJywgJ3BnYWRtaW4uZmlsZV9tYW5hZ2VyJwog ICBdLAogICBmdW5jdGlvbigKQEAgLTE5MSw5ICsxOTEsOSBAQCBkZWZpbmUo CiAgICAgICAgIHNxbF9wYW5lbC5sb2FkKG1haW5fZG9ja2VyKTsKICAgICAg ICAgdmFyIHNxbF9wYW5lbF9vYmogPSBtYWluX2RvY2tlci5hZGRQYW5lbCgn c3FsX3BhbmVsJywgd2NEb2NrZXIuRE9DSy5UT1ApOwoKLSAgICAgICAgdmFy IG91dHB1dF9jb250YWluZXIgPSAkKCc8ZGl2IGlkPSJvdXRwdXQtcGFuZWwi PjwvZGl2PicpOwotICAgICAgICB2YXIgdGV4dF9jb250YWluZXIgPSAkKCc8 dGV4dGFyZWEgaWQ9InNxbF9xdWVyeV90b29sIj48L3RleHRhcmVhPicpLmFw cGVuZChvdXRwdXRfY29udGFpbmVyKTsKLSAgICAgICAgc3FsX3BhbmVsX29i ai5sYXlvdXQoKS5hZGRJdGVtKHRleHRfY29udGFpbmVyKTsKKyAgICAgICAg dmFyIHRleHRfY29udGFpbmVyID0gJCgnPHRleHRhcmVhIGlkPSJzcWxfcXVl cnlfdG9vbCI+PC90ZXh0YXJlYT4nKTsKKyAgICAgICAgdmFyIG91dHB1dF9j b250YWluZXIgPSAkKCc8ZGl2IGlkPSJvdXRwdXQtcGFuZWwiPjwvZGl2Picp LmFwcGVuZCh0ZXh0X2NvbnRhaW5lcik7CisgICAgICAgIHNxbF9wYW5lbF9v YmouJGNvbnRhaW5lci5maW5kKCcucGctcGFuZWwtY29udGVudCcpLmFwcGVu ZChvdXRwdXRfY29udGFpbmVyKTsKCiAgICAgICAgIHNlbGYucXVlcnlfdG9v bF9vYmogPSBDb2RlTWlycm9yLmZyb21UZXh0QXJlYSh0ZXh0X2NvbnRhaW5l ci5nZXQoMCksIHsKICAgICAgICAgICAgIGxpbmVOdW1iZXJzOiB0cnVlLApA QCAtMjEwLDcgKzIxMCw4IEBAIGRlZmluZSgKICAgICAgICAgICAgIH0sCiAg ICAgICAgICAgICBndXR0ZXJzOiBbIkNvZGVNaXJyb3ItbGluZW51bWJlcnMi LCAiQ29kZU1pcnJvci1mb2xkZ3V0dGVyIl0sCiAgICAgICAgICAgICBleHRy YUtleXM6IHBnQnJvd3Nlci5lZGl0b3Jfc2hvcnRjdXRfa2V5cywKLSAgICAg ICAgICAgIHRhYlNpemU6IHBnQWRtaW4uQnJvd3Nlci5lZGl0b3Jfb3B0aW9u cy50YWJTaXplCisgICAgICAgICAgICB0YWJTaXplOiBwZ0FkbWluLkJyb3dz ZXIuZWRpdG9yX29wdGlvbnMudGFiU2l6ZSwKKyAgICAgICAgICAgIHNjcm9s bGJhclN0eWxlOiAnc2ltcGxlJwogICAgICAgICB9KTsKCiAgICAgICAgIC8v IENyZWF0ZSBwYW5lbHMgZm9yICdEYXRhIE91dHB1dCcsICdFeHBsYWluJywg J01lc3NhZ2VzJyBhbmQgJ0hpc3RvcnknCg== --001a114426e2a57b13053c8822e2 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114426e2a57b13053c8822e2--