Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMumE-0004m5-IZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jul 2016 10:18:54 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMumE-0001I5-5c for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jul 2016 10:18:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMumD-0001Hy-NI for pgadmin-hackers@postgresql.org; Tue, 12 Jul 2016 10:18:53 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMumA-00067I-1r for pgadmin-hackers@postgresql.org; Tue, 12 Jul 2016 10:18:53 +0000 Received: by mail-wm0-x231.google.com with SMTP id r190so2859757wmr.0 for ; Tue, 12 Jul 2016 03:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9hwiXnbRBmOFR5EhL9OPeMdhCvkTfE0ePdF5UeamfW8=; b=ryPiant+UUZnLDRoPYi5u+OFXL+IH+ZB+e6WGtMtH8KPlJkjsNSAbdlf3wSHvhHCYZ mbVhc71Y2cjyEyGcgAPrZP3qzMJjatQn97F/KaVSuzqyWvRwO7ZbjvOAatOqa9wAeQYI WHjncS4Z5B7V5ZdDKnUtDt93PfbVnhtBg1+vJX6Ti7EU87F728aSkT4aN7RuCJPX064e c5uIUq3w1Yt+zfEnWJaFlANKmXTKdrmw3BIw9YLIobLHYyGVdcmlMb6z3WAsKtSWX9Sp j7l29rlbEGZO93Ss6rMSEu65LHIEptS42nLggSZZi6A8fqfkmMa4TgBG83oqQ8ygTUji 1UHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9hwiXnbRBmOFR5EhL9OPeMdhCvkTfE0ePdF5UeamfW8=; b=T9lQVlFUnnP63Q4O6DtERglTKBRgFXiI84MlMsmSkpfdunKqrYonOZgpCSwCq3oLBn CLyky4pKEkWAYRWf5nCkEADzJA9j2etUnU1lgInmDwNoM/GCWBs7ohyXfem5zjU1QcYY UNe003uk/BQI+PVNNyfrahTR2E9TspJXkmtSs9D9QIx9SBceUHz808blmdHA+HZL838j +5SkOnIvCtmNbXCbc72eJgnyEAPLcsGec01J4sTJJcQEDkS7ISUnIdmmJQWqgFMCfpls 4aVIDH5CJkFx2cXC4W3onpKcnneW2hCkkStVT3nUORCuVAtMlKloJMBSV4MculG2uWmL NhsQ== X-Gm-Message-State: ALyK8tIWXlLV4kKlMbHr/bgfuC5kbXETqdcPr4phqtt7IsIg8Syvk3X1soTOaKZeXdWSCuFBJMIuIdwJWhnq5Tn3 X-Received: by 10.28.183.134 with SMTP id h128mr2326732wmf.7.1468318729289; Tue, 12 Jul 2016 03:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Tue, 12 Jul 2016 03:18:19 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Tue, 12 Jul 2016 15:48:19 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1148f70e47177405376d98d7 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1148f70e47177405376d98d7 Content-Type: text/plain; charset=UTF-8 On Tue, Jul 12, 2016 at 3:43 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > Just a heads up, This issue is occurs only in runtime & If you try in web > everything works fine when you provide unicode characters as object name. > No, this issue is reported for both web and runtime application. It is reproducible to me in web application. > > Now sure but the issue is when runtime(QtWebkit) sends data it does not > encodes it properly & this should be generic fix in runtime. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Jul 12, 2016 at 3:27 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi >> >> *What is happening in code?* >> Database is created with Chinese characters successfully with ascii >> values(Chinese characters converted to ascii) before saving internally. >> >> but when database properties is retrieved by name, it fails to fetch data >> and throws UnicodeError. >> >> *Solution:* >> Database name should be encoded in 'utf-8' before storing to database. >> This resolved the issue. >> I have tested this patch by creating database name using Japanese and >> Chinese characters. It works. >> >> Also referenced the code to *set default encoding to 'uff-8' *before >> start of application. >> https://github.com/joeyespo/grip/issues/86 >> >> @Ashesh/@Dave can you please review the patch? >> If it looks good, we can do the same changes in case of other nodes. >> >> Thanks, >> Surinder Kumar >> >> >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a1148f70e47177405376d98d7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Jul 12, 2016 at 3:43 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Just a heads up, This issue = is occurs only in runtime & If you try in web everything works fine whe= n you provide unicode characters as object name.
No, this issue is reported for both web and runtime application. It is r= eproducible to me in web application.
<= div dir=3D"ltr">

Now sure but the issue is when runtime(= QtWebkit) sends data it does not encodes it properly & this should be g= eneric fix in runtime.

Regards,
Murtuza<= /div>

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The E= nterprise PostgreSQL Company

On Tue, Jul 12, 2016 = at 3:27 PM, Surinder Kumar <surinder.kumar@enterprisedb.com<= /a>> wrote:
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--001a1148f70e47177405376d98d7--