Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blz6T-0000uC-Py for pgadmin-hackers@arkaria.postgresql.org; Mon, 19 Sep 2016 13:59:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1blz6T-0004UK-Bm for pgadmin-hackers@arkaria.postgresql.org; Mon, 19 Sep 2016 13:59:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1blz6S-0004UD-P3 for pgadmin-hackers@postgresql.org; Mon, 19 Sep 2016 13:59:24 +0000 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1blz6Q-0005rV-0a for pgadmin-hackers@postgresql.org; Mon, 19 Sep 2016 13:59:23 +0000 Received: by mail-lf0-x231.google.com with SMTP id h127so113042466lfh.0 for ; Mon, 19 Sep 2016 06:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=PLqEgUVgyUtrnSrsG7RceeBzRd9jWEHfclzSafJ6DHc=; b=LbsOS/o2sZ2LIqCz8y9A4uRI37hbMMwWTyvUR8yiEEoa4k+3nbQm6Ud08tVhYEAcSi VSjOr4PPk38YTsY+qL61kelfBCSvKuXk32nzpeGcL51QsHi5eKG8UuoiBh4CaEoBaufI pYByMUCVwohtmCcTCFr07UMSMtid54oPZ5pOoKRVFL5YLUXXcb/ESbdIVMNEu+c6Y4Jy YO8ylw3oku6Pl3ShEYFvpFD6Dm1RdQEsjLnc+kdF1jsfTqgXsZ3kDfntWOlJuf8Cu8CI OVrKHMJDweuaOBjfxBejL0SpOIS/E5VfWJGXIpGtli/NHfxIxuHguq5UT4WTK/EvdPve FYTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PLqEgUVgyUtrnSrsG7RceeBzRd9jWEHfclzSafJ6DHc=; b=NC6XFg3+qbbv8GXfHbKe9UXjpTXPu7+UUh+AanaAFjJuY++dgCnREraHbDT6cxfEjd U5+qF/yr+w/5XoBi+E/a+HBHdgTfDJbTPxrlbuLWd5lJTKcz+hW8jVkgXK4lpMFYiorG +CxfFQL6eLGfO/tBQ0lL+0lZ6Qro1E88yBLDb09BvlCVUshZyaS9T/Vhlq9wBr1aEUbD SSvTpDXGDSKPwMrdTcyw5qfGNvuLo0mC/u1OdLRwSokYpb93KSRyV6RgOizBUaPAIJ4z P18rgAgZB8Xhw3VyMkyvzjCziUuZ9EkFPRSVbnwoMxDBP5H3l5IWGPinzJte9Xpf7p24 1eKw== X-Gm-Message-State: AE9vXwOxkQ6qwOodH8D+6RO7un8iyNYxm3jLaDmgA0SF1ZBw977lyQ61X9/F8WF3I0TF0GrS6UWaA6jVXgWJpKqs X-Received: by 10.194.89.228 with SMTP id br4mr23163418wjb.187.1474293560110; Mon, 19 Sep 2016 06:59:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Mon, 19 Sep 2016 06:58:49 -0700 (PDT) From: Surinder Kumar Date: Mon, 19 Sep 2016 19:28:49 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Slickgrid loading issue in Query tool To: pgadmin-hackers Content-Type: multipart/mixed; boundary=047d7bf10adaf257a9053cdcb7ee X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bf10adaf257a9053cdcb7ee Content-Type: multipart/alternative; boundary=047d7bf10adaf257a6053cdcb7ec --047d7bf10adaf257a6053cdcb7ec Content-Type: text/plain; charset=UTF-8 Hi *Issue:* Slick-grid libraries loads when an instance of query tool is opened. But sometimes it throws exception "jQuery is not defined" and it doesn't opens up. *Solution:* As per my understanding, In *datagrid/index.html* file, we set the order of loading libraries such as *require(['jquery', 'pgadmin', 'pgadmin.sqleditor']) * but it still loads *pgadmin.sqleditor.js* file before *jQuery* for unknown reason. To fix this, we load *pgadmin.sqleditor.js* file using *require([], function(){}) *module loader which ensures that the code within *function(){}* will be executed when pgadmin.sqleditor.js is loaded. Please find attache patch. This issue is fixed by *Ashesh Vashi*. Thanks, Surinder Kumar --047d7bf10adaf257a6053cdcb7ec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Issue:
Slick-grid librarie= s loads when an instance of query tool is opened. But sometimes it throws e= xception "jQuery is not defined" and it doesn't opens up.

Solution:
As per my understan= ding, In datagrid/index.html file, we set the order of loading libra= ries such as=C2=A0
require(['jquery', 'pgadmin= ', 'pgadmin.sqleditor'])=C2=A0
but it still loads pgadmin.sqleditor.js file before jQuery<= /b> for unknown reason.

To fix this, we load=C2=A0pgadmin.sqleditor.js= =C2=A0file using require([], function(){}) module loader which ensur= es that the code within function(){} will be executed when pgadmin.s= qleditor.js is loaded.

Please find attache patch.
This issue is fixed by Ashesh Vashi.

Thanks,
Surinder Kumar
--047d7bf10adaf257a6053cdcb7ec-- --047d7bf10adaf257a9053cdcb7ee Content-Type: application/octet-stream; name="slickgrid_js_load_issue.patch" Content-Disposition: attachment; filename="slickgrid_js_load_issue.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ita4ader0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3RlbXBs YXRlcy9kYXRhZ3JpZC9pbmRleC5odG1sIGIvd2ViL3BnYWRtaW4vdG9vbHMv ZGF0YWdyaWQvdGVtcGxhdGVzL2RhdGFncmlkL2luZGV4Lmh0bWwKaW5kZXgg MzdlNDYzMi4uMjA1ZWM1MyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9v bHMvZGF0YWdyaWQvdGVtcGxhdGVzL2RhdGFncmlkL2luZGV4Lmh0bWwKKysr IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvdGVtcGxhdGVzL2RhdGFn cmlkL2luZGV4Lmh0bWwKQEAgLTE4MSw3ICsxODEsNyBAQAogICAgICAgICAg ICAgICAgIDwvdWw+CiAgICAgICAgICAgICA8L2Rpdj4KICAgICAgICAgICAg IDxkaXYgY2xhc3M9ImJ0bi1ncm91cCIgcm9sZT0iZ3JvdXAiIGFyaWEtbGFi ZWw9IiI+Ci0gICAgICAgICAgICAgICAgPGJ1dHRvbiBpZD0iYnRuLWRvd25s b2FkIiB0eXBlPSJidXR0b24iIGNsYXNzPSJidG4gYnRuLWRlZmF1bHQiIHRp dGxlPSJ7eyBfKCdEb3dubG9hZCBhcyBDU1YgKEY4KScpIH19Ij4KKyAgICAg ICAgICAgICAgICA8YnV0dG9uIGlkPSJidG4tZG93bmxvYWQiIHR5cGU9ImJ1 dHRvbiIgY2xhc3M9ImJ0biBidG4tZGVmYXVsdCIgdGl0bGU9Int7IF8oJ0Rv d25sb2FkIGFzIENTViAoRjgpJykgfX0iIGRpc2FibGVkPgogICAgICAgICAg ICAgICAgICAgICA8aSBjbGFzcz0iZmEgZmEtZG93bmxvYWQiIGFyaWEtaGlk ZGVuPSJ0cnVlIj48L2k+CiAgICAgICAgICAgICAgICAgPC9idXR0b24+CiAg ICAgICAgICAgICA8L2Rpdj4KQEAgLTIwOSw2NCArMjA5LDYwIEBACiA8L2Rp dj4KIHslIGVuZGJsb2NrICV9CiAKLXslIGJsb2NrIGluaXRfc2NyaXB0ICV9 Ci10cnkgewotcmVxdWlyZSgKLVsnanF1ZXJ5JywgJ3BnYWRtaW4nLCAncGdh ZG1pbi5zcWxlZGl0b3InXSwKLWZ1bmN0aW9uKCQsIHBnQWRtaW4pIHsKK3sl IGJsb2NrIGluaXRfc2NyaXB0ICV9cmVxdWlyZSgKKyAgWydqcXVlcnknLCAn cGdhZG1pbicsICdyZXF1aXJlJywgJ3VuZGVyc2NvcmUuc3RyaW5nJ10sCitm dW5jdGlvbigkLCBwZ0FkbWluLCBSLCBTKSB7CisJUihbJ3BnYWRtaW4uc3Fs ZWRpdG9yJ10sIGZ1bmN0aW9uKCkgeworICAgIHZhciBlZGl0b3JQYW5lbCA9 ICQoJy5zcWwtZWRpdG9yJyksCisgICAgbG9hZGluZ0RpdiA9ICQoJyNmZXRj aGluZ19kYXRhJyksCisgICAgbXNnRGl2ID0gbG9hZGluZ0Rpdi5maW5kKCcu c3FsLWVkaXRvci1idXN5LXRleHQnKTsKIAotdmFyIGVkaXRvclBhbmVsID0g JCgnLnNxbC1lZGl0b3InKSwKLWxvYWRpbmdEaXYgPSAkKCcjZmV0Y2hpbmdf ZGF0YScpLAotbXNnRGl2ID0gbG9hZGluZ0Rpdi5maW5kKCcuc3FsLWVkaXRv ci1idXN5LXRleHQnKTsKKyAgICAvLyBHZXQgdGhlIGNvbnRyb2xsZXIgb2Jq ZWN0IGZyb20gcGdBZG1pbi5TcWxFZGl0b3IKKyAgICB2YXIgc3FsRWRpdG9y Q29udHJvbGxlciA9IHBnQWRtaW4uU3FsRWRpdG9yLmNyZWF0ZShlZGl0b3JQ YW5lbCk7CiAKLS8vIEdldCB0aGUgY29udHJvbGxlciBvYmplY3QgZnJvbSBw Z0FkbWluLlNxbEVkaXRvcgotdmFyIHNxbEVkaXRvckNvbnRyb2xsZXIgPSBw Z0FkbWluLlNxbEVkaXRvci5jcmVhdGUoZWRpdG9yUGFuZWwpOworICAgIC8v IExpc3RlbiBvbiBldmVudHMgdG8gc2hvdy9oaWRlIGxvYWRpbmctaWNvbiBh bmQgY2hhbmdlIG1lc3NhZ2VzLgorICAgIHNxbEVkaXRvckNvbnRyb2xsZXIu b24oJ3BnYWRtaW4tc3FsZWRpdG9yOmxvYWRpbmctaWNvbjptZXNzYWdlJywg ZnVuY3Rpb24obXNnKSB7CisgICAgICBtc2dEaXYudGV4dChtc2cpOworICAg ICAgfSkub24oJ3BnYWRtaW4tc3FsZWRpdG9yOmxvYWRpbmctaWNvbjpzaG93 JywgZnVuY3Rpb24obXNnKSB7CisgICAgICAgIGxvYWRpbmdEaXYucmVtb3Zl Q2xhc3MoJ2hpZGUnKTsKKyAgICAgICAgbXNnRGl2LnRleHQobXNnKTsKKyAg ICAgICAgfSkub24oJ3BnYWRtaW4tc3FsZWRpdG9yOmxvYWRpbmctaWNvbjpo aWRlJywgZnVuY3Rpb24oKSB7CisgICAgICAgICAgaWYgKCFsb2FkaW5nRGl2 Lmhhc0NsYXNzKCdoaWRlJykpIHsKKyAgICAgICAgICBsb2FkaW5nRGl2LmFk ZENsYXNzKCdoaWRlJyk7CisgICAgICAgICAgfQorICAgICAgICAgIH0pOwog Ci0vLyBMaXN0ZW4gb24gZXZlbnRzIHRvIHNob3cvaGlkZSBsb2FkaW5nLWlj b24gYW5kIGNoYW5nZSBtZXNzYWdlcy4KLXNxbEVkaXRvckNvbnRyb2xsZXIu b24oJ3BnYWRtaW4tc3FsZWRpdG9yOmxvYWRpbmctaWNvbjptZXNzYWdlJywg ZnVuY3Rpb24obXNnKSB7Ci1tc2dEaXYudGV4dChtc2cpOwotfSkub24oJ3Bn YWRtaW4tc3FsZWRpdG9yOmxvYWRpbmctaWNvbjpzaG93JywgZnVuY3Rpb24o bXNnKSB7Ci1sb2FkaW5nRGl2LnJlbW92ZUNsYXNzKCdoaWRlJyk7Ci1tc2dE aXYudGV4dChtc2cpOwotfSkub24oJ3BnYWRtaW4tc3FsZWRpdG9yOmxvYWRp bmctaWNvbjpoaWRlJywgZnVuY3Rpb24oKSB7Ci1pZiAoIWxvYWRpbmdEaXYu aGFzQ2xhc3MoJ2hpZGUnKSkgewotbG9hZGluZ0Rpdi5hZGRDbGFzcygnaGlk ZScpOwotfQotfSk7Ci0KLS8vIEZldGNoIHRoZSBTUUwgZm9yIFNjcmlwdHMg KGVnOiBDUkVBVEUvVVBEQVRFL0RFTEVURS9TRUxFQ1QpCi12YXIgc2NyaXB0 X3NxbCA9ICcnOworICAgIC8vIEZldGNoIHRoZSBTUUwgZm9yIFNjcmlwdHMg KGVnOiBDUkVBVEUvVVBEQVRFL0RFTEVURS9TRUxFQ1QpCisgICAgdmFyIHNj cmlwdF9zcWwgPSAnJzsKIHslIGlmIHNjcmlwdF90eXBlX3VybCV9Ci0vLyBD YWxsIEFKQVggb25seSBpZiBzY3JpcHQgdHlwZSB1cmwgaXMgcHJlc2VudAot JC5hamF4KHsKLXVybDogJ3t7IHNjcmlwdF90eXBlX3VybCB9fScsCi10eXBl OidHRVQnLAotYXN5bmM6IGZhbHNlLAotc3VjY2VzczogZnVuY3Rpb24ocmVz KSB7Ci1zY3JpcHRfc3FsID0gcmVzOwotfSwKLWVycm9yOiBmdW5jdGlvbihq cXgpIHsKLXZhciBtc2cgPSBqcXgucmVzcG9uc2VUZXh0OwotLyogRXJyb3Ig ZnJvbSB0aGUgc2VydmVyICovCi1pZiAoanF4LnN0YXR1cyA9PSA0MTAgfHwg anF4LnN0YXR1cyA9PSA1MDApIHsKLXRyeSB7Ci12YXIgZGF0YSA9ICQucGFy c2VKU09OKGpxeC5yZXNwb25zZVRleHQpOwotbXNnID0gZGF0YS5lcnJvcm1z ZzsKLX0gY2F0Y2ggKGUpIHt9Ci19Ci1wZ0Jyb3dzZXIucmVwb3J0X2Vycm9y KAotUygne3sgXygnRXJyb3IgZmV0Y2hpbmcgU1FMIGZvciBzY3JpcHQ6ICIl cyInKSB9fScpCi0uc3ByaW50Zihtc2cpCi0udmFsdWUoKSwgbXNnKTsKLX0K LX0pOworICAgIC8vIENhbGwgQUpBWCBvbmx5IGlmIHNjcmlwdCB0eXBlIHVy bCBpcyBwcmVzZW50CisgICAgJC5hamF4KHsKKyAgICAgIHVybDogJ3t7IHNj cmlwdF90eXBlX3VybCB9fScsCisgICAgICB0eXBlOidHRVQnLAorICAgICAg YXN5bmM6IGZhbHNlLAorICAgICAgc3VjY2VzczogZnVuY3Rpb24ocmVzKSB7 CisgICAgICAgIHNjcmlwdF9zcWwgPSByZXM7CisgICAgICB9LAorICAgICAg ZXJyb3I6IGZ1bmN0aW9uKGpxeCkgeworICAgICAgICB2YXIgbXNnID0ganF4 LnJlc3BvbnNlVGV4dDsKKyAgICAgICAgLyogRXJyb3IgZnJvbSB0aGUgc2Vy dmVyICovCisgICAgICAgIGlmIChqcXguc3RhdHVzID09IDQxMCB8fCBqcXgu c3RhdHVzID09IDUwMCkgeworICAgICAgICAgIHRyeSB7CisgICAgICAgICAg ICB2YXIgZGF0YSA9ICQucGFyc2VKU09OKGpxeC5yZXNwb25zZVRleHQpOwor ICAgICAgICAgICAgbXNnID0gZGF0YS5lcnJvcm1zZzsKKyAgICAgICAgICB9 IGNhdGNoIChlKSB7fQorICAgICAgICB9CisgICAgICAgIHBnQnJvd3Nlci5y ZXBvcnRfZXJyb3IoCisgICAgICAgICAgUygne3sgXygnRXJyb3IgZmV0Y2hp bmcgU1FMIGZvciBzY3JpcHQ6ICIlcyInKSB9fScpCisgICAgICAgICAgLnNw cmludGYobXNnKQorICAgICAgICAgIC52YWx1ZSgpLCBtc2cKKyAgICAgICAg KTsKKyAgICAgIH0KKyAgICB9KTsKIHslIGVuZGlmICV9CiAKLS8vIFN0YXJ0 IHRoZSBxdWVyeSB0b29sLgotc3FsRWRpdG9yQ29udHJvbGxlci5zdGFydCh7 eyBpc19xdWVyeV90b29sIH19LCAie3sgZWRpdG9yX3RpdGxlIH19Iiwgc2Ny aXB0X3NxbCk7CisgICAgLy8gU3RhcnQgdGhlIHF1ZXJ5IHRvb2wuCisgICAg c3FsRWRpdG9yQ29udHJvbGxlci5zdGFydCh7eyBpc19xdWVyeV90b29sIH19 LCAie3sgZWRpdG9yX3RpdGxlIH19Iiwgc2NyaXB0X3NxbCk7CisgIH0pOwog fSk7Ci19IGNhdGNoIChlcnIpIHsKLS8qIFNob3cgcHJvcGVyIGVycm9yIGRp YWxvZyAqLwotY29uc29sZS5sb2coZXJyKTsKLX0KIHslIGVuZGJsb2NrICV9 Cg== --047d7bf10adaf257a9053cdcb7ee Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --047d7bf10adaf257a9053cdcb7ee--