MIME-Version: 1.0
From: Surinder Kumar <surinder.kumar@enterprisedb.com>
Date: Mon, 18 Jan 2016 16:33:36 +0530
Message-ID: 
 <CAM5-9D8hPH9Hj8mAq+XorWvV7N4xKn5g3PCUj-x6UhhCReiPmQ@mail.gmail.com>
Subject: [pgAdmin3][Extension]: Wrong SQL generated
To: pgadmin-hackers@postgresql.org
Content-Type: multipart/alternative; boundary=047d7bd91af22092c1052999b6e1
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--047d7bd91af22092c1052999b6e1
Content-Type: text/plain; charset=UTF-8

Hi all,


While implementing Extension module in pgAdmin4, I came to know that there
is an bug in pgadmin3.

Following are the steps to reproduce it:
1. Edit an existing extension.
2. In definition tab, set schema and version fields to empty.
3. In SQL tab, it generates an sql for the changes made which is wrong, it
shouldn't generate sql for the schema and version field if it is kept
empty, both fields should be validated.


Below is the wrong SQL generated:

*ALTER EXTENSION btree_gin*
*  SET SCHEMA ;*
*ALTER EXTENSION btree_gin*
*  UPDATE TO ;*


Let me know for any comments.

Thanks
Surinder Kumar

--047d7bd91af22092c1052999b6e1
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi all,<div><br></div><div><br><div>While implementing Ext=
ension module in pgAdmin4, I came to know that there is an bug in pgadmin3.=
</div><div><br></div><div>Following are the steps to reproduce it:</div><di=
v>1. Edit an existing extension.</div><div>2. In definition tab, set schema=
 and version fields to empty.</div><div>3. In SQL tab, it generates an sql =
for the changes made which is wrong, it shouldn&#39;t generate sql for the =
schema and version field if it is kept empty, both fields should be validat=
ed.</div><div><br></div><div><br></div><div>Below is the wrong SQL generate=
d:</div><div><br></div><div><div><b style=3D"background-color:rgb(255,255,2=
55)">ALTER EXTENSION btree_gin</b></div><div><b style=3D"background-color:r=
gb(255,255,255)">=C2=A0 SET SCHEMA ;</b></div><div><b style=3D"background-c=
olor:rgb(255,255,255)">ALTER EXTENSION btree_gin</b></div><div><b style=3D"=
background-color:rgb(255,255,255)">=C2=A0 UPDATE TO ;</b></div></div><div><=
b style=3D"background-color:rgb(255,255,255)"><br></b></div><div><b style=
=3D"background-color:rgb(255,255,255)"><br></b></div><div>Let me know for a=
ny comments.</div><div><b style=3D"background-color:rgb(255,255,255)"><br><=
/b></div><div>Thanks</div><div>Surinder Kumar</div></div></div>

--047d7bd91af22092c1052999b6e1--