MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D8tCizz9o7EDDr_Xyur8Wh2HX1rs5drEycAKmsXBtE+1A@mail.gmail.com>
References: 
 <CAM5-9D8tCizz9o7EDDr_Xyur8Wh2HX1rs5drEycAKmsXBtE+1A@mail.gmail.com>
From: Surinder Kumar <surinder.kumar@enterprisedb.com>
Date: Fri, 29 Apr 2016 11:34:23 +0530
Message-ID: 
 <CAM5-9D8hpNUTdYG_xqTLw7YxjynnNLM+niEgOd3gOab0G3Ry6g@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Remove default extraclass
 from the SqlFieldControl
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a114b6a7ee027530531996b4d
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a114b6a7ee027530531996b4d
Content-Type: text/plain; charset=UTF-8

Hi,

More specifically to the issue.
I am using SqlFieldControl in View for Definition Field which takes default
height of 300px which is set by Control as default height. but as per
dave's suggestion on thread

http://www.postgresql.org/message-id/CA+OCxozN++8sFqJwJZ5QSFBxa7p-47apohOLtSotPBK6N5vUJA@mail.gmail.com

"The Definition box on the View dialogue should start at a single
line and expand as needed - see the Function dialogue".

If user still need some height for control, It can be specified in*
extraclasses[]* parameter which will apply to the specific field.


On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <
surinder.kumar@enterprisedb.com> wrote:

> Hi,
>
> The *SqlFieldControl* is setting default height for textarea, which is
> not needed.
> It should expand as needed as similar in *SqlTabControl*.
>
> Please find the attached patch, review it.
>
> Thanks
> Surinder Kumar
>

--001a114b6a7ee027530531996b4d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>More specifically to the issue.</di=
v><div>I am using SqlFieldControl in View for Definition Field which takes =
default height of 300px which is set by Control as default height. but as p=
er dave&#39;s suggestion on thread</div><div><br></div><div><a href=3D"http=
://www.postgresql.org/message-id/CA+OCxozN++8sFqJwJZ5QSFBxa7p-47apohOLtSotP=
BK6N5vUJA@mail.gmail.com">http://www.postgresql.org/message-id/CA+OCxozN++8=
sFqJwJZ5QSFBxa7p-47apohOLtSotPBK6N5vUJA@mail.gmail.com</a><br></div><div><b=
r></div><div><div>&quot;The Definition box on the View dialogue should star=
t at a single</div><div>line and expand as needed - see the Function dialog=
ue&quot;.</div></div><div><br></div><div>If user still need some height for=
 control, It can be specified in<b> extraclasses[]</b> parameter which will=
 apply to the specific field.</div><div><br></div><div><br></div></div><div=
 class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, Apr 28, 2016 =
at 7:02 PM, Surinder Kumar <span dir=3D"ltr">&lt;<a href=3D"mailto:surinder=
.kumar@enterprisedb.com" target=3D"_blank">surinder.kumar@enterprisedb.com<=
/a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:=
0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi=
,<div><br></div><div>The=C2=A0<b>SqlFieldControl</b> is setting default hei=
ght for textarea, which is not needed.</div><div>It should expand as needed=
 as similar in=C2=A0<b>SqlTabControl</b>.</div><div><br></div><div>Please f=
ind the attached patch, review it.</div><div><br></div><div>Thanks</div><sp=
an class=3D"HOEnZb"><font color=3D"#888888"><div>Surinder Kumar</div></font=
></span></div>
</blockquote></div><br></div>

--001a114b6a7ee027530531996b4d--