Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bw2Pe-0003Au-62 for pgadmin-hackers@arkaria.postgresql.org; Mon, 17 Oct 2016 07:32:46 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bw2Pd-0006EB-KR for pgadmin-hackers@arkaria.postgresql.org; Mon, 17 Oct 2016 07:32:45 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bw2Pc-0006E4-Ou for pgadmin-hackers@postgresql.org; Mon, 17 Oct 2016 07:32:45 +0000 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bw2PV-0007cV-RM for pgadmin-hackers@postgresql.org; Mon, 17 Oct 2016 07:32:43 +0000 Received: by mail-qk0-x232.google.com with SMTP id f128so209489999qkb.1 for ; Mon, 17 Oct 2016 00:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kyhR1rdqNFwZ3yKyKekzjFrL5kOLfVPilHUEDw3cbrQ=; b=C9X45hfSH/WidjRJevAMLaicz5/tFtq1l0Pf2S083feFZ1EP742bxh9sioy+I/IHwS K13zUfJzFsyPgd44yLux4MQofDHvdcIlGqFCAbR5aTYhvR7XXi0HlBdW0UOKzF0+2euO aIYoC3CRQ++44BHbZbsmzGoFWQ2BWSSdhSW6Kawa1JqCJJTHc13qSP9ei3i+wyfXjjAS sX1O1f/t8CGYMDZuf7GVBGCD9PtSsUbUECIqengGe3eemBWW6f30TK6/K5edfQ2TzzWq yPIIav37mrdb6njB56ocZ/HkhR2pE2gUa1nfle/TvjMZtamBSyH+FJoDCkwTpmRqqIcp E4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kyhR1rdqNFwZ3yKyKekzjFrL5kOLfVPilHUEDw3cbrQ=; b=cCHPBGBBJaMG3EaT7l1lIIErupOlTPZot2fVqueh0LCBUInx9/xwExK9ithFXYGkP8 XwuDL0E2Xx/FAv+6PfCRkW4BoylfPkNX4iitxcx++HffSQdB44pAbihD4VkhQLTTHwp6 KV8wW51qUhJ/p9vtuA2vtqngExikHbmF5m6oXWyNtZLVIPEgmgy5VsBTIZab3EHtui36 IHtjNdgXRLq4hidobrEP12uS7c1DW3yS95TzQbqPmM3S3D6x9fH0p5r8wFc7AwbdC76q SV3RQFL9djRI4sPhSs3+xFSsMQLgQujA6LPteDfI/PFUixEvosHvFfnHemGzfdHU33yd y/WQ== X-Gm-Message-State: AA6/9Rl6gg0QchvqCHPX46s3jQayQu2GQ28Cb16Nm0gYM7Xr267s4onSVZPvkv8G7jNePxzVdrE7WJylcDEAn1ni X-Received: by 10.194.147.48 with SMTP id th16mr10437654wjb.68.1476689556401; Mon, 17 Oct 2016 00:32:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Mon, 17 Oct 2016 00:32:05 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Mon, 17 Oct 2016 13:02:05 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Listing of files/folders not sorted alphabetically in Storage Manager To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=089e012282b6741abe053f0a94f5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e012282b6741abe053f0a94f5 Content-Type: multipart/alternative; boundary=089e012282b6741abb053f0a94f3 --089e012282b6741abb053f0a94f3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=80=8BHi Dave, As we have already been using natural sort in pgAdmin4 for sorting browser tree nodes. So I have used the same for sorting Storage Manager's filesystem. Please find updated patch and let me know for comments. On Fri, Oct 7, 2016 at 5:10 PM, Dave Page wrote: > Hi > > The patch fixes the filename length issue, but does not seem to > resolve the sorting. Please see the attached screenshot. > > On Fri, Oct 7, 2016 at 8:48 AM, Surinder Kumar > wrote: > > Hi, > > > > Issues fixed: > > 1) Listing of files/folders not sorted alphabetically. > > 2) Some file names are truncated despite the fact that there is plenty = of > > room to be displayed. > > > > Not Fixed: > > In Table mode, clicking on Name bar makes no difference. > > As discussed with Ashesh we are not implementing it now. It requires a > lot > > of changes with current implementation. > > > > Please find attached patch and review. > > > > Thanks, > > Surinder Kumar > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --089e012282b6741abb053f0a94f3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=E2= =80=8BHi Dave,
=
As we have= already been using natural sort in pgAdmin4 for sorting browser tree nodes= . So I have used the same for sorting Storage Manager's filesystem.
Please find update= d patch and let me know for comments.

On Fri, Oct 7, 2016 at 5:10 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Hi

The patch fixes the filename length issue, but does not seem to
resolve the sorting. Please see the attached screenshot.

On Fri, Oct 7, 2016 at 8:48 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi,
>
> Issues fixed:
> 1) Listing of files/folders not sorted alphabetically.
> 2) Some file names are truncated despite the fact that there is plenty= of
> room to be displayed.
>
> Not Fixed:
> In Table mode, clicking on Name bar makes no difference.
> As discussed with Ashesh we are not implementing it now. It requires a= lot
> of changes with current implementation.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--089e012282b6741abb053f0a94f3-- --089e012282b6741abe053f0a94f5 Content-Type: application/octet-stream; name="RM1792_v1.patch" Content-Disposition: attachment; filename="RM1792_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iudqta0e1 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL19f aW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvX19p bml0X18ucHkKaW5kZXggZTI2MjIwOC4uNWM2YTkwOCAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvX19pbml0X18ucHkKKysr IGIvd2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvX19pbml0X18ucHkK QEAgLTQxNSw3ICs0MTUsNyBAQCBjbGFzcyBGaWxlbWFuYWdlcihvYmplY3Qp OgogICAgICAgICAgICAgICAgIGV4Y2VwdDoKICAgICAgICAgICAgICAgICAg ICAgZHJpdmVfc2l6ZSA9IDAKICAgICAgICAgICAgICAgICBwcm90ZWN0ZWQg PSAxIGlmIGRyaXZlX3NpemUgPT0gMCBlbHNlIDAKLSAgICAgICAgICAgICAg ICBmaWxlc1tkcml2ZV0gPSB7CisgICAgICAgICAgICAgICAgZmlsZXNbZmls ZV9uYW1lXSA9IHsKICAgICAgICAgICAgICAgICAgICAgIkZpbGVuYW1lIjog ZmlsZV9uYW1lLAogICAgICAgICAgICAgICAgICAgICAiUGF0aCI6IHBhdGgs CiAgICAgICAgICAgICAgICAgICAgICJmaWxlX3R5cGUiOiAnZHJpdmUnLApA QCAtNDQxLDcgKzQ0MSwxMiBAQCBjbGFzcyBGaWxlbWFuYWdlcihvYmplY3Qp OgoKICAgICAgICAgb3JpZ19wYXRoID0gdW5xdW90ZShvcmlnX3BhdGgpCiAg ICAgICAgIHRyeToKLSAgICAgICAgICAgIGZvciBmIGluIHNvcnRlZChvcy5s aXN0ZGlyKG9yaWdfcGF0aCkpOgorICAgICAgICAgICAgZGVmIGN1c3RvbV9z b3J0KHgsIHkpOgorICAgICAgICAgICAgICAgIHJldHVybiB5Lmxvd2VyKCkg PiB4Lmxvd2VyKCkKKworICAgICAgICAgICAgbXlsaXN0ID0gW3ggZm9yIHgg aW4gc29ydGVkKG9zLmxpc3RkaXIob3JpZ19wYXRoKSwKKyAgICAgICAgICAg ICAgICAgICAgICBjbXA9Y3VzdG9tX3NvcnQpXQorICAgICAgICAgICAgZm9y IGYgaW4gbXlsaXN0OgogICAgICAgICAgICAgICAgIHByb3RlY3RlZCA9IDAK ICAgICAgICAgICAgICAgICBzeXN0ZW1fcGF0aCA9IG9zLnBhdGguam9pbihv cy5wYXRoLmpvaW4ob3JpZ19wYXRoLCBmKSkKCkBAIC00NzQsNyArNDc5LDcg QEAgY2xhc3MgRmlsZW1hbmFnZXIob2JqZWN0KToKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb250aW51ZQoKICAgICAgICAgICAgICAgICAjIGNy ZWF0ZSBhIGxpc3Qgb2YgZmlsZXMgYW5kIGZvbGRlcnMKLSAgICAgICAgICAg ICAgICBmaWxlc1t1c2VyX3BhdGhdID0geworICAgICAgICAgICAgICAgIGZp bGVzW2ZdID0gewogICAgICAgICAgICAgICAgICAgICAiRmlsZW5hbWUiOiBm LAogICAgICAgICAgICAgICAgICAgICAiUGF0aCI6IHVzZXJfcGF0aCwKICAg ICAgICAgICAgICAgICAgICAgImZpbGVfdHlwZSI6IGZpbGVfZXh0ZW5zaW9u LApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIv dGVtcGxhdGVzL2ZpbGVfbWFuYWdlci9qcy91dGlsaXR5LmpzIGIvd2ViL3Bn YWRtaW4vbWlzYy9maWxlX21hbmFnZXIvdGVtcGxhdGVzL2ZpbGVfbWFuYWdl ci9qcy91dGlsaXR5LmpzCmluZGV4IDFiZjdjZDYuLmYxYTVlZjQgMTAwNzU1 Ci0tLSBhL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL3RlbXBsYXRl cy9maWxlX21hbmFnZXIvanMvdXRpbGl0eS5qcworKysgYi93ZWIvcGdhZG1p bi9taXNjL2ZpbGVfbWFuYWdlci90ZW1wbGF0ZXMvZmlsZV9tYW5hZ2VyL2pz L3V0aWxpdHkuanMKQEAgLTIzNiw3ICsyMzYsNyBAQCB2YXIgc2V0VXBsb2Fk ZXIgPSBmdW5jdGlvbihwYXRoKSB7CgogICAgICAgLy8gdGVtcGxhdGUgZm9y IGNyZWF0aW5nIG5ldyBmb2xkZXIKICAgICAgIGZvbGRlcl9kaXYgPQotICAg ICAgICAiPGxpIGNsYXNzPSdjYXBfZG93bmxvYWRjYXBfZGVsZXRlY2FwX3Nl bGVjdF9maWxlY2FwX3NlbGVjdF9mb2xkZXJjYXBfcmVuYW1lY2FwX2NyZWF0 ZWNhcF91cGxvYWQnPiIgKworICAgICAgICAiPGxpIGNsYXNzPSdjYXBfZG93 bmxvYWQgY2FwX2RlbGV0ZSBjYXBfc2VsZWN0X2ZpbGUgY2FwX3NlbGVjdF9m b2xkZXIgY2FwX3JlbmFtZSBjYXBfY3JlYXRlIGNhcF91cGxvYWQnPiIgKwog ICAgICAgICAiPGRpdiBjbGFzcz0nY2xpcCc+PHNwYW4gZGF0YS1hbHQ9Jycg Y2xhc3M9J2ZhIGZhLWZvbGRlci1vcGVuIGZtX2ZvbGRlcic+PC9zcGFuPjwv ZGl2PiIgKwogICAgICAgICAiPHA+PGlucHV0IHR5cGU9J3RleHQnIGNsYXNz PSdmbV9maWxlX3JlbmFtZSc+PHNwYW4gdGl0bGU9Jyc+TmV3X0ZvbGRlcjwv c3Bhbj48L3A+IiArCiAgICAgICAgICI8c3BhbiBjbGFzcz0nbWV0YSBzaXpl Jz48L3NwYW4+PHNwYW4gY2xhc3M9J21ldGEgY3JlYXRlZCc+PC9zcGFuPjxz cGFuIGNsYXNzPSdtZXRhIG1vZGlmaWVkJz48L3NwYW4+PC9saT4iOwpAQCAt Njg2LDcgKzY4Niw5IEBAIHZhciBnZXRGb2xkZXJJbmZvID0gZnVuY3Rpb24o cGF0aCwgZmlsZV90eXBlKSB7CiAgICAgICBpZiAoIV8uaXNFbXB0eShkYXRh KSkgewogICAgICAgICBpZiAoJCgnLmZpbGVpbmZvJykuZGF0YSgndmlldycp ID09ICdncmlkJykgewogICAgICAgICAgIHJlc3VsdCArPSAnPHVsIGlkPSJj b250ZW50cyIgY2xhc3M9ImdyaWQiPic7Ci0gICAgICAgICAgT2JqZWN0Lmtl eXMoZGF0YSkuZm9yRWFjaChmdW5jdGlvbiAoa2V5KSB7CisgICAgICAgICAg T2JqZWN0LmtleXMoZGF0YSkuc29ydChmdW5jdGlvbiBrZXlPcmRlcih4LCB5 KSB7CisgICAgICAgICAgICAgIHJldHVybiBwZ0FkbWluLm5hdHVyYWxfc29y dCh4LnRvTG93ZXJDYXNlKCksIHkudG9Mb3dlckNhc2UoKSk7CisgICAgICAg ICAgICB9KS5mb3JFYWNoKGZ1bmN0aW9uIChrZXkpIHsKICAgICAgICAgICAg IHZhciBwcm9wcyA9IChkYXRhW2tleV0pLlByb3BlcnRpZXMsCiAgICAgICAg ICAgICAgICAgY2FwX2NsYXNzZXMgPSAiIjsKCkBAIC03NjAsNyArNzYyLDkg QEAgdmFyIGdldEZvbGRlckluZm8gPSBmdW5jdGlvbihwYXRoLCBmaWxlX3R5 cGUpIHsKICAgICAgICAgICByZXN1bHQgKz0gJzxzcGFuPicgKyBsZy5tb2Rp ZmllZCArICc8L3NwYW4+PC90aD48L3RyPjwvdGhlYWQ+JzsKICAgICAgICAg ICByZXN1bHQgKz0gJzx0Ym9keT4nOwoKLSAgICAgICAgICBPYmplY3Qua2V5 cyhkYXRhKS5mb3JFYWNoKGZ1bmN0aW9uIChrZXkpIHsKKyAgICAgICAgICBP YmplY3Qua2V5cyhkYXRhKS5zb3J0KGZ1bmN0aW9uIGtleU9yZGVyKHgsIHkp IHsKKyAgICAgICAgICAgICAgcmV0dXJuIHBnQWRtaW4ubmF0dXJhbF9zb3J0 KHgudG9Mb3dlckNhc2UoKSwgeS50b0xvd2VyQ2FzZSgpKTsKKyAgICAgICAg ICAgIH0pLmZvckVhY2goZnVuY3Rpb24gKGtleSkgewogICAgICAgICAgICAg dmFyIHBhdGggPSBlbmNvZGVVUkkoKGRhdGFba2V5XSkuUGF0aCksCiAgICAg ICAgICAgICAgICAgcHJvcHMgPSAoZGF0YVtrZXldKS5Qcm9wZXJ0aWVzLAog ICAgICAgICAgICAgICAgIGNhcF9jbGFzc2VzID0gIiIsIGNhcCwgY2xhc3Nf dHlwZTsKQEAgLTc4Nyw4ICs3OTEsOCBAQCB2YXIgZ2V0Rm9sZGVySW5mbyA9 IGZ1bmN0aW9uKHBhdGgsIGZpbGVfdHlwZSkgewogICAgICAgICAgICAgcmVz dWx0ICs9ICc8dHIgY2xhc3M9IicgKyBjYXBfY2xhc3NlcyArICciPic7Cgog ICAgICAgICAgICAgdmFyIGZtX2ZpbGVuYW1lID0gKGRhdGFba2V5XSkuRmls ZW5hbWU7Ci0gICAgICAgICAgICBpZiAoZm1fZmlsZW5hbWUubGVuZ3RoID4g MTUgKSB7Ci0gICAgICAgICAgICAgIGZtX2ZpbGVuYW1lID0gKGRhdGFba2V5 XSkuRmlsZW5hbWUuc3Vic3RyKDAsIDEwKSArJy4uLic7CisgICAgICAgICAg ICBpZiAoZm1fZmlsZW5hbWUubGVuZ3RoID4gNDgpIHsKKyAgICAgICAgICAg ICAgZm1fZmlsZW5hbWUgPSAoZGF0YVtrZXldKS5GaWxlbmFtZS5zdWJzdHIo MCwgNDgpICsnLi4uJzsKICAgICAgICAgICAgIH0KCiAgICAgICAgICAgICBy ZXN1bHQgKz0gJzx0ZCB0aXRsZT0iJyArIHBhdGggKyAnIiBjbGFzcz0iJytj bGFzc190eXBlKyciPic7Cg== --089e012282b6741abe053f0a94f5 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --089e012282b6741abe053f0a94f5--