Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkToK-0004xC-TY for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 10:22:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkToK-0002YQ-EP for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 10:22:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkTo6-0002K7-Bd for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 10:22:14 +0000 Received: from mail-it0-x229.google.com ([2607:f8b0:4001:c0b::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkTnz-0007Qy-8O for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 10:22:13 +0000 Received: by mail-it0-x229.google.com with SMTP id n143so67786849ita.1 for ; Thu, 15 Sep 2016 03:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=TyqI3X+/DwmOcnINjK3jz468r5vzkRGgKA10TdFTdeg=; b=j7F18B61wpN1GK+C28nKXUnjRG5eRHObJGiBa+plHSBRzO0vFFm++vDBGMRPsFMEFG Ui7aqUJ93x06c7IMujnILSrkxFvCRf5J+LW93MJVTti3f38C8HPW3VH3d5KfyB7/i94+ hRaFD5mGNu3PnUPk9XDvRfWBnqD3VRRVZykL7gnDT9P4M+IphvKpVLBdI9NmSDBgLjwP M+7PVoDt+qpJ5lknsPsO5OlIJ9oZwKKDChnMHwTb+PQnkeZbtgV6BxWyNdLaEZBQTuHP 6t61Vm/ACmUonCVq/N0G9Za2+Ze6OOTyK/ySsBhuB5AMhhTEFY0kYjVt9axdORLB7YGR BPxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TyqI3X+/DwmOcnINjK3jz468r5vzkRGgKA10TdFTdeg=; b=V03IURqLxDeSwr58OAbf9E9Ac+cwvT/+vs3+t7NOTQN/PXLGlpra9kzdaZLuAZL85I TlnO90A6SlVmOeTakNqL3PWDNoqXxwS+w3KA/kET3rUbdtOy5s9SupYjtiQNZizvNgbY pO2nXl8ML9WP9hcWovyqT2l5rL3ncD71f32kKiVpGZzhjxdtA6Hcg/4IIrBIZ/GduRfU yOVPzeC4VInxbGBSNDhdIq4+8BeUNqx9n2yEdaR69ZtpI61hK46glqS/svIJY+UqKF4P kZBH5gAntNiCL4O/yL9fZycnkJ5L5JBy9q14Kn1ZVHbDHzU331rxjMq76Ab6OvaXM/zE UkQg== X-Gm-Message-State: AE9vXwMku9jrjn9joqXoJfFLTAWqfPqDXzAQsGhcxeI4TZqDAGK5OJW9L8CB7iD9qOKK0rde5ZJdlGjjQhAPjFNZ X-Received: by 10.107.142.143 with SMTP id q137mr17651729iod.67.1473934925179; Thu, 15 Sep 2016 03:22:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.51.83 with HTTP; Thu, 15 Sep 2016 03:21:34 -0700 (PDT) From: Surinder Kumar Date: Thu, 15 Sep 2016 15:51:34 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM1669 - Cannot remove nor change length definition on column in "The Table Dialog" To: pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c05a54ea4fecf053c893722 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c05a54ea4fecf053c893722 Content-Type: multipart/alternative; boundary=94eb2c05a54ea4fecb053c893720 --94eb2c05a54ea4fecb053c893720 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Please find attached patch. > Add proper check for the column length and precision in Jinja template. =E2=80=8BPlease review. Thanks, Surinder Kumar=E2=80=8B --94eb2c05a54ea4fecb053c893720 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Please find attached patc= h.
Add proper check for the column length and precisi= on in Jinja template.

=E2=80=8BPlease review.


Thanks,
Surinder Kumar=E2=80=8B
--94eb2c05a54ea4fecb053c893720-- --94eb2c05a54ea4fecf053c893722 Content-Type: application/octet-stream; name="RM1669.patch" Content-Disposition: attachment; filename="RM1669.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it46mdm90 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMv Y29sdW1uL3NxbC85LjFfcGx1cy91cGRhdGUuc3FsIGIvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvdGFibGVzL3RlbXBsYXRlcy9jb2x1bW4vc3FsLzkuMV9wbHVzL3VwZGF0 ZS5zcWwKaW5kZXggNDU0Zjk2NC4uODBmNzM2YSAxMDA2NDQKLS0tIGEvd2Vi L3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJh c2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy9jb2x1bW4vc3FsLzkuMV9w bHVzL3VwZGF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2 ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3Rl bXBsYXRlcy9jb2x1bW4vc3FsLzkuMV9wbHVzL3VwZGF0ZS5zcWwKQEAgLTgs MTMgKzgsMTIgQEAgQUxURVIgVEFCTEUge3tjb25ufHF0SWRlbnQoZGF0YS5z Y2hlbWEsIGRhdGEudGFibGUpfX0KCiB7JSBlbmRpZiAlfQogeyMjIyAgQWx0 ZXIgY29sdW1uIHR5cGUgYW5kIGNvbGxhdGlvbiAjIyN9Ci17JSBpZiAoZGF0 YS5jbHR5cGUgYW5kIGRhdGEuY2x0eXBlICE9IG9fZGF0YS5jbHR5cGUpIG9y IChkYXRhLmF0dGxlbiBhbmQgZGF0YS5hdHRsZW4gIT0gb19kYXRhLmF0dGxl bikgb3IgKGRhdGEuYXR0cHJlY2lzaW9uIGFuZCBkYXRhLmF0dHByZWNpc2lv biAhPSBvX2RhdGEuYXR0cHJlY2lzaW9uKSAlfQoreyUgaWYgKGRhdGEuY2x0 eXBlIGFuZCBkYXRhLmNsdHlwZSAhPSBvX2RhdGEuY2x0eXBlKSBvciAoZGF0 YS5hdHRsZW4gYW5kIGRhdGEuYXR0bGVuICE9IG9fZGF0YS5hdHRsZW4pIG9y IChkYXRhLmF0dHByZWNpc2lvbiBvciBkYXRhLmF0dHByZWNpc2lvbiAhPSBv X2RhdGEuYXR0cHJlY2lzaW9uKSAlfQogQUxURVIgVEFCTEUge3tjb25ufHF0 SWRlbnQoZGF0YS5zY2hlbWEsIGRhdGEudGFibGUpfX0KICAgICBBTFRFUiBD T0xVTU4geyUgaWYgZGF0YS5uYW1lICV9e3tjb25ufHF0VHlwZUlkZW50KGRh dGEubmFtZSl9fXslIGVsc2UgJX17e2Nvbm58cXRUeXBlSWRlbnQob19kYXRh Lm5hbWUpfX17JSBlbmRpZiAlfSBUWVBFIHslIGlmIGRhdGEuY2x0eXBlICV9 e3tjb25ufHF0VHlwZUlkZW50KGRhdGEuY2x0eXBlKX19IHslIGVsc2UgJX17 e2Nvbm58cXRUeXBlSWRlbnQob19kYXRhLmNsdHlwZSl9fSB7JSBlbmRpZiAl fQoteyUgaWYgZGF0YS5hdHRsZW4gJX0oe3tkYXRhLmF0dGxlbn19eyUgZWxp ZiBub3QgZGF0YS5jbHR5cGUgJX0oe3tvX2RhdGEuYXR0bGVufX17JSBlbmRp ZiAlfXslIGlmIGRhdGEuYXR0cHJlY2lzaW9uJX0sIHt7ZGF0YS5hdHRwcmVj aXNpb259fSl7JSBlbGlmIG5vdCBkYXRhLmNsdHlwZSAlfSwge3tvX2RhdGEu YXR0cHJlY2lzaW9ufX0peyUgZWxpZiBkYXRhLmF0dGxlbiAlfSl7JSBlbmRp ZiAlfXslIGlmIGRhdGEuaGFzU3FyQnJhY2tldCAlfQoreyUgaWYgZGF0YS5h dHRsZW4gYW5kIGRhdGEuYXR0bGVuICE9ICdOb25lJyAlfSh7e2RhdGEuYXR0 bGVufX17JSBpZiBkYXRhLmF0dGxlbiAhPSAnTm9uZScgYW5kIGRhdGEuYXR0 cHJlY2lzaW9uICV9LCB7e2RhdGEuYXR0cHJlY2lzaW9ufX0peyUgZWxpZiAo ZGF0YS5jbHR5cGUgaXMgZGVmaW5lZCBhbmQgbm90IGRhdGEuY2x0eXBlKSAl fSwge3tvX2RhdGEuYXR0cHJlY2lzaW9ufX0peyUgZWxpZiBkYXRhLmF0dGxl biAlfSl7JSBlbmRpZiAlfXslIGVuZGlmICV9eyUgaWYgZGF0YS5oYXNTcXJC cmFja2V0ICV9CiBbXXslIGVuZGlmICV9eyUgaWYgZGF0YS5jb2xsc3BjbmFt ZSBhbmQgZGF0YS5jb2xsc3BjbmFtZSAhPSBvX2RhdGEuY29sbHNwY25hbWUg JX0KICBDT0xMQVRFIHt7ZGF0YS5jb2xsc3BjbmFtZX19eyUgZW5kaWYgJX07 Ci0KIHslIGVuZGlmICV9CiB7IyMjICBBbHRlciBjb2x1bW4gZGVmYXVsdCB2 YWx1ZSAjIyN9CiB7JSBpZiBkYXRhLmRlZnZhbCBhbmQgZGF0YS5kZWZ2YWwg IT0gb19kYXRhLmRlZnZhbCAlfQpAQCAtMTQ1LDQgKzE0NCw0IEBAIEFMVEVS IFRBQkxFIHt7Y29ubnxxdElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLnRhYmxl KX19CiB7JSBlbmRmb3IgJX0KIHslIGVuZGlmICV9CgoteyUgZW5kaWYgJX0K XCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit7JSBlbmRpZiAlfQpkaWZm IC0tZ2l0IGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3Nl cnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy9jb2x1 bW4vc3FsLzkuMl9wbHVzL3VwZGF0ZS5zcWwgYi93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvdGVtcGxhdGVzL2NvbHVtbi9zcWwvOS4yX3BsdXMvdXBkYXRlLnNx bAppbmRleCA3N2VmOGVhLi4wZmU4ZmRmIDEwMDY0NAotLS0gYS93ZWIvcGdh ZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMv c2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL2NvbHVtbi9zcWwvOS4yX3BsdXMv dXBkYXRlLnNxbAorKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxh dGVzL2NvbHVtbi9zcWwvOS4yX3BsdXMvdXBkYXRlLnNxbApAQCAtOCwxMCAr OCwxMCBAQCBBTFRFUiBUQUJMRSB7e2Nvbm58cXRJZGVudChkYXRhLnNjaGVt YSwgZGF0YS50YWJsZSl9fQoKIHslIGVuZGlmICV9CiB7IyMjICBBbHRlciBj b2x1bW4gdHlwZSBhbmQgY29sbGF0aW9uICMjI30KLXslIGlmIChkYXRhLmNs dHlwZSBhbmQgZGF0YS5jbHR5cGUgIT0gb19kYXRhLmNsdHlwZSkgb3IgKGRh dGEuYXR0bGVuIGFuZCBkYXRhLmF0dGxlbiAhPSBvX2RhdGEuYXR0bGVuKSBv ciAoZGF0YS5hdHRwcmVjaXNpb24gYW5kIGRhdGEuYXR0cHJlY2lzaW9uICE9 IG9fZGF0YS5hdHRwcmVjaXNpb24pICV9Cit7JSBpZiAoZGF0YS5jbHR5cGUg YW5kIGRhdGEuY2x0eXBlICE9IG9fZGF0YS5jbHR5cGUpIG9yIChkYXRhLmF0 dGxlbiBhbmQgZGF0YS5hdHRsZW4gIT0gb19kYXRhLmF0dGxlbikgb3IgKGRh dGEuYXR0cHJlY2lzaW9uIG9yIGRhdGEuYXR0cHJlY2lzaW9uICE9IG9fZGF0 YS5hdHRwcmVjaXNpb24pICV9CiBBTFRFUiBUQUJMRSB7e2Nvbm58cXRJZGVu dChkYXRhLnNjaGVtYSwgZGF0YS50YWJsZSl9fQogICAgIEFMVEVSIENPTFVN TiB7JSBpZiBkYXRhLm5hbWUgJX17e2Nvbm58cXRUeXBlSWRlbnQoZGF0YS5u YW1lKX19eyUgZWxzZSAlfXt7Y29ubnxxdFR5cGVJZGVudChvX2RhdGEubmFt ZSl9fXslIGVuZGlmICV9IFRZUEUgeyUgaWYgZGF0YS5jbHR5cGUgJX17e2Nv bm58cXRUeXBlSWRlbnQoZGF0YS5jbHR5cGUpfX0geyUgZWxzZSAlfXt7Y29u bnxxdFR5cGVJZGVudChvX2RhdGEuY2x0eXBlKX19IHslIGVuZGlmICV9Ci17 JSBpZiBkYXRhLmF0dGxlbiAlfSh7e2RhdGEuYXR0bGVufX17JSBlbGlmIG5v dCBkYXRhLmNsdHlwZSAlfSh7e29fZGF0YS5hdHRsZW59fXslIGVuZGlmICV9 eyUgaWYgZGF0YS5hdHRwcmVjaXNpb24lfSwge3tkYXRhLmF0dHByZWNpc2lv bn19KXslIGVsaWYgbm90IGRhdGEuY2x0eXBlICV9LCB7e29fZGF0YS5hdHRw cmVjaXNpb259fSl7JSBlbGlmIGRhdGEuYXR0bGVuICV9KXslIGVuZGlmICV9 eyUgaWYgZGF0YS5oYXNTcXJCcmFja2V0ICV9Cit7JSBpZiBkYXRhLmF0dGxl biBhbmQgZGF0YS5hdHRsZW4gIT0gJ05vbmUnICV9KHt7ZGF0YS5hdHRsZW59 fXslIGlmIGRhdGEuYXR0bGVuICE9ICdOb25lJyBhbmQgZGF0YS5hdHRwcmVj aXNpb24gJX0sIHt7ZGF0YS5hdHRwcmVjaXNpb259fSl7JSBlbGlmIChkYXRh LmNsdHlwZSBpcyBkZWZpbmVkIGFuZCBub3QgZGF0YS5jbHR5cGUpICV9LCB7 e29fZGF0YS5hdHRwcmVjaXNpb259fSl7JSBlbGlmIGRhdGEuYXR0bGVuICV9 KXslIGVuZGlmICV9eyUgZW5kaWYgJX17JSBpZiBkYXRhLmhhc1NxckJyYWNr ZXQgJX0KIFtdeyUgZW5kaWYgJX17JSBpZiBkYXRhLmNvbGxzcGNuYW1lIGFu ZCBkYXRhLmNvbGxzcGNuYW1lICE9IG9fZGF0YS5jb2xsc3BjbmFtZSAlfQog IENPTExBVEUge3tkYXRhLmNvbGxzcGNuYW1lfX17JSBlbmRpZiAlfTsKIHsl IGVuZGlmICV9CkBAIC0xNDIsNCArMTQyLDQgQEAgQUxURVIgVEFCTEUge3tj b25ufHF0SWRlbnQoZGF0YS5zY2hlbWEsIGRhdGEudGFibGUpfX0KIHslIGVu ZGlmICV9CiB7JSBlbmRmb3IgJX0KIHslIGVuZGlmICV9Ci17JSBlbmRpZiAl fQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKK3slIGVuZGlmICV9Cg== --94eb2c05a54ea4fecf053c893722 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c05a54ea4fecf053c893722--