Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxbyI-0003RT-UL for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:43:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bxbyI-00063q-HJ for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 15:43:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bxby5-0005pg-CT for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:42:49 +0000 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bxby1-0002KG-IL for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 15:42:48 +0000 Received: by mail-lf0-x22e.google.com with SMTP id b75so148287576lfg.3 for ; Fri, 21 Oct 2016 08:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XLel6HfVtUAzTOWCcF7bQnIXsITGSMyVILkxMLyoOFQ=; b=t3krJBkRB/ogBrLfr2HxpRWM8H1dvvA/5JUt7VPPUYzd1nian8AoIj7+ARQa5jtMwR Z7ATxOiGsm/OLlBD3XGNhYtjp1WIHmdqC2gSHokdQZqqcmTE7AbBSWElm+wFQBaIXyPx kBHoXq4WjU7GKqNfmd9C3eOgknzIPFFHhi/Tky6g3562l23RjiM1bNZ2nNPoIcmz6oKc fHEh6eMFFO8ISpiyCtwA2qY38We63pwDHvDeHS7XXm9pCe2HjlQkVeQTlOs9xBMjB9fC DrkXzAWURsHmTv6ARcZ66t/szHDLLiJ5z4Cc7vs4YpEP9qGA5T+WzsFApGDryK+8E3xN vybA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XLel6HfVtUAzTOWCcF7bQnIXsITGSMyVILkxMLyoOFQ=; b=NRPWt1mLLxotvj4mKr34RIq3Sx/jZKhy3kOIa8r+l0TgSgRWCj4Do18EEaufEul+3D Ennju6eh+xwmS0D4TrqwJpkzfUF3ZNn+/s0mU3uD4LVNgWAvb15igrApZ1sA0SU9h1uc cRXCCHXo7EfKnyNolzWOrTEyEsVkFsfse3CabINfOvEA8yBAKV3Qw/RT05lEYnDvCJ9j n9VQteY8mYZX2ovaap3a6AhZxKZSQoqfNdBuFUKqWRoo0jR4tFrYdYIREvTUJXfHGvuq PpUPlg4uDP6pfiayyukjJfrJDLJ3IvnGXj7BYNuCNTxp5elqEnrivWkJYVx1Zf6ibsOu n8GQ== X-Gm-Message-State: ABUngvekEgJxqckuzRC5FJ2eQ53n5h0azpiAjFxfK8bEPgy3WFEAvAVdYXuTbN0/ZxjRfFQ0nzJZ91qSn6J0Ihrj X-Received: by 10.194.20.231 with SMTP id q7mr1287302wje.57.1477064564714; Fri, 21 Oct 2016 08:42:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 21 Oct 2016 08:42:14 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Fri, 21 Oct 2016 21:12:14 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7b451208b0bba4053f61e43c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b451208b0bba4053f61e43c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: > Hi > > On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar > wrote: > > Hi > > > > This fix is for exclusion constraint. > > The options like "order" and "nulls" must be conditional. i.e. include > only > > when access method type is other than "gist". > > When creating an index, the asc/desc options are disabled if gist/gin > used. I think they also should be here. > > Also, what about gin indexes in this case? > =E2=80=8BAs per documentation , =E2=80=8B *The access method must support amgettuple (see Chapter 52 ); at present this means GIN cannot be used* > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --047d7b451208b0bba4053f61e43c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Fri, Oct 21, 2016 at 8:52 PM= , Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi
>
> This fix is for exclusion constraint.
> The options like "order" and "nulls" must be condi= tional. i.e. include only
> when access method type is other than "gist".

When creating an index, the asc/desc options are disabled if gist/gi= n
used. I think they also should be here.

Also, what about gin indexes in this case?
=E2=80=8BAs per documentation, =E2=80=8B
= The access method must support=C2=A0amgettuple=C2=A0(see=C2= =A0Chapter 52); at present this means=C2=A0GIN=C2=A0cannot be used=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--047d7b451208b0bba4053f61e43c--