Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsPuT-0004j3-E1 for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 07:49:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bsPuS-0001iS-Cj for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 07:49:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsPuE-0001UC-Qu for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 07:49:22 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bsPu7-0000hd-8e for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 07:49:21 +0000 Received: by mail-wm0-x22a.google.com with SMTP id k125so16379672wma.1 for ; Fri, 07 Oct 2016 00:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=faRNlJvDtjZmI+enf+LaKlW4v8+1dT4kxsT/o1R1wNk=; b=J8AgyqVnAn077CluFzszKF+ODCh6NJ3tg06Kqx8AH0M9iAyx37vgdQjcAGQzE+TwKr r/rTi0F53R736t7/68PAqmJPnwhUKjq1w9+1qTXpE2dYttm0caZSfOzaioJYd3EDoUMY eyfOatEt7GuinedWPWbc/QqTTfzbNYIgb9v3WAdH1eUmajq4AFFW8UFA8glFwOKB0r7N W6sB1rgAb9VW/fqEZXIsWbByD7zshIuRJdZvIOqEScOO4i44X7qsr4josjSYT88WVHWc nHjEZBZVtdGltd6WkZTfem6NyweryyOXw7hUiBwyiRvVKnoEmfb5O5YzV62gAE0SmhZE AoUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=faRNlJvDtjZmI+enf+LaKlW4v8+1dT4kxsT/o1R1wNk=; b=T34VVRSGGrwqf+8qiI09m/AHQjlpboDph6fc89lW4gN4mdoVR4nnPqmuaNWl+FLRIG 1A4hZFUZzS+TrprNXeji6GVCR0Gv2iqF0fbTvubduTGMXCGhxyyQ6dJ0BcRImMPKK2RB /bKsVZ0PiZQIPVwGHg2Snf8aoUPichgNzA2gAda2lKkZj0FpIl2oCoaQaUBv6Sju0eF/ MJslLvwtJbPspQdMbUdnnndVYxzhnyldpLRASym1ePFX3IXLTaZHos1CffYNYDsg2mq2 WZ06eRbRaj6Cjq4ztBEaamlFlaI/mkYeInjxZaIxB0y3NuhoKDV+PQfnDzoMoeXOp36o 4LmQ== X-Gm-Message-State: AA6/9Rnl5OpvSEmML0lkHoBOxmr4PTmsTfGzbs+T7uzl0Y7iS/0eXDMje9tX7KMhG3ZcIa478aY42vPNtZ/juYXk X-Received: by 10.194.103.138 with SMTP id fw10mr15168448wjb.93.1475826552224; Fri, 07 Oct 2016 00:49:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 7 Oct 2016 00:48:41 -0700 (PDT) From: Surinder Kumar Date: Fri, 7 Oct 2016 13:18:41 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Listing of files/folders not sorted alphabetically in Storage Manager To: pgadmin-hackers Content-Type: multipart/mixed; boundary=089e010d84a665b8ac053e41a59e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e010d84a665b8ac053e41a59e Content-Type: multipart/alternative; boundary=089e010d84a665b8a7053e41a59c --089e010d84a665b8a7053e41a59c Content-Type: text/plain; charset=UTF-8 Hi, *Issues fixed:* 1) Listing of files/folders not sorted alphabetically. 2) Some file names are truncated despite the fact that there is plenty of room to be displayed. *Not Fixed:* In Table mode, clicking on Name bar makes no difference. As discussed with Ashesh we are not implementing it now. It requires a lot of changes with current implementation. Please find attached patch and review. Thanks, Surinder Kumar --089e010d84a665b8a7053e41a59c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,=

Issues fixed:<= /u>
1) Listing = of files/folders not sorted alphabetically.
2)=C2=A0Some file names are truncated despite the fact that there is plenty = of room to be displayed.

Not Fixed:<= /span>
In Table mode, clicking on Name bar ma= kes no difference.
As discussed with Ashesh we are not implementing it now. It requires a lot= of changes with current implementation.

Please find attached patch and review.
=
Thanks,
Surinder Kumar
--089e010d84a665b8a7053e41a59c-- --089e010d84a665b8ac053e41a59e Content-Type: application/octet-stream; name="RM1792.patch" Content-Disposition: attachment; filename="RM1792.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itzgxi3q0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL19f aW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvX19p bml0X18ucHkKaW5kZXggZTI2MjIwOC4uYzUyYTViYSAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvX19pbml0X18ucHkKKysr IGIvd2ViL3BnYWRtaW4vbWlzYy9maWxlX21hbmFnZXIvX19pbml0X18ucHkK QEAgLTQ0MSw3ICs0NDEsMTIgQEAgY2xhc3MgRmlsZW1hbmFnZXIob2JqZWN0 KToKIAogICAgICAgICBvcmlnX3BhdGggPSB1bnF1b3RlKG9yaWdfcGF0aCkK ICAgICAgICAgdHJ5OgotICAgICAgICAgICAgZm9yIGYgaW4gc29ydGVkKG9z Lmxpc3RkaXIob3JpZ19wYXRoKSk6CisgICAgICAgICAgICBkZWYgY3VzdG9t X3NvcnQoeCwgeSk6CisgICAgICAgICAgICAgICAgcmV0dXJuIHkubG93ZXIo KSA+IHgubG93ZXIoKQorCisgICAgICAgICAgICBteWxpc3QgPSBbeCBmb3Ig eCBpbiBzb3J0ZWQob3MubGlzdGRpcihvcmlnX3BhdGgpLAorICAgICAgICAg ICAgICAgICAgICAgIGNtcD1jdXN0b21fc29ydCldCisgICAgICAgICAgICBm b3IgZiBpbiBteWxpc3Q6CiAgICAgICAgICAgICAgICAgcHJvdGVjdGVkID0g MAogICAgICAgICAgICAgICAgIHN5c3RlbV9wYXRoID0gb3MucGF0aC5qb2lu KG9zLnBhdGguam9pbihvcmlnX3BhdGgsIGYpKQogCmRpZmYgLS1naXQgYS93 ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci90ZW1wbGF0ZXMvZmlsZV9t YW5hZ2VyL2pzL3V0aWxpdHkuanMgYi93ZWIvcGdhZG1pbi9taXNjL2ZpbGVf bWFuYWdlci90ZW1wbGF0ZXMvZmlsZV9tYW5hZ2VyL2pzL3V0aWxpdHkuanMK aW5kZXggOGQ4OTFmZC4uM2FjZDJmZiAxMDA3NTUKLS0tIGEvd2ViL3BnYWRt aW4vbWlzYy9maWxlX21hbmFnZXIvdGVtcGxhdGVzL2ZpbGVfbWFuYWdlci9q cy91dGlsaXR5LmpzCisrKyBiL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5h Z2VyL3RlbXBsYXRlcy9maWxlX21hbmFnZXIvanMvdXRpbGl0eS5qcwpAQCAt MjM2LDcgKzIzNiw3IEBAIHZhciBzZXRVcGxvYWRlciA9IGZ1bmN0aW9uKHBh dGgpIHsKIAogICAgICAgLy8gdGVtcGxhdGUgZm9yIGNyZWF0aW5nIG5ldyBm b2xkZXIKICAgICAgIGZvbGRlcl9kaXYgPQotICAgICAgICAiPGxpIGNsYXNz PSdjYXBfZG93bmxvYWRjYXBfZGVsZXRlY2FwX3NlbGVjdF9maWxlY2FwX3Nl bGVjdF9mb2xkZXJjYXBfcmVuYW1lY2FwX2NyZWF0ZWNhcF91cGxvYWQnPiIg KworICAgICAgICAiPGxpIGNsYXNzPSdjYXBfZG93bmxvYWQgY2FwX2RlbGV0 ZSBjYXBfc2VsZWN0X2ZpbGUgY2FwX3NlbGVjdF9mb2xkZXIgY2FwX3JlbmFt ZSBjYXBfY3JlYXRlIGNhcF91cGxvYWQnPiIgKwogICAgICAgICAiPGRpdiBj bGFzcz0nY2xpcCc+PHNwYW4gZGF0YS1hbHQ9JycgY2xhc3M9J2ZhIGZhLWZv bGRlci1vcGVuIGZtX2ZvbGRlcic+PC9zcGFuPjwvZGl2PiIgKwogICAgICAg ICAiPHA+PGlucHV0IHR5cGU9J3RleHQnIGNsYXNzPSdmbV9maWxlX3JlbmFt ZSc+PHNwYW4gdGl0bGU9Jyc+TmV3X0ZvbGRlcjwvc3Bhbj48L3A+IiArCiAg ICAgICAgICI8c3BhbiBjbGFzcz0nbWV0YSBzaXplJz48L3NwYW4+PHNwYW4g Y2xhc3M9J21ldGEgY3JlYXRlZCc+PC9zcGFuPjxzcGFuIGNsYXNzPSdtZXRh IG1vZGlmaWVkJz48L3NwYW4+PC9saT4iOwpAQCAtNjg2LDcgKzY4Niw5IEBA IHZhciBnZXRGb2xkZXJJbmZvID0gZnVuY3Rpb24ocGF0aCwgZmlsZV90eXBl KSB7CiAgICAgICBpZiAoIV8uaXNFbXB0eShkYXRhKSkgewogICAgICAgICBp ZiAoJCgnLmZpbGVpbmZvJykuZGF0YSgndmlldycpID09ICdncmlkJykgewog ICAgICAgICAgIHJlc3VsdCArPSAnPHVsIGlkPSJjb250ZW50cyIgY2xhc3M9 ImdyaWQiPic7Ci0gICAgICAgICAgT2JqZWN0LmtleXMoZGF0YSkuZm9yRWFj aChmdW5jdGlvbiAoa2V5KSB7CisgICAgICAgICAgT2JqZWN0LmtleXMoZGF0 YSkuc29ydChmdW5jdGlvbiBrZXlPcmRlcih4LCB5KSB7CisgICAgICAgICAg ICAgIHJldHVybiAoeC50b0xvd2VyQ2FzZSgpID4geS50b0xvd2VyQ2FzZSgp KTsKKyAgICAgICAgICAgIH0pLmZvckVhY2goZnVuY3Rpb24gKGtleSkgewog ICAgICAgICAgICAgdmFyIHByb3BzID0gKGRhdGFba2V5XSkuUHJvcGVydGll cywKICAgICAgICAgICAgICAgICBjYXBfY2xhc3NlcyA9ICIiOwogCkBAIC03 NjAsNyArNzYyLDkgQEAgdmFyIGdldEZvbGRlckluZm8gPSBmdW5jdGlvbihw YXRoLCBmaWxlX3R5cGUpIHsKICAgICAgICAgICByZXN1bHQgKz0gJzxzcGFu PicgKyBsZy5tb2RpZmllZCArICc8L3NwYW4+PC90aD48L3RyPjwvdGhlYWQ+ JzsKICAgICAgICAgICByZXN1bHQgKz0gJzx0Ym9keT4nOwogCi0gICAgICAg ICAgT2JqZWN0LmtleXMoZGF0YSkuZm9yRWFjaChmdW5jdGlvbiAoa2V5KSB7 CisgICAgICAgICAgT2JqZWN0LmtleXMoZGF0YSkuc29ydChmdW5jdGlvbiBr ZXlPcmRlcih4LCB5KSB7CisgICAgICAgICAgICAgIHJldHVybiAoeC50b0xv d2VyQ2FzZSgpID4geS50b0xvd2VyQ2FzZSgpKTsKKyAgICAgICAgICAgIH0p LmZvckVhY2goZnVuY3Rpb24gKGtleSkgewogICAgICAgICAgICAgdmFyIHBh dGggPSBlbmNvZGVVUkkoKGRhdGFba2V5XSkuUGF0aCksCiAgICAgICAgICAg ICAgICAgcHJvcHMgPSAoZGF0YVtrZXldKS5Qcm9wZXJ0aWVzLAogICAgICAg ICAgICAgICAgIGNhcF9jbGFzc2VzID0gIiIsIGNhcCwgY2xhc3NfdHlwZTsK QEAgLTc4Nyw4ICs3OTEsOCBAQCB2YXIgZ2V0Rm9sZGVySW5mbyA9IGZ1bmN0 aW9uKHBhdGgsIGZpbGVfdHlwZSkgewogICAgICAgICAgICAgcmVzdWx0ICs9 ICc8dHIgY2xhc3M9IicgKyBjYXBfY2xhc3NlcyArICciPic7CiAKICAgICAg ICAgICAgIHZhciBmbV9maWxlbmFtZSA9IChkYXRhW2tleV0pLkZpbGVuYW1l OwotICAgICAgICAgICAgaWYgKGZtX2ZpbGVuYW1lLmxlbmd0aCA+IDE1ICkg ewotICAgICAgICAgICAgICBmbV9maWxlbmFtZSA9IChkYXRhW2tleV0pLkZp bGVuYW1lLnN1YnN0cigwLCAxMCkgKycuLi4nOworICAgICAgICAgICAgaWYg KGZtX2ZpbGVuYW1lLmxlbmd0aCA+IDQ4KSB7CisgICAgICAgICAgICAgIGZt X2ZpbGVuYW1lID0gKGRhdGFba2V5XSkuRmlsZW5hbWUuc3Vic3RyKDAsIDQ4 KSArJy4uLic7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIHJlc3Vs dCArPSAnPHRkIHRpdGxlPSInICsgcGF0aCArICciIGNsYXNzPSInK2NsYXNz X3R5cGUrJyI+JzsK --089e010d84a665b8ac053e41a59e Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --089e010d84a665b8ac053e41a59e--