Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avm3f-0003mM-N8 for pgadmin-hackers@arkaria.postgresql.org; Thu, 28 Apr 2016 13:32:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1avm3f-0003Qa-9n for pgadmin-hackers@arkaria.postgresql.org; Thu, 28 Apr 2016 13:32:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1avm3e-0003QT-Sz for pgadmin-hackers@postgresql.org; Thu, 28 Apr 2016 13:32:42 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1avm3a-0001Us-Rf for pgadmin-hackers@postgresql.org; Thu, 28 Apr 2016 13:32:42 +0000 Received: by mail-wm0-x230.google.com with SMTP id g17so41720439wme.1 for ; Thu, 28 Apr 2016 06:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=l1tYm4hcF3B1O/D8fPdVmWTm1vwV+2WHJz/MaKsUjAA=; b=O+6H5toojFjfY6LJ+CwaXlU2nAEdQm3oG6DIVoEf9HoL7MhXHMLStCmZKIE5JzY+7K cklOo745K/onGkBPnd8ebxdGUmfW4QZsVXEpH7nK14sgFxoyzi9Rad/spdas1qNAq4Cd oD5p6y0LhCWEO/mIDLUCLyd/+enY0kX9VmHKWbYxbaQVViBlmLG/DVazhuN9Yi9mwVf6 ZL5vx3JHbQvy/m6fDpKdofEhNTdD5EK9cSTUXZs5Gbr6hfWFQOh6vt2i2htWmhlnJwGE QG1oTQ3bJgiBPXYv2NhcvDn/J2oQgqcS2bg5qIbqcTeaChCS9T0YPRljUcKhsufucm8D C8jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=l1tYm4hcF3B1O/D8fPdVmWTm1vwV+2WHJz/MaKsUjAA=; b=YMwk9nOpkkkQlD+vDysmlh4XaU7XPOfCNB9oEc3AfWiGcP7wLXkDueQmOHxoKFsos4 lNfC0xCNULlCtg5MoRtmiM3fiEjGQCk5PgKszvaqvCniK/UKj+Zv95yU0YfUJfZui7Ch bcMxCMwn8iTuRFe3dkXkBENs09slnbArOnCBqOnBXwRiGLiL8oLIV9X10P3uJ2VBVME+ SGNkN2qlzTEZTxYezzLYCY/IF5Ftw001IWq/3nJzvn0/c3QdyI001QSQzoqJo5ucNuVv JpYWskeY9WbJprQnQxDF1vQwe9k9PbPMf9CTvEhSNE5N3cMItYFVgJghRZYNubcVVKd0 0PSw== X-Gm-Message-State: AOPr4FWF5SiKTwNv90WNsY7urOGJdnTa/B0ZmdH8+1fmPKWpsXlPoYsfojT+EBKcaEzgXh3oLboz+jsuXri03N0F X-Received: by 10.28.0.87 with SMTP id 84mr29967691wma.68.1461850357014; Thu, 28 Apr 2016 06:32:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.53.133 with HTTP; Thu, 28 Apr 2016 06:32:07 -0700 (PDT) From: Surinder Kumar Date: Thu, 28 Apr 2016 19:02:07 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113c9f6e3ee9bc05318b8ff6 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113c9f6e3ee9bc05318b8ff6 Content-Type: multipart/alternative; boundary=001a113c9f6e3ee9b905318b8ff4 --001a113c9f6e3ee9b905318b8ff4 Content-Type: text/plain; charset=UTF-8 Hi, The *SqlFieldControl* is setting default height for textarea, which is not needed. It should expand as needed as similar in *SqlTabControl*. Please find the attached patch, review it. Thanks Surinder Kumar --001a113c9f6e3ee9b905318b8ff4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

The=C2=A0SqlFieldControl is = setting default height for textarea, which is not needed.
It shou= ld expand as needed as similar in=C2=A0SqlTabControl.

=
Please find the attached patch, review it.

<= div>Thanks
Surinder Kumar
--001a113c9f6e3ee9b905318b8ff4-- --001a113c9f6e3ee9bc05318b8ff6 Content-Type: application/octet-stream; name="remove_default_height_in_SqlFieldControl.patch" Content-Disposition: attachment; filename="remove_default_height_in_SqlFieldControl.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_inkbwhui0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5w Z2FkbWluLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBn YWRtaW4uanMKaW5kZXggNTQ0ZDU3NC4uZWM3ZWNmNCAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKKysr IGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMK QEAgLTE5MDUsNyArMTkwNSw3IEBACiAKICAgICBkZWZhdWx0czogewogICAg ICAgbGFiZWw6ICIiLAotICAgICAgZXh0cmFDbGFzc2VzOiBbJ3NxbF9maWVs ZF9oZWlnaHRfMzAwJ10sIC8vIEFkZCBkZWZhdWx0IGNvbnRyb2wgaGVpZ2h0 CisgICAgICBleHRyYUNsYXNzZXM6IFtdLCAvLyBBZGQgZGVmYXVsdCBjb250 cm9sIGhlaWdodAogICAgICAgaGVscE1lc3NhZ2U6IG51bGwsCiAgICAgICBt YXhsZW5ndGg6IDQwOTYsCiAgICAgICByb3dzOiB1bmRlZmluZWQK --001a113c9f6e3ee9bc05318b8ff6 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113c9f6e3ee9bc05318b8ff6--