Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKN3Z-0005NT-0Z for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jul 2016 09:54:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bKN3Y-00056e-5n for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jul 2016 09:54:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bKN3W-00056V-N1 for pgadmin-hackers@postgresql.org; Tue, 05 Jul 2016 09:54:14 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bKN3T-0005K0-HM for pgadmin-hackers@postgresql.org; Tue, 05 Jul 2016 09:54:13 +0000 Received: by mail-wm0-x22d.google.com with SMTP id f126so130404290wma.1 for ; Tue, 05 Jul 2016 02:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=sHyc4jPO3jGQ4jTywDKkmrFHgKY6JYsdbVrmDi8eU6E=; b=JW2M21tE1EKo3ZIHFRw2JYmUwxnTAp+9H3zwdY4gcC9efFdQw1MXFjKrDsENoh1VfV 4CWHQckOQT+2D2zqmwwoeqUWRRPN/+66pobg569r92G91Q+5dDigCWQYSXhnYXw4uSKV S8spnUFcfBr9Be6BN0+QY8CiPDiFw5FuaWXhpja5wvzRRhrZkuPY9wA2VUidvrtMc636 K9hoUgvrtMqmuhEvB64j+HHnCvpzG/HZ4hcJ5JQ5ayeA6B9ZBk6tsx5WjvW+RH59du8q xB9ckaDhVxctkadbN8kLsgUh7CyW5pfoorSmcPqeBeqsqybqAnIruth5apwTXEG1q8F1 dcag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sHyc4jPO3jGQ4jTywDKkmrFHgKY6JYsdbVrmDi8eU6E=; b=M8oC0SbxhalM/t724Qebl/b+Gh/8hi1sK2ii47LrQAGegqej6xJWUnNZ/wnlpQp9HR FkemGguQXB2Kz/TQwL1Pyk9SM5wWWOJqhnWaX/g5hW6SgpXnRkoDTAdYei5TVYm4DLE2 vY3Q/HSFy0oOzk96GQookc2ekmYXZQMdSCPFc3MMvO9HytljtzBNDeplhoDihyl+yhgE 1N3ar/TKapKUfJ1n5JxKK/0jGpH7cJOqH+2ue3rPAKK/zdTWtarV5pGwsje9aLPeFkrP Q3JG11CiZ++mfu8wlVooJCVkuewQi6MWau/UJVV4LQlsvRlF2TP+XIk6KlvL//xqAEWx nPSA== X-Gm-Message-State: ALyK8tJWVTuUrowT2wV3owlp8hEvHyWOt8mYTnNZb6MR2GqIufDTF6mF5eLnXIjifSjTJK25CnzvANfMHCfbow6P X-Received: by 10.194.248.230 with SMTP id yp6mr14682397wjc.144.1467712449467; Tue, 05 Jul 2016 02:54:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.24.2 with HTTP; Tue, 5 Jul 2016 02:53:39 -0700 (PDT) From: Surinder Kumar Date: Tue, 5 Jul 2016 15:23:39 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM#1423 - SQL panel should be greyed in Edit Data mode To: pgadmin-hackers Content-Type: multipart/mixed; boundary=089e013d1c642f228e0536e06fab X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e013d1c642f228e0536e06fab Content-Type: multipart/alternative; boundary=089e013d1c642f22890536e06fa9 --089e013d1c642f22890536e06fa9 Content-Type: text/plain; charset=UTF-8 Hi Please find the attached patch with solution: 1. Introduced a new class 'cm_disabled' with css property background-color to '#EEEEE' 2. Query tool in edit mode, add the class 'cm_disabled' to set background color to dark and set the cursor property to 'nocursor' to disable editor. 3. Increased the query tool title padding to fix the issue of whitespace below the title. Please review. Thanks, Surinder Kumar --089e013d1c642f22890536e06fa9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

Please find the attached patch with = solution:
  1. Introduced a new class 'cm_disabled' wi= th css property background-color to '#EEEEE'
  2. Query tool= in edit mode, add the class 'cm_disabled' to set background color = to dark and set the cursor property to 'nocursor' to disable editor= .
  3. Increased the query tool title padding to fix the issue of whites= pace below the title.
Please review.

=
Thanks,
Surinder Kumar
--089e013d1c642f22890536e06fa9-- --089e013d1c642f228e0536e06fab Content-Type: application/octet-stream; name="RM#1423.patch" Content-Disposition: attachment; filename="RM#1423.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iq9a5dq10 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9jc3Mvb3ZlcnJpZGVz LmNzcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9jc3Mvb3ZlcnJpZGVzLmNzcwpp bmRleCBkNGUwOWMwLi4yNTM2ZmUzIDEwMDc1NQotLS0gYS93ZWIvcGdhZG1p bi9zdGF0aWMvY3NzL292ZXJyaWRlcy5jc3MKKysrIGIvd2ViL3BnYWRtaW4v c3RhdGljL2Nzcy9vdmVycmlkZXMuY3NzCkBAIC0xMzU5LDMgKzEzNTksOCBA QCB0YWJsZS5iYWNrZ3JpZCB7CiAuYWNpVHJlZS5hY2lUcmVlTG9hZCB7CiAg IGJhY2tncm91bmQ6IG5vbmU7CiB9CisKKy8qIGNsYXNzIHRvIGRpc2FibGUg Q29kZW1pcnJvciBlZGl0b3IgKi8KKy5jbV9kaXNhYmxlZCB7CisgIGJhY2tn cm91bmQ6ICNFRUVFRUU7Cit9CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90 b29scy9zcWxlZGl0b3Ivc3RhdGljL2Nzcy9zcWxlZGl0b3IuY3NzIGIvd2Vi L3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9jc3Mvc3FsZWRpdG9y LmNzcwppbmRleCBiNTkwNWRhLi45M2M3OTIxIDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi90b29scy9zcWxlZGl0b3Ivc3RhdGljL2Nzcy9zcWxlZGl0b3Iu Y3NzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMv Y3NzL3NxbGVkaXRvci5jc3MKQEAgLTM1LDcgKzM1LDcgQEAKCiAuZWRpdG9y LXRpdGxlIHsKICAgYmFja2dyb3VuZC1jb2xvcjogIzJDNzZCNDsKLSAgcGFk ZGluZzogMnB4OworICBwYWRkaW5nOiA0cHggNXB4OwogICBjb2xvcjogd2hp dGU7CiAgIGZvbnQtc2l6ZTogMTNweDsKIH0KZGlmZiAtLWdpdCBhL3dlYi9w Z2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pz L3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90 ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcwppbmRleCA1YjA4 NjIzLi5iNGM0OGU4IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9z cWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRvci9qcy9zcWxlZGl0b3IuanMK KysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3RlbXBsYXRlcy9z cWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCkBAIC0xMTI0LDcgKzExMjQsMTIg QEAgZGVmaW5lKAogICAgICAgICAgICAgfQogICAgICAgICAgIH0KICAgICAg ICAgICBlbHNlIHsKLSAgICAgICAgICAgIHNlbGYuZ3JpZFZpZXcucXVlcnlf dG9vbF9vYmouc2V0T3B0aW9uKCJyZWFkT25seSIsdHJ1ZSk7CisgICAgICAg ICAgICAvLyBEaXNhYmxlIGNvZGVtaXJyb3IgYnkgc2V0dGluZyBjdXJzb3Ig dG8gbm9jdXJzb3IgYW5kIGJhY2tncm91bmQgdG8gZGFyay4KKyAgICAgICAg ICAgIHNlbGYuZ3JpZFZpZXcucXVlcnlfdG9vbF9vYmouc2V0T3B0aW9uKCJy ZWFkT25seSIsICdub2N1cnNvcicpOworICAgICAgICAgICAgdmFyIGNtID0g c2VsZi5ncmlkVmlldy5xdWVyeV90b29sX29iai5nZXRXcmFwcGVyRWxlbWVu dCgpOworICAgICAgICAgICAgaWYgKGNtKSB7CisgICAgICAgICAgICAgIGNt LmNsYXNzTmFtZSArPSAnIGNtX2Rpc2FibGVkJzsKKyAgICAgICAgICAgIH0K ICAgICAgICAgICAgIHNlbGYuZGlzYWJsZV90b29sX2J1dHRvbnModHJ1ZSk7 CiAgICAgICAgICAgICBzZWxmLl9leGVjdXRlX2RhdGFfcXVlcnkoKTsKICAg ICAgICAgICB9Cg== --089e013d1c642f228e0536e06fab Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --089e013d1c642f228e0536e06fab--