public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server
@ 2016-09-15 12:05 Surinder Kumar <[email protected]>
  2016-09-16 10:12 ` Re: [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server Dave Page <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Surinder Kumar @ 2016-09-15 12:05 UTC (permalink / raw)
  To: pgadmin-hackers

Hi

An extra comma at the end of *function statement* results in Syntax Error
while saving.

Please find attached patch and review.


Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM1600.patch (813B, 3-RM1600.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/9.5_plus/create.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/9.5_plus/create.sql
index 8668990..15eec6b 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/9.5_plus/create.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/9.5_plus/create.sql
@@ -25,7 +25,7 @@ CREATE FUNCTION {{ conn|qtIdent(data.pronamespace, data.name) }}()
 {{ data.probin|qtLiteral }}, {{ data.prosrc_c|qtLiteral }}
 {% else %}
 $BODY$
-{{ data.prosrc }};
+{{ data.prosrc }}
 $BODY${% endif -%};
 {% if data.funcowner %}
 


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server
  2016-09-15 12:05 [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server Surinder Kumar <[email protected]>
@ 2016-09-16 10:12 ` Dave Page <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-09-16 10:12 UTC (permalink / raw)
  To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Thu, Sep 15, 2016 at 1:05 PM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> An extra comma at the end of function statement results in Syntax Error
> while saving.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-09-16 10:12 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 12:05 [pgAdmin4][Patch]: RM1600 - Trigger function is not being created in EPAS 9.6 and PPAS-9.5 server Surinder Kumar <[email protected]>
2016-09-16 10:12 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox