Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9sv4-0007nU-AL for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Nov 2016 12:14:26 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c9sv3-0004Fj-TQ for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Nov 2016 12:14:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c9sup-0003oR-Tf for pgadmin-hackers@postgresql.org; Thu, 24 Nov 2016 12:14:12 +0000 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1c9sul-0007GE-HU for pgadmin-hackers@postgresql.org; Thu, 24 Nov 2016 12:14:11 +0000 Received: by mail-wm0-x236.google.com with SMTP id c184so20890498wmd.0 for ; Thu, 24 Nov 2016 04:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VNOGd5mAIpYLQLinwZwMAwj8gpNk6Nz+fnX6UzspWnI=; b=XwukZboluGvzkBq5aHkKe1aVRalxs8ZSeiyczIqYCPkw2mcVhFexP7Vo5+f9TQ60po S+aYRgd+X2DurcupsT8xkqR564/0FJigO7wDJQ5how/dECE2yQwhV5J54fp1rGFveJ02 ZbqnUuXo4rebes+w3L/+wM+eo0WH/Y4e29hC37B0fO3BIvJVDFtVO8eGiVGbkaM4YYg4 7gKzs3bm7z+dN+tJ8oX56Tcmq72I0SjVy/zxse1BdVAhICywLfGOppAiksrofplnkWHS Idy6F9WthagAVRbmaHTY6RdmE5lz6k0SZdG95aw55S+ESKuo6jqzUdqgxn3MMrZawQMF TzKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VNOGd5mAIpYLQLinwZwMAwj8gpNk6Nz+fnX6UzspWnI=; b=StWpMbGeRHHvPNaERNC9BfaKAyMsNApP4ZVgLqN+W/iSR2smpZwQtT5Zcro8ImPw6m oEJC/uCECSS04GCvfqDGNkYMT59YHrRW1Te9gvsTAbGAFV0f/9vdEDKzXjMDlzCT8f8H MQZYcZM7yT4Pc3ilV2AmlImzGj9oSfG8wgEjuFsFdaW4HHCVIz5xg14g97c9j5+WOEh2 rLtryx6pdKHPntselwsER3I8Vum2ejrEH7FIphidCKIL6Z/XK6oq+exHe9tx+wKN8HqQ qAEI06INqpVO0ytkpnRpbTGu/atoE9AG9Tu93n6kzXQZSHON9Di9F18c9t8Fou9R2SdH j8yg== X-Gm-Message-State: AKaTC00GbN3iuHhSC4NK4vFPIvZpyweZegB6O8FsxdsSZKs51AKPGkBoxLAp6yYLlwRGDBowMc/FLSGYMlmd/4fV X-Received: by 10.28.136.198 with SMTP id k189mr2012559wmd.24.1479989646627; Thu, 24 Nov 2016 04:14:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.142.5 with HTTP; Thu, 24 Nov 2016 04:13:35 -0800 (PST) In-Reply-To: References: From: Surinder Kumar Date: Thu, 24 Nov 2016 17:43:35 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11443a8a28c2af05420af129 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11443a8a28c2af05420af129 Content-Type: multipart/alternative; boundary=001a11443a8a28c2aa05420af127 --001a11443a8a28c2aa05420af127 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Please find updated patch with change. On Fri, Oct 21, 2016 at 9:16 PM, Dave Page wrote: > On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar > wrote: > > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar > >> wrote: > >> > Hi > >> > > >> > This fix is for exclusion constraint. > >> > The options like "order" and "nulls" must be conditional. i.e. inclu= de > >> > only > >> > when access method type is other than "gist". > >> > >> When creating an index, the asc/desc options are disabled if gist/gin > >> used. I think they also should be here. > >> > >> Also, what about gin indexes in this case? > > > > As per documentation, > > The access method must support amgettuple (see Chapter 52); at present > this > > means GIN cannot be used > > OK, but this patch (unlike the last one) only seems to check for gist. > =E2=80=8BI have modified the code so It will check for 'gist' and 'spgist' > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11443a8a28c2aa05420af127 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Please find updated patch= with change.

On Fri, Oct 21, 2016 at 9:16 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Oct 21, 2016 at 4:42= PM, Surinder Kumar
<sur= inder.kumar@enterprisedb.com> wrote:
> On Fri, Oct 21, 2016 at 8:52 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
>> <surinder.ku= mar@enterprisedb.com> wrote:
>> > Hi
>> >
>> > This fix is for exclusion constraint.
>> > The options like "order" and "nulls" must= be conditional. i.e. include
>> > only
>> > when access method type is other than "gist".
>>
>> When creating an index, the asc/desc options are disabled if gist/= gin
>> used. I think they also should be here.
>>
>> Also, what about gin indexes in this case?
>
> As per documentation,
> The access method must support amgettuple (see Chapter 52); at present= this
> means GIN cannot be used

OK, but this patch (unlike the last one) only seems to check for gis= t.
= =E2=80=8BI have modified the code so It will check for 'gist' and &= #39;spgist'

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11443a8a28c2aa05420af127-- --001a11443a8a28c2af05420af129 Content-Type: application/octet-stream; name="RM1840_exclusion_constraint_v2.patch" Content-Disposition: attachment; filename="RM1840_exclusion_constraint_v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ivwblo330 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMv ZXhjbHVzaW9uX2NvbnN0cmFpbnQvc3FsLzkuMV9wbHVzL2NyZWF0ZS5zcWwg Yi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9k YXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL2V4Y2x1c2lvbl9j b25zdHJhaW50L3NxbC85LjFfcGx1cy9jcmVhdGUuc3FsCmluZGV4IGRiMjkw NDguLjkzZjM2NDggMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIv c2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxl cy90ZW1wbGF0ZXMvZXhjbHVzaW9uX2NvbnN0cmFpbnQvc3FsLzkuMV9wbHVz L2NyZWF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJf Z3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBs YXRlcy9leGNsdXNpb25fY29uc3RyYWludC9zcWwvOS4xX3BsdXMvY3JlYXRl LnNxbApAQCAtMSw3ICsxLDcgQEAKIEFMVEVSIFRBQkxFIHt7IGNvbm58cXRJ ZGVudChkYXRhLnNjaGVtYSwgZGF0YS50YWJsZSkgfX0KICAgICBBRER7JSBp ZiBkYXRhLm5hbWUgJX0gQ09OU1RSQUlOVCB7eyBjb25ufHF0SWRlbnQoZGF0 YS5uYW1lKSB9fXslIGVuZGlmJX0gRVhDTFVERSB7JSBpZiBkYXRhLmFtbmFt ZSBhbmQgZGF0YS5hbW5hbWUgIT0gJycgJX1VU0lORyB7e2RhdGEuYW1uYW1l fX17JSBlbmRpZiAlfSAoCiAgICAgeyUgZm9yIGNvbCBpbiBkYXRhLmNvbHVt bnMgJX17JSBpZiBsb29wLmluZGV4ICE9IDEgJX0sCi0gICAgeyUgZW5kaWYg JX17eyBjb25ufHF0SWRlbnQoY29sLmNvbHVtbil9fSB7JSBpZiBjb2wub3Bl cl9jbGFzcyBhbmQgY29sLm9wZXJfY2xhc3MgIT0gJycgJX17e2NvbC5vcGVy X2NsYXNzfX0geyUgZW5kaWYlfXslIGlmIGNvbC5vcmRlciAlfUFTQ3slIGVs c2UgJX1ERVNDeyUgZW5kaWYgJX0gTlVMTFMgeyUgaWYgY29sLm51bGxzX29y ZGVyICV9RklSU1R7JSBlbHNlICV9TEFTVHslIGVuZGlmICV9IFdJVEgge3tj b2wub3BlcmF0b3J9fXslIGVuZGZvciAlfSl7JSBpZiBkYXRhLmZpbGxmYWN0 b3IgJX0KKyAgICB7JSBlbmRpZiAlfXt7IGNvbm58cXRJZGVudChjb2wuY29s dW1uKX19IHslIGlmIGRhdGEuYW1uYW1lIGlzIGRlZmluZWQgYW5kIGRhdGEu YW1uYW1lIG5vdCBpbiBbJ2dpc3QnLCAnc3BnaXN0J10gJX17JSBpZiBjb2wu b3Blcl9jbGFzcyBhbmQgY29sLm9wZXJfY2xhc3MgIT0gJycgJX17e2NvbC5v cGVyX2NsYXNzfX0geyUgZW5kaWYlfXslIGlmIGNvbC5vcmRlciAlfUFTQ3sl IGVsc2UgJX1ERVNDeyUgZW5kaWYgJX0gTlVMTFMgeyUgaWYgY29sLm51bGxz X29yZGVyICV9RklSU1R7JSBlbHNlICV9TEFTVHslIGVuZGlmICV9eyUgZW5k aWYgJX0gV0lUSCB7e2NvbC5vcGVyYXRvcn19eyUgZW5kZm9yICV9KXslIGlm IGRhdGEuZmlsbGZhY3RvciAlfQogICAgIFdJVEggKEZJTExGQUNUT1I9e3tk YXRhLmZpbGxmYWN0b3J9fSl7JSBlbmRpZiAlfXslIGlmIGRhdGEuc3BjbmFt ZSBhbmQgZGF0YS5zcGNuYW1lICE9ICJwZ19kZWZhdWx0IiAlfQogCiAgICAg VVNJTkcgSU5ERVggVEFCTEVTUEFDRSB7eyBjb25ufHF0SWRlbnQoZGF0YS5z cGNuYW1lKSB9fXslIGVuZGlmICV9CkBAIC0xNCw0ICsxNCw0IEBAIEFMVEVS IFRBQkxFIHt7IGNvbm58cXRJZGVudChkYXRhLnNjaGVtYSwgZGF0YS50YWJs ZSkgfX0KIAogQ09NTUVOVCBPTiBDT05TVFJBSU5UIHt7IGNvbm58cXRJZGVu dChkYXRhLm5hbWUpIH19IE9OIHt7IGNvbm58cXRJZGVudChkYXRhLnNjaGVt YSwgZGF0YS50YWJsZSkgfX0KICAgICBJUyB7eyBkYXRhLmNvbW1lbnR8cXRM aXRlcmFsIH19OwoteyUgZW5kaWYgJX0KXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCit7JSBlbmRpZiAlfQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvdGFibGVzL3RlbXBsYXRlcy9leGNsdXNpb25fY29uc3RyYWludC9zcWwv OS4yX3BsdXMvY3JlYXRlLnNxbCBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy dmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90 ZW1wbGF0ZXMvZXhjbHVzaW9uX2NvbnN0cmFpbnQvc3FsLzkuMl9wbHVzL2Ny ZWF0ZS5zcWwKaW5kZXggZGIyOTA0OC4uOTNmMzY0OCAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0 YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy9leGNsdXNpb25fY29u c3RyYWludC9zcWwvOS4yX3BsdXMvY3JlYXRlLnNxbAorKysgYi93ZWIvcGdh ZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMv c2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL2V4Y2x1c2lvbl9jb25zdHJhaW50 L3NxbC85LjJfcGx1cy9jcmVhdGUuc3FsCkBAIC0xLDcgKzEsNyBAQAogQUxU RVIgVEFCTEUge3sgY29ubnxxdElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLnRh YmxlKSB9fQogICAgIEFERHslIGlmIGRhdGEubmFtZSAlfSBDT05TVFJBSU5U IHt7IGNvbm58cXRJZGVudChkYXRhLm5hbWUpIH19eyUgZW5kaWYlfSBFWENM VURFIHslIGlmIGRhdGEuYW1uYW1lIGFuZCBkYXRhLmFtbmFtZSAhPSAnJyAl fVVTSU5HIHt7ZGF0YS5hbW5hbWV9fXslIGVuZGlmICV9ICgKICAgICB7JSBm b3IgY29sIGluIGRhdGEuY29sdW1ucyAlfXslIGlmIGxvb3AuaW5kZXggIT0g MSAlfSwKLSAgICB7JSBlbmRpZiAlfXt7IGNvbm58cXRJZGVudChjb2wuY29s dW1uKX19IHslIGlmIGNvbC5vcGVyX2NsYXNzIGFuZCBjb2wub3Blcl9jbGFz cyAhPSAnJyAlfXt7Y29sLm9wZXJfY2xhc3N9fSB7JSBlbmRpZiV9eyUgaWYg Y29sLm9yZGVyICV9QVNDeyUgZWxzZSAlfURFU0N7JSBlbmRpZiAlfSBOVUxM UyB7JSBpZiBjb2wubnVsbHNfb3JkZXIgJX1GSVJTVHslIGVsc2UgJX1MQVNU eyUgZW5kaWYgJX0gV0lUSCB7e2NvbC5vcGVyYXRvcn19eyUgZW5kZm9yICV9 KXslIGlmIGRhdGEuZmlsbGZhY3RvciAlfQorICAgIHslIGVuZGlmICV9e3sg Y29ubnxxdElkZW50KGNvbC5jb2x1bW4pfX0geyUgaWYgZGF0YS5hbW5hbWUg aXMgZGVmaW5lZCBhbmQgZGF0YS5hbW5hbWUgbm90IGluIFsnZ2lzdCcsICdz cGdpc3QnXSAlfXslIGlmIGNvbC5vcGVyX2NsYXNzIGFuZCBjb2wub3Blcl9j bGFzcyAhPSAnJyAlfXt7Y29sLm9wZXJfY2xhc3N9fSB7JSBlbmRpZiV9eyUg aWYgY29sLm9yZGVyICV9QVNDeyUgZWxzZSAlfURFU0N7JSBlbmRpZiAlfSBO VUxMUyB7JSBpZiBjb2wubnVsbHNfb3JkZXIgJX1GSVJTVHslIGVsc2UgJX1M QVNUeyUgZW5kaWYgJX17JSBlbmRpZiAlfSBXSVRIIHt7Y29sLm9wZXJhdG9y fX17JSBlbmRmb3IgJX0peyUgaWYgZGF0YS5maWxsZmFjdG9yICV9CiAgICAg V0lUSCAoRklMTEZBQ1RPUj17e2RhdGEuZmlsbGZhY3Rvcn19KXslIGVuZGlm ICV9eyUgaWYgZGF0YS5zcGNuYW1lIGFuZCBkYXRhLnNwY25hbWUgIT0gInBn X2RlZmF1bHQiICV9CiAKICAgICBVU0lORyBJTkRFWCBUQUJMRVNQQUNFIHt7 IGNvbm58cXRJZGVudChkYXRhLnNwY25hbWUpIH19eyUgZW5kaWYgJX0KQEAg LTE0LDQgKzE0LDQgQEAgQUxURVIgVEFCTEUge3sgY29ubnxxdElkZW50KGRh dGEuc2NoZW1hLCBkYXRhLnRhYmxlKSB9fQogCiBDT01NRU5UIE9OIENPTlNU UkFJTlQge3sgY29ubnxxdElkZW50KGRhdGEubmFtZSkgfX0gT04ge3sgY29u bnxxdElkZW50KGRhdGEuc2NoZW1hLCBkYXRhLnRhYmxlKSB9fQogICAgIElT IHt7IGRhdGEuY29tbWVudHxxdExpdGVyYWwgfX07Ci17JSBlbmRpZiAlfQpc IE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKK3slIGVuZGlmICV9Cg== --001a11443a8a28c2af05420af129 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11443a8a28c2af05420af129--