Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKjNI-0001qd-CR for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Jun 2017 10:48:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dKjNH-0003FQ-76 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Jun 2017 10:48:39 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dKjNF-0003FA-4S for pgadmin-hackers@postgresql.org; Tue, 13 Jun 2017 10:48:37 +0000 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dKjNB-0000kG-Nz for pgadmin-hackers@postgresql.org; Tue, 13 Jun 2017 10:48:35 +0000 Received: by mail-wr0-x22e.google.com with SMTP id q97so137033938wrb.2 for ; Tue, 13 Jun 2017 03:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oQl8/29kSnujsGgCg8Y0UeaaaKhRmfxffUbVXLXtSow=; b=SnsAIBHODsxSSJ6Q4ggLKeCR9XghSeNLH8/Ss42zqWHCLNsbcWssO8PwtcJPR733M3 SU8bFI2wLJukw8h3brBTD0iDE8pOCusv7qpGctw38zYFMNRCtDcmVn4sc6/vI8sOFzYP GSHOaTVIm9E+MiLPOY5LHnjFJzh8z4PqYvxzSzfIdTf49rf4OoATm/R4lVW4534xTTMp WCb20tyTMHkN9ZJzvVJss8p/T/dGZzDxf1Rf9Nl56dZrxSOAF9XqhVGDmQXXtn8XJ2Xp /gsxJ7MypOZzrBV1yltbhu5QJyxtdgsBoKUeDMAoB57UVqRpk6WYHd3rV3J9BEwBROYz 6nIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oQl8/29kSnujsGgCg8Y0UeaaaKhRmfxffUbVXLXtSow=; b=B0Np2l1mSwZVftQ+oUXJmrOIv6uC9zM+iZJecL5EW3RJSHLBqZn60NOPd2md/cezmL v7bjy4dqEQI2RF/IKCob/zXY4ynkZZ/01SpabVuWiyg9n1Fq8/hP5FuT73pfBpOpZV72 EpWgaf/Fv2Qw9yt5e9H2y8W8H6dSFzIKiFo8C5yVk/S39TYqTqsrEkC1LXBtX/oh1ETh izwBWk17loP6YF6rF8nBAP96xJYLrz+7e7V4tbF/QkdISfc6uaU2q2CQLMiKjXJYpW+/ F40oba0xmz/jftoeWlN2AoJqNcoZ1B/Z7lofNQ1mqG0IIIgtj1LMDsaNrzCrGnTJfjtM DMsA== X-Gm-Message-State: AODbwcBlDTAVJGoMoGezK4EL866sUf4CFpuCMrR8SonTmtRzs5Mrypub 00in3s0dulGcAL+m0Hc8WcUe1TVeM4Z6 X-Received: by 10.28.21.205 with SMTP id 196mr9630115wmv.99.1497350906825; Tue, 13 Jun 2017 03:48:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.99.197 with HTTP; Tue, 13 Jun 2017 03:47:55 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Tue, 13 Jun 2017 16:17:55 +0530 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Dave Page Cc: Ashesh Vashi , Shruti B Iyer , Joao Pedro De Almeida Pereira , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1145a814e7f4270551d52c89" List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145a814e7f4270551d52c89 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar > wrote: > > > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > >> > >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > >> wrote: > >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote= : > >> >> > >> >> And then I find a problem. Sigh. > >> >> > >> >> When running in the desktop runtime, under QtWekKit (the forked, > >> >> updated version that is by far the best of the browser engines we'v= e > >> >> used), we get the attached error at startup. I don't see this under > >> >> QtWebEngine, though as we've already found, that's not usable for > >> >> other reasons. > >> >> > >> >> Is this fixable? > >> > > >> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html': > >> > " > >> > WebKit engine itself has not been updated since Qt 5.2 release. That= 's > >> > why > >> > it didn't support recent changes in Web standards that happened afte= r > >> > 2013, > >> > including: new JavaScript language standard ES2015 (also known as > ES6), > >> > as > >> > well as improvements in DOM API and CSS. > >> > ... > >> > " > >> > > >> > Could this be a reason? > >> > >> For the old webkit, certainly, but if you read further down, the > >> version we're using has been updated and does now claim to support > >> most of ES2015. > > > > In fact the modern browsers don't support ES6 JS so the JS files > containing > > ES6 code are first transpiled using babel into JS that browsers support= s. > > Well, we *could* do that, but are we? I'm not sure the current code > does anything more than lint and webpack it. > =E2=80=8BYes. babel is used in webpack config which converts JSX, JS and re= act JS library code into browser supportable JS code and put them into generated directory which we are then imported in sqleditor.js > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1145a814e7f4270551d52c89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On = Tue, Jun 13, 2017 at 4:05 PM, Dave Page <dpage@pgadmin.org> = wrote:
On Tue, Jun 13, 2017 at 11:31 AM, Surind= er Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
>
> On Tue, Jun 13, 2017 at 3:56 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>> <ashesh.vashi@enterprisedb.com> wrote:
>> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dpage@pgadmin.org> wrote: >> >>
>> >> And then I find a problem. Sigh.
>> >>
>> >> When running in the desktop runtime, under QtWekKit (the = forked,
>> >> updated version that is by far the best of the browser en= gines we've
>> >> used), we get the attached error at startup. I don't = see this under
>> >> QtWebEngine, though as we've already found, that'= s not usable for
>> >> other reasons.
>> >>
>> >> Is this fixable?
>> >
>> > As per 'http://qtwebkit.b= logspot.in/2016/08/qtwebkit-im-back.html':
>> > "
>> > WebKit engine itself has not been updated since Qt 5.2 releas= e. That's
>> > why
>> > it didn't support recent changes in Web standards that ha= ppened after
>> > 2013,
>> > including: new JavaScript language standard ES2015 (also know= n as ES6),
>> > as
>> > well as improvements in DOM API and CSS.
>> > ...
>> > "
>> >
>> > Could this be a reason?
>>
>> For the old webkit, certainly, but if you read further down, the >> version we're using has been updated and does now claim to sup= port
>> most of ES2015.
>
> In fact the modern browsers don't support ES6 JS so the JS files c= ontaining
> ES6 code are first transpiled using babel into JS that browsers suppor= ts.

Well, we *could* do that, but are we? I'm not sure the curr= ent code
does anything more than lint and webpack it.
=E2=80=8BYes. babel is used in web= pack config which converts JSX, JS and react JS library code into browser s= upportable JS code and put them into generated directory which we are then = imported in sqleditor.js

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1145a814e7f4270551d52c89--