Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0Xwx-0005hz-RO for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 May 2016 17:29:32 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b0Xwx-0000F5-Cn for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 May 2016 17:29:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b0Xwj-0008Rh-OW for pgadmin-hackers@postgresql.org; Wed, 11 May 2016 17:29:17 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b0Xwg-00059A-NJ for pgadmin-hackers@postgresql.org; Wed, 11 May 2016 17:29:17 +0000 Received: by mail-wm0-x22e.google.com with SMTP id e201so228224075wme.0 for ; Wed, 11 May 2016 10:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=CiA0vEzBArfaFMtbe8Mf0grlqwgGiHFx/YNTtmHD61g=; b=blfRJseDVxAah6k9VDGoKWsxdIJYzpQVasBj0PLcAYxTAkeao1Pm3G5LkbxIsxgbq1 oyY0bwBlAIsmIhm9fXZ588loxFqCxtSJkHRYyNdZjMvNEv7ugp8VKX92SyHh2sdrBSth 6vedX0hKvUNtVm9chs/pr64oSG9HA86+DwtpmLr0I7EC/93+jjEXnDfHZ7r870My8rdP e0Zw54aB9aX+hbJgBCIRAAfAwFqZhTZCQl47XAYUIUc0U517ZlWRCKFBdcztiefvjYb/ SHqsBRq9elhw1soH9YsqNXMk+WVeYMQ65nkUO4CUNZI0lI0Er/aJUJEMLIkp4d8BpzQx lvGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=CiA0vEzBArfaFMtbe8Mf0grlqwgGiHFx/YNTtmHD61g=; b=fErD8d0CFmLdpfKvfsbnxA7qEs12f/XzMEdDr+jk/eTYD7yDGTxrFJQUsMCUov8Iu+ IyhSr2+z833ZELmy3ih0n7CpFobHMVpwLouX25w6oScSkBZHfT4iyT/eULg8i8eRikVL 9ociiHZSlHSQRJbBwnuGWUfVmxaD2KsbVXqvkxvJpLIdBvUCLuPdYP+Ip3KD5ZP7a2Gy Do9v1OhI/m8iUOR+reSgZ/EBp525zKTdt0m8E5ArUlKXZYAnWVoJ44/vc49HTxrOi+4P yVgwQINEO13Rzc4V4SPmAPZ2zNMoaj8vR7XqqUZUIDnYQ7E+b7IvAIMtMqosZL1uGOG8 WFiQ== X-Gm-Message-State: AOPr4FWZDgD6ImomehV4GwF+tsm6A6NaAZw4WTAb+g/Nwe5OEK2zOxO9gb9vBgxaJGpQjDGXI8sm23GO30bCcLiz X-Received: by 10.28.126.133 with SMTP id z127mr5626461wmc.68.1462987753868; Wed, 11 May 2016 10:29:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.14.212 with HTTP; Wed, 11 May 2016 10:28:43 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 11 May 2016 22:58:43 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Grant Wizard To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1141785661c57a05329461a6 X-Pg-Spam-Score: 0.7 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1141785661c57a05329461a6 Content-Type: multipart/alternative; boundary=001a1141785661c57205329461a4 --001a1141785661c57205329461a4 Content-Type: text/plain; charset=UTF-8 Hi, PFA updated patch *Change*: removed '*ajs_content*' css from *wizard.css* causing padding issue in alertify dialog. Thanks murtuza for reporting. On Fri, May 6, 2016 at 3:00 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > PFA patch with following issues fixed: > 1. As SqlTab Control is renamed to SqlCtrl, throws error on grant wizard > close. it is Fixed. > 2. Moved grant wizard specific css from wizard.css to grant_wizard.css. > > On Wed, Apr 13, 2016 at 8:41 PM, Dave Page wrote: > >> Hi >> >> On Fri, Apr 8, 2016 at 6:59 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Hi >>> >>> PFA patch with resolved review comments. >>> >>> On Fri, Apr 8, 2016 at 12:52 AM, Dave Page wrote: >>> >>>> Hi >>>> >>>> Nearly there :-). Assuming no regressions, I believe we'll be ready to >>>> commit once the following issues are resolved: >>>> >>>> - The select object grid should fill the available vertical space in >>>> the dialogue - at present there's a gap below it. >>>> >>> Done >>> >> >> This does not seem to be fixed (see attached screenshot). In fact, the >> gap gets bigger proportionally as the window is resized. >> > Fixed > >> >> >>> >>>> - When selecting privileges, each time I click on a checkbox, the row >>>> closes. Similar grids elsewhere in the app close the row when the cell >>>> loses focus, *however*, that is also the incorrect behaviour - the row >>>> should only close when the row itself loses focus (and should open when it >>>> gets focus). >>>> >>> I checked the row closes either when gets clicked on row or outside row, >>> it doesn't seems to close on click on checkbox. >>> >> >> This is still broken for me. I'm using Chrome on OS X. As soon as I click >> any checkbox, the row closes, and I have to click again to see the >> checkboxes again. >> > I checked with Chrome on OS X, windows and ubuntu, it is working fine. Can > you please send me screenshot if possible? > >> >> One additional issue: >> >> - If I select some objects and permissions (in my case, everything in a >> PEM database, and ALL), hit Next so I can see the SQL, then hit back >> *twice*, I see the second attached screenshot. >> > I followed the same steps and when hit back twice on *previous* button of > SQL page, it takes me to first page which is right. > It would be easy for me to find out the exact cause if you send me output > of browser console panel. > >> >> I'm going to commit the code with these issues as they are largely >> cosmetic. Please submit a patch to fix them (I'll add a new card to our >> internal Kanban chart). >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > --001a1141785661c57205329461a4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA updated patch

Change: removed 'ajs_content' css from wiz= ard.css causing padding issue in alertify dialog.
Thanks murt= uza for reporting.

On Fri, May 6, 2016 at 3:00 PM, Surinder Kumar = <surinder.kumar@enterprisedb.com> wrote:
Hi,
PFA patch with following issues fixed:
1. As = SqlTab Control is renamed to SqlCtrl, throws error on grant wizard close. i= t is Fixed.
2. Moved grant wizard specific css from wizard.css to= grant_wizard.css.

On Wed, Apr 13, 2016 at 8:41 PM, Dave Page &= lt;dpage@pgadmin.org= > wrote:
H= i

On Fri= , Apr 8, 2016 at 6:59 PM, Surinder Kumar <surinder.kumar@ent= erprisedb.com> wrote:
Hi

PFA patch with resolved revi= ew comments.

On Fri, Apr 8, 2016 at 12:52 AM, Dave Page <dpage@pgadmin.org&g= t; wrote:
= Hi

Nearly there :-). Assuming no regressions, I be= lieve we'll be ready to commit once the following issues are resolved:<= /div>

- The select object grid should fill the avai= lable vertical space in the dialogue - at present there's a gap below i= t.
Done=C2=A0

This does not seem to be fixed = (see attached screenshot). In fact, the gap gets bigger proportionally as t= he window is resized.
Fixed=C2=A0
=C2=A0

- When selecting pr= ivileges, each time I click on a checkbox, the row closes. Similar grids el= sewhere in the app close the row when the cell loses focus, *however*, that= is also the incorrect behaviour - the row should only close when the row i= tself loses focus (and should open when it gets focus).
I checked the row closes either when gets clicked on= row or outside row, it doesn't seems to close on click on checkbox.

This is still = broken for me. I'm using Chrome on OS X. As soon as I click any checkbo= x, the row closes, and I have to click again to see the checkboxes again.
I ch= ecked with Chrome on OS X, windows and ubuntu, it is working fine. Can you = please send me screenshot if possible?

One additional issue:

- If I select some objects and permissions (in my case, everything in a P= EM database, and ALL), hit Next so I can see the SQL, then hit back *twice*= , I see the second attached screenshot.
I followed the same steps and when hit= back twice on previous=C2=A0button of SQL page, it takes me to firs= t page which is right.
It would be= easy for me to find out the exact cause if you send me output of browser c= onsole panel.

<= div>I'm going to commit the code with these issues as they are largely = cosmetic. Please submit a patch to fix them (I'll add a new card to our= internal Kanban chart).

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company



--001a1141785661c57205329461a4-- --001a1141785661c57a05329461a6 Content-Type: application/octet-stream; name="grant_wizard_v11.patch" Content-Disposition: attachment; filename="grant_wizard_v11.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_io354eec1 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2Nzcy93 aXphcmQuY3NzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvY3NzL3dp emFyZC5jc3MKaW5kZXggMmMxOWEwOS4uZGE5M2Q1NyAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvY3NzL3dpemFyZC5jc3MKKysr IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvY3NzL3dpemFyZC5jc3MK QEAgLTE0Myw3ICsxNDMsMyBAQAogLnNlbGVjdDItY29udGFpbmVyLS1vcGVu IHsKICAgei1pbmRleDogMTAwMDA7CiB9Ci0KLS5hbGVydGlmeSAuYWpzLWJv ZHkgLmFqcy1jb250ZW50IHsKLSAgcGFkZGluZzogMHB4OwotfQpcIE5vIG5l d2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWlu L3Rvb2xzL2dyYW50X3dpemFyZC90ZW1wbGF0ZXMvZ3JhbnRfd2l6YXJkL2pz L2dyYW50X3dpemFyZC5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2dyYW50X3dp emFyZC90ZW1wbGF0ZXMvZ3JhbnRfd2l6YXJkL2pzL2dyYW50X3dpemFyZC5q cwppbmRleCAyMWY4NTE2Li5hZWY3NjIxIDEwMDY0NAotLS0gYS93ZWIvcGdh ZG1pbi90b29scy9ncmFudF93aXphcmQvdGVtcGxhdGVzL2dyYW50X3dpemFy ZC9qcy9ncmFudF93aXphcmQuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMv Z3JhbnRfd2l6YXJkL3RlbXBsYXRlcy9ncmFudF93aXphcmQvanMvZ3JhbnRf d2l6YXJkLmpzCkBAIC0xNDIsNyArMTQyLDcgQEAgZGVmaW5lKFsKICAgICAg ICAgdmFyIHN1cHBvcnRlZF9ub2RlcyA9IFsKICAgICAgICAgICAgICAgJ3Nj aGVtYScsICdjb2xsLWZ1bmN0aW9uJywgJ2NvbGwtc2VxdWVuY2UnLAogICAg ICAgICAgICAgICAnY29sbC10YWJsZScsICdjb2xsLXZpZXcnLCAnY29sbC1w cm9jZWR1cmUnLAotICAgICAgICAgICAgICAnY29sbC1tYXRlcmlhbGl6ZWRf dmlldycsICdkYXRhYmFzZScKKyAgICAgICAgICAgICAgJ2NvbGwtbXZpZXcn LCAnZGF0YWJhc2UnCiAgICAgICAgICAgICBdLAogCiAgICAgICAgICAgICAv KioK --001a1141785661c57a05329461a6 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1141785661c57a05329461a6--