Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7fg0-0000o0-R3 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 10:14:01 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7ffz-0006Tu-GU for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 10:13:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7ffi-00065M-J8 for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 10:13:43 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7ffd-0008Of-Up for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 10:13:40 +0000 Received: by mail-wm0-x231.google.com with SMTP id 142so59247902wma.1 for ; Mon, 08 May 2017 03:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qJ48yZN0bgALyXMQgu4FEKe7tJ67S11yjtWchyb0MV4=; b=DwOQ+na9JKiRvNipW2tLTWhV7SXAwU/X6z8ApC09fBcMgG6tstgKybhM2i0B/0LxkT XX4RucIZoo2p2al+YTcXPVhe5H8Hi/kjnXvkW10k5bV1DPyQyF0lS/dMxlVPN8B3KcDX SJq9q3C0VqPht5BWlATVKJ8bf2N1fjL7u5QTuBkJL5XwJFtLCqIaxFTZ/ZuCcJBR7ZYA FihJ/P3ngNlrPpj4DDgf7d1Wx74t6xUww+5iJ4UQ0Rz20k1WHgfIj0VYPq+1WXjcEAIp JIwx04mFWLsBqsyIOJCN7f+sQFQY441YbLOAc1ZZ26bvQkjU7agmj9LggMCzZE/AXyeG 2zVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qJ48yZN0bgALyXMQgu4FEKe7tJ67S11yjtWchyb0MV4=; b=WcCgFXuTFjl5N7QXnK9GsOcW3chRAe61kLduq9ceA6vNNQn3EX36LJRU/hcVAYHYac kcrIpRAaqOoA7cKvoGXSVS44YB7BqTm1MuWpGXe+IxU3uoaGMO3Ha50j6VL/mcUbjU7x tOJzb5nD/43lEi3gRLGUJ5J2w1EQfY5FjN8x9NwsZHr5lSgYdTzw2cS8q7o/zJmhmJqr kTvMy3/kpIA82+lndoWCL2nUNtj35FFJM7CF27gr3EEUXNCdHcARgoyP5rPaCErChRTC tE3R+mzKcY2yuLKXVSLTXb+lTZu+UMjXiFGhBeLpgJnaJntP8wCuFaPFGacZ5ISfjGtR FqUA== X-Gm-Message-State: AN3rC/4J0ZX1MiHAgw7ezSqLnIu+1+BY/HDOumuAbfhWXgQ0y2brEDSq 4HOr4ooLkhdtXz51Wqdhr419t03ojYL3 X-Received: by 10.28.229.145 with SMTP id c139mr13182181wmh.107.1494238416053; Mon, 08 May 2017 03:13:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.19.138 with HTTP; Mon, 8 May 2017 03:13:05 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Mon, 8 May 2017 15:43:05 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114712e2ffc2eb054f007db8 X-Pg-Spam-Score: -2.3 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114712e2ffc2eb054f007db8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Dave, On Mon, May 8, 2017 at 3:28 PM, Dave Page wrote: > Hi > > On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi Dave, >> >> The support to handle [null] and [default] values is added for following >> formatters: >> - JsonFormatter >> - NumbersFormatter >> - CheckmarkFormatter >> - TextFormatter >> >> Previously when a new row is added, it was not validating each and every >> cell for columns with attribute not_null =3D true. >> Introduced a new function validateRow(...) which is called on adding a >> new row, it validates each cell with column having >> attribute(not_null=3Dtrue). the corresponding cell will highlighted and = save >> button will be disabled if value is [null]. >> > > I'm not sure that behaviour is right. What I now see (given the table > below) is that: > > - If I click in the id field of a new row, it forces me to enter a value > or hit escape. Why is it trying to force me? It's a serial field, so will > get a value on save anyway. > =E2=80=8BYes, It is because I am validating all cell values after it render= s. It will reverted back. > > - If I do enter a value in the ID field, focus jumps over all the other > fields with either a default or no 'not null' option to the data_no_nulls > column. Focus should always go to the next field. > > I think this addition can just be removed - I'm pretty sure the previous > behaviour would have been what we want, with the additional formatters > fixed. > =E2=80=8BBut If i remove this addition, the value for column like 'data_no_= nulls' =E2=80=8Bwill be set to '' (blank string), then on save its value will be v= alidated on the server side and whatever the error message is will be returned back (the same behaviour as in pgAdmin3) > > >> >> Now I will add more feature test cases for remaining formatters. Will >> send separate patch for feature test cases once completed. >> > > Thanks. > > >> >> Please review updated patch. >> >> >> On Tue, May 2, 2017 at 5:57 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, May 2, 2017 at 5:21 PM, Dave Page wrote: >>> >>>> Hi, >>>> >>>> This is looking much better now :-). Couple of thoughts and a bug: >>>> >>>> - Only the TextFormatter seems to handle both [null] and [default] >>>> values. Shouldn't all formatters do so (including Json and Checkmark)? >>>> >>> =E2=80=8BYes, I will apply the same changes for other formatters too.= =E2=80=8B >>> >>>> For example, "serial" columns currently get displayed as [null] when >>>> left blank, but I would expect to see [default]. >>>> >>>> - I would suggest we put [null] and [default] in a lighter colour - >>>> #999999. >>>> >>>> - With the feature test patch added, I seem to be consistently getting >>>> the following failure (immediately after your new tests run): >>>> >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> ERROR: runTest (pgadmin.feature_tests.xss_che >>>> cks_panels_and_query_tool_test.CheckForXssFeatureTest) >>>> Test XSS check for panels and query tool >>>> ---------------------------------------------------------------------- >>>> Traceback (most recent call last): >>>> File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_fe= ature_test.py", >>>> line 42, in setUp >>>> self._screenshot() >>>> File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_fe= ature_test.py", >>>> line 92, in _screenshot >>>> python_version)) >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 802, in >>>> get_screenshot_as_file >>>> png =3D self.get_screenshot_as_png() >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 821, in >>>> get_screenshot_as_png >>>> return base64.b64decode(self.get_screenshot_as_base64().encode('as= c >>>> ii')) >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 831, in >>>> get_screenshot_as_base64 >>>> return self.execute(Command.SCREENSHOT)['value'] >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 238, in execute >>>> self.error_handler.check_response(response) >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/errorhandler.py", line 193, in >>>> check_response >>>> raise exception_class(message, screen, stacktrace) >>>> UnexpectedAlertPresentException: Alert Text: None >>>> Message: unexpected alert open: {Alert text : Are you sure you wish to >>>> close the pgAdmin 4 browser?} >>>> (Session info: chrome=3D58.0.3029.81) >>>> (Driver info: chromedriver=3D2.29.461585 (0be2cd95f834e9ee7c46bcc7cf= 405b483f5ae83b),platform=3DMac >>>> OS X 10.12.3 x86_64) >>>> >>>> >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> ERROR: runTest (pgadmin.feature_tests.xss_che >>>> cks_pgadmin_debugger_test.CheckDebuggerForXssFeatureTest) >>>> Test table DDL generation >>>> ---------------------------------------------------------------------- >>>> Traceback (most recent call last): >>>> File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_fe= ature_test.py", >>>> line 42, in setUp >>>> self._screenshot() >>>> File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_fe= ature_test.py", >>>> line 92, in _screenshot >>>> python_version)) >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 802, in >>>> get_screenshot_as_file >>>> png =3D self.get_screenshot_as_png() >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 821, in >>>> get_screenshot_as_png >>>> return base64.b64decode(self.get_screenshot_as_base64().encode('as= c >>>> ii')) >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 831, in >>>> get_screenshot_as_base64 >>>> return self.execute(Command.SCREENSHOT)['value'] >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/webdriver.py", line 238, in execute >>>> self.error_handler.check_response(response) >>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>> ges/selenium/webdriver/remote/errorhandler.py", line 193, in >>>> check_response >>>> raise exception_class(message, screen, stacktrace) >>>> UnexpectedAlertPresentException: Alert Text: None >>>> Message: unexpected alert open: {Alert text : Are you sure you wish to >>>> close the pgAdmin 4 browser?} >>>> (Session info: chrome=3D58.0.3029.81) >>>> (Driver info: chromedriver=3D2.29.461585 (0be2cd95f834e9ee7c46bcc7cf= 405b483f5ae83b),platform=3DMac >>>> OS X 10.12.3 x86_64) >>>> >>> =E2=80=8BSure. I will fix this.=E2=80=8B >>> >>>> >>>> Thanks! >>>> >>>> >>>> On Fri, Apr 28, 2017 at 10:19 AM, Surinder Kumar < >>>> surinder.kumar@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find updated patch for RM case and a separate patch for Featur= e >>>>> tests. >>>>> >>>>> *Python:* >>>>> >>>>> - Added [default] label for cells with default values while inserting >>>>> a new row. >>>>> >>>>> - Introduced a FieldValidator function for cells that don't allow nul= l >>>>> values. If user tries to insert null value, field with be highlighted= with >>>>> red borders around. >>>>> >>>>> =E2=80=8B- >>>>> If a cell contains blank string('') and when we set it to null, the >>>>> change into the cell is not detected. It was because the comparison >>>>> for (defaultValue =3D=3D null) return true if defaultValue is undefin= ed. >>>>> Hence _.isNull(value) is used to fix this. >>>>> >>>>> *Feature Test cases:* >>>>> >>>>> - Introduced a new method create_table_with_query(server, db_name, >>>>> query) in test_utils.py which executes the given query on connected >>>>> server. >>>>> >>>>> - Added a new file test_data.json that has test data for test cases. >>>>> >>>>> >>>>> On Fri, Apr 7, 2017 at 2:21 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Sat, Apr 1, 2017 at 12:45 PM, Surinder Kumar >>>>>> wrote: >>>>>> > Hi >>>>>> > >>>>>> > Issues fixed: >>>>>> > >>>>>> > 1. If a column is defined with a default modifier, there is now wa= y >>>>>> to >>>>>> > insert the row with those defaults. >>>>>> > The column will be left blank and it will take default value >>>>>> automatically. >>>>>> > >>>>>> > 2. If a column has a not-null constraint then an error is returned >>>>>> and the >>>>>> > row is not inserted. >>>>>> > The column will be left blank >>>>>> > >>>>>> > The default values for new added rows will be displayed on >>>>>> refresh/execute. >>>>>> > >>>>>> > Please find attached patch and review. >>>>>> >>>>>> This largely works as expected, but there is some weirdness. I have = a >>>>>> test table that looks like this: >>>>>> >>>>>> CREATE TABLE public.defaults >>>>>> ( >>>>>> id bigint NOT NULL DEFAULT nextval('defaults_id_seq'::regclass), >>>>>> data_default_nulls text COLLATE pg_catalog."default" DEFAULT >>>>>> 'abc123'::text, >>>>>> data_default_no_nulls text COLLATE pg_catalog."default" NOT NULL >>>>>> DEFAULT 'def456'::text, >>>>>> data_nulls text COLLATE pg_catalog."default", >>>>>> data_no_nulls text COLLATE pg_catalog."default" NOT NULL, >>>>>> CONSTRAINT defaults_pkey PRIMARY KEY (id) >>>>>> ) >>>>>> >>>>>> Remember that the expected behaviour is: >>>>>> >>>>>> - Set a value to empty to update the column to null. >>>>>> - Set a value to '' to update the column to an empty string >>>>>> - Set a value to anything else to update the column to that value >>>>>> >>>>>> 1) In a row with values in each column, if I try to set the value of >>>>>> data_default_nulls to null, the query executed is: >>>>>> >>>>>> UPDATE public.defaults SET >>>>>> data_default_nulls =3D '' WHERE >>>>>> id =3D '2'; >>>>>> >>>>>> 2) If I do the same in the data_nulls column, the value is immediate= ly >>>>>> shown as [null] and the query executed is: >>>>>> >>>>>> UPDATE public.defaults SET >>>>>> data_nulls =3D NULL WHERE >>>>>> id =3D '2'; >>>>>> >>>>>> 3) If I then edit the value in data_default_nulls, it shows the >>>>>> current value as ''. Removing the quotes (to set it to null) doesn't >>>>>> get detected as a change. >>>>>> >>>>> =E2=80=8B=E2=80=8BTaken care. >>>>> >>>>>> >>>>>> 4) When I manually executed "update defaults set data_default_nulls = =3D >>>>>> null where id =3D 2" in a query tool window, I got: >>>>>> >>>>>> 2017-04-07 09:43:02,987: INFO werkzeug: 127.0.0.1 - - [07/Apr/2017 >>>>>> 09:43:02] "GET /sqleditor/columns/8745675 HTTP/1.1" 500 - >>>>>> Traceback (most recent call last): >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 2000, in __call__ >>>>>> return self.wsgi_app(environ, start_response) >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1991, in wsgi_app >>>>>> response =3D self.make_response(self.handle_exception(e)) >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1567, in handle_exception >>>>>> reraise(exc_type, exc_value, tb) >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1988, in wsgi_app >>>>>> response =3D self.full_dispatch_request() >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1641, in full_dispatch_request >>>>>> rv =3D self.handle_user_exception(e) >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1544, in handle_user_exception >>>>>> reraise(exc_type, exc_value, tb) >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1639, in full_dispatch_request >>>>>> rv =3D self.dispatch_request() >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask/app.py", >>>>>> line 1625, in dispatch_request >>>>>> return self.view_functions[rule.endpoint](**req.view_args) >>>>>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >>>>>> ges/flask_login.py", >>>>>> line 792, in decorated_view >>>>>> return func(*args, **kwargs) >>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/__ini >>>>>> t__.py", >>>>>> line 452, in get_columns >>>>>> tid=3Dcommand_obj.obj_id) >>>>>> AttributeError: 'QueryToolCommand' object has no attribute 'obj_id' >>>>>> >>>>> =E2=80=8BFixed.=E2=80=8B >>>>> >>>>>> >>>>>> 5) When I run the query again in pgAdmin III, then refresh the data = in >>>>>> pgAdmin 4, the data_default_nulls column is displayed without the >>>>>> [null] marker (despite having a null value, which I confirmed in >>>>>> pgAdmin 3). >>>>>> >>>>> =E2=80=8BFixed.=E2=80=8B >>>>> >>>>>> >>>>>> I'm sure there are other combinations of issues here. Please fix and >>>>>> thoroughly re-test to ensure behaviour is consistent - and to avoid >>>>>> future issues, please add some appropriate feature tests to check >>>>>> nulls, defaults and empty strings are properly handled in view, inse= rt >>>>>> and updates. Murtuza recently wrote some feature tests for the query >>>>>> tool - you should be able to use those as a starting point. >>>>>> >>>>> =E2=80=8BAdded feature tests=E2=80=8B >>>>> >>>>>> >>>>>> Thanks. >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114712e2ffc2eb054f007db8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi = Dave,

On Mon= , May 8, 2017 at 3:28 PM, Dave Page <dpage@pgadmin.org> wrot= e:
Hi

On Fri, May 5, = 2017 at 12:52 PM, Surinder Kumar <surinder.kumar@enterprised= b.com> wrote:
<= div dir=3D"ltr">
Hi Dave,

= The support to handle [null] and [default] values is added for following fo= rmatters:
=C2=A0-=C2=A0JsonFormatter
=C2=A0-=C2=A0NumbersFormatter
=C2=A0-=C2=A0CheckmarkFormatter
=C2=A0-=C2=A0TextFormatter

Previously when a new row is= added, it was not validating each and every cell for columns with attribut= e not_null =3D true.
Introduced a new function=C2=A0validateRow(...)=C2= =A0which is called on adding a new row, it validates each cell = with column having attribute(not_null=3Dtrue). the corresponding cell will = highlighted and save button will be disabled if value is [null].

I'm not sure that behaviour is= right. What I now see (given the table below) is that:

- If I click in the id field of a new row, it forces me to enter a va= lue or hit escape. Why is it trying to force me? It's a serial field, s= o will get a value on save anyway.
=E2=80=8BYes, It is beca= use I am validating all cell values after it renders. It will reverted back= .

- If I do enter a val= ue in the ID field, focus jumps over all the other fields with either a def= ault or no 'not null' option to the data_no_nulls column. Focus sho= uld always go to the next field.

I think this addi= tion can just be removed - I'm pretty sure the previous behaviour would= have been what we want, with the additional formatters fixed.=C2=A0
<= /div>
=E2=80=8BBut If i remove this addition, the value for column like= 'data_no_nulls' =E2=80=8Bwill be set to '' (blank string),= then on save its value will be validated on the server side and whatever t= he error message is will be returned back (the same behaviour as in pgAdmin= 3)
=C2=A0

Now I will ad= d more feature test cases for remaining formatters. Will send separate patc= h for feature test cases once completed.

<= /div>
Thanks.
=C2=A0

Please revie= w updated patch.


On Tue, May 2, 2= 017 at 5:57 PM, Surinder Kumar <surinder.kumar@enterprisedb.= com> wrote:
Hi Dave,

On Tue, May 2, 2017 at 5:21 PM, = Dave Page <dpage@pgadmin.org> wrote:
Hi,

This is looking much bet= ter now :-). Couple of thoughts and a bug:

- Only = the TextFormatter seems to handle both [null] and [default] values. Shouldn= 't all formatters do so (including Json and Checkmark)?
=E2=80=8BYes, I will apply t= he same changes for other formatters too.=E2=80=8B
For example, "serial" columns currently = get displayed as [null] when left blank, but I would expect to see [default= ].=C2=A0

- I would suggest we put [null] and [defa= ult] in a lighter colour - #999999.

- With the fea= ture test patch added, I seem to be consistently getting the following fail= ure (immediately after your new tests run):

= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.feature_tests.xss_checks_panels_and_que= ry_tool_test.CheckForXssFeatureTest)
Test XSS check for pane= ls and query tool
------------------------------------------= ----------------------------
Traceback (most recent ca= ll last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web<= wbr>/regression/feature_utils/base_feature_test.py", line 42, in = setUp
=C2=A0 =C2=A0 self._screenshot()
=C2=A0 File &quo= t;/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_fea= ture_test.py", line 92, in _screenshot
=C2=A0 =C2=A0 python_= version))
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmi= n4/lib/python2.7/site-packages/selenium/webdriver/remote/webdrive= r.py", line 802, in get_screenshot_as_file
=C2=A0 =C2=A0 png= =3D self.get_screenshot_as_png()
=C2=A0 File "/Users/dpage/= .virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdri= ver/remote/webdriver.py", line 821, in get_screenshot_as_png
=C2=A0 =C2=A0 return base64.b64decode(self.get_screenshot_as_bas= e64().encode('ascii'))
=C2=A0 File "/Users/dpag= e/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webd= river/remote/webdriver.py", line 831, in get_screenshot_as_base64=
=C2=A0 =C2=A0 return self.execute(Command.SCREENSHOT)['= value']
=C2=A0 File "/Users/dpage/.virtualenvs/pgad= min4/lib/python2.7/site-packages/selenium/webdriver/remote/webdri= ver.py", line 238, in execute
=C2=A0 =C2=A0 self.error_handl= er.check_response(response)
=C2=A0 File "/Users/dpage/.= virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriv= er/remote/errorhandler.py", line 193, in check_response
=C2=A0 =C2=A0 raise exception_class(message, screen, stacktrace)
UnexpectedAlertPresentException: Alert Text: None
Message: = unexpected alert open: {Alert text : Are you sure you wish to close the pgA= dmin 4 browser?}
=C2=A0 (Session info: chrome=3D58.0.3029.81)
=C2=A0 (Driver info: chromedriver=3D2.29.461585 (0be2cd95f834e9ee7c4= 6bcc7cf405b483f5ae83b),platform=3DMac OS X 10.12.3 x86_64)
<= br>

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.feature_tests= .xss_checks_pgadmin_debugger_test.CheckDebuggerForXssFeatureTest)=
Test table DDL generation
----------------------------= ------------------------------------------
Traceb= ack (most recent call last):
=C2=A0 File "/Users/dpag= e/git/pgadmin4/web/regression/feature_utils/base_feature_test.py&= quot;, line 42, in setUp
=C2=A0 =C2=A0 self._screenshot()
=C2=A0 File "/Users/dpage/git/pgadmin4/web/regression/feature_= utils/base_feature_test.py", line 92, in _screenshot
= =C2=A0 =C2=A0 python_version))
=C2=A0 File "/Users/dpage/.vi= rtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver= /remote/webdriver.py", line 802, in get_screenshot_as_file
<= div>=C2=A0 =C2=A0 png =3D self.get_screenshot_as_png()
=C2=A0 Fil= e "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 821, in get_s= creenshot_as_png
=C2=A0 =C2=A0 return base64.b64decode(self.get_s= creenshot_as_base64().encode('ascii'))
=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa<= wbr>ges/selenium/webdriver/remote/webdriver.py", line 831, in get= _screenshot_as_base64
=C2=A0 =C2=A0 return self.execute(Command.S= CREENSHOT)['value']
=C2=A0 File "/Users/dpage/.= virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriv= er/remote/webdriver.py", line 238, in execute
=C2=A0 = =C2=A0 self.error_handler.check_response(response)
=C2=A0 Fi= le "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 193, in c= heck_response
=C2=A0 =C2=A0 raise exception_class(message, screen= , stacktrace)
UnexpectedAlertPresentException: Alert Text: N= one
Message: unexpected alert open: {Alert text : Are you sure yo= u wish to close the pgAdmin 4 browser?}
=C2=A0 (Session info: chr= ome=3D58.0.3029.81)
=C2=A0 (Driver info: chromedriver=3D2.29.4615= 85 (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=3DMac OS X 10.1= 2.3 x86_64)
=E2=80=8BSure. I will fix this.=E2=80=8B

Thanks!


On Fri, Apr 28= , 2017 at 10:19 AM, Surinder Kumar <surinder.kumar@enterpris= edb.com> wrote:
Hi Dave,
=

Ple= ase find updated patch for RM case and a separate patch for Feature tests.<= /div>

Python:

- Added=C2=A0[default] = label for cells with default values while inserting a new row.
=

- I= ntroduced a FieldValidator function for cells that don't allow null val= ues. If user tries to insert null value, field with be highlighted with red= =C2=A0 =C2=A0borders around.

=E2=80=8B-=C2=A0
If a c= ell contains blank string('') and when we set it to null, the chang= e into the cell is not detected. It was because the comparison
for (defa= ultValue =3D=3D null) return true if defaultValue is undefined. Hence _.isN= ull(value) is used to fix this.

Feature Test cases:

=C2=A0- Introduced a new method=C2=A0create_table_with_query(server, db_name, query)=C2=A0 in= test_utils.py which executes the given query on connected server.

=C2=A0- Added a new file test_data.json that has test data= for test cases.


On Fri, Apr 7, 20= 17 at 2:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Sat, Apr 1, 2017 at 12:45 PM, Surinder Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Issues fixed:
>
> 1. If a column is defined with a default modifier, there is now way to=
> insert the row with those defaults.
> The column will be left blank and it will take default value automatic= ally.
>
> 2. If a column has a not-null constraint then an error is returned and= the
> row is not inserted.
> The column will be left blank
>
> The default values for new added rows will be displayed on refresh/exe= cute.
>
> Please find attached patch and review.

This largely works as expected, but there is some weirdness. I have = a
test table that looks like this:

CREATE TABLE public.defaults
(
=C2=A0 =C2=A0 id bigint NOT NULL DEFAULT nextval('defaults_id_seq':= :regclass),
=C2=A0 =C2=A0 data_default_nulls text COLLATE pg_catalog."default"= ; DEFAULT 'abc123'::text,
=C2=A0 =C2=A0 data_default_no_nulls text COLLATE pg_catalog."default&q= uot; NOT NULL
DEFAULT 'def456'::text,
=C2=A0 =C2=A0 data_nulls text COLLATE pg_catalog."default",
=C2=A0 =C2=A0 data_no_nulls text COLLATE pg_catalog."default" NOT= NULL,
=C2=A0 =C2=A0 CONSTRAINT defaults_pkey PRIMARY KEY (id)
)

Remember that the expected behaviour is:

- Set a value to empty to update the column to null.
- Set a value to '' to update the column to an empty string
- Set a value to anything else to update the column to that value

1) In a row with values in each column, if I try to set the value of
data_default_nulls to null, the query executed is:

UPDATE public.defaults SET
data_default_nulls =3D '' WHERE
id =3D '2';

2) If I do the same in the data_nulls column, the value is immediately
shown as [null] and the query executed is:

UPDATE public.defaults SET
data_nulls =3D NULL WHERE
id =3D '2';

3) If I then edit the value in data_default_nulls, it shows the
current value as ''. Removing the quotes (to set it to null) doesn&= #39;t
get detected as a change.
=E2=80=8B=E2=80=8BTaken care.=C2=A0

4) When I manually executed "update defaults set data_default_nulls = =3D
null where id =3D 2" in a query tool window, I got:

2017-04-07 09:43:02,987: INFO werkzeug: 127.0.0.1 - - [07/Apr/2017
09:43:02] "GET /sqleditor/columns/8745675 HTTP/1.1" 500 -
Traceback (most recent call last):
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 2000, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1991, in wsgi_app
=C2=A0 =C2=A0 response =3D self.make_response(self.handle_exception(e)= )
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1567, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1988, in wsgi_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1641, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1544, in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1639, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",
line 1625, in dispatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req.view_arg= s)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask_login.py",
line 792, in decorated_view
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqledito= r/__init__.py",
line 452, in get_columns
=C2=A0 =C2=A0 tid=3Dcommand_obj.obj_id)
AttributeError: 'QueryToolCommand' object has no attribute 'obj= _id'
=E2=80= =8BFixed.=E2=80=8B

5) When I run the query again in pgAdmin III, then refresh the data in
pgAdmin 4, the data_default_nulls column is displayed without the
[null] marker (despite having a null value, which I confirmed in
pgAdmin 3).
=E2=80=8B= Fixed.=E2=80=8B

I'm sure there are other combinations of issues here. Please fix and thoroughly re-test to ensure behaviour is consistent - and to avoid
future issues, please add some appropriate feature tests to check
nulls, defaults and empty strings are properly handled in view, insert
and updates. Murtuza recently wrote some feature tests for the query
tool - you should be able to use those as a starting point.
=E2=80=8BAdded feature tests=E2=80= =8B

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter:= @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreS= QL Company





--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company

--001a114712e2ffc2eb054f007db8--