Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkRVo-0006SQ-V6 for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 07:55:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkRVo-00010O-HZ for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 07:55:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkRVn-0000yL-RM for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 07:55:11 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkRVl-0004IX-99 for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 07:55:11 +0000 Received: by mail-wm0-x22a.google.com with SMTP id i130so85475000wmf.0 for ; Thu, 15 Sep 2016 00:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=iJT87S006DeEIqvWGRu3ln/YFp0g00PfdWpPt+SS4/E=; b=HfC0HI67Ox+vjSY//m1g8cDmQocM3TtmDZGgUiFN3/9JruPwTJA3e3QPmuViNGJYVm zdzdECOff1LMBbtP3MZqN3WPrFY3eZRJoye+ohgz+wx4fQ+Xw2MFGePlhUGW5N5fBk/6 XVzv98rlMWK8gG77SoT9kKHSe/3Wgx3EICfot5FL4fymJZrQD9o6KRgDnMoJLkL7amn3 5CsgYVAMNCaKeXuxc68PLx+UpE48CLWmcWMSsfrR8Ua8IkXPpEAjA2oXz8bBUMFpubj5 svoWZaf7kR8ETQCiwOrvQkanEHwt6ZINvXSbNY9ZV9/BEwkrC3ZTNzuTpIKoWX7vE0wr oqMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iJT87S006DeEIqvWGRu3ln/YFp0g00PfdWpPt+SS4/E=; b=BRsihzGfQkoZx1ZJI83nIIj0ZENtHVD6RPlIIUxfBHuk6QLc8iiKSK3OOAAbY2Evam +MkRrK1gnSQ3jFxWI4NFWoKyMPJeV+FogcRuVrIA2UEys55FZVhkFr5eck4vq8yUpsMQ A17kNBdlKSbCIoONUNMIeWm0d2EsRflHx/XscxrVxMGfSDW3v/plXgQ7bC8bpHIMuKa6 hW7vbruhu0calcNUELsIAgE9xwnnx7ZoEKxdPITODsxjK0TZHglktfZsm2ddP+LcE4v/ fl8vCOqh+qUQlZr9cFjog/AthIH02c9TFGcHlYf89/4ExdEMohHRfx1eLh7Yy+PjYSMa xeEA== X-Gm-Message-State: AE9vXwM88r7gMJEbCry73FrMsLo1v3wgEfrYpNX8B6enYqu+3yYdQss4llwkFmtjwZy/pe1FaumQqdjCkWcKESTB X-Received: by 10.28.46.204 with SMTP id u195mr1534789wmu.57.1473926107081; Thu, 15 Sep 2016 00:55:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Thu, 15 Sep 2016 00:54:36 -0700 (PDT) From: Surinder Kumar Date: Thu, 15 Sep 2016 13:24:36 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11423a7a0ad2ab053c872aea X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11423a7a0ad2ab053c872aea Content-Type: multipart/alternative; boundary=001a11423a7a0ad2a6053c872ae8 --001a11423a7a0ad2a6053c872ae8 Content-Type: text/plain; charset=UTF-8 Hi *Please find the attached patch patch with following changes:* 1) Implemented CodeMirror addon 'simplescrollbars'. 2) The CodeMirror instance of query tool was not rendering into wcDocker's *'pg-panel-content' div*. it renders outside the div, due to which it took little more time investigating why scrollbars doesn't appear in editor. 3) Add new css specific to query tool. Please review. Thanks, Surinder Kumar --001a11423a7a0ad2a6053c872ae8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Please find the att= ached patch patch with following changes:

1) Implemented CodeMirror addon '= ;simplescrollbars'.

2= ) The=C2=A0CodeMirror=C2=A0instance of query tool was not rendering into wc= Docker's 'pg-panel-content' div. it renders outside the = div, due to which it took little more time investigating why scrollbars doe= sn't appear in editor.

3) Add new css specific to query tool.


Please review.

Than= ks,
Surinder Ku= mar

<= /div> --001a11423a7a0ad2a6053c872ae8-- --001a11423a7a0ad2ab053c872aea Content-Type: application/octet-stream; name="RM1579.patch" Content-Disposition: attachment; filename="RM1579.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it41il8f0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9jc3Mvb3ZlcnJpZGVz LmNzcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9jc3Mvb3ZlcnJpZGVzLmNzcwpp bmRleCAxMjJjOTQyLi4xNTgwMTEwIDEwMDc1NQotLS0gYS93ZWIvcGdhZG1p bi9zdGF0aWMvY3NzL292ZXJyaWRlcy5jc3MKKysrIGIvd2ViL3BnYWRtaW4v c3RhdGljL2Nzcy9vdmVycmlkZXMuY3NzCkBAIC01Myw4ICs1Myw4IEBAIGlm cmFtZSB7CgogLyogRW5zdXJlIHRoZSBjb2RlbWlycm9yIGVkaXRvciBkaXNw bGF5cyBmdWxsIGhlaWdodCBndXR0ZXJzIHdoZW4gcmVzaXplZCAqLwogLkNv ZGVNaXJyb3IsIC5Db2RlTWlycm9yLWd1dHRlcnMgewotICAgIGhlaWdodDog MTAwJSAhaW1wb3J0YW50OwotfQorICAgIGhlaWdodDogMTAwJSAhaW1wb3J0 YW50OworfQoKIC8qIFBhZGRpbmcgZm9yIHRoZSB0cmVldmlldyAqLwogLmJy b3dzZXItYnJvd3Nlci1wYW5lIHsKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWlu L3RlbXBsYXRlcy9iYXNlLmh0bWwgYi93ZWIvcGdhZG1pbi90ZW1wbGF0ZXMv YmFzZS5odG1sCmluZGV4IDUzYWFmOGQuLmRiNzZmNjEgMTAwNzU1Ci0tLSBh L3dlYi9wZ2FkbWluL3RlbXBsYXRlcy9iYXNlLmh0bWwKKysrIGIvd2ViL3Bn YWRtaW4vdGVtcGxhdGVzL2Jhc2UuaHRtbApAQCAtNTAsNiArNTAsOCBAQAog ICAgICAgICAgIGhyZWY9Int7IHVybF9mb3IoJ3N0YXRpYycsIGZpbGVuYW1l PSdjc3Mvc2xpY2tncmlkL3NsaWNrLWRlZmF1bHQtdGhlbWUuY3NzJyl9fSIv PgogICAgIDxsaW5rIHR5cGU9InRleHQvY3NzIiByZWw9InN0eWxlc2hlZXQi CiAgICAgICAgICAgaHJlZj0ie3sgdXJsX2Zvcignc3RhdGljJywgZmlsZW5h bWU9J2Nzcy9zbGlja2dyaWQvc21vb3RobmVzcy9qcXVlcnktdWktMS4xMS4z LmN1c3RvbS5jc3MnIGlmIGNvbmZpZy5ERUJVRyBlbHNlICdjc3Mvc2xpY2tn cmlkL3Ntb290aG5lc3MvanF1ZXJ5LXVpLTEuMTEuMy5jdXN0b20ubWluLmNz cycpfX0iLz4KKyAgICA8bGluayB0eXBlPSJ0ZXh0L2NzcyIgcmVsPSJzdHls ZXNoZWV0IgorICAgICAgICAgIGhyZWY9Int7IHVybF9mb3IoJ3N0YXRpYycs IGZpbGVuYW1lPSdqcy9jb2RlbWlycm9yL2FkZG9uL3Njcm9sbC9zaW1wbGVz Y3JvbGxiYXJzLmNzcycpfX0iLz4KCiAgICAgPCEtLSBWaWV3IHNwZWNpZmll ZCBzdHlsZXNoZWV0cyAtLT4KICAgICB7JSBmb3Igc3R5bGVzaGVldCBpbiBj dXJyZW50X2FwcC5zdHlsZXNoZWV0cyAlfQpkaWZmIC0tZ2l0IGEvd2ViL3Bn YWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9jc3Mvc3FsZWRpdG9yLmNz cyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvY3NzL3Nx bGVkaXRvci5jc3MKaW5kZXggZGVhYzM2MC4uZTMwYjU2MiAxMDA2NDQKLS0t IGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9jc3Mvc3Fs ZWRpdG9yLmNzcworKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3Iv c3RhdGljL2Nzcy9zcWxlZGl0b3IuY3NzCkBAIC0xNTYsNiArMTU2LDE4IEBA CiAgICAgbWluLWhlaWdodDogMTAwJTsKIH0KCisvKiBDaGFuZ2VzIHNwZWNp ZmljIHRvIG91dHB1dCBwYW5lbCBvZiBxdWVyeSB0b29sICovCisjb3V0cHV0 LXBhbmVsLCAjb3V0cHV0LXBhbmVsIC5Db2RlTWlycm9yLCAjb3V0cHV0LXBh bmVsIC5Db2RlTWlycm9yLWd1dHRlcnMgeworICBoZWlnaHQ6IDEwMCUgIWlt cG9ydGFudDsKK30KKworI291dHB1dC1wYW5lbCAuQ29kZU1pcnJvci1ndXR0 ZXItd3JhcHBlciB7CisgIHdpZHRoOiA0M3B4OworICBoZWlnaHQ6IDIycHg7 CisgIGJvcmRlci1yaWdodDogMXB4IHNvbGlkICNkZGQgIWltcG9ydGFudDsK KyAgYmFja2dyb3VuZDogI2Y3ZjdmNyAhaW1wb3J0YW50OworfQorCiAuQ29k ZU1pcnJvci1mb2xkZ3V0dGVyIHsKICAgd2lkdGg6IC45ZW07CiB9CmRpZmYg LS1naXQgYS93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVz L3NxbGVkaXRvci9qcy9zcWxlZGl0b3IuanMgYi93ZWIvcGdhZG1pbi90b29s cy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRvci9qcy9zcWxlZGl0b3Iu anMKaW5kZXggNzUyMDVkMy4uZDgxZTc5ZCAxMDA2NDQKLS0tIGEvd2ViL3Bn YWRtaW4vdG9vbHMvc3FsZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMv c3FsZWRpdG9yLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRv ci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcwpAQCAtNyw3 ICs3LDcgQEAgZGVmaW5lKAogICAgICdjb2RlbWlycm9yL2FkZG9uL3NlbGVj dGlvbi9hY3RpdmUtbGluZScsCiAgICAgJ2NvZGVtaXJyb3IvYWRkb24vZm9s ZC9mb2xkZ3V0dGVyJywgJ2NvZGVtaXJyb3IvYWRkb24vZm9sZC9mb2xkY29k ZScsCiAgICAgJ2NvZGVtaXJyb3IvYWRkb24vaGludC9zaG93LWhpbnQnLCAn Y29kZW1pcnJvci9hZGRvbi9oaW50L3NxbC1oaW50JywKLSAgICAnY29kZW1p cnJvci9hZGRvbi9mb2xkL3BnYWRtaW4tc3FsZm9sZGNvZGUnLAorICAgICdj b2RlbWlycm9yL2FkZG9uL2ZvbGQvcGdhZG1pbi1zcWxmb2xkY29kZScsJ2Nv ZGVtaXJyb3IvYWRkb24vc2Nyb2xsL3NpbXBsZXNjcm9sbGJhcnMnLAogICAg ICdiYWNrZ3JpZC5zaXplYWJsZS5jb2x1bW5zJywgJ3djZG9ja2VyJywgJ3Bn YWRtaW4uZmlsZV9tYW5hZ2VyJwogICBdLAogICBmdW5jdGlvbigKQEAgLTE5 MSw5ICsxOTEsOSBAQCBkZWZpbmUoCiAgICAgICAgIHNxbF9wYW5lbC5sb2Fk KG1haW5fZG9ja2VyKTsKICAgICAgICAgdmFyIHNxbF9wYW5lbF9vYmogPSBt YWluX2RvY2tlci5hZGRQYW5lbCgnc3FsX3BhbmVsJywgd2NEb2NrZXIuRE9D Sy5UT1ApOwoKLSAgICAgICAgdmFyIG91dHB1dF9jb250YWluZXIgPSAkKCc8 ZGl2IGlkPSJvdXRwdXQtcGFuZWwiPjwvZGl2PicpOwotICAgICAgICB2YXIg dGV4dF9jb250YWluZXIgPSAkKCc8dGV4dGFyZWEgaWQ9InNxbF9xdWVyeV90 b29sIj48L3RleHRhcmVhPicpLmFwcGVuZChvdXRwdXRfY29udGFpbmVyKTsK LSAgICAgICAgc3FsX3BhbmVsX29iai5sYXlvdXQoKS5hZGRJdGVtKHRleHRf Y29udGFpbmVyKTsKKyAgICAgICAgdmFyIHRleHRfY29udGFpbmVyID0gJCgn PHRleHRhcmVhIGlkPSJzcWxfcXVlcnlfdG9vbCI+PC90ZXh0YXJlYT4nKTsK KyAgICAgICAgdmFyIG91dHB1dF9jb250YWluZXIgPSAkKCc8ZGl2IGlkPSJv dXRwdXQtcGFuZWwiPjwvZGl2PicpLmFwcGVuZCh0ZXh0X2NvbnRhaW5lcik7 CisgICAgICAgIHNxbF9wYW5lbF9vYmouJGNvbnRhaW5lci5maW5kKCcucGct cGFuZWwtY29udGVudCcpLmFwcGVuZChvdXRwdXRfY29udGFpbmVyKTsKCiAg ICAgICAgIHNlbGYucXVlcnlfdG9vbF9vYmogPSBDb2RlTWlycm9yLmZyb21U ZXh0QXJlYSh0ZXh0X2NvbnRhaW5lci5nZXQoMCksIHsKICAgICAgICAgICAg IGxpbmVOdW1iZXJzOiB0cnVlLApAQCAtMjEwLDcgKzIxMCw4IEBAIGRlZmlu ZSgKICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICBndXR0ZXJzOiBbIkNv ZGVNaXJyb3ItbGluZW51bWJlcnMiLCAiQ29kZU1pcnJvci1mb2xkZ3V0dGVy Il0sCiAgICAgICAgICAgICBleHRyYUtleXM6IHBnQnJvd3Nlci5lZGl0b3Jf c2hvcnRjdXRfa2V5cywKLSAgICAgICAgICAgIHRhYlNpemU6IHBnQWRtaW4u QnJvd3Nlci5lZGl0b3Jfb3B0aW9ucy50YWJTaXplCisgICAgICAgICAgICB0 YWJTaXplOiBwZ0FkbWluLkJyb3dzZXIuZWRpdG9yX29wdGlvbnMudGFiU2l6 ZSwKKyAgICAgICAgICAgIHNjcm9sbGJhclN0eWxlOiAnc2ltcGxlJwogICAg ICAgICB9KTsKCiAgICAgICAgIC8vIENyZWF0ZSBwYW5lbHMgZm9yICdEYXRh IE91dHB1dCcsICdFeHBsYWluJywgJ01lc3NhZ2VzJyBhbmQgJ0hpc3Rvcnkn Cg== --001a11423a7a0ad2ab053c872aea Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11423a7a0ad2ab053c872aea--