public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM1674 - Reverse engineered SQL for functions with default values is incorrect
Date: Wed, 14 Sep 2016 15:53:09 +0530
Message-ID: <CAM5-9D9_=QN8=jTAdfTKwMVacpUyHsA8doQCN+8FB_x9o=QXBg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoz1ck9EXMoAoHS0imtC_92xNs7WfNNXZSNKFBtAXJvA_w@mail.gmail.com>
References: <CAM5-9D9RGfpc0yjt_6gcot3-+r31iFDz91YZYSxTrGRiqyL35Q@mail.gmail.com>
	<CA+OCxoz1ck9EXMoAoHS0imtC_92xNs7WfNNXZSNKFBtAXJvA_w@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Wed, Sep 14, 2016 at 3:30 PM, Dave Page <[email protected]> wrote:

> Thanks - committed with a couple of minor formatting tweaks:
>
> - Remove the leading space before arguments (e.g. s/, /\r\t/ instead
> of s/,/\r\t/)
> - Put the first argument on a new line as well.

​It seems fine except the case when there are no arguments, the closing
bracket ends in next line. Is it ok?

>
> Please double-check I didn't break anything that I've missed!
>
It doesn't break anything
​.​

>
> On Tue, Sep 13, 2016 at 12:41 PM, Surinder Kumar
> <[email protected]> wrote:
> > Hi
> >
> > Patch with following changes:
> >
> > 1) In SQL pane, the signature in comments had arguments with name and
> type,
> > Now it will show arguments with type only.
> >
> > 2) There is no indent+newline between arguments (there isn't even a
> space).
> > - Fixed
> >
> > 3) The default value for the last argument is omitted. - Fixed
> > Last argument is omitted because the value for the last argument we got
> from
> > table is empty.
> > Now we form function signature in the get_definition.sql using
> > 'pg_catalog.pg_get_function_arguments' method.
> >
> > Above changes will reflect in Functions, Procedures & Trigger function
> > Nodes.
> >
> > Please review attached patch.
> >
> > Thanks,
> > Surinder Kumar
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list ([email protected])
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM1674 - Reverse engineered SQL for functions with default values is incorrect
  In-Reply-To: <CAM5-9D9_=QN8=jTAdfTKwMVacpUyHsA8doQCN+8FB_x9o=QXBg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox