Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ao75t-0007g2-GP for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Apr 2016 10:23:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ao75s-0006GM-UG for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Apr 2016 10:23:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ao75f-0005jA-1c for pgadmin-hackers@postgresql.org; Thu, 07 Apr 2016 10:23:07 +0000 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ao75b-0005nb-5y for pgadmin-hackers@postgresql.org; Thu, 07 Apr 2016 10:23:06 +0000 Received: by mail-wm0-x235.google.com with SMTP id l6so18878581wml.1 for ; Thu, 07 Apr 2016 03:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JFcJDaJljsupiEiWohqx9hAoHIK825bXEi5UIh39EJY=; b=gNZ3Pm/G3BeYcCdlPyS8+H8xS2lm9Ok8No9Oq5fhdTRzEXqgFKR8cLYA4eiz+XnQFd l5mzXQOwQgT3pymN4KFc2AIdxETwT1iBs5WWIjyJ80MDT8ZjvHNFenHQbpNKklztK2KK cBz+HUDMMaqulGZz2MiKFWfGBbaApQRlqZU53RDwj7BM0DYqbxIP/Fz/BMhlo7VRL/EG ioWXQkViuEWorbY0Jh2OsQmG5T8erJdoPz+FU65w3eyHAaOpME9hvLf7lX4D1AsXao4p wj2dsQTflNX1+RRd/bPK4BXp/CaRyJ4DYbFqSa3CVXTsjJ5ak2vO7tmQPvJ8k9WuSbad KdZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JFcJDaJljsupiEiWohqx9hAoHIK825bXEi5UIh39EJY=; b=c0IYPdVjYLTKEK1gAw/9oeyb8lDf7RSOnfOnCHtDgslYaPOWe8aTsmEq7bjFf7hsli RvnlD/QCINuOOC4gu6DDzi4sD4ahkFgu5H65NHcrOiFOaj+HtiZQ1bYBZcmqwFw4GqQA LfUTsgl7Zxj622BmAslq4S8viPdiUMxJYUh5WMLpFRWRN7G2eCsj7TggyInd2mpO7gxR 88U42LndlVi4iH5+Ha+1zAuuf33d17Jxj+nZjmrbzCzjNF/MMtTyq8SsgFv/tnTVK70C XzpLKLIB1Terke5YywCR//KEoqhsQRTx557H5bVXUa3sBRZdL5D1s+GECPi/Fi/g2dN7 Mnsg== X-Gm-Message-State: AD7BkJL57wwNnfUp1am5g23VTZK9PEBzjPyHVs44QE4TBR/PiQ4ES6RHks2j039V8whsQHt4jQXboW+YWC93POlh X-Received: by 10.194.92.163 with SMTP id cn3mr841283wjb.3.1460024582372; Thu, 07 Apr 2016 03:23:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.55.9 with HTTP; Thu, 7 Apr 2016 03:22:32 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Thu, 7 Apr 2016 15:52:32 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7bfceec6989187052fe27658 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bfceec6989187052fe27658 Content-Type: text/plain; charset=UTF-8 It seems you forgot to attach screenshot. Please send. On Thu, Apr 7, 2016 at 3:44 PM, Dave Page wrote: > Hi > > On Thu, Apr 7, 2016 at 8:45 AM, Surinder Kumar > wrote: > > Hi, > > > > PFA minor patch for PrivilegeRoleModel > > > > Change: Add check to disable PrivilegeRoleModel fields for nodes visible > > under catalog. > > > > Please review the patch. > > I'm unclear what this is supposed to do: > > - Those fields already seem to be disabled under catalog nodes (though > - the Add button on subnode grids is still active, but doesn't do > anything) > > - Shouldn't we just hide privilege info on those nodes directly? Why > break modularity for this? > > - I'm seeing weird effects after applying this patch - see the > attached screenshot. However, that issue remains even after I remove > it again (and restart the server, and hard-reload). It does seem to > fix itself eventually, but I'm not sure what causes that. If I try to > refresh the Functions node, I get: > > jquery.contextMenu.js:309 No items specified to show in > contextMenuhandle.contextmenu @ > jquery.contextMenu.js:309jQuery.event.dispatch @ > jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333 > jquery.contextMenu.js:312 Uncaught Error: No Items > specifiedhandle.contextmenu @ > jquery.contextMenu.js:312jQuery.event.dispatch @ > jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333 > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --047d7bfceec6989187052fe27658 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
It seems you forgot to attach screenshot.
Please send.=

On Th= u, Apr 7, 2016 at 3:44 PM, Dave Page <dpage@pgadmin.org> wro= te:
Hi

On Thu, Apr 7, 2016 at 8:45 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi,
>
> PFA minor patch for PrivilegeRoleModel
>
> Change: Add check to disable PrivilegeRoleModel fields for nodes visib= le
> under catalog.
>
> Please review the patch.

I'm unclear what this is supposed to do:

- Those fields already seem to be disabled under catalog nodes (though
- the Add button on subnode grids is still active, but doesn't do
anything)

- Shouldn't we just hide privilege info on those nodes directly? Why break modularity for this?

- I'm seeing weird effects after applying this patch - see the
attached screenshot. However, that issue remains even after I remove
it again (and restart the server, and hard-reload). It does seem to
fix itself eventually, but I'm not sure what causes that. If I try to refresh the Functions node, I get:

jquery.contextMenu.js:309 No items specified to show in
contextMenuhandle.contextmenu @
jquery.contextMenu.js:309jQuery.event.dispatch @
jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333
jquery.contextMenu.js:312 Uncaught Error: No Items
specifiedhandle.contextmenu @
jquery.contextMenu.js:312jQuery.event.dispatch @
jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--047d7bfceec6989187052fe27658--