Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnOIz-0003va-Hq for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 11:06:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bnOIy-00059v-8W for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Sep 2016 11:06:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bnOIj-0004sZ-PN for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 11:05:53 +0000 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bnOIZ-0004vN-GB for pgadmin-hackers@postgresql.org; Fri, 23 Sep 2016 11:05:52 +0000 Received: by mail-wm0-x236.google.com with SMTP id 197so4711550wmk.1 for ; Fri, 23 Sep 2016 04:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=J1qgA/jdy44/xTGXOB1oONzPxI2WxDMybtVHr4l3dtk=; b=KP4o8dg0hGMQrtf+Yq89OwIMr7AIqL01bDo+9Nfm9drfLT5cLfXVGAzo4A8le6r6gd AaUfG94z7CT3TRRPCqUBL46bpfCKEtdZz4ZoasXuaeg4SCvz7C/9Z9XKTP1ATkleM+JC 8J2+hNQnv9hZ1PPVCUkR8/S09XQHOI2gKJDOmmvqr72KT8soj9isksYHDAkNM4hgVLA2 25QJejZaWxhvk0MRQjVkxJWQYLlBuf35aEo3Iel8vfRAhXszYEBgR1OVYvqEtGK1iNa8 +5hksmnW4vJbww/ffT1sUjiQiOYA635Y/ZtTue3aBwKe4xBdKtEqekkdrLDH+NEazjIh EwqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=J1qgA/jdy44/xTGXOB1oONzPxI2WxDMybtVHr4l3dtk=; b=YXZQiSqYviQxjdJLK09Cnqy59q4iBDG8gDcRaI2Lk3k0U4Ai1Kvtdnmbf/oypj3GfV cE7BlPXMqxzoXIZU7XtuejRHObKs0ARJ6cNzFLd24kxoAubXFI2vBv9y3Taf+3r4QBZB T/EFbQSg/WY1duO5q3ZYlSKfPPwiN9k9owhJUEDjKrnwoMBhorjhZSYd9FyigipuxrKM ahfRx0guQu+fgdL+3b+wp5Zmd9LGb78kk0p0JoJWHxiT6QcDMaVAzzgl379XQj04ejqa giCiNEhZ2M7q/ImqxhPK9txPAQhfbBrvXYRmzet4bVPvqXFIcHodWeQUnIBA8R7m35rV wO6A== X-Gm-Message-State: AA6/9RmMRUCt0SYNeqF+HN7p7scsNxoBFyQy5lWVote/EYvwEMfuQ83zgzrg+PqR9AVTKUbxTyi02/MNmJ8HTnFJ X-Received: by 10.28.16.148 with SMTP id 142mr2124797wmq.5.1474628742427; Fri, 23 Sep 2016 04:05:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Fri, 23 Sep 2016 04:05:11 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Fri, 23 Sep 2016 16:35:11 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1145b4525e7e71053d2ac261 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145b4525e7e71053d2ac261 Content-Type: multipart/alternative; boundary=001a1145b4525e7e6c053d2ac25f --001a1145b4525e7e6c053d2ac25f Content-Type: text/plain; charset=UTF-8 Hi, Please find updated patch with changes: 1) On debugging through JS files, the issue was in synonym update method which wasn't returning node object. 2) retrieving schema name in node.sql for creating node object in update method. Please review and let me know for comments. On Fri, Sep 23, 2016 at 2:44 PM, Dave Page wrote: > Hi > > On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar > wrote: > > Hi > > > > Issue: > > on updating node, we deselect and then again select the node updated to > > refresh the panel. but it needs some delay of few milliseconds between > > deselect and select to fix this issue. > > > > Please find attached patch and review. > > This does not resolve the issue for me. I tested using a synonym to a > package on EPAS 9.5, by changing the target package name. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1145b4525e7e6c053d2ac25f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,=

Please find updated patc= h with changes:
1) On debugging through JS files, the issue was in synonym update method w= hich wasn't returning node object.
2) retrieving schema name in node.sql for creating = node object in update method.

Please review and let me know for comments.

On Fri, Sep 23, 2016 at 2:44 PM,= Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi
>
> Issue:
> on updating node, we deselect and then again select the node updated t= o
> refresh the panel. but it needs some delay of few milliseconds between=
> deselect and select to fix this issue.
>
> Please find attached patch and review.

This does not resolve the issue for me. I tested using a synonym to = a
package on EPAS 9.5, by changing the target package name.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1145b4525e7e6c053d2ac25f-- --001a1145b4525e7e71053d2ac261 Content-Type: application/octet-stream; name="RM1728_v1.patch" Content-Disposition: attachment; filename="RM1728_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itfnuxt90 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3N5bm9ueW1zL19faW5pdF9f LnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvc3lub255bXMvX19pbml0X18ucHkKaW5k ZXggOTVlNThiNi4uMmQyZTQwZiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvc3lub255bXMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMv c3lub255bXMvX19pbml0X18ucHkKQEAgLTQ4MywxNCArNDgzLDIzIEBAIGNs YXNzIFN5bm9ueW1WaWV3KFBHQ2hpbGROb2RlVmlldyk6CiAgICAgICAgICAg ICAgICAgaWYgbm90IHN0YXR1czoKICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIGludGVybmFsX3NlcnZlcl9lcnJvcihlcnJvcm1zZz1yZXMpCgotICAg ICAgICAgICAgICAgIHJldHVybiBtYWtlX2pzb25fcmVzcG9uc2UoCi0gICAg ICAgICAgICAgICAgICAgIHN1Y2Nlc3M9MSwKLSAgICAgICAgICAgICAgICAg ICAgaW5mbz0iU3lub255bSB1cGRhdGVkIiwKLSAgICAgICAgICAgICAgICAg ICAgZGF0YT17Ci0gICAgICAgICAgICAgICAgICAgICAgICAnaWQnOiBzeWlk LAotICAgICAgICAgICAgICAgICAgICAgICAgJ3NjaWQnOiBzY2lkLAotICAg ICAgICAgICAgICAgICAgICAgICAgJ2RpZCc6IGRpZAotICAgICAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgU1FMID0gcmVuZGVyX3RlbXBs YXRlKAorICAgICAgICAgICAgICAgICAgICAiLyIuam9pbihbc2VsZi50ZW1w bGF0ZV9wYXRoLCAnbm9kZXMuc3FsJ10pLAorICAgICAgICAgICAgICAgICAg ICBzY2lkPXNjaWQKKyAgICAgICAgICAgICAgICApCisKKyAgICAgICAgICAg ICAgICBzdGF0dXMsIHJzZXQgPSBzZWxmLmNvbm4uZXhlY3V0ZV8yZGFycmF5 KFNRTCkKKyAgICAgICAgICAgICAgICBpZiBub3Qgc3RhdHVzOgorICAgICAg ICAgICAgICAgICAgICByZXR1cm4gaW50ZXJuYWxfc2VydmVyX2Vycm9yKGVy cm9ybXNnPXJzZXQpCisgICAgICAgICAgICAgICAgcm93ID0gcnNldFsncm93 cyddWzBdCisKKyAgICAgICAgICAgICAgICByZXR1cm4ganNvbmlmeSgKKyAg ICAgICAgICAgICAgICAgICAgbm9kZT1zZWxmLmJsdWVwcmludC5nZW5lcmF0 ZV9icm93c2VyX25vZGUoCisgICAgICAgICAgICAgICAgICAgICAgICBzeWlk LAorICAgICAgICAgICAgICAgICAgICAgICAgcm93WydzY2hlbWEnXSwKKyAg ICAgICAgICAgICAgICAgICAgICAgIHJvd1snbmFtZSddLAorICAgICAgICAg ICAgICAgICAgICAgICAgaWNvbj0iaWNvbi0lcyIgJSBzZWxmLm5vZGVfdHlw ZQorICAgICAgICAgICAgICAgICAgICApCiAgICAgICAgICAgICAgICAgKQog ICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICByZXR1cm4gbWFr ZV9qc29uX3Jlc3BvbnNlKApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMv c3lub255bXMvdGVtcGxhdGVzL3N5bm9ueW0vc3FsLzkuMV9wbHVzL25vZGVz LnNxbCBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3N5bm9ueW1zL3RlbXBsYXRlcy9zeW5v bnltL3NxbC85LjFfcGx1cy9ub2Rlcy5zcWwKaW5kZXggMWY4MjU5Yi4uNDJj YWY0MCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJf Z3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvc3lub255bXMvdGVt cGxhdGVzL3N5bm9ueW0vc3FsLzkuMV9wbHVzL25vZGVzLnNxbAorKysgYi93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvc2NoZW1hcy9zeW5vbnltcy90ZW1wbGF0ZXMvc3lub255bS9zcWwv OS4xX3BsdXMvbm9kZXMuc3FsCkBAIC0xLDQgKzEsNCBAQAotU0VMRUNUIHN5 bm5hbWUgYXMgbmFtZQorU0VMRUNUIHN5bm5hbWUgYXMgbmFtZSwgc3lubmFt ZXNwYWNlIGFzIHNjaGVtYQogRlJPTSBwZ19zeW5vbnltIHMKICAgICBKT0lO IHBnX25hbWVzcGFjZSBucyBPTiBzLnN5bm5hbWVzcGFjZSA9IG5zLm9pZAog ICAgIEFORCBzLnN5bm5hbWVzcGFjZSA9IHt7c2NpZH19OjpvaWQKZGlmZiAt LWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3N5bm9ueW1zL3RlbXBsYXRlcy9zeW5v bnltL3NxbC85LjVfcGx1cy9ub2Rlcy5zcWwgYi93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9z eW5vbnltcy90ZW1wbGF0ZXMvc3lub255bS9zcWwvOS41X3BsdXMvbm9kZXMu c3FsCmluZGV4IDFmODI1OWIuLjQyY2FmNDAgMTAwNjQ0Ci0tLSBhL3dlYi9w Z2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNl cy9zY2hlbWFzL3N5bm9ueW1zL3RlbXBsYXRlcy9zeW5vbnltL3NxbC85LjVf cGx1cy9ub2Rlcy5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2 ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvc3lub255bXMv dGVtcGxhdGVzL3N5bm9ueW0vc3FsLzkuNV9wbHVzL25vZGVzLnNxbApAQCAt MSw0ICsxLDQgQEAKLVNFTEVDVCBzeW5uYW1lIGFzIG5hbWUKK1NFTEVDVCBz eW5uYW1lIGFzIG5hbWUsIHN5bm5hbWVzcGFjZSBhcyBzY2hlbWEKIEZST00g cGdfc3lub255bSBzCiAgICAgSk9JTiBwZ19uYW1lc3BhY2UgbnMgT04gcy5z eW5uYW1lc3BhY2UgPSBucy5vaWQKICAgICBBTkQgcy5zeW5uYW1lc3BhY2Ug PSB7e3NjaWR9fTo6b2lkCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93 c2VyL3RlbXBsYXRlcy9icm93c2VyL2pzL2Jyb3dzZXIuanMgYi93ZWIvcGdh ZG1pbi9icm93c2VyL3RlbXBsYXRlcy9icm93c2VyL2pzL2Jyb3dzZXIuanMK aW5kZXggNDZjNDljZi4uMzY1MmVjNSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRt aW4vYnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9icm93c2VyLmpzCisr KyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jyb3dzZXIvanMv YnJvd3Nlci5qcwpAQCAtMTE0OCw3ICsxMTQ4LDggQEAgZnVuY3Rpb24ocmVx dWlyZSwgJCwgXywgUywgQm9vdHN0cmFwLCBwZ0FkbWluLCBBbGVydGlmeSwg Q29kZU1pcnJvcikgewogICAgICAgICAgICAgaWYgKAogICAgICAgICAgICAg ICB0aGlzLmkgJiYgdGhpcy5kICYmIHRoaXMubmV3Ll90eXBlID09IHRoaXMu ZC5fdHlwZQogICAgICAgICAgICAgKSB7Ci0gICAgICAgICAgICAgIHZhciBf aWQgPSB0aGlzLmQuX2lkOworICAgICAgICAgICAgICB2YXIgc2VsZiA9IHRo aXMsCisgICAgICAgICAgICAgIF9pZCA9IHRoaXMuZC5faWQ7CiAgICAgICAg ICAgICAgIGlmICh0aGlzLm5ldy5faWQgIT0gdGhpcy5kLl9pZCkgewogICAg ICAgICAgICAgICAgIC8vIEZvdW5kIHRoZSBuZXcgb2lkLCB1cGRhdGUgaXRz IG5vZGVfaWQKICAgICAgICAgICAgICAgICB2YXIgbm9kZV9kYXRhID0gdGhp cy50Lml0ZW1EYXRhKGN0eC5pKTsKQEAgLTExNjIsNyArMTE2MywxMCBAQCBm dW5jdGlvbihyZXF1aXJlLCAkLCBfLCBTLCBCb290c3RyYXAsIHBnQWRtaW4s IEFsZXJ0aWZ5LCBDb2RlTWlycm9yKSB7CiAgICAgICAgICAgICAgICAgdGhp cy50LnNldElkKGN0eC5pZCwge2lkOiB0aGlzLm5ldy5pZH0pOwogICAgICAg ICAgICAgICAgIHRoaXMudC5vcGVuUGF0aCh0aGlzLmkpOwogICAgICAgICAg ICAgICAgIHRoaXMudC5kZXNlbGVjdCh0aGlzLmkpOwotICAgICAgICAgICAg ICAgIHRoaXMudC5zZWxlY3QodGhpcy5pKTsKKyAgICAgICAgICAgICAgICAv LyBzZWxlY3QgdHJlZSBpdGVtIGFmdGVyIGZldyBtaWxsaXNlY29uZHMKKyAg ICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAg ICAgICAgICAgICAgc2VsZi50LnNlbGVjdChzZWxmLmkpOworICAgICAgICAg ICAgICAgIH0sIDEwKTsKICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg fQogICAgICAgICAgICAgdmFyIHN1Y2Nlc3MgPSB0aGlzLm8gJiYgdGhpcy5v LnN1Y2Nlc3M7Cg== --001a1145b4525e7e71053d2ac261 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1145b4525e7e71053d2ac261--