Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjKcs-00050L-Vc for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 06:21:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjKcs-0005h0-FB for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 06:21:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjKcf-0005Sc-2z for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 06:21:41 +0000 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjKcb-0004Hp-J5 for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 06:21:40 +0000 Received: by mail-wm0-x232.google.com with SMTP id b187so118655705wme.1 for ; Sun, 11 Sep 2016 23:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jW7x4YdRfkHoM5Ov/vccFAdyP66Lz53guGNe/v2Skeg=; b=RNAfcK0KARWinvhwU81frjsPc6yECxsoOr7GJexRS64zOCxIqh7t2JNnqdRpHBBgt7 Vq3JZfdLVFhqeKMAduauSbmG+pExM0wHWUtpjW+EfLr7lxfVJbBBMj/B2zKfI77OZGee KkoS7QJZxaSUBYyKz43TpkZXbB1X981efggTbR2UNE58ybXZMaLerQ5ycxjjBYy63Fdn JPnJ8KWNFE9XUfKXC6gGKc7ERgFgiSmlck+mcp9XefgP5S+xJswwdEq93rIk3HdqtHJ9 RjLpblBgfxBgur23gRkyLxZniuaG6TfFNo4allgH3tcTP62BBc1m/5As5a/rRuybbWtC s8ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jW7x4YdRfkHoM5Ov/vccFAdyP66Lz53guGNe/v2Skeg=; b=KDzsQJCC8+5j9HtmLtz3guAvTqjq73I+s8CqLgAys1AEqagjFPWtdrStn3c7wYZhUZ WMnMjlu1fFkYo5xND0VOHWokqOdRGxWhIe18wfe1LFHPBkCRHJCC0mQhvAT3KrE7WDrt fnRpKOQtzZQyqRiHDMhuGzZ95xGXPAVgHStCszOubzMhuPmyho7uTVH5/78CqFGLAZfE 5N7VBL3JCMIZKeO4rij1dUKAHxDtHp25XAUwaG2h2CGmV1KptPDnqbkeKNMsr3x39syl /ARqznFhc32Qvd5Bs7fIbPjXvR9X6B6JIIbzY6kOpnMLvBOUKnFA2Tdn0INu0X5FGI1b wKwA== X-Gm-Message-State: AE9vXwP4rNIVsY1swQZtG5tmndEhUg+AMd8IiCDyf/Jxcb91jdDogio/NLIKNjhm6K2Ttc+fSMVSp56K8vpgFzrq X-Received: by 10.194.83.33 with SMTP id n1mr12666296wjy.36.1473661296638; Sun, 11 Sep 2016 23:21:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Sun, 11 Sep 2016 23:21:06 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Mon, 12 Sep 2016 11:51:06 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7bb04d7e1b1477053c498281 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bb04d7e1b1477053c498281 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 12, 2016 at 11:13 AM, Murtuza Zabuawala wrote: > Hi Surinder, > > Just a heads up, When server is not connected and listed down in browser > tree then node has attribute 'type' instead of 'server_type'. > I have fixed similar issue few days ago Ref. link > > Yup this was a =E2=80=8Bbug . =E2=80=8B Previously, *server_type* was not returned=E2=80=8B on listing do= wn after disconnect then connect. And =E2=80=8B it has already been taken care in this commit=E2=80=8B . So, the check will work fine with *server_type=E2=80=8B. * > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Sep 12, 2016 at 10:42 AM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi >> >> *Please find attached with following fixes:* >> >> 1) The function '*canCreateProc*' that checks if package is auth to >> create under catalog gets failed due to improper check of 'type'. Instea= d >> check should be like >> node_hierarchy['server'].*server_type* =3D=3D "ppas" not >> node_hierarchy['server'].*type* =3D=3D "ppas" >> >> 2) Also found, *package.js* was loading at schema level, due to this, >> context menu doesn't popup under catalog. Now it is load at database lev= el. >> >> 3) In *package.js*, remove extra comma from columns array. >> >> 4) Rule create option should not available on table under catalogs. Fixe= d. >> >> Please review. >> >> Thanks, >> Surinder Kumar >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --047d7bb04d7e1b1477053c498281 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = Mon, Sep 12, 2016 at 11:13 AM, Murtuza Zabuawala <murtuza= .zabuawala@enterprisedb.com> wrote:
Hi Surinder,

Just a heads up, When server is not conn= ected and listed down in browser tree then node has attribute 'type'= ; instead of 'server_type'.
I have fixed similar issue few days = ago Ref. lin= k
=C2=A0Yup this was a=C2=A0
=E2=80=8Bbug
.
=E2=80=8B Previously, server_type<= /b> was not returned=E2=80=8B on listing down after disconnect then connect= .
=C2=A0And
=E2=80=8B
it has already been taken care in this commit=E2=80=8B.
=C2=A0So, the check will work fine with server_= type=E2=80=8B.=C2=A0
<= br clear=3D"all">
--
Regards,
Murtuza Zab= uawala
EnterpriseDB:=C2=A0h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>

On Mon, Sep 12, 2016 at 10:42 AM, = Surinder Kumar <surinder.kumar@enterprisedb.com>= wrote:
Hi

Please find attached= with following fixes:
1) The function 'canC= reateProc' that checks if package is auth to create under catalog g= ets failed due to improper check of 'type'. Instead check should be= like
node_hierarchy['server'].= server_type =3D=3D "ppas" not=C2=A0
node_hierarchy['server'].type=C2=A0=3D=3D "ppas"

2) Also found, package.js was loadi= ng at schema level, due to this, context menu doesn't popup under catal= og. Now it is load at database level.
<= br>
3) In package.js, remove ext= ra comma from columns array.

=
4) Rule create option should not available o= n table under catalogs. Fixed.

Please review.

Thanks,
Surinder Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--047d7bb04d7e1b1477053c498281--