Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmf5F-0008PE-Hr for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 10:48:57 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bmf5E-0000Tz-V4 for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 10:48:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmf5E-0000Tq-8u for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 10:48:56 +0000 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bmf57-0006TW-Bv for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 10:48:54 +0000 Received: by mail-wm0-x233.google.com with SMTP id l132so84101618wmf.1 for ; Wed, 21 Sep 2016 03:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=VuKLFzO18/dh87pKgeH9cJBn35IQfHo3YAkvJ/iNx6w=; b=RDW9V4ilbOPIFP0Jr86hhXz8nINc3E/r60Q9S513YpNxmTYHwYPbr2kKTHUNWj+fbn jLB6Ths2czGqQQpYofjLgZQNNLx1xcgr+p7ooDcHD2DRaxFEbbh/HW3VmSVvgsNFohXe QslCDfP/Rr+WLp4A/16xEk2s38lgi2JMZtTchWP7Xm6wZs5gCyLqy6JZ+TRviVYp9Pmi foULIy3uF7elzaSRW8eFRfhv0hTlH+FOi7TQxVVWV/xU7u5CGjfajtMJLzJ161ceT7c6 8ht6vTSvd2rPptiVgLlCqmsxwyXr/Uuy9E3cmJSdz5s1+Tn2OETMPjhE5TPQgxFr3Pq7 5bWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=VuKLFzO18/dh87pKgeH9cJBn35IQfHo3YAkvJ/iNx6w=; b=Ec5Mo9CQk+ULvH7BNm3UDDZ5mg4R/CWZXQiHAYVmaLopI49bt8opY4013HJvRKhy05 wcyHlj+sUAHTeJc07oj2+4HpFGqyYOHuDkFn3nJ8kXoIPT6y/Hn1usaReGRhYs3Viq6V 8unaEvakEoC1AqVekbfPaUp+57MMpGrjOLJ8LiU9AaS9m8c4PkNUj9oDdBYeM0lHq2ii f4ocFzFcxekG6c+dl3vg5H70/UziXZPKpWSWCTq8sqxGd1n5jT0Hv1amy8Koa/AxZ4Mh RoA5lNvls8pQpXDCPbMUVsF+NkG9PgClCnvK7N68absA5ymAkf4E0AnyuoHt7vo3Dx5P 58wA== X-Gm-Message-State: AE9vXwNEx8Kp+1fFUtsleZAFFtvcwjOF9Mkol11Qk/N76x69Ym3c2xnFGT9nsBUW6UYa+eCXHtAwwyZF2M447COM X-Received: by 10.28.94.18 with SMTP id s18mr2812160wmb.44.1474454926382; Wed, 21 Sep 2016 03:48:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Wed, 21 Sep 2016 03:48:15 -0700 (PDT) From: Surinder Kumar Date: Wed, 21 Sep 2016 16:18:15 +0530 Message-ID: Subject: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a11468e08200ad7053d024a39 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11468e08200ad7053d024a39 Content-Type: multipart/alternative; boundary=001a11468e08200ad2053d024a37 --001a11468e08200ad2053d024a37 Content-Type: text/plain; charset=UTF-8 Hi While working on RM*1391 *I found another issue* 'Backup is not working on windows".* The reason is that the process executor which uses subprocess Popen() to execute job fails when we pass close_fds=True and shell=False in windows. Now we are settings close_fds=False and shell=True to fix it. These settings are specific to windows only. Please review the attached patch. Thanks, Surinder Kumar --001a11468e08200ad2053d024a37 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

While working on RM139= 1 I found another issue 'Backup is not working on windows".=

The reason is that the process=C2=A0exe= cutor which uses subprocess Popen() to execute job fails when we pass=C2= =A0close_fds=3DTrue and=C2=A0shell=3DFalse in windows.

Now we are settin= gs close_fds=3DFalse and shell=3DTrue to fix it. These settings are specifi= c to windows only.

Please review the attached patch.


Thanks,
Surinder Kumar
--001a11468e08200ad2053d024a37-- --001a11468e08200ad7053d024a39 Content-Type: application/octet-stream; name="process_executor_not_running_in_win.patch" Content-Disposition: attachment; filename="process_executor_not_running_in_win.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itcsdc3u0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvYmdwcm9jZXNzL3Byb2Nl c3NfZXhlY3V0b3IucHkgYi93ZWIvcGdhZG1pbi9taXNjL2JncHJvY2Vzcy9w cm9jZXNzX2V4ZWN1dG9yLnB5CmluZGV4IGQ0ZmNkNTIuLjM3MTI3ZDIgMTAw NjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL21pc2MvYmdwcm9jZXNzL3Byb2Nlc3Nf ZXhlY3V0b3IucHkKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9iZ3Byb2Nlc3Mv cHJvY2Vzc19leGVjdXRvci5weQpAQCAtMzUsNyArMzUsNyBAQCBpbXBvcnQg b3MKIGltcG9ydCBhcmdwYXJzZQogaW1wb3J0IHNxbGl0ZTMKIGZyb20gZGF0 ZXRpbWUgaW1wb3J0IGRhdGV0aW1lCi1mcm9tIHN1YnByb2Nlc3MgaW1wb3J0 IFBvcGVuLCBQSVBFCitpbXBvcnQgc3VicHJvY2VzcwogZnJvbSB0aHJlYWRp bmcgaW1wb3J0IFRocmVhZAogaW1wb3J0IGNzdgogaW1wb3J0IHB5dHoKQEAg LTI5NSwxMCArMjk1LDIwIEBAIGRlZiBleGVjdXRlKGNvbmZpZ3MpOgogICAg ICAgICAgICAgaWYgYXJnc1sncGlkJ10gaW4gb3MuZW52aXJvbjoKICAgICAg ICAgICAgICAgICBvcy5lbnZpcm9uWydQR1BBU1NXT1JEJ10gPSBvcy5lbnZp cm9uW2FyZ3NbJ3BpZCddXQogCi0gICAgICAgICAgICBwcm9jZXNzID0gUG9w ZW4oCi0gICAgICAgICAgICAgICAgY29tbWFuZCwgc3Rkb3V0PVBJUEUsIHN0 ZGVycj1QSVBFLCBzdGRpbj1QSVBFLAotICAgICAgICAgICAgICAgIHNoZWxs PShvcy5uYW1lID09ICdudCcpLCBjbG9zZV9mZHM9KG9zLm5hbWUgIT0gJ250 JykKLSAgICAgICAgICAgICkKKyAgICAgICAgICAgIGlmIG9zLm5hbWUgPT0g J250JzoKKyAgICAgICAgICAgICAgICBzaSA9IHN1YnByb2Nlc3MuU1RBUlRV UElORk8oKQorICAgICAgICAgICAgICAgIHNpLmR3RmxhZ3MgPSBzdWJwcm9j ZXNzLlNXX0hJREUKKyAgICAgICAgICAgICAgICBzaS53U2hvd1dpbmRvdyA9 IDExCisgICAgICAgICAgICAgICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9w ZW4oCisgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQsIHN0ZG91dD1zdWJw cm9jZXNzLlBJUEUsIHN0ZGVycj1zdWJwcm9jZXNzLlBJUEUsCisgICAgICAg ICAgICAgICAgICAgIHN0ZGluPXN1YnByb2Nlc3MuUElQRSwgc2hlbGw9VHJ1 ZSwgY2xvc2VfZmRzPUZhbHNlLAorICAgICAgICAgICAgICAgICAgICBjcmVh dGlvbmZsYWdzPTB4MDgwMDAwMDAsIHN0YXJ0dXBpbmZvPXNpCisgICAgICAg ICAgICAgICAgKQorICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAg ICBwcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3BlbigKKyAgICAgICAgICAgICAg ICAgICAgY29tbWFuZCwgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwgc3RkZXJy PXN1YnByb2Nlc3MuUElQRSwKKyAgICAgICAgICAgICAgICAgICAgc3RkaW49 c3VicHJvY2Vzcy5QSVBFLCBzaGVsbD1GYWxzZSwgY2xvc2VfZmRzPVRydWUK KyAgICAgICAgICAgICAgICApCiAgICAgICAgICAgICB0cnk6CiAgICAgICAg ICAgICAgICAgZGVsIChvcy5lbnZpcm9uWydQR1BBU1NXT1JEJ10pCiAgICAg ICAgICAgICBleGNlcHQ6CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9taXNj L2JncHJvY2Vzcy9wcm9jZXNzZXMucHkgYi93ZWIvcGdhZG1pbi9taXNjL2Jn cHJvY2Vzcy9wcm9jZXNzZXMucHkKaW5kZXggZjNiYWIyNi4uYjdhYzgyZSAx MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vbWlzYy9iZ3Byb2Nlc3MvcHJvY2Vz c2VzLnB5CisrKyBiL3dlYi9wZ2FkbWluL21pc2MvYmdwcm9jZXNzL3Byb2Nl c3Nlcy5weQpAQCAtMTksNyArMTksNyBAQCBpbXBvcnQgc3lzCiBmcm9tIGFi YyBpbXBvcnQgQUJDTWV0YSwgYWJzdHJhY3Rwcm9wZXJ0eSwgYWJzdHJhY3Rt ZXRob2QKIGZyb20gZGF0ZXRpbWUgaW1wb3J0IGRhdGV0aW1lCiBmcm9tIHBp Y2tsZSBpbXBvcnQgZHVtcHMsIGxvYWRzCi1mcm9tIHN1YnByb2Nlc3MgaW1w b3J0IFBvcGVuLCBQSVBFCitpbXBvcnQgc3VicHJvY2VzcwogCiBpbXBvcnQg cHl0egogZnJvbSBkYXRldXRpbCBpbXBvcnQgcGFyc2VyCkBAIC0xOTEsOSAr MTkxLDEyIEBAIGNsYXNzIEJhdGNoUHJvY2VzcyhvYmplY3QpOgogICAgICAg ICBdCiAKICAgICAgICAgaWYgb3MubmFtZSA9PSAnbnQnOgotICAgICAgICAg ICAgcCA9IFBvcGVuKAotICAgICAgICAgICAgICAgIGNtZCwgc3Rkb3V0PU5v bmUsIHN0ZGVycj1Ob25lLCBzdGRpbj1Ob25lLCBjbG9zZV9mZHM9VHJ1ZSwK LSAgICAgICAgICAgICAgICBzaGVsbD1GYWxzZSwgY3JlYXRpb25mbGFncz0w eDAwMDAwMDA4CisgICAgICAgICAgICBzaSA9IHN1YnByb2Nlc3MuU1RBUlRV UElORk8oKQorICAgICAgICAgICAgc2kuZHdGbGFncyA9IHN1YnByb2Nlc3Mu U1dfSElERQorICAgICAgICAgICAgc2kud1Nob3dXaW5kb3cgPSAxMQorICAg ICAgICAgICAgcCA9IHN1YnByb2Nlc3MuUG9wZW4oCisgICAgICAgICAgICAg ICAgY21kLCBzdGRvdXQ9Tm9uZSwgc3RkZXJyPU5vbmUsIHN0ZGluPU5vbmUs IGNsb3NlX2Zkcz1GYWxzZSwKKyAgICAgICAgICAgICAgICBzaGVsbD1UcnVl LCBjcmVhdGlvbmZsYWdzPTB4MDAwMDAwMDh8MHgwODAwMDAwMCwgc3RhcnR1 cGluZm89c2kKICAgICAgICAgICAgICkKICAgICAgICAgZWxzZToKICAgICAg ICAgICAgIGRlZiBwcmVleGVjX2Z1bmN0aW9uKCk6CkBAIC0yMDMsOCArMjA2 LDggQEAgY2xhc3MgQmF0Y2hQcm9jZXNzKG9iamVjdCk6CiAgICAgICAgICAg ICAgICAgIyBFeHBsaWNpdGx5IGlnbm9yaW5nIHNpZ25hbHMgaW4gdGhlIGNo aWxkIHByb2Nlc3MKICAgICAgICAgICAgICAgICBzaWduYWwuc2lnbmFsKHNp Z25hbC5TSUdJTlQsIHNpZ25hbC5TSUdfSUdOKQogCi0gICAgICAgICAgICBw ID0gUG9wZW4oCi0gICAgICAgICAgICAgICAgY21kLCBzdGRvdXQ9UElQRSwg c3RkZXJyPU5vbmUsIHN0ZGluPU5vbmUsIGNsb3NlX2Zkcz1UcnVlLAorICAg ICAgICAgICAgcCA9IHN1YnByb2Nlc3MuUG9wZW4oCisgICAgICAgICAgICAg ICAgY21kLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFLCBzdGRlcnI9Tm9uZSwg c3RkaW49Tm9uZSwgY2xvc2VfZmRzPVRydWUsCiAgICAgICAgICAgICAgICAg c2hlbGw9RmFsc2UsIHByZWV4ZWNfZm49cHJlZXhlY19mdW5jdGlvbgogICAg ICAgICAgICAgKQogCg== --001a11468e08200ad7053d024a39 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a11468e08200ad7053d024a39--