Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSSLA-0001Oz-Kl for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 17:09:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bSSLA-0002Ab-7S for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 17:09:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bSSL9-00028u-3j for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 17:09:51 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bSSL5-00032r-LH for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 17:09:50 +0000 Received: by mail-wm0-x22e.google.com with SMTP id i5so72157117wmg.0 for ; Wed, 27 Jul 2016 10:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nNrYS7yVLOZAQxzfZykRmC9xEMl5JOlLu5n3PeliDsM=; b=PVC/pCOyhbQcBd7Icg87Ab6G3717KUlkDxYrOYWx0gbu8xBTxnNAKULDHniP+Mg9Lw EA+v1AWBkUfL2FgrCVzrN2ybgnrSvEtaXsnfvkN6yLKfqTu74JcGnHWro5uEvsv1eEZH JKG8SSIs43yu0R1OSP1g1wkpQlwCy/IfD97HeBcv1YhLGrlhNntVrIe+EKoryHr913AS 3f87SHylJGLi5ngxmIW1PXWwa+Y5A5jldHuGPIaLPsOwAzfFm6VlhCQzciwJJGwz8QOx TIF2I2G6ACAHUfCkE8SDQsh6zfnUPPHcBH3gmqLo9LjUbDuXXSME2xs9fKkP5flbsw8u gEmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nNrYS7yVLOZAQxzfZykRmC9xEMl5JOlLu5n3PeliDsM=; b=R5pqIp2N/hc2RIHIWmTLxDaGsTQTd63ump8nywYr7xKV3DVM58q6JKdcGHAUmsTfqu HC0YkpaN9vpwx+UwGIzw7Qr86WoX6fImwNqXt/MB8G4I2PVaqcRmO1UH/NzE+KotOMQz E2e5lGICTM+RPNWyZBzave0/8fORWhfM4VhlVAqczqDtanE72dcRvYmddbwR0JWqU5/t GJurHXeLJxK1OyscfcBbb7DRWjPefpFQkfWLU3UZgm8xD/cQ+zxbhgOFz24r7cY1FClz oghk5V1OlvFaaXcf5/s+A0UhYPHicG/VjT7c4wvTC4/lmoBSunepR+zEUhbVZS5/67+4 oRIA== X-Gm-Message-State: AEkoouvJfV8QTqHzxgIFrc5dt1G2TgmR9oYAaEh3guq84qC2N9rswfjt3Once4+vR4g7Puk/KUos89PwFx30ggyg X-Received: by 10.28.99.86 with SMTP id x83mr19605353wmb.95.1469639386657; Wed, 27 Jul 2016 10:09:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.54.164 with HTTP; Wed, 27 Jul 2016 10:09:16 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 27 Jul 2016 22:39:16 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Using F5 for Query Execution in Query tool To: Dave Page , pgadmin-hackers Cc: Ashesh Vashi , Harshal Dhumal Content-Type: multipart/mixed; boundary=001a1148dfd6979e430538a115de X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1148dfd6979e430538a115de Content-Type: multipart/alternative; boundary=001a1148dfd6979e3f0538a115dc --001a1148dfd6979e3f0538a115dc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Please find attached patch with following fixes: 1) This patch adds support for Function Keys(F5, F7, F8) as keyboard shortcuts. Following are the keyboard shortcuts for query tool operations such as: - Execute query --> *F5* - Explain query --> *F7* - Explain analyze query --> *Shift + F7* - Download query result as CSV --> *F8* 2) Add proper condition to check string in JS array in explain analyze. The code breaks while running explain analyse. This patch partially resolves *RM1478*. Please review. On Wed, Jul 27, 2016 at 5:48 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > On Wed, Jul 27, 2016 at 2:31 PM, Dave Page wrote: > > > > > > Hi > > > > On Tue, Jul 26, 2016 at 7:13 PM, Surinder Kumar > > wrote: > > > Hi Dave > > > > > > I spend some time looking at RM#1412 - Function Keys in Query Tool > specific > > > to execute query using F5 key. > > > > Please note that RM1412 was rejected. 1478 is where we're tracking all > > the shortcut issues now. > > > > > As we know F5 key is bound to reload/refresh for browsers on Linux & > > > Windows. > > > But If we use F5 key to execute query, then F5 key event is first > captured > > > inside the code and execution works. > > > > OK. > > > > > It will not affect the browser reload behaviour. F5 key for execution > will > > > only work if focus is on Query tool. > > > > > > Ashesh's concern is: > > > If focus is not on query tool and user mistakenly pressed Fn+F5 key, > the > > > page will reload which shouldn't happened. > > > > > > In such case: > > > The page doesn't reload directly as we always ask user "Whether to > Stay on > > > page or Leave page". > > > > Right. > > > > > The other way is to disable reload page on F5 Key only when focus is > inside > > > the app. > > > If focus is on browser then F5 for reload will work. (not a good idea) > > > > > > @Dave What do you think? > > > > On Mac it works nicely, both in the runtime and in Chrome, Safari and > > Firefox - and given the number of people complaining about the > > shortcuts here, I think the limitation of focus on the text box is > > acceptable. > > > > > I have tested this attached patch on following platforms without any > issue: > > > Windows 7 - Runtime & IE 9 & 10. > > > Mac OSX Yosemite - Safari(8.0.3), Chrome(51) & Firefox(47) > > > Ubuntu-14.04.2 - Chrome & Firefox. > > > > > > Please review the patch. > > > > The patch doesn't update the tooltips/buttons/menus to display the > > correct shortcuts - plus, if we're doing this for F5, then I think we > > should also keep F7 for Explain, Shift+F7 for Explain Analyse and F8 > > for Execute to File (CSV Downlaod), like pgAdmin 3. > Tooltips/buttons/menus are updated with correct shortcuts keys in attached patch.=E2=80=8B > =E2=80=8BI will send a patch later today.=E2=80=8B > > > > > > > > Please note though that that would only partially resolve RM1478. On > > some browsers/platforms, there is also some CodeMirror related > > shortcut weirdness that needs to be resolved. It may be worth seeing > > if a CodeMirror update would help. > Okay > > > > Thanks! > > > > -- > > Dave Page > > Blog: http://pgsnake.blogspot.com > > Twitter: @pgsnake > > > > EnterpriseDB UK: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > --001a1148dfd6979e3f0538a115dc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Please find attached patc= h with following fixes:

1= ) This patch adds support for Function Keys(F5, F7, F8) as keyboard shortcu= ts.
Following a= re the keyboard shortcuts for query tool operations such as:
  • Execute query -->=C2=A0F5
  • Explain query -->= ; F7
  • Explain analyze query -->=C2=A0Shift + F7=
  • Download query result as CSV -->=C2=A0F8
2= ) Add proper condition to check string in JS array in explain analyze. The = code breaks while running explain analyse.

This patch partially resolves RM1= 478.

Please review.<= /div>

= On Wed, Jul 27, 2016 at 5:48 PM, Surinder Kumar <surinder.ku= mar@enterprisedb.com> wrote:
On Wed, Jul 27, 2016 at 2:31 PM, Dave Page <dpage@pgadmin.org> wrote:

>

> Hi
>
> On Tue, Jul 26, 2016 at 7:13 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
> > Hi Dave
> >
> > I spend some time looking at RM#1412 - Function Keys in Query Too= l specific
> > to execute query using F5 key.
>
> Please note that RM1412 was rejected. 1478 is where we're tracking= all
> the shortcut issues now.
>
> > As we know F5 key is bound to reload/refresh for browsers on Linu= x &
> > Windows.
> > But If we use F5 key to execute query, then F5 key event is first= captured
> > inside the code and execution works.
>
> OK.
>
> > It will not affect the browser reload behaviour. F5 key for execu= tion will
> > only work if focus is on Query tool.
> >
> > Ashesh's concern is:
> > If focus is not on query tool and user mistakenly pressed Fn+F5 k= ey, the
> > page will reload which shouldn't happened.
> >
> > In such case:
> > The page doesn't reload directly as we always ask user "= Whether to Stay on
> > page or Leave page".
>
> Right.
>
> > The other way is to disable reload page on F5 Key only when focus= is inside
> > the app.
> > If focus is on browser then F5 for reload will work. (not a good = idea)
> >
> > @Dave What do you think?
>
> On Mac it works nicely, both in the runtime and in Chrome, Safari and<= br> > Firefox - and given the number of people complaining about the
> shortcuts here, I think the limitation of focus on the text box is
> acceptable.
>
> > I have tested this attached patch on following platforms without = any issue:
> > Windows 7 - Runtime & IE 9 & 10.
> > Mac OSX Yosemite - Safari(8.0.3), Chrome(51) & Firefox(47)
> > Ubuntu-14.04.2 - Chrome & Firefox.
> >
> > Please review the patch.
>
> The patch doesn't update the tooltips/buttons/menus to display the=
> correct shortcuts - plus, if we're doing this for F5, then I think= we
> should also keep F7 for Explain, Shift+F7 for Explain Analyse and F8 > for Execute to File (CSV Downlaod), like pgAdmin 3.

Tooltips/b= uttons/menus are updated with correct shortcuts keys in attached patch.=E2= =80=8B

=E2=80=8BI will send a patch later today.=E2=80= =8B


>
>
> Please note though that that would only partially resolve RM1478. On > some browsers/platforms, there is also some CodeMirror related
> shortcut weirdness that needs to be resolved. It may be worth seeing > if a CodeMirror update would help.
 Okay
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.co= m
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.ente= rprisedb.com
> The Enterprise PostgreSQL Company


--001a1148dfd6979e3f0538a115dc-- --001a1148dfd6979e430538a115de Content-Type: application/octet-stream; name="support_for_function_keys.patch" Content-Disposition: attachment; filename="support_for_function_keys.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ir555hvj0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3RlbXBs YXRlcy9kYXRhZ3JpZC9pbmRleC5odG1sIGIvd2ViL3BnYWRtaW4vdG9vbHMv ZGF0YWdyaWQvdGVtcGxhdGVzL2RhdGFncmlkL2luZGV4Lmh0bWwKaW5kZXgg ZDEwMTBiZC4uNTM3Njg1YyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9v bHMvZGF0YWdyaWQvdGVtcGxhdGVzL2RhdGFncmlkL2luZGV4Lmh0bWwKKysr IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvdGVtcGxhdGVzL2RhdGFn cmlkL2luZGV4Lmh0bWwKQEAgLTg2LDcgKzg2LDcgQEAKICAgICAgICAgICAg IDwvZGl2PgogICAgICAgICAgICAgPGRpdiBjbGFzcz0iYnRuLWdyb3VwIiBy b2xlPSJncm91cCIgYXJpYS1sYWJlbD0iIj4KICAgICAgICAgICAgICAgICA8 YnV0dG9uIGlkPSJidG4tZmxhc2giIHR5cGU9ImJ1dHRvbiIgY2xhc3M9ImJ0 biBidG4tZGVmYXVsdCIgc3R5bGU9IndpZHRoOiA0MHB4OyIKLSAgICAgICAg ICAgICAgICAgICAgICAgIHRpdGxlPSJ7eyBfKCdFeGVjdXRlL1JlZnJlc2gg KEN0cmwrU2hpZnQrRSknKSB9fSI+CisgICAgICAgICAgICAgICAgICAgICAg ICB0aXRsZT0ie3sgXygnRXhlY3V0ZS9SZWZyZXNoIChGNSknKSB9fSI+CiAg ICAgICAgICAgICAgICAgICAgIDxpIGNsYXNzPSJmYSBmYS1ib2x0IiBhcmlh LWhpZGRlbj0idHJ1ZSI+PC9pPgogICAgICAgICAgICAgICAgIDwvYnV0dG9u PgogICAgICAgICAgICAgICAgIDxidXR0b24gaWQ9ImJ0bi1xdWVyeS1kcm9w ZG93biIgdHlwZT0iYnV0dG9uIiBjbGFzcz0iYnRuIGJ0bi1kZWZhdWx0IGRy b3Bkb3duLXRvZ2dsZSIKQEAgLTk2LDEyICs5NiwxMiBAQAogICAgICAgICAg ICAgICAgIDx1bCBjbGFzcz0iZHJvcGRvd24tbWVudSBkcm9wZG93bi1tZW51 Ij4KICAgICAgICAgICAgICAgICAgICAgPGxpPgogICAgICAgICAgICAgICAg ICAgICAgICAgPGEgaWQ9ImJ0bi1leHBsYWluIiBocmVmPSIjIj4KLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICA8c3Bhbj57eyBfKCdFeHBsYWluIChD dHJsK1NoaWZ0K1gpJykgfX08L3NwYW4+CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgPHNwYW4+e3sgXygnRXhwbGFpbiAoRjcpJykgfX08L3NwYW4+ CiAgICAgICAgICAgICAgICAgICAgICAgICA8L2E+CiAgICAgICAgICAgICAg ICAgICAgIDwvbGk+CiAgICAgICAgICAgICAgICAgICAgIDxsaT4KICAgICAg ICAgICAgICAgICAgICAgICAgIDxhIGlkPSJidG4tZXhwbGFpbi1hbmFseXpl IiBocmVmPSIjIj4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICA8c3Bh bj57eyBfKCdFeHBsYWluIGFuYWx5emUgKEN0cmwrU2hpZnQrTiknKSB9fTwv c3Bhbj4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICA8c3Bhbj57eyBf KCdFeHBsYWluIGFuYWx5emUgKEY4KScpIH19PC9zcGFuPgogICAgICAgICAg ICAgICAgICAgICAgICAgPC9hPgogICAgICAgICAgICAgICAgICAgICA8L2xp PgogICAgICAgICAgICAgICAgICAgICA8bGkgY2xhc3M9ImRpdmlkZXIiPjwv bGk+CkBAIC0xNzUsNyArMTc1LDcgQEAKICAgICAgICAgICAgICAgICA8L3Vs PgogICAgICAgICAgICAgPC9kaXY+CiAgICAgICAgICAgICA8ZGl2IGNsYXNz PSJidG4tZ3JvdXAiIHJvbGU9Imdyb3VwIiBhcmlhLWxhYmVsPSIiPgotICAg ICAgICAgICAgICAgIDxidXR0b24gaWQ9ImJ0bi1kb3dubG9hZCIgdHlwZT0i YnV0dG9uIiBjbGFzcz0iYnRuIGJ0bi1kZWZhdWx0IiB0aXRsZT0ie3sgXygn RG93bmxvYWQgYXMgQ1NWJykgfX0iPgorICAgICAgICAgICAgICAgIDxidXR0 b24gaWQ9ImJ0bi1kb3dubG9hZCIgdHlwZT0iYnV0dG9uIiBjbGFzcz0iYnRu IGJ0bi1kZWZhdWx0IiB0aXRsZT0ie3sgXygnRG93bmxvYWQgYXMgQ1NWIChG OCknKSB9fSI+CiAgICAgICAgICAgICAgICAgICAgIDxpIGNsYXNzPSJmYSBm YS1kb3dubG9hZCIgYXJpYS1oaWRkZW49InRydWUiPjwvaT4KICAgICAgICAg ICAgICAgICA8L2J1dHRvbj4KICAgICAgICAgICAgIDwvZGl2PgpkaWZmIC0t Z2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3RlbXBsYXRlcy9z cWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMv c3FsZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpz CmluZGV4IDg5NjFjNTUuLjJlNjQyNmEgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2Fk bWluL3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3Nx bGVkaXRvci5qcworKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3Iv dGVtcGxhdGVzL3NxbGVkaXRvci9qcy9zcWxlZGl0b3IuanMKQEAgLTI3LDYg KzI3LDExIEBAIGRlZmluZSgKICAgICAgKi8KICAgICBmdW5jdGlvbiBlcGlj UmFuZG9tU3RyaW5nKGIpe2Zvcih2YXIgYT0oTWF0aC5yYW5kb20oKSpldmFs KCIxZSIrfn4oNTAqTWF0aC5yYW5kb20oKSs1MCkpKS50b1N0cmluZygzNiku c3BsaXQoIiIpLGM9MztjPGEubGVuZ3RoO2MrKyljPT1+fihNYXRoLnJhbmRv bSgpKmMpKzEmJmFbY10ubWF0Y2goL1thLXpdLykmJihhW2NdPWFbY10udG9V cHBlckNhc2UoKSk7YT1hLmpvaW4oIiIpO2E9YS5zdWJzdHIofn4oTWF0aC5y YW5kb20oKSp+fihhLmxlbmd0aC8zKSksfn4oTWF0aC5yYW5kb20oKSooYS5s ZW5ndGgtfn4oYS5sZW5ndGgvMyoyKSsxKSkrfn4oYS5sZW5ndGgvMyoyKSk7 aWYoMjQ+YilyZXR1cm4gYj9hLnN1YnN0cihhLGIpOmE7YT1hLnN1YnN0cihh LGIpO2lmKGEubGVuZ3RoPT1iKXJldHVybiBhO2Zvcig7YS5sZW5ndGg8Yjsp YSs9ZXBpY1JhbmRvbVN0cmluZygpO3JldHVybiBhLnN1YnN0cigwLGIpfTsK CisgICAgLy8gRGVmaW5lIGtleSBjb2RlcyBmb3Igc2hvcnRjdXQga2V5cwor ICAgIHZhciBGNV9LRVkgPSAxMTYsCisgICAgICAgIEY3X0tFWSA9IDExOCwK KyAgICAgICAgRjhfS0VZID0gMTE5OworCiAgICAgLy8gRGVmaW5pbmcgdGhl IGJhY2tib25lIG1vZGVsIGZvciB0aGUgc3FsIGdyaWQKICAgICB2YXIgc3Fs RWRpdG9yVmlld01vZGVsID0gQmFja2JvbmUuTW9kZWwuZXh0ZW5kKHsKCkBA IC0xMDMwLDIyICsxMDM1LDM1IEBAIGRlZmluZSgKICAgICAgICAgKTsKICAg ICAgIH0sCgotICAgICAgLy8gQ2FsbGJhY2sgZm9yIGtleWJvYXJkIGV2ZW50 CisgICAgICAvKgorICAgICAgICogQ2FsbGJhY2tzIGZvciBrZXlib2FyZCBl dmVudHMgYmluZCB0byB0aGUKKyAgICAgICAqIHF1ZXJ5IHRvb2wgYnV0dG9u cy4KKyAgICAgICAqIEZvbGxvd2luZyBhcmUgdGhlIGtleWJvYXJkIHNob3J0 Y3V0czoKKyAgICAgICAqICBGNSAtIEV4ZWN1dGUgcXVlcnkKKyAgICAgICAq ICBGNyAtIEV4cGxhaW4gcXVlcnkKKyAgICAgICAqICBGOCAtIERvd25sb2Fk IHJlc3VsdCBhcyBDU1YKKyAgICAgICAqICBTaGlmdCtGNyAtIEV4cGxhaW4g YW5hbHl6ZSBxdWVyeQorICAgICAgICovCiAgICAgICBrZXlBY3Rpb246IGZ1 bmN0aW9uKGV2KSB7Ci0gICAgICAgIGlmKGV2LmN0cmxLZXkgJiYgZXYuc2hp ZnRLZXkpIHsKLSAgICAgICAgICBpZihldi5rZXlDb2RlID09IDY5KSB7Ci0g ICAgICAgICAgICAvLyBjaGFyIGUvRQotICAgICAgICAgICAgLy8gRXhlY3V0 ZSBxdWVyeS4KLSAgICAgICAgICAgIHRoaXMub25fZmxhc2goZXYpOwotICAg ICAgICAgIH0gZWxzZSBpZihldi5rZXlDb2RlID09IDg4KSB7Ci0gICAgICAg ICAgICAvLyBjaGFyIHgvWAotICAgICAgICAgICAgLy8gRXhwbGFpbiBxdWVy eS4KLSAgICAgICAgICAgIHRoaXMub25fZXhwbGFpbihldik7Ci0gICAgICAg ICAgfSBlbHNlIGlmKGV2LmtleUNvZGUgPT0gNzgpIHsKLSAgICAgICAgICAg IC8vIGNoYXIgbi9OCi0gICAgICAgICAgICAvLyBFeHBsYWluIGFuYWx5emUg cXVlcnkuCi0gICAgICAgICAgICB0aGlzLm9uX2V4cGxhaW5fYW5hbHl6ZShl dik7Ci0gICAgICAgICAgfQorICAgICAgICB2YXIga2V5Q29kZSA9IGV2Lndo aWNoIHx8IGV2LmtleUNvZGU7CisgICAgICAgIGlmIChldi5zaGlmdEtleSAm JiBrZXlDb2RlID09IEY3X0tFWSkgeworICAgICAgICAgIC8vIEV4cGxhaW4g YW5hbHl6ZSBxdWVyeS4KKyAgICAgICAgICB0aGlzLm9uX2V4cGxhaW5fYW5h bHl6ZShldik7CisgICAgICAgICAgZXYucHJldmVudERlZmF1bHQoKTsKKyAg ICAgICAgfQorCisgICAgICAgIGlmIChrZXlDb2RlID09IEY1X0tFWSkgewor ICAgICAgICAgIC8vIEV4ZWN1dGUgcXVlcnkuCisgICAgICAgICAgdGhpcy5v bl9mbGFzaChldik7CisgICAgICAgICAgZXYucHJldmVudERlZmF1bHQoKTsK KyAgICAgICAgfSBlbHNlIGlmIChrZXlDb2RlID09IEY3X0tFWSkgeworICAg ICAgICAgIC8vIEV4cGxhaW4gcXVlcnkuCisgICAgICAgICAgdGhpcy5vbl9l eHBsYWluKGV2KTsKKyAgICAgICAgICBldi5wcmV2ZW50RGVmYXVsdCgpOwor ICAgICAgICB9IGVsc2UgaWYgKGtleUNvZGUgPT0gRjhfS0VZKSB7CisgICAg ICAgICAgLy8gRG93bmxvYWQgcXVlcnkgcmVzdWx0IGFzIENTVi4KKyAgICAg ICAgICB0aGlzLm9uX2Rvd25sb2FkKGV2KTsKKyAgICAgICAgICBldi5wcmV2 ZW50RGVmYXVsdCgpOwogICAgICAgICB9CiAgICAgICB9CiAgICAgfSk7CkBA IC0xNDMyLDcgKzE0NTAsNyBAQCBkZWZpbmUoCiAgICAgICAgICAgICovCiAg ICAgICAgICAgdmFyIGV4cGxhaW5fZGF0YV9hcnJheSA9IFtdOwogICAgICAg ICAgIGlmKGRhdGEucmVzdWx0ICYmCi0gICAgICAgICAgICAgICdRVUVSWSBQ TEFOJyBpbiBkYXRhLnJlc3VsdFswXSAmJgorICAgICAgICAgICAgICBkYXRh LnJlc3VsdFswXSAmJiBkYXRhLnJlc3VsdFswXS5oYXNPd25Qcm9wZXJ0eSgn UVVFUlkgUExBTicpICYmCiAgICAgICAgICAgICAgIF8uaXNPYmplY3QoZGF0 YS5yZXN1bHRbMF1bJ1FVRVJZIFBMQU4nXSkpIHsKICAgICAgICAgICAgICAg dmFyIGV4cGxhaW5fZGF0YSA9IHsnUVVFUlkgUExBTicgOiBKU09OLnN0cmlu Z2lmeShkYXRhLnJlc3VsdFswXVsnUVVFUlkgUExBTiddLCBudWxsLCAyKX07 CiAgICAgICAgICAgICAgIGV4cGxhaW5fZGF0YV9hcnJheS5wdXNoKGV4cGxh aW5fZGF0YSk7Cg== --001a1148dfd6979e430538a115de Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1148dfd6979e430538a115de--