public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
Date: Mon, 19 Sep 2016 20:59:38 +0530
Message-ID: <CAM5-9D_CmhAW3ePLK90hifKKzvqrPBVfa3+BG0H1=1_D16jFQA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyUdxLTM-X8+wVjTngOR5X+RL4o+WK8DF=M3EOa3Md=ag@mail.gmail.com>
References: <CAM5-9D-ZEfmyouAYrrM8V00AccPup0Uu_6vw48GQaDvWk_jW8Q@mail.gmail.com>
	<CA+OCxoyUdxLTM-X8+wVjTngOR5X+RL4o+WK8DF=M3EOa3Md=ag@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Mon, Sep 19, 2016 at 8:48 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar
> <[email protected]> wrote:
> > Hi
> >
> > Please find attached patch with fix.
> >>
> >> Download as CSV
> >>  button should be enabled only for SELECT queries.
>
> I'm not sure there's a way to do this without parsing the query.
> Simply matching on ^select certainly won't work reliably - for
> example, there could be multiple statements in the script, or it could
> be PERFORM ...  or UPDATE ... RETURNING ...
>
I wasn't aware of such cases.

>
> I think we need to leave the button enabled, but give the user a
> message if no data is returned, e.g.
>
​ok.​ sure.

>
> =======
> Download as CSV
> -------------------------
>
> The query executed did not return any data.
>
> [OK]
> ========


> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
  In-Reply-To: <CAM5-9D_CmhAW3ePLK90hifKKzvqrPBVfa3+BG0H1=1_D16jFQA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox