Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjOwD-0000B6-Kh for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 10:58:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjOwD-0004tS-7K for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 10:58:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjOvz-0004Oo-AY for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 10:57:55 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjOvw-0006bD-Rd for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 10:57:54 +0000 Received: by mail-wm0-x231.google.com with SMTP id a6so47298049wmc.0 for ; Mon, 12 Sep 2016 03:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=ScSgoAWg5xUVV/taHtULi/7764XXCpjcJteKdSQC1aQ=; b=u2xn7AOyDLNAVwJfGtjYJAIRgCfHh+xSbidnuA1NoARGEPs9pumHNEi/RduNK87g0i GoNibWtnHCpTVHu5jQP06aac19kugtMGxXkuNQHKazINaIFADHU6xXsgBRKU8iTM8e/Y gW/pzqyURlkkNTojYeNR/pWDd5p1sqDXbhl8SEE1wKJSHwSWKvipuTyDx4LS4h/lyVir lHVfXcuCxA2X4B2VUvLSFgBksgIYgJVoLrjUtZAizq9H2wWLiQo6FBFMofF9wr8fL17t 2iwDt4sUqbeAift5KpHMUIYwgM4neA2ZELvhEy0V2KTF1iEBL2oD3m2wNRocK/1WMKIx 5MOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=ScSgoAWg5xUVV/taHtULi/7764XXCpjcJteKdSQC1aQ=; b=QGA0z4BQXOyTboz1KIrmQY2OWkN99sZ7LReeAqjcKPWPl06PbHf4Cp5jMWXruNQAyK G/oAfWlfezfOrqWEyh7qNsT6KL5/Q0OxFv43ZAYRvwpviucgh6cbu8fLmEbGMHpS40sr HDuS1z4IHhmDM/ph9wCQkGkM7QTJlsMiaUx83jn5r/1V+WV4o6XMC7ad6fzJX7CzbyxM 2q3UsvHvUOBQjQOIneMfbxKOI7vYAzRRnbwLFpUznhpbyDaq0VFUrFqJCQVasvimMfFQ nfEytrH1GF4gl29i2Qr4U8uDIs7zUsUaHmOlt4te63FDdjSPewjIdR+Gz+v426U4alLy Tpyg== X-Gm-Message-State: AE9vXwP7JuFPyXlz9LurCRhePmh3kPENzqZ8r7bXP+WBixmpDvUERKbQtJQdldqO+dXb5BRp39ZOwu21tSp9BXrJ X-Received: by 10.194.149.238 with SMTP id ud14mr10809144wjb.194.1473677870955; Mon, 12 Sep 2016 03:57:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Mon, 12 Sep 2016 03:57:20 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Mon, 12 Sep 2016 16:27:20 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters To: pgadmin-hackers Content-Type: multipart/mixed; boundary=089e01228b94033214053c4d5eee X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e01228b94033214053c4d5eee Content-Type: multipart/alternative; boundary=089e01228b9403320f053c4d5eec --089e01228b9403320f053c4d5eec Content-Type: text/plain; charset=UTF-8 Hi I forgot to remove a line args_without_name += ', ' from the code in previous patch, thus it adds extra commas into the function arguments in case of procedures only. It is now fixed. Please find updated v2 patch and review. On Mon, Sep 12, 2016 at 3:54 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > This patch doesn't fix the issue in Procedure node. I will send updated > patch. > > On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch with fix. >> *Changes:* >> 1) Take a list of "function argument types", create a string separated by >> comma(removing trailing comma). >> 2) Function arguments in ALTER and GRANT not necessarily to have *argument >> mode, name, *they are optional. Only type is required. >> Now GRANT statement is represented as >> >> *GRANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer, >> integer) TO postgres *as in pgadmin3. >> >> >> Please review. >> > > --089e01228b9403320f053c4d5eec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

I forgot to remove a line= =C2=A0args_without_name += =3D ', '= =C2=A0from the code in previous patch, thus it adds extra commas into the f= unction arguments in case of procedures only.
It is now fixed.
Please find updated v2 patch and re= view.


On Mon, Sep 12, 2016 at 3:5= 4 PM, Surinder Kumar <surinder.kumar@enterprisedb.com>= ; wrote:
This patch doesn't fix t= he issue in Procedure node. I will send updated patch.

On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Ple= ase find attached patch with fix.
Changes:
1) Take a list of "function argument type= s", create a string separated by comma(removing trailing comma).
=
2) Function argument= s in ALTER and GRANT not necessarily to have argument mode, name,=C2=A0<= /b>they are optional. Only type is required.
Now GRANT statement is represented as

GRANT EXECUTE ON FUNCTION test_schema.test_func(i= nteger, integer, integer) TO postgres=C2=A0as in pgadmin3.


Please review.


--089e01228b9403320f053c4d5eec-- --089e01228b94033214053c4d5eee Content-Type: application/octet-stream; name="RM1683_v2.patch" Content-Disposition: attachment; filename="RM1683_v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iszxqfi90 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL2Z1bmN0aW9ucy9fX2luaXRf Xy5weSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL2Z1bmN0aW9ucy9fX2luaXRfXy5weQpp bmRleCA3ODViYTMzLi5mMjY5ZGNiIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p bi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2No ZW1hcy9mdW5jdGlvbnMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvZnVuY3Rpb25zL19faW5pdF9fLnB5CkBAIC05MDYsMzQgKzkwNiwzNCBA QCBjbGFzcyBGdW5jdGlvblZpZXcoUEdDaGlsZE5vZGVWaWV3LCBEYXRhVHlw ZVJlYWRlcik6CiAgICAgICAgIHJlc3BfZGF0YSA9IHNlbGYuX2ZldGNoX3By b3BlcnRpZXMoZ2lkLCBzaWQsIGRpZCwgc2NpZCwgZm5pZCkKICAgICAgICAg IyBGZXRjaCB0aGUgZnVuY3Rpb24gZGVmaW5pdGlvbi4KICAgICAgICAgYXJn cyA9IHUnJwotICAgICAgICBhcmdzX3dpdGhvdXRfbmFtZSA9IHUnJworICAg ICAgICBhcmdzX3dpdGhvdXRfbmFtZSA9IFtdCiAgICAgICAgIGNudCA9IDEK ICAgICAgICAgYXJnc19saXN0ID0gW10KKwogICAgICAgICBpZiAnYXJndW1l bnRzJyBpbiByZXNwX2RhdGEgYW5kIGxlbihyZXNwX2RhdGFbJ2FyZ3VtZW50 cyddKSA+IDA6CiAgICAgICAgICAgICBhcmdzX2xpc3QgPSByZXNwX2RhdGFb J2FyZ3VtZW50cyddCiAgICAgICAgICAgICByZXNwX2RhdGFbJ2FyZ3MnXSA9 IHJlc3BfZGF0YVsnYXJndW1lbnRzJ10KCiAgICAgICAgIGZvciBhIGluIGFy Z3NfbGlzdDoKICAgICAgICAgICAgIGlmICgoJ2FyZ21vZGUnIGluIGEgYW5k IGFbJ2FyZ21vZGUnXSAhPSAnT1VUJyBhbmQKLSAgICAgICAgICAgICAgICAg ICAgICAgICBhWydhcmdtb2RlJ10gaXMgbm90IE5vbmUKKyAgICAgICAgICAg ICAgICAgICAgYVsnYXJnbW9kZSddIGlzIG5vdCBOb25lCiAgICAgICAgICAg ICAgICAgICkgb3IgJ2FyZ21vZGUnIG5vdCBpbiBhKToKICAgICAgICAgICAg ICAgICBpZiAnYXJnbW9kZScgaW4gYToKICAgICAgICAgICAgICAgICAgICAg YXJncyArPSBhWydhcmdtb2RlJ10gKyAiICIKLSAgICAgICAgICAgICAgICAg ICAgYXJnc193aXRob3V0X25hbWUgKz0gYVsnYXJnbW9kZSddICsgIiAiCiAg ICAgICAgICAgICAgICAgaWYgJ2FyZ25hbWUnIGluIGEgYW5kIGFbJ2FyZ25h bWUnXSAhPSAnJyBcCiAgICAgICAgICAgICAgICAgICAgICAgICBhbmQgYVsn YXJnbmFtZSddIGlzIG5vdCBOb25lOgogICAgICAgICAgICAgICAgICAgICBh cmdzICs9IHNlbGYucXRJZGVudCgKICAgICAgICAgICAgICAgICAgICAgICAg IHNlbGYuY29ubiwgYVsnYXJnbmFtZSddKSArICIgIgogICAgICAgICAgICAg ICAgIGlmICdhcmd0eXBlJyBpbiBhOgogICAgICAgICAgICAgICAgICAgICBh cmdzICs9IGFbJ2FyZ3R5cGUnXQotICAgICAgICAgICAgICAgICAgICBhcmdz X3dpdGhvdXRfbmFtZSArPSBhWydhcmd0eXBlJ10KKyAgICAgICAgICAgICAg ICAgICAgYXJnc193aXRob3V0X25hbWUuYXBwZW5kKGFbJ2FyZ3R5cGUnXSkK ICAgICAgICAgICAgICAgICBpZiBjbnQgPCBsZW4oYXJnc19saXN0KToKICAg ICAgICAgICAgICAgICAgICAgYXJncyArPSAnLCAnCi0gICAgICAgICAgICAg ICAgICAgIGFyZ3Nfd2l0aG91dF9uYW1lICs9ICcsICcKICAgICAgICAgICAg IGNudCArPSAxCgogICAgICAgICByZXNwX2RhdGFbJ2Z1bmNfYXJncyddID0g YXJncy5zdHJpcCgnICcpCi0gICAgICAgIHJlc3BfZGF0YVsnZnVuY19hcmdz X3dpdGhvdXQnXSA9IGFyZ3Nfd2l0aG91dF9uYW1lLnN0cmlwKCcgJykKKwor ICAgICAgICByZXNwX2RhdGFbJ2Z1bmNfYXJnc193aXRob3V0J10gPSAnLCAn LmpvaW4oYXJnc193aXRob3V0X25hbWUpCgogICAgICAgICBpZiBzZWxmLm5v ZGVfdHlwZSA9PSAncHJvY2VkdXJlJzoKICAgICAgICAgICAgIG9iamVjdF90 eXBlID0gJ3Byb2NlZHVyZScKQEAgLTExNTgsNyArMTE1OCw3IEBAIGNsYXNz IEZ1bmN0aW9uVmlldyhQR0NoaWxkTm9kZVZpZXcsIERhdGFUeXBlUmVhZGVy KToKICAgICAgICAgICAgICAgICBkYXRhWydhY2wnXSA9IHBhcnNlX3ByaXZf dG9fZGIoZGF0YVsnYWNsJ10sIFsiWCJdKQoKICAgICAgICAgICAgIGFyZ3Mg PSB1JycKLSAgICAgICAgICAgIGFyZ3Nfd2l0aG91dF9uYW1lID0gdScnCisg ICAgICAgICAgICBhcmdzX3dpdGhvdXRfbmFtZSA9IFtdCiAgICAgICAgICAg ICBjbnQgPSAxCiAgICAgICAgICAgICBhcmdzX2xpc3QgPSBbXQogICAgICAg ICAgICAgaWYgJ2FyZ3VtZW50cycgaW4gZGF0YSBhbmQgbGVuKGRhdGFbJ2Fy Z3VtZW50cyddKSA+IDA6CkBAIC0xMTcxLDI4ICsxMTcxLDI2IEBAIGNsYXNz IEZ1bmN0aW9uVmlldyhQR0NoaWxkTm9kZVZpZXcsIERhdGFUeXBlUmVhZGVy KToKICAgICAgICAgICAgICAgICAgICAgICkgb3IgJ2FyZ21vZGUnIG5vdCBp biBhKToKICAgICAgICAgICAgICAgICAgICAgaWYgJ2FyZ21vZGUnIGluIGE6 CiAgICAgICAgICAgICAgICAgICAgICAgICBhcmdzICs9IGFbJ2FyZ21vZGUn XSArICIgIgotICAgICAgICAgICAgICAgICAgICAgICAgYXJnc193aXRob3V0 X25hbWUgKz0gYVsnYXJnbW9kZSddICsgIiAiCiAgICAgICAgICAgICAgICAg ICAgIGlmICdhcmduYW1lJyBpbiBhIGFuZCBhWydhcmduYW1lJ10gIT0gJycg XAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFuZCBhWydhcmduYW1l J10gaXMgbm90IE5vbmU6CiAgICAgICAgICAgICAgICAgICAgICAgICBhcmdz ICs9IHNlbGYucXRJZGVudCgKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzZWxmLmNvbm4sIGFbJ2FyZ25hbWUnXSkgKyAiICIKICAgICAgICAgICAg ICAgICAgICAgaWYgJ2FyZ3R5cGUnIGluIGE6CiAgICAgICAgICAgICAgICAg ICAgICAgICBhcmdzICs9IGFbJ2FyZ3R5cGUnXQotICAgICAgICAgICAgICAg ICAgICAgICAgYXJnc193aXRob3V0X25hbWUgKz0gYVsnYXJndHlwZSddCisg ICAgICAgICAgICAgICAgICAgICAgICBhcmdzX3dpdGhvdXRfbmFtZS5hcHBl bmQoYVsnYXJndHlwZSddKQogICAgICAgICAgICAgICAgICAgICBpZiBjbnQg PCBsZW4oYXJnc19saXN0KToKICAgICAgICAgICAgICAgICAgICAgICAgIGFy Z3MgKz0gJywgJwotICAgICAgICAgICAgICAgICAgICAgICAgYXJnc193aXRo b3V0X25hbWUgKz0gJywgJwogICAgICAgICAgICAgICAgIGNudCArPSAxCgog ICAgICAgICAgICAgZGF0YVsnZnVuY19hcmdzJ10gPSBhcmdzLnN0cmlwKCcg JykKLSAgICAgICAgICAgIGRhdGFbJ2Z1bmNfYXJnc193aXRob3V0J10gPSBh cmdzX3dpdGhvdXRfbmFtZS5zdHJpcCgnICcpCisKKyAgICAgICAgICAgIGRh dGFbJ2Z1bmNfYXJnc193aXRob3V0J10gPSAnLCAnLmpvaW4oYXJnc193aXRo b3V0X25hbWUpCiAgICAgICAgICAgICAjIENyZWF0ZSBtb2RlCiAgICAgICAg ICAgICBTUUwgPSByZW5kZXJfdGVtcGxhdGUoIi8iLmpvaW4oW3NlbGYuc3Fs X3RlbXBsYXRlX3BhdGgsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICdjcmVhdGUuc3FsJ10pLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGRhdGE9ZGF0YSwgaXNfc3FsPWlzX3Nx bCkKICAgICAgICAgcmV0dXJuIFRydWUsIFNRTC5zdHJpcCgnXG4nKQoKLQog ICAgIGRlZiBfZmV0Y2hfcHJvcGVydGllcyhzZWxmLCBnaWQsIHNpZCwgZGlk LCBzY2lkLCBmbmlkPU5vbmUpOgogICAgICAgICAiIiIKICAgICAgICAgUmV0 dXJuIEZ1bmN0aW9uIFByb3BlcnRpZXMgd2hpY2ggd2lsbCBiZSB1c2VkIGlu IHByb3BlcnRpZXMsCg== --089e01228b94033214053c4d5eee Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --089e01228b94033214053c4d5eee--