public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
Date: Mon, 11 Jul 2016 13:43:45 +0530
Message-ID: <CAM5-9D_WuQz6RnLx-n=ugDUnhLGKbcB3EWP2YsVDS3rHOAEdxQ@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

*Issue:*
When we click on "Clear query window" button in Query tool, a new instance
of query tool opens in new window. The event "StopEventPropogation" was not
working.

Please find the attached patch and review.

Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] clear_query_opens_in_new_window_mac_runtime.patch (657B, 3-clear_query_opens_in_new_window_mac_runtime.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 965d56e..233a6c4 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -862,9 +862,8 @@ define(

       // Callback function for the clear button click.
       on_clear: function(ev) {
-        ev = ev || window.event;
-        ev.cancelBubble = true;
-        ev.stopPropagation();
+        this._stopEventPropogation(ev);
+        this._closeDropDown(ev);

         this.query_tool_obj.setValue('');
       },

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
  In-Reply-To: <CAM5-9D_WuQz6RnLx-n=ugDUnhLGKbcB3EWP2YsVDS3rHOAEdxQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox