Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIcGV-0008Np-Tq for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Jun 2017 14:48:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dIcGV-0003LJ-GT for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Jun 2017 14:48:55 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dIcGU-0003EC-Cu for pgadmin-hackers@postgresql.org; Wed, 07 Jun 2017 14:48:54 +0000 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dIcGR-0001pf-9r for pgadmin-hackers@postgresql.org; Wed, 07 Jun 2017 14:48:53 +0000 Received: by mail-wr0-x22c.google.com with SMTP id g76so7231087wrd.1 for ; Wed, 07 Jun 2017 07:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HQfiim0rAmml6GdPeUReN+/YoxEeTAajWQGJakeqUXY=; b=eEmE+hizMMG4EocHkb3s1Dc9uyZLSYfaW8MSbKcSlPSku9Ho81MapBvdb/C81G82So ZzehXtVouaRaGjG7L1zgiDQTiXIW/aBIF8viH6Rv+bXoRk0SM7IWAiizMp44MKPUjiMF Gy+4mYiwkU+7KnIbzA26P6QmKUIdgNGR0D5NrkUFgO/FJfwme4v7Tz7V4xsL/OaWNvax WQNEvGdVQX2u3AK919n0jsnArMdKOUMV+3aH7lH8fi8oR9Y7ZEyvq5Rib+ZQ+fjRpIP8 xbpFa5wEg+cBE/YCtI/3gt0Ot2gJFrhLcDWkJuXFM8a5mgabMhstkG9Y3d8Q0J6Lnlm/ jwGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HQfiim0rAmml6GdPeUReN+/YoxEeTAajWQGJakeqUXY=; b=kfSy1U1XvjZW8pL9056m8NY9tpSV9pznWtnilE+5scO793n+pJqtLHPEwmiNCuBsoo gzhoRPyvm3lKsbKDMzmldQqvPC0Fs/RHCoDPBIy0j34s1wgkIJQqbS1x2wUEdvJVMgoT OEHBOxNoCtFe8si45PoUpp6U0Dd99fI8yXh9sV5msukPfYse+D6BnpQsHn6Zwc5UOoWp STgm6VNHNZWnoHsEEfz8TKYhOG8+1+Dj/gBEpzCL13Sb2vIiFIUa+8P24jTXstDe1pG6 RB6IQdjLIaZLyupS3N8Bd/utwgfSTenH1uSwJT8NAV3liXvydTSJd8OQWJ9tZk5N3kEY U33g== X-Gm-Message-State: AODbwcBciX1pROR24nAri5/u424YJ/Of0pLktRTpb4KEXozywGaiii4O mjHrNP58urX7Wzjlw5Tjnl5YHRddBFV3 X-Received: by 10.223.182.130 with SMTP id j2mr2268565wre.87.1496846929491; Wed, 07 Jun 2017 07:48:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.9.208 with HTTP; Wed, 7 Jun 2017 07:48:18 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 7 Jun 2017 20:18:18 +0530 Message-ID: Subject: Re: [pgAdmin4][PATCH] Consolidating gray colors in the application To: Robert Eckhardt Cc: Dave Page , Shruti B Iyer , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/mixed; boundary="f403043893488471a005515fd52e" X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f403043893488471a005515fd52e Content-Type: multipart/alternative; boundary="f4030438934884719b05515fd52c" --f4030438934884719b05515fd52c Content-Type: text/plain; charset="UTF-8" Hi I have used classes 'bg-gray-2 border-gray-3' for styling header and footer of properties panel which are also used in other places. Please find attached patch. On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt wrote: > Thank you. > > -- Rob > > On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Sure I will send. >> >> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: >> >>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar >>> wrote: >>> > Hi >>> > >>> > With the latest pull, I found: >>> > The header color of Properties panel disappears and background color of >>> > footer area in Edit Properties panel is changed. >>> >>> Oh, I missed that :-(. Can you come up with a quick fix using the new >>> classes? >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --f4030438934884719b05515fd52c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi<= /div>

I have used classes '= bg-gray-2 border-gray-3' for styling header and footer of properties pa= nel which are also used in other places.

Please find attached patch.

On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt= <reckhardt@pivotal.io> wrote:
Thank you.=C2=A0

-- Rob

=
On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar <= span dir=3D"ltr"><surinder.kumar@enterprisedb.com> wrote:
Sure I will send.

On Wed, Jun 7, 2017 at 6= :54 PM, Dave Page <dpage@pgadmin.org> wrote:
On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
> Hi
>
> With the latest pull, I found:
> The header color of Properties panel disappears and background color o= f
> footer area in Edit Properties panel is changed.

Oh, I missed that :-(. Can you come up with a quick fix using the ne= w classes?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--f4030438934884719b05515fd52c-- --f403043893488471a005515fd52e Content-Type: application/octet-stream; name="apply_color_to_properties_header_footer_panel.patch" Content-Disposition: attachment; filename="apply_color_to_properties_header_footer_panel.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3n3wsvg0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jy b3dzZXIvanMvbm9kZS5qcyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxh dGVzL2Jyb3dzZXIvanMvbm9kZS5qcwppbmRleCA0MTY2OTExLi4xNGEzMzgz IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBsYXRlcy9i cm93c2VyL2pzL25vZGUuanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci90 ZW1wbGF0ZXMvYnJvd3Nlci9qcy9ub2RlLmpzCkBAIC0xMDAzLDcgKzEwMDMs NyBAQCBkZWZpbmUoWwogICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9 KTsKIAotICAgICAgICAgICAgY3JlYXRlQnV0dG9ucyhidXR0b25zLCAnaGVh ZGVyJywgJ3BnLXByb3AtYnRuLWdyb3VwLWFib3ZlJyk7CisgICAgICAgICAg ICBjcmVhdGVCdXR0b25zKGJ1dHRvbnMsICdoZWFkZXInLCAncGctcHJvcC1i dG4tZ3JvdXAtYWJvdmUgYmctZ3JheS0yIGJvcmRlci1ncmF5LTMnKTsKICAg ICAgICAgICB9CiAgICAgICAgICAgai5hcHBlbmQoY29udGVudCk7CiAgICAg ICAgIH0uYmluZChwYW5lbCksCkBAIC0xMjQzLDcgKzEyNDMsNyBAQCBkZWZp bmUoWwogICAgICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigp IHsgZWRpdEZ1bmMuY2FsbCgpOyB9LCAwKTsKICAgICAgICAgICAgICAgICB9 KTsKICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfV0sJ2Zvb3Rlcicg LCdwZy1wcm9wLWJ0bi1ncm91cC1iZWxvdycpOworICAgICAgICAgICAgfV0s J2Zvb3RlcicgLCdwZy1wcm9wLWJ0bi1ncm91cC1iZWxvdyBiZy1ncmF5LTIg Ym9yZGVyLWdyYXktMycpOwogICAgICAgICAgIH07CiAKICAgICAgICAgICAv LyBDcmVhdGUgc3RhdHVzIGJhci4K --f403043893488471a005515fd52e Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --f403043893488471a005515fd52e--