Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhdpn-0004na-DM for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 14:28:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bhdpm-0005Qo-VT for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 14:28:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bhdpZ-0005BS-3Y for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 14:28:01 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bhdpQ-00068Y-2k for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 14:27:59 +0000 Received: by mail-wm0-x22d.google.com with SMTP id w12so36015146wmf.0 for ; Wed, 07 Sep 2016 07:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l0ix4Xz+e4wTOhJEmgRxyXHcGtj6gqgBHuuXITXWSOY=; b=daByeBaa+grpRE8obX6654TEVYPqH0yfAo2WwgwidkHI9QnZuD99ZueuwE0vORo4GG 03yeugSSKhS0B6hGoG1dPp/eNmqfBM2TsR1G+QiFqXnnm8JRA9Omjr0lvCsO1tMxrRoJ TKIUbnnV9Fuf9uJBwVKTSaUsq4VrUUg96WQLDb+W7r4Ow6wp5Wl1QxzbBwSdEOKhbxep V/spcIXzbzWdf1mNXuRrYAsGj5m0M1sxCYSb2M2KDp2/tiBeP17W8DrMZYwSCu89/e9j gUd8+GxKJg0lN5hPM8RsFwHwmmzzZvdr/89K8SoEonQtlXcY6in2eroJ9FMMWXwqdbVV s40Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l0ix4Xz+e4wTOhJEmgRxyXHcGtj6gqgBHuuXITXWSOY=; b=FoJcCV06SKt65/LOLvVFRorjMt8SpA8BmolsKTCkNsmJ2ol9re3cCJtxAA0XcsoJlY yRYvuqYhE7w8sgDAUULzlRVK5a1GyDiGvkoYd+Hb3OYUDWdu07pqs6FRGuPEemdOFf/s zq4FIuQlrur29BVgcV6NMUo/ZKsdBhZlN9jdTXxRyYVG7hPowWUavvU9E3V7KuXoBEnt L29y3RJlgVWlEP6+fe2T8a5zaSyf6Z+LFz6b3CbUKo2NvuukO5Nz2n9WFWPMqYATz+UU 9M7IKxbcEiDvZciGkq6BdCS3a/3ZjHTH9PF5FwaF70GB6JD1luUvelr33ljoaoXgqnjz H82Q== X-Gm-Message-State: AE9vXwOiO01WyyPkfCSIgcKh5muNNYSxPUJir/WhLpvdPJcFjBMHFI9jI0XqRGRlkxzsL6wSxR0+xyxDQiuGn1ty X-Received: by 10.28.97.196 with SMTP id v187mr1724131wmb.50.1473258470307; Wed, 07 Sep 2016 07:27:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Wed, 7 Sep 2016 07:27:19 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 7 Sep 2016 19:57:19 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1581 - When switching between query tabs, the selected tab is not ready to run a query To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1148d6d4c9796b053bebb75e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1148d6d4c9796b053bebb75e Content-Type: multipart/alternative; boundary=001a1148d6d4c97964053bebb75c --001a1148d6d4c97964053bebb75c Content-Type: text/plain; charset=UTF-8 Hi Please find updated patch with below changes: 1. A code block is formatted, previously not aligned. 2. rebased the patch. 3. Remove trailing whitespace. On Wed, Sep 7, 2016 at 6:33 PM, Dave Page wrote: > Hi > > This doesn't apply - can you rebase it please? > > Thanks. > > On Wed, Sep 7, 2016 at 12:46 PM, Surinder Kumar > wrote: > > Hi > > > > This patch contains following changes: > > 1) Set focus on query tool once loaded. > > 2) While switching b/w panels find active tab and set focus on query > tool. > > 3) Remove whitespace from file. > > > > This will allow user to switch b/w panels without insisting user to > click on > > query tool. > > > > Please find attached patch and review. > > > > Thanks, > > Surinder Kumar > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1148d6d4c97964053bebb75c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi<= /div>

Please find updated patch= with below changes:
1. A code block is formatted, previously not aligned.
2. rebased the patch.
3. Remove trailing whit= espace.

On Wed, Sep 7, 2016 at 6:33 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This doesn't apply - can you rebase it please?

Thanks.

On Wed, Sep 7, 2016 at 12:46 PM, Surinder Kumar
<surinder.kumar@enter= prisedb.com> wrote:
> Hi
>
> This patch contains following changes:
> 1) Set focus on query tool once loaded.
> 2) While switching b/w panels find active tab and set focus on query t= ool.
> 3) Remove whitespace from file.
>
> This will allow user to switch b/w panels without insisting user to cl= ick on
> query tool.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1148d6d4c97964053bebb75c-- --001a1148d6d4c9796b053bebb75e Content-Type: application/octet-stream; name="RM1581_v1.patch" Content-Disposition: attachment; filename="RM1581_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ist0162q0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1w bGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWlu L3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVk aXRvci5qcwppbmRleCBlYmM3MDc3Li42MTUyNTVjIDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRv ci9qcy9zcWxlZGl0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3Fs ZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCkBA IC0yNjgsMzQgKzI2OCw0NyBAQCBkZWZpbmUoCiAKICAgICAgICAgc2VsZi5y ZW5kZXJfaGlzdG9yeV9ncmlkKCk7CiAKLSAgICAgICAvLyBMaXN0ZW4gb24g dGhlIHBhbmVsIGNsb3NlZCBldmVudCBhbmQgbm90aWZ5IHVzZXIgdG8gc2F2 ZSBtb2RpZmljYXRpb25zLgotICAgICAgIF8uZWFjaCh3aW5kb3cudG9wLnBn QWRtaW4uQnJvd3Nlci5kb2NrZXIuZmluZFBhbmVscygnZnJtX2RhdGFncmlk JyksIGZ1bmN0aW9uKHApIHsKLSAgICAgICAgIGlmKHAuaXNWaXNpYmxlKCkp IHsKLSAgICAgICAgICAgcC5vbih3Y0RvY2tlci5FVkVOVC5DTE9TSU5HLCBm dW5jdGlvbigpIHsKLSAgICAgICAgICAgICAvLyBPbmx5IGlmIHdlIGNhbiBl ZGl0IGRhdGEgdGhlbiBwZXJmb3JtIHRoaXMgY2hlY2sKLSAgICAgICAgICAg ICB2YXIgbm90aWZ5ID0gZmFsc2UsIG1zZzsKLSAgICAgICAgICAgICBpZihz ZWxmLmhhbmRsZXIuY2FuX2VkaXQpIHsKLSAgICAgICAgICAgICAgIHZhciBk YXRhX3N0b3JlID0gc2VsZi5oYW5kbGVyLmRhdGFfc3RvcmU7Ci0gICAgICAg ICAgICAgICBpZihfLnNpemUoZGF0YV9zdG9yZS5hZGRlZCkgfHwKLSAgICAg ICAgICAgICAgICAgICBfLnNpemUoZGF0YV9zdG9yZS51cGRhdGVkKSkgewot ICAgICAgICAgICAgICAgICBtc2cgPSAne3sgXygnVGhlIGRhdGEgaGFzIGJl ZW4gbW9kaWZpZWQsIGJ1dCBub3Qgc2F2ZWQuIEFyZSB5b3Ugc3VyZSB5b3Ug d2lzaCB0byBkaXNjYXJkIHRoZSBjaGFuZ2VzPycpIH19JzsKLSAgICAgICAg ICAgICAgICAgbm90aWZ5ID0gdHJ1ZTsgCi0gICAgICAgICAgICAgICB9Ci0g ICAgICAgICAgICAgfSBlbHNlIGlmKHNlbGYuaGFuZGxlci5pc19xdWVyeV90 b29sKSB7Ci0gICAgICAgICAgICAgICAvLyBXZSB3aWxsIGNoZWNrIGZvciBt b2RpZmllZCBzcWwgY29udGVudAotICAgICAgICAgICAgICAgdmFyIHNxbCA9 IHNlbGYuaGFuZGxlci5ncmlkVmlldy5xdWVyeV90b29sX29iai5nZXRWYWx1 ZSgpOwotICAgICAgICAgICAgICAgc3FsID0gc3FsLnJlcGxhY2UoL1xzKy9n LCAnJyk7IAotICAgICAgICAgICAgICAgLy8gSWYgaXQgaXMgYW4gZW1wdHkg cXVlcnksIGRvIG5vdGhpbmcuCi0gICAgICAgICAgICAgICBpZiAoc3FsLmxl bmd0aCA+IDApIHsKLSAgICAgICAgICAgICAgICAgbXNnID0gJ3t7IF8oJ1Ro ZSBxdWVyeSBoYXMgYmVlbiBtb2RpZmllZCwgYnV0IG5vdCBzYXZlZC4gQXJl IHlvdSBzdXJlIHlvdSB3aXNoIHRvIGRpc2NhcmQgdGhlIGNoYW5nZXM/Jykg fX0nOwotICAgICAgICAgICAgICAgICBub3RpZnkgPSB0cnVlOyAKLSAgICAg ICAgICAgICAgIH0gCi0gICAgICAgICAgICAgfQotICAgICAgICAgICAgIGlm KG5vdGlmeSkge3JldHVybiBzZWxmLnVzZXJfY29uZmlybWF0aW9uKHAsIG1z Zyk7fQotICAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAgICAgICB9 KTsKLSAgICAgICAgIH0KLSAgICAgICB9KTsKKyAgICAgICAgLy8gTGlzdGVu IG9uIHRoZSBwYW5lbCBjbG9zZWQgZXZlbnQgYW5kIG5vdGlmeSB1c2VyIHRv IHNhdmUgbW9kaWZpY2F0aW9ucy4KKyAgICAgICAgXy5lYWNoKHdpbmRvdy50 b3AucGdBZG1pbi5Ccm93c2VyLmRvY2tlci5maW5kUGFuZWxzKCdmcm1fZGF0 YWdyaWQnKSwgZnVuY3Rpb24ocCkgeworICAgICAgICAgIGlmKHAuaXNWaXNp YmxlKCkpIHsKKyAgICAgICAgICAgIHAub24od2NEb2NrZXIuRVZFTlQuQ0xP U0lORywgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgIC8vIE9ubHkgaWYg d2UgY2FuIGVkaXQgZGF0YSB0aGVuIHBlcmZvcm0gdGhpcyBjaGVjaworICAg ICAgICAgICAgICB2YXIgbm90aWZ5ID0gZmFsc2UsIG1zZzsKKyAgICAgICAg ICAgICAgaWYoc2VsZi5oYW5kbGVyLmNhbl9lZGl0KSB7CisgICAgICAgICAg ICAgICAgdmFyIGRhdGFfc3RvcmUgPSBzZWxmLmhhbmRsZXIuZGF0YV9zdG9y ZTsKKyAgICAgICAgICAgICAgICBpZihfLnNpemUoZGF0YV9zdG9yZS5hZGRl ZCkgfHwKKyAgICAgICAgICAgICAgICAgICAgXy5zaXplKGRhdGFfc3RvcmUu dXBkYXRlZCkpIHsKKyAgICAgICAgICAgICAgICAgIG1zZyA9ICd7eyBfKCdU aGUgZGF0YSBoYXMgYmVlbiBtb2RpZmllZCwgYnV0IG5vdCBzYXZlZC4gQXJl IHlvdSBzdXJlIHlvdSB3aXNoIHRvIGRpc2NhcmQgdGhlIGNoYW5nZXM/Jykg fX0nOworICAgICAgICAgICAgICAgICAgbm90aWZ5ID0gdHJ1ZTsKKyAgICAg ICAgICAgICAgICB9CisgICAgICAgICAgICAgIH0gZWxzZSBpZihzZWxmLmhh bmRsZXIuaXNfcXVlcnlfdG9vbCkgeworICAgICAgICAgICAgICAgIC8vIFdl IHdpbGwgY2hlY2sgZm9yIG1vZGlmaWVkIHNxbCBjb250ZW50CisgICAgICAg ICAgICAgICAgdmFyIHNxbCA9IHNlbGYuaGFuZGxlci5ncmlkVmlldy5xdWVy eV90b29sX29iai5nZXRWYWx1ZSgpOworICAgICAgICAgICAgICAgIHNxbCA9 IHNxbC5yZXBsYWNlKC9ccysvZywgJycpOworICAgICAgICAgICAgICAgIC8v IElmIGl0IGlzIGFuIGVtcHR5IHF1ZXJ5LCBkbyBub3RoaW5nLgorICAgICAg ICAgICAgICAgIGlmIChzcWwubGVuZ3RoID4gMCkgeworICAgICAgICAgICAg ICAgICAgbXNnID0gJ3t7IF8oJ1RoZSBxdWVyeSBoYXMgYmVlbiBtb2RpZmll ZCwgYnV0IG5vdCBzYXZlZC4gQXJlIHlvdSBzdXJlIHlvdSB3aXNoIHRvIGRp c2NhcmQgdGhlIGNoYW5nZXM/JykgfX0nOworICAgICAgICAgICAgICAgICAg bm90aWZ5ID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgICAgaWYobm90aWZ5KSB7cmV0dXJuIHNlbGYu dXNlcl9jb25maXJtYXRpb24ocCwgbXNnKTt9CisgICAgICAgICAgICAgIHJl dHVybiB0cnVlOworICAgICAgICAgICAgfSk7CisgICAgICAgICAgICAvLyBT ZXQgZm9jdXMgb24gcXVlcnkgdG9vbCBvZiBhY3RpdmUgcGFuZWwKKyAgICAg ICAgICAgIHAub24od2NEb2NrZXIuRVZFTlQuR0FJTl9GT0NVUywgZnVuY3Rp b24oKSB7CisgICAgICAgICAgICAgIGlmICghJChwLiRjb250YWluZXIpLmhh c0NsYXNzKCd3Y1BhbmVsVGFiQ29udGVudEhpZGRlbicpKSB7CisgICAgICAg ICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAg ICAgICAgIHNlbGYuaGFuZGxlci5ncmlkVmlldy5xdWVyeV90b29sX29iai5m b2N1cygpOworICAgICAgICAgICAgICAgIH0sIDIwMCk7CisgICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIH0pOworICAgICAgICAgIH0KKyAgICAgICAg fSk7CisKKyAgICAgICAgLy8gc2V0IGZvY3VzIG9uIHF1ZXJ5IHRvb2wgb25j ZSBsb2FkZWQKKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAg ICAgICAgICBzZWxmLnF1ZXJ5X3Rvb2xfb2JqLmZvY3VzKCk7CisgICAgICAg IH0sIDUwMCk7CiAKICAgICAgICAgLyogV2UgaGF2ZSBvdmVycmlkZS9yZWdp c3RlciB0aGUgaGludCBmdW5jdGlvbiBvZiBDb2RlTWlycm9yCiAgICAgICAg ICAqIHRvIHByb3ZpZGUgb3VyIG93biBoaW50IGxvZ2ljLgpAQCAtNDAxLDgg KzQxNCw4IEBAIGRlZmluZSgKIAogICAgICAgLyogVG8gcHJvbXB0IHVzZXIg Zm9yIHVuc2F2ZWQgY2hhbmdlcyAqLwogICAgICAgdXNlcl9jb25maXJtYXRp b246IGZ1bmN0aW9uKHBhbmVsLCBtc2cpIHsKLSAgICAgICAgLy8gSWYgdGhl cmUgaXMgYW55dGhpbmcgdG8gc2F2ZSB0aGVuIHByb21wdCB1c2VyIAotICAg ICAgICAgIGFsZXJ0aWZ5LmNvbmZpcm0oJ3t7IF8oJ1Vuc2F2ZWQgY2hhbmdl cycpIH19JywgbXNnLCAKKyAgICAgICAgLy8gSWYgdGhlcmUgaXMgYW55dGhp bmcgdG8gc2F2ZSB0aGVuIHByb21wdCB1c2VyCisgICAgICAgICAgYWxlcnRp ZnkuY29uZmlybSgne3sgXygnVW5zYXZlZCBjaGFuZ2VzJykgfX0nLCBtc2cs CiAgICAgICAgICAgICBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgLy8g RG8gbm90aGluZyBhcyB1c2VyIGRvIG5vdCB3YW50IHRvIHNhdmUsIGp1c3Qg Y29udGludWUKICAgICAgICAgICAgICAgd2luZG93Lm9uYmVmb3JldW5sb2Fk ID0gbnVsbDsK --001a1148d6d4c9796b053bebb75e Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1148d6d4c9796b053bebb75e--