Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKjM4-00008c-DM for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jul 2016 09:42:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bKjM3-00028N-7A for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jul 2016 09:42:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bKjM2-00028H-P7 for pgadmin-hackers@postgresql.org; Wed, 06 Jul 2016 09:42:50 +0000 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bKjLz-0000dZ-Fx for pgadmin-hackers@postgresql.org; Wed, 06 Jul 2016 09:42:49 +0000 Received: by mail-wm0-x229.google.com with SMTP id a66so185126242wme.0 for ; Wed, 06 Jul 2016 02:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=x2W3lS1jOtJReYHSBn7vE+jQKeC78qBcOXdoJUJ+EsU=; b=O1Yace98HzDP0varXChFyANJFHyEt9En7mjCN7n/Y0DkAVpiLlT/Klz77PJGk/OoNf nKbUTSIpKP70p4kyzsruGN8SjXAVuAb6itXWv+hdvq09edDD4AV5CS/Rp6grnlsUThqD uSw3h/Qbxf9MOdDeal0681epBbpNS5gT52SE3J4AAQ4b+mQAXEp4k/VMxukD5Z4FJH9X SOPVxV6+NQzIat6LBj5ZEpDB3i7S2ZnjhShnxIlYLupUB+wyCOqh9NknTns9LQ6Bz5gG ZiA3Qt9mC3Zfy2mGZ7PC/zi3boDJGPVirb0QGezSB1uFr+p7Z2h9VJOK/HoX+VKEmbpl jAJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=x2W3lS1jOtJReYHSBn7vE+jQKeC78qBcOXdoJUJ+EsU=; b=gB47Hj2F6VBL79CxahQOiN8S9XRBoWXQATKfdNCdfhaRTzpc3EIZkQ9vsAQLEl4fQn UtYoUX6i5v1EpDs7SrGO3Bq9+UcIsKRKdEGYUDmfinYh4NyW3uZSZb/XIr0i4JtUhthe pFq3fN/KY5IBuYU6CF4sZgZU45dsblmN343nfRmy3p3CYpNoDK3e/H1jQfN+jP2Ngr4X 6QLYI/tdhyJ2W6bOUH9Hu2cyfNTkAoKTXELPGxoeIRjESuBaZerYacXmjIB44EqJF4/B m6yjQJv8cC6RgOE3dvfima3oJf/9JJ3sKV9MzPz1moyeYHwIrlzg3vZpyhh4WER95NiI E/xw== X-Gm-Message-State: ALyK8tIDFnDNk6fB2tBhYBj+Eeik9t27FkKiNV0S1Cao2dkEfdffqzqkONnGhRyiG6EhZG/zxHulUEwAjyILqrRD X-Received: by 10.28.54.147 with SMTP id y19mr19655008wmh.68.1467798165716; Wed, 06 Jul 2016 02:42:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.24.2 with HTTP; Wed, 6 Jul 2016 02:42:16 -0700 (PDT) From: Surinder Kumar Date: Wed, 6 Jul 2016 15:12:16 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error To: marc.linster@enterprisedb.com, pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114311064538b70536f464f7 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114311064538b70536f464f7 Content-Type: multipart/alternative; boundary=001a114311064538b30536f464f5 --001a114311064538b30536f464f5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Please find the patch with issue fixed: File Browser - File does not exist error > it is due to wrong path formation. strip the leftmost slash only from the > file name selected not from the full path. Please review. *Reply to the comments:* The file browser is virtually unreadable (see screen shot), it does not work like Mac app It seems to be font issue to me. I will fix it and send a patch. When I click on the folder name, it offers to change the folder name instead of opening it (opening works when I click on the folder logo) we are performing two operations on double click: 1) Navigate inside the folder double clicking on folder icon allows to navigate inside the folder. 2) Rename folder double clicking on folder name allows to rename the file/folder. When I manage to navigate to the right file and want to open it, I get a red message =E2=80=98File does not exist=E2=80=99. That message disappears = after 2-3 seconds attached a patch with fix. Thanks, Surinder Kumar --001a114311064538b30536f464f5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

Please find the patch with issue fix= ed:
File Browser - File does not exist error
it is due to wrong path formation. strip the leftmost slash only from= the file name selected not from the full path.

=
Please review.

Reply to the comments:<= /div>
The file browser is virt= ually unreadable (see screen shot), it does not work like Mac app
It seems to be font issue to me. I will fix it and send a patc= h.=C2=A0

=
When I click on the fol= der name, it offers to change the folder name instead of opening it (openin= g works when I click on the folder logo)
we are performing two operations on double= click:
= 1) Navigate inside the folder
double clicking on folder ic= on allows to navigate inside the folder.
2) Rename folder
double clicking on folde= r name allows to rename the file/folder.

When I manage to navigate to the right file and want to open it, = I get a red message =E2=80=98File does not exist=E2=80=99. That message dis= appears after 2-3 seconds
attached a patch with fix.

Thanks,
Surinder Kumar
--001a114311064538b30536f464f5-- --001a114311064538b70536f464f7 Content-Type: application/octet-stream; name="RM#1432.patch" Content-Disposition: attachment; filename="RM#1432.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqap25g90 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2lu aXRfXy5weSBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRf Xy5weQppbmRleCBjNzEzZmI1Li45MmU0YjE3IDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi90b29scy9zcWxlZGl0b3IvX19pbml0X18ucHkKKysrIGIvd2Vi L3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL19faW5pdF9fLnB5CkBAIC0xMTIx LDE2ICsxMTIxLDEzIEBAIGRlZiBsb2FkX2ZpbGUoKToKICAgICBpZiByZXF1 ZXN0LmRhdGE6CiAgICAgICAgIGZpbGVfZGF0YSA9IGpzb24ubG9hZHMocmVx dWVzdC5kYXRhLmRlY29kZSgpKQoKKyAgICBmaWxlX3BhdGggPSB1bnF1b3Rl KGZpbGVfZGF0YVsnZmlsZV9uYW1lJ10pCiAgICAgIyByZXRyaWV2ZSBzdG9y YWdlIGRpcmVjdG9yeSBwYXRoCiAgICAgc3RvcmFnZV9tYW5hZ2VyX3BhdGgg PSBnZXRfc3RvcmFnZV9kaXJlY3RvcnkoKQotICAgIGlmIHN0b3JhZ2VfbWFu YWdlcl9wYXRoIGlzIE5vbmU6Ci0gICAgICAgIHN0b3JhZ2VfbWFuYWdlcl9w YXRoID0gIiIKKyAgICBpZiBzdG9yYWdlX21hbmFnZXJfcGF0aDoKKyAgICAg ICAgIyBnZW5lcmF0ZSBmdWxsIHBhdGggb2YgZmlsZQorICAgICAgICBmaWxl X3BhdGggPSBvcy5wYXRoLmpvaW4oc3RvcmFnZV9tYW5hZ2VyX3BhdGgsIGZp bGVfcGF0aC5sc3RyaXAoJy8nKSkKCi0gICAgIyBnZW5lcmF0ZSBmdWxsIHBh dGggb2YgZmlsZQotICAgIGZpbGVfcGF0aCA9IG9zLnBhdGguam9pbigKLSAg ICAgICAgc3RvcmFnZV9tYW5hZ2VyX3BhdGgsCi0gICAgICAgIHVucXVvdGUo ZmlsZV9kYXRhWydmaWxlX25hbWUnXS5sc3RyaXAoJy8nKSkKLSAgICApCiAg ICAgZmlsZV9kYXRhID0gTm9uZQoKICAgICAjIGNoZWNrIGlmIGZpbGUgdHlw ZSBpcyB0ZXh0IG9yIGJpbmFyeQo= --001a114311064538b70536f464f7 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114311064538b70536f464f7--