Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL8ll-0003CP-1d for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 12:51:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bL8lk-0006MR-L5 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 12:51:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bL8lX-00068P-7G for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 12:50:51 +0000 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bL8lT-0001J3-S3 for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 12:50:50 +0000 Received: by mail-wm0-x236.google.com with SMTP id z126so147337563wme.0 for ; Thu, 07 Jul 2016 05:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YCA5kzEkhJ5/qWTQev0K8QNcoCgR6GNYAnSQgGpNoyI=; b=nAOw1WGMvfVgAP1Q5C+F85Z5sccIBbg7ZOTpPccbu8iI9y8kAayIuo++IXq8k030mV E0RxCLvGm4ifoilkDDWKDa980+IIG3YdzG4uhDirFEWocA7y3j0UjPktoHezQH8wNrLb o2hincArCnB3aesE5UWwL6+e+Dn6IP/I3bzNBOyo7ti6sPkzFX2TfRPYKVPYnAjqty0l zIp/MPBUtbRkk8rqDJpATcsa+4vQJtPPZ7aU8EuoYZHicO/53AlHHD5FIAigHx5D183b 9DepMz5/i+AazU//N6utNuPy8/CmNvLP0cEjupr57uAj36y3TwYCFVVx3O9p/1iM9lnC 8uwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YCA5kzEkhJ5/qWTQev0K8QNcoCgR6GNYAnSQgGpNoyI=; b=XrtLFegClBrdxHooFeMolt6CRHyd2y1wprOPqNEIZ7YynGi4zflkrzqqOaObiYFiXw kOmgr6cAWLQIlmEhx5FiydFcAsoJPdXkUtEKm2ggabZqq6fMacBKZTjdqNc+rHMD9fVD o0U3h36SMHOo4UbBoSWzlSpZpuOHjFOFrkB0YXV+1V2DuH9z9OfKeNZT4+7mXp9duPfx ZTAaX2jUk6n6qv4cwLhXvQlvLgzmW0qCYUPFuXaj4u9uSRPipNIp4NngANcDgfFAC6kw 5k1vPCt78RAj51c/8Hf+x1gxNL8h4XxZWgtYL+LybFVZGQLjRnnxU5xOnQjhKawqHM5C gqxA== X-Gm-Message-State: ALyK8tLLHwIMx4/FUz9Qo+Gngjam1vf9UdDTY1oeO0JRhEGJ8/Qm7Ka4bkZWDcOfu3z9Zx9MhR/46Q8BiOgX6Qq8 X-Received: by 10.194.54.198 with SMTP id l6mr25294643wjp.67.1467895845695; Thu, 07 Jul 2016 05:50:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.24.2 with HTTP; Thu, 7 Jul 2016 05:50:16 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Thu, 7 Jul 2016 18:20:16 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error To: Dave Page Cc: Marc Linster , pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7b66f39f73860b05370b226d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b66f39f73860b05370b226d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: > >> Hi, >> >> I think we need more changes than just that; >> >> - The path at the top should not be editable (it should be greyed in fac= t) >> > Ok > >> >> - The path at the top should only show the directory path. The >> filename should never be appended. >> > Ok > >> >> - The CSS needs to be fixed so the filename textbox at the bottom is >> never hidden (as it is now if the dialogue opens at a small size). >> > Ok > >> >> - Double-click to navigate vs. rename should be modified to work in >> part like it does on Mac - Double-click on either the icon or the name >> should open the item (browser into a folder, or select and "OK" on a >> file), and Click then Enter should rename. I'm hesitant to try to >> implement "slow double click to rename" as that would likely need to >> be tunable for accessibility reasons. >> > Ok, I will fix it. > In the current scenario, the Enter Key is bound to the OK button by default in Alertify dialog which servers the purpose of closing the dialog. Should we de-attach Enter Key event bound to OK button and use it for rename file? please suggest what should I do? On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find the patch with issue fixed: >> > File Browser - File does not exist error >> >> >> >> it is due to wrong path formation. strip the leftmost slash only from >> the >> >> file name selected not from the full path. >> > >> > >> > Please review. >> > >> > Reply to the comments: >> > The file browser is virtually unreadable (see screen shot), it does no= t >> work >> > like Mac app >> > It seems to be font issue to me. I will fix it and send a patch. >> > >> > When I click on the folder name, it offers to change the folder name >> instead >> > of opening it (opening works when I click on the folder logo) >> > we are performing two operations on double click: >> > 1) Navigate inside the folder >> > double clicking on folder icon allows to navigate inside the folder. >> > 2) Rename folder >> > double clicking on folder name allows to rename the file/folder. >> > >> > When I manage to navigate to the right file and want to open it, I get >> a red >> > message =E2=80=98File does not exist=E2=80=99. That message disappears= after 2-3 seconds >> > attached a patch with fix. >> > >> > Thanks, >> > Surinder Kumar >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --047d7b66f39f73860b05370b226d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
=
On Wed, Jul 6, 2016 at 5:40 PM, Dave Page= <dpage@pgadmin.org> wrote:
Hi,

I think we need more changes than just that;

- The path at the top should not be editable (it should be greyed in fact)<= br>
Ok=C2=A0

- The path at the top should only show the directory path. The
filename should never be appended.
Ok=C2=A0

- The CSS needs to be fixed so the filename textbox at the bottom is
never hidden (as it is now if the dialogue opens at a small size).
Ok=C2=A0

- Double-click to navigate vs. rename should be modified to work in
part like it does on Mac - Double-click on either the icon or the name
should open the item (browser into a folder, or select and "OK" o= n a
file), and Click then Enter should rename. I'm hesitant to try to
implement "slow double click to rename" as that would likely need= to
be tunable for accessibility reasons.
Ok, I wil= l fix it.=C2=A0
In the current sce= nario, the Enter Key is bound to the OK button by default in Alertify dialo= g which servers the purpose of closing the dialog.
Should we de-a= ttach Enter Key event bound to OK button and use it for rename file?
<= div>please suggest what should I do?


On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar
<su= rinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find the patch with issue fixed:
> File Browser - File does not exist error
>>
>> it is due to wrong path formation. strip the leftmost slash only f= rom the
>> file name selected not from the full path.
>
>
> Please review.
>
> Reply to the comments:
> The file browser is virtually unreadable (see screen shot), it does no= t work
> like Mac app
> It seems to be font issue to me. I will fix it and send a patch.
>
> When I click on the folder name, it offers to change the folder name i= nstead
> of opening it (opening works when I click on the folder logo)
> we are performing two operations on double click:
> 1) Navigate inside the folder
> double clicking on folder icon allows to navigate inside the folder. > 2) Rename folder
> double clicking on folder name allows to rename the file/folder.
>
> When I manage to navigate to the right file and want to open it, I get= a red
> message =E2=80=98File does not exist=E2=80=99. That message disappears= after 2-3 seconds
> attached a patch with fix.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--047d7b66f39f73860b05370b226d--