Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmhm9-0008RN-S2 for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 13:41:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bmhm9-00005w-79 for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 13:41:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmhlv-0008J3-ME for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 13:41:11 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bmhlr-0003SV-Sh for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 13:41:11 +0000 Received: by mail-wm0-x22b.google.com with SMTP id l132so269314867wmf.0 for ; Wed, 21 Sep 2016 06:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QmDKDb/lesV0EerFMeSR3FvcPVqTaafyMpg7Pd/qBIs=; b=oe9Exmcws8NfcvonRRODUVikcJQk78A5JVNFZUDgx6fTvFHjiAswYy3aU9gCzUK8dH opey7LhaurCav4qRNpAubUGEAkncVNVdXkMhbfmCeIOuyNRfQkBl/Ts1KzPHSB5JufCW viZqfAGlqVtElmW4BMihi8V4UhcoU8IXFouMygN22FyBMxe8XrKKbDs7qi/J474RY/T9 KZh5zK3fZjbj8IG20MdbdZRrRw3sgjgqcMuPTBXIYsDh2DRSANXkZ0oWirVePGlyKHZ0 S7V+nPONausE/PRyTs/QRh32vn1yM4hE2A3M34OL8KGkA+n8jXgUyLpR43cDgVV+bvm1 qDEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QmDKDb/lesV0EerFMeSR3FvcPVqTaafyMpg7Pd/qBIs=; b=DjeDbjkKVuN5dQJLDJcnLFeIUvjAFuYj3vGUjhrj2OcyMh07ZI9SqE5Q74KAASKp8V pXDJxrS0wu2dBWNT8bgV+WXTb+pP3Uq5hwuecfzm6UMJQUDJt7hczAWMIhuGYiFkRlql wsS4Bbbpz4L/BH29ScdstLyOu1ItYAIt/+P6l4tUg3PRje36wEj5dQKmAbsz11AJVzay L0asM+6gcQ2GIENVa9bFlJtJ6btHf3WQ6PheUhbD5KRVQlUPuewDxXUEhN6nCYXx1VRw eRPOAlTb9XmuK5bLBAYGOWAqlQwhUy8n8Wt2pIkO5uP/oPuEajNIsp1qAw5byXp4B8Xm Nm0g== X-Gm-Message-State: AE9vXwNdWz9IF30p+P7zXGiTLKgIKuBuvDvqXHPiqJG/vPiLjE2ejHfirYCEmKm2NXTU8jGay2eZCGXmSoBAXflC X-Received: by 10.28.16.148 with SMTP id 142mr3129458wmq.5.1474465266066; Wed, 21 Sep 2016 06:41:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.172.198 with HTTP; Wed, 21 Sep 2016 06:40:35 -0700 (PDT) In-Reply-To: References: From: Surinder Kumar Date: Wed, 21 Sep 2016 19:10:35 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1171 - Fix IE caching issue To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1145b4526bc628053d04b269 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145b4526bc628053d04b269 Content-Type: multipart/alternative; boundary=001a1145b4526bc624053d04b267 --001a1145b4526bc624053d04b267 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=80=8BHi I did git pull and applied the patch without any error.=E2=80=8B I have att= ached updated patch. Please apply this patch and let me know if any issue. On Wed, Sep 21, 2016 at 5:59 PM, Dave Page wrote: > Can you rebase please? > > piranha:web dpage$ git apply ~/Downloads/RM1171_v1.patch > error: patch failed: web/pgadmin/utils/ajax.py:29 > error: web/pgadmin/utils/ajax.py: patch does not apply > > On Tue, Sep 20, 2016 at 2:58 PM, Surinder Kumar > wrote: > > Missed method closing parenthesis while calling > > > > Please find updated patch > > > > On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar > > wrote: > >> > >> This patch has some issue in chrome while loading nodes. I will send > >> updated patch. > >> > >> On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar > >> wrote: > >>> > >>> Hi > >>> > >>> Issue: > >>> IE always caching the response data returned from the server and when > >>> same request is made for next time, it doesn't bring new data, instead > it > >>> use cached data. > >>> > >>> Solution: > >>> Set cache to 'no-cache' in response headers while sending from the > server > >>> side. This prevents browser from caching data every time an http > request is > >>> made. > >>> > >>> Thanks to Harshal & Murtaza for discussing issue and solution. > >>> > >>> Please find attached patch and review. > >>> > >>> > >>> Thanks, > >>> Surinder Kumar > >> > >> > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1145b4526bc624053d04b267 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=E2= =80=8BHi=C2=A0
=
I did git = pull and applied the patch without any error.=E2=80=8B I have attached upda= ted patch.
Plea= se apply this patch and let me know if any issue.

On Wed, Sep 21, 2016 at 5:59 PM= , Dave Page <dpage@pgadmin.org> wrote:
Can you rebase please?

piranha:web dpage$ git apply ~/Downloads/RM1171_v1.patch
error: patch failed: web/pgadmin/utils/ajax.py:29
error: web/pgadmin/utils/ajax.py: patch does not apply

On Tue, Sep 20, 2016 at 2:58 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Missed method closing parenthesis while calling
>
> Please find updated patch
>
> On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar
> <surinder.kumar@= enterprisedb.com> wrote:
>>
>> This patch has some issue in chrome while loading nodes. I will se= nd
>> updated patch.
>>
>> On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar
>> <surinder.ku= mar@enterprisedb.com> wrote:
>>>
>>> Hi
>>>
>>> Issue:
>>> IE always caching the response data returned from the server a= nd when
>>> same request is made for next time, it doesn't bring new d= ata, instead it
>>> use cached data.
>>>
>>> Solution:
>>> Set cache to 'no-cache' in response headers while send= ing from the server
>>> side. This prevents browser from caching data every time an ht= tp request is
>>> made.
>>>
>>> Thanks to Harshal & Murtaza for discussing issue and solut= ion.
>>>
>>> Please find attached patch and review.
>>>
>>>
>>> Thanks,
>>> Surinder Kumar
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1145b4526bc624053d04b267-- --001a1145b4526bc628053d04b269 Content-Type: application/octet-stream; name="RM1171_v2.patch" Content-Disposition: attachment; filename="RM1171_v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itcyigj30 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3V0aWxzL2FqYXgucHkgYi93ZWIv cGdhZG1pbi91dGlscy9hamF4LnB5CmluZGV4IDBlMTFlYWMuLjBjOGFkNTYg MTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3V0aWxzL2FqYXgucHkKKysrIGIv d2ViL3BnYWRtaW4vdXRpbHMvYWpheC5weQpAQCAtMjksNiArMjksMTggQEAg Y2xhc3MgRGF0YVR5cGVKU09ORW5jb2Rlcihqc29uLkpTT05FbmNvZGVyKToK CiAgICAgICAgIHJldHVybiBqc29uLkpTT05FbmNvZGVyLmRlZmF1bHQoc2Vs Ziwgb2JqKQoKK2RlZiBnZXRfbm9fY2FjaGVfaGVhZGVyKCk6CisgICAgIiIi CisgICAgUHJldmVudCBicm93c2VyIGZyb20gY2FjaGluZyBkYXRhIGV2ZXJ5 IHRpbWUgYW4KKyAgICBodHRwIHJlcXVlc3QgaXMgbWFkZS4KKyAgICBSZXR1 cm5zOiBoZWFkZXJzCisgICAgIiIiCisgICAgaGVhZGVycyA9IHt9CisgICAg aGVhZGVyc1siQ2FjaGUtQ29udHJvbCJdID0gIm5vLWNhY2hlLCBuby1zdG9y ZSwgbXVzdC1yZXZhbGlkYXRlIiAgIyBIVFRQIDEuMS4KKyAgICBoZWFkZXJz WyJQcmFnbWEiXSA9ICJuby1jYWNoZSIgICMgSFRUUCAxLjAuCisgICAgaGVh ZGVyc1siRXhwaXJlcyJdID0gIjAiICAjIFByb3hpZXMuCisgICAgcmV0dXJu IGhlYWRlcnMKKwoKIGRlZiBtYWtlX2pzb25fcmVzcG9uc2UoCiAgICAgICAg IHN1Y2Nlc3M9MSwgZXJyb3Jtc2c9JycsIGluZm89JycsIHJlc3VsdD1Ob25l LCBkYXRhPU5vbmUsIHN0YXR1cz0yMDAKQEAgLTQ1LDcgKzU3LDggQEAgZGVm IG1ha2VfanNvbl9yZXNwb25zZSgKICAgICByZXR1cm4gUmVzcG9uc2UoCiAg ICAgICAgIHJlc3BvbnNlPWpzb24uZHVtcHMoZG9jLCBjbHM9RGF0YVR5cGVK U09ORW5jb2RlciksCiAgICAgICAgIHN0YXR1cz1zdGF0dXMsCi0gICAgICAg IG1pbWV0eXBlPSJhcHBsaWNhdGlvbi9qc29uIgorICAgICAgICBtaW1ldHlw ZT0iYXBwbGljYXRpb24vanNvbiIsCisgICAgICAgIGhlYWRlcnM9Z2V0X25v X2NhY2hlX2hlYWRlcigpCiAgICAgKQoKCkBAIC01NCw3ICs2Nyw4IEBAIGRl ZiBtYWtlX3Jlc3BvbnNlKHJlc3BvbnNlPU5vbmUsIHN0YXR1cz0yMDApOgog ICAgIHJldHVybiBSZXNwb25zZSgKICAgICAgICAgcmVzcG9uc2U9anNvbi5k dW1wcyhyZXNwb25zZSwgY2xzPURhdGFUeXBlSlNPTkVuY29kZXIpLAogICAg ICAgICBzdGF0dXM9c3RhdHVzLAotICAgICAgICBtaW1ldHlwZT0iYXBwbGlj YXRpb24vanNvbiIKKyAgICAgICAgbWltZXR5cGU9ImFwcGxpY2F0aW9uL2pz b24iLAorICAgICAgICBoZWFkZXJzPWdldF9ub19jYWNoZV9oZWFkZXIoKQog ICAgICkKCgo= --001a1145b4526bc628053d04b269 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1145b4526bc628053d04b269--